You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Rick Hillegas (Created) (JIRA)" <ji...@apache.org> on 2011/10/26 20:17:32 UTC
[jira] [Created] (DERBY-5486) Upgrade tests should verify that
DERBY-4437 was backed out of 10.8.2.2
Upgrade tests should verify that DERBY-4437 was backed out of 10.8.2.2
----------------------------------------------------------------------
Key: DERBY-5486
URL: https://issues.apache.org/jira/browse/DERBY-5486
Project: Derby
Issue Type: Improvement
Components: SQL, Test
Reporter: Rick Hillegas
The following code in UpgradeRun needs to be reworked to verify that sequence/identities behave as expected when upgrading from 10.8.2.2:
if ( lessThan( version, new int[] { 10, 8, 1, 6 } ) )
{ suite.addTest(Changes10_8_2.suite(phase)); }
The following might do the trick:
if (oldMinor < 7)
suite.addTest(Changes10_7.suite(phase));
if (oldMinor < 9)
{
suite.addTest(Changes10_9.suite(phase));
suite.addTest(Changes10_8_2.suite(phase));
}
Thanks to Kristian for spotting this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (DERBY-5486) Upgrade tests should verify that
DERBY-4437 was backed out of 10.8.2.2
Posted by "Rick Hillegas (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rick Hillegas reassigned DERBY-5486:
------------------------------------
Assignee: Rick Hillegas
> Upgrade tests should verify that DERBY-4437 was backed out of 10.8.2.2
> ----------------------------------------------------------------------
>
> Key: DERBY-5486
> URL: https://issues.apache.org/jira/browse/DERBY-5486
> Project: Derby
> Issue Type: Improvement
> Components: SQL, Test
> Reporter: Rick Hillegas
> Assignee: Rick Hillegas
>
> The following code in UpgradeRun needs to be reworked to verify that sequence/identities behave as expected when upgrading from 10.8.2.2:
> if ( lessThan( version, new int[] { 10, 8, 1, 6 } ) )
> { suite.addTest(Changes10_8_2.suite(phase)); }
> The following might do the trick:
> if (oldMinor < 7)
> suite.addTest(Changes10_7.suite(phase));
> if (oldMinor < 9)
> {
> suite.addTest(Changes10_9.suite(phase));
> suite.addTest(Changes10_8_2.suite(phase));
> }
> Thanks to Kristian for spotting this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-5486) Upgrade tests should verify that
DERBY-4437 was backed out of 10.8.2.2
Posted by "Rick Hillegas (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rick Hillegas updated DERBY-5486:
---------------------------------
Attachment: derby-5486-01-ab-mergeFiles.diff
Attaching derby-5486-01-ab-mergeFiles.diff. This patch removes Changes10_8_2, merging it into Changes10_9. Removes the special exception for 10.8.2. I see errors in trigger-related upgrade tests. However, these are identical to the errors I see on a codeline without this patch. Committed at subversion revision 1195476.
Touches the following files:
M java/testing/org/apache/derbyTesting/functionTests/tests/upgradeTests/Changes10_9.java
M java/testing/org/apache/derbyTesting/functionTests/tests/upgradeTests/UpgradeRun.java
D java/testing/org/apache/derbyTesting/functionTests/tests/upgradeTests/Changes10_8_2.java
> Upgrade tests should verify that DERBY-4437 was backed out of 10.8.2.2
> ----------------------------------------------------------------------
>
> Key: DERBY-5486
> URL: https://issues.apache.org/jira/browse/DERBY-5486
> Project: Derby
> Issue Type: Improvement
> Components: SQL, Test
> Reporter: Rick Hillegas
> Assignee: Rick Hillegas
> Attachments: derby-5486-01-ab-mergeFiles.diff
>
>
> The following code in UpgradeRun needs to be reworked to verify that sequence/identities behave as expected when upgrading from 10.8.2.2:
> if ( lessThan( version, new int[] { 10, 8, 1, 6 } ) )
> { suite.addTest(Changes10_8_2.suite(phase)); }
> The following might do the trick:
> if (oldMinor < 7)
> suite.addTest(Changes10_7.suite(phase));
> if (oldMinor < 9)
> {
> suite.addTest(Changes10_9.suite(phase));
> suite.addTest(Changes10_8_2.suite(phase));
> }
> Thanks to Kristian for spotting this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-5486) Upgrade tests should verify that
DERBY-4437 was backed out of 10.8.2.2
Posted by "Rick Hillegas (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138247#comment-13138247 ]
Rick Hillegas commented on DERBY-5486:
--------------------------------------
Thanks, Knut. That's a good suggestion.
> Upgrade tests should verify that DERBY-4437 was backed out of 10.8.2.2
> ----------------------------------------------------------------------
>
> Key: DERBY-5486
> URL: https://issues.apache.org/jira/browse/DERBY-5486
> Project: Derby
> Issue Type: Improvement
> Components: SQL, Test
> Reporter: Rick Hillegas
>
> The following code in UpgradeRun needs to be reworked to verify that sequence/identities behave as expected when upgrading from 10.8.2.2:
> if ( lessThan( version, new int[] { 10, 8, 1, 6 } ) )
> { suite.addTest(Changes10_8_2.suite(phase)); }
> The following might do the trick:
> if (oldMinor < 7)
> suite.addTest(Changes10_7.suite(phase));
> if (oldMinor < 9)
> {
> suite.addTest(Changes10_9.suite(phase));
> suite.addTest(Changes10_8_2.suite(phase));
> }
> Thanks to Kristian for spotting this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-5486) Upgrade tests should verify that
DERBY-4437 was backed out of 10.8.2.2
Posted by "Rick Hillegas (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rick Hillegas updated DERBY-5486:
---------------------------------
Attachment: derby-5486-02-aa-removeTests.diff
Attaching derby-5486-02-aa-removeTests.diff. This patch removes the tests which were merged in the previous patch. For some reason those tests are turning up intermittent failures in the nightly tests. I don't know what the instability is. However, on further reflection, I don't think that these tests add any value on top of the existing upgrade/downgrade tests for identity behavior. So I am removing these useless tests rather than spend any time tracking down the instability. Committed at subversion revision 1197272.
> Upgrade tests should verify that DERBY-4437 was backed out of 10.8.2.2
> ----------------------------------------------------------------------
>
> Key: DERBY-5486
> URL: https://issues.apache.org/jira/browse/DERBY-5486
> Project: Derby
> Issue Type: Improvement
> Components: SQL, Test
> Reporter: Rick Hillegas
> Assignee: Rick Hillegas
> Attachments: derby-5486-01-ab-mergeFiles.diff, derby-5486-02-aa-removeTests.diff
>
>
> The following code in UpgradeRun needs to be reworked to verify that sequence/identities behave as expected when upgrading from 10.8.2.2:
> if ( lessThan( version, new int[] { 10, 8, 1, 6 } ) )
> { suite.addTest(Changes10_8_2.suite(phase)); }
> The following might do the trick:
> if (oldMinor < 7)
> suite.addTest(Changes10_7.suite(phase));
> if (oldMinor < 9)
> {
> suite.addTest(Changes10_9.suite(phase));
> suite.addTest(Changes10_8_2.suite(phase));
> }
> Thanks to Kristian for spotting this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-5486) Upgrade tests should verify that
DERBY-4437 was backed out of 10.8.2.2
Posted by "Rick Hillegas (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143945#comment-13143945 ]
Rick Hillegas commented on DERBY-5486:
--------------------------------------
Hi Knut,
Yes, I think that is the case. Thanks.
> Upgrade tests should verify that DERBY-4437 was backed out of 10.8.2.2
> ----------------------------------------------------------------------
>
> Key: DERBY-5486
> URL: https://issues.apache.org/jira/browse/DERBY-5486
> Project: Derby
> Issue Type: Improvement
> Components: SQL, Test
> Reporter: Rick Hillegas
> Assignee: Rick Hillegas
> Attachments: derby-5486-01-ab-mergeFiles.diff, derby-5486-02-aa-removeTests.diff
>
>
> The following code in UpgradeRun needs to be reworked to verify that sequence/identities behave as expected when upgrading from 10.8.2.2:
> if ( lessThan( version, new int[] { 10, 8, 1, 6 } ) )
> { suite.addTest(Changes10_8_2.suite(phase)); }
> The following might do the trick:
> if (oldMinor < 7)
> suite.addTest(Changes10_7.suite(phase));
> if (oldMinor < 9)
> {
> suite.addTest(Changes10_9.suite(phase));
> suite.addTest(Changes10_8_2.suite(phase));
> }
> Thanks to Kristian for spotting this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-5486) Upgrade tests should verify that
DERBY-4437 was backed out of 10.8.2.2
Posted by "Knut Anders Hatlen (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13144430#comment-13144430 ]
Knut Anders Hatlen commented on DERBY-5486:
-------------------------------------------
It looks to me as if the tests failed because the sequence returned the same value twice. That sounds like a bug to me. I'm able to reproduce it on trunk by running these two ij sessions:
ij version 10.9
ij> connect 'jdbc:derby:db;create=true';
ij> create sequence s;
0 rows inserted/updated/deleted
ij> values next value for s;
1
-----------
-2147483648
1 row selected
ij>
At this point, kill the ij process. Should not be a clean shutdown. Then restart ij and retrieve the next value from the sequence:
ij version 10.9
ij> connect 'jdbc:derby:db';
ij> values next value for s;
1
-----------
-2147483648
1 row selected
ij>
Here, we got the same value as we did the first time, but we should have got a new value.
> Upgrade tests should verify that DERBY-4437 was backed out of 10.8.2.2
> ----------------------------------------------------------------------
>
> Key: DERBY-5486
> URL: https://issues.apache.org/jira/browse/DERBY-5486
> Project: Derby
> Issue Type: Improvement
> Components: SQL, Test
> Reporter: Rick Hillegas
> Assignee: Rick Hillegas
> Attachments: derby-5486-01-ab-mergeFiles.diff, derby-5486-02-aa-removeTests.diff
>
>
> The following code in UpgradeRun needs to be reworked to verify that sequence/identities behave as expected when upgrading from 10.8.2.2:
> if ( lessThan( version, new int[] { 10, 8, 1, 6 } ) )
> { suite.addTest(Changes10_8_2.suite(phase)); }
> The following might do the trick:
> if (oldMinor < 7)
> suite.addTest(Changes10_7.suite(phase));
> if (oldMinor < 9)
> {
> suite.addTest(Changes10_9.suite(phase));
> suite.addTest(Changes10_8_2.suite(phase));
> }
> Thanks to Kristian for spotting this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-5486) Upgrade tests should verify that
DERBY-4437 was backed out of 10.8.2.2
Posted by "Rick Hillegas (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145545#comment-13145545 ]
Rick Hillegas commented on DERBY-5486:
--------------------------------------
Thanks, Knut. Those do look like bugs. I have logged JIRAs for them and linked them to a master JIRA for fixes to sequence/identity generators: DERBY-5495. Thanks.
> Upgrade tests should verify that DERBY-4437 was backed out of 10.8.2.2
> ----------------------------------------------------------------------
>
> Key: DERBY-5486
> URL: https://issues.apache.org/jira/browse/DERBY-5486
> Project: Derby
> Issue Type: Improvement
> Components: SQL, Test
> Reporter: Rick Hillegas
> Assignee: Rick Hillegas
> Attachments: derby-5486-01-ab-mergeFiles.diff, derby-5486-02-aa-removeTests.diff
>
>
> The following code in UpgradeRun needs to be reworked to verify that sequence/identities behave as expected when upgrading from 10.8.2.2:
> if ( lessThan( version, new int[] { 10, 8, 1, 6 } ) )
> { suite.addTest(Changes10_8_2.suite(phase)); }
> The following might do the trick:
> if (oldMinor < 7)
> suite.addTest(Changes10_7.suite(phase));
> if (oldMinor < 9)
> {
> suite.addTest(Changes10_9.suite(phase));
> suite.addTest(Changes10_8_2.suite(phase));
> }
> Thanks to Kristian for spotting this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-5486) Upgrade tests should verify that
DERBY-4437 was backed out of 10.8.2.2
Posted by "Knut Anders Hatlen (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145356#comment-13145356 ]
Knut Anders Hatlen commented on DERBY-5486:
-------------------------------------------
It is also possible to get the same value returned twice in a single ij session (might be a different bug):
ij version 10.9
ij> connect 'jdbc:derby:memory:db;create=true';
ij> create table t (x int);
0 rows inserted/updated/deleted
ij> create sequence s;
0 rows inserted/updated/deleted
ij> autocommit off;
ij> select count(*) from sys.syssequences with rs;
1
-----------
1
1 row selected
ij> values next value for s;
1
-----------
-2147483648
1 row selected
ij> drop table t;
0 rows inserted/updated/deleted
ij> rollback;
ij> values next value for s;
1
-----------
-2147483648
1 row selected
> Upgrade tests should verify that DERBY-4437 was backed out of 10.8.2.2
> ----------------------------------------------------------------------
>
> Key: DERBY-5486
> URL: https://issues.apache.org/jira/browse/DERBY-5486
> Project: Derby
> Issue Type: Improvement
> Components: SQL, Test
> Reporter: Rick Hillegas
> Assignee: Rick Hillegas
> Attachments: derby-5486-01-ab-mergeFiles.diff, derby-5486-02-aa-removeTests.diff
>
>
> The following code in UpgradeRun needs to be reworked to verify that sequence/identities behave as expected when upgrading from 10.8.2.2:
> if ( lessThan( version, new int[] { 10, 8, 1, 6 } ) )
> { suite.addTest(Changes10_8_2.suite(phase)); }
> The following might do the trick:
> if (oldMinor < 7)
> suite.addTest(Changes10_7.suite(phase));
> if (oldMinor < 9)
> {
> suite.addTest(Changes10_9.suite(phase));
> suite.addTest(Changes10_8_2.suite(phase));
> }
> Thanks to Kristian for spotting this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-5486) Upgrade tests should verify that
DERBY-4437 was backed out of 10.8.2.2
Posted by "Knut Anders Hatlen (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143890#comment-13143890 ]
Knut Anders Hatlen commented on DERBY-5486:
-------------------------------------------
Are we confident that the intermittent failures are problems with the tests and not with the implementation? If so, just removing the tests sounds OK. But if there's potentially a problem with the implementation, that problem will still be there after the removal of the tests...
> Upgrade tests should verify that DERBY-4437 was backed out of 10.8.2.2
> ----------------------------------------------------------------------
>
> Key: DERBY-5486
> URL: https://issues.apache.org/jira/browse/DERBY-5486
> Project: Derby
> Issue Type: Improvement
> Components: SQL, Test
> Reporter: Rick Hillegas
> Assignee: Rick Hillegas
> Attachments: derby-5486-01-ab-mergeFiles.diff, derby-5486-02-aa-removeTests.diff
>
>
> The following code in UpgradeRun needs to be reworked to verify that sequence/identities behave as expected when upgrading from 10.8.2.2:
> if ( lessThan( version, new int[] { 10, 8, 1, 6 } ) )
> { suite.addTest(Changes10_8_2.suite(phase)); }
> The following might do the trick:
> if (oldMinor < 7)
> suite.addTest(Changes10_7.suite(phase));
> if (oldMinor < 9)
> {
> suite.addTest(Changes10_9.suite(phase));
> suite.addTest(Changes10_8_2.suite(phase));
> }
> Thanks to Kristian for spotting this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-5486) Upgrade tests should verify that
DERBY-4437 was backed out of 10.8.2.2
Posted by "Knut Anders Hatlen (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138178#comment-13138178 ]
Knut Anders Hatlen commented on DERBY-5486:
-------------------------------------------
Would it be better to move the test cases from Changes10_8_2 to Changes10_9? Since the changes didn't actually end up in 10.8.2, the current name of the class is misleading.
> Upgrade tests should verify that DERBY-4437 was backed out of 10.8.2.2
> ----------------------------------------------------------------------
>
> Key: DERBY-5486
> URL: https://issues.apache.org/jira/browse/DERBY-5486
> Project: Derby
> Issue Type: Improvement
> Components: SQL, Test
> Reporter: Rick Hillegas
>
> The following code in UpgradeRun needs to be reworked to verify that sequence/identities behave as expected when upgrading from 10.8.2.2:
> if ( lessThan( version, new int[] { 10, 8, 1, 6 } ) )
> { suite.addTest(Changes10_8_2.suite(phase)); }
> The following might do the trick:
> if (oldMinor < 7)
> suite.addTest(Changes10_7.suite(phase));
> if (oldMinor < 9)
> {
> suite.addTest(Changes10_9.suite(phase));
> suite.addTest(Changes10_8_2.suite(phase));
> }
> Thanks to Kristian for spotting this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (DERBY-5486) Upgrade tests should verify that
DERBY-4437 was backed out of 10.8.2.2
Posted by "Rick Hillegas (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rick Hillegas resolved DERBY-5486.
----------------------------------
Resolution: Won't Fix
I don't intend to work on this issue, now that derby-4437 has been backed out of the trunk as well as the 10.8 branch.
> Upgrade tests should verify that DERBY-4437 was backed out of 10.8.2.2
> ----------------------------------------------------------------------
>
> Key: DERBY-5486
> URL: https://issues.apache.org/jira/browse/DERBY-5486
> Project: Derby
> Issue Type: Improvement
> Components: SQL, Test
> Reporter: Rick Hillegas
> Assignee: Rick Hillegas
> Attachments: derby-5486-01-ab-mergeFiles.diff, derby-5486-02-aa-removeTests.diff
>
>
> The following code in UpgradeRun needs to be reworked to verify that sequence/identities behave as expected when upgrading from 10.8.2.2:
> if ( lessThan( version, new int[] { 10, 8, 1, 6 } ) )
> { suite.addTest(Changes10_8_2.suite(phase)); }
> The following might do the trick:
> if (oldMinor < 7)
> suite.addTest(Changes10_7.suite(phase));
> if (oldMinor < 9)
> {
> suite.addTest(Changes10_9.suite(phase));
> suite.addTest(Changes10_8_2.suite(phase));
> }
> Thanks to Kristian for spotting this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira