You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "Revanth14 (via GitHub)" <gi...@apache.org> on 2026/10/02 18:02:18 UTC
[I] OpenAPI: Remove deprecated TrueExpression and FalseExpression [iceberg]
Revanth14 opened a new issue, #18351:
URL: https://github.com/apache/iceberg/issues/18351
### Feature Request / Improvement
`rest-catalog-open-api.yaml` still lists `TrueExpression` and `FalseExpression` (`{"type":"true"}` / `{"type":"false"}`) as deprecated alternatives in `Predicate`, after apache/iceberg#17138.
These forms don't match the rest of the project:
- `format/expressions-spec.md` Appendix B doesn't include them. `PREDICATE` allows bare `true`/`false`, and `DEPRECATED_PREDICATE` lists only the term-based forms.
- Java's `ExpressionParser.fromJson` rejects them. `{"type":"true"}` resolves to the `TRUE` operation, has no case in the switch, and falls through to predicate parsing, which requires `term`.
So the reference implementation (and iceberg-go) rejects a form the OpenAPI schema says is valid.
**Proposal:** remove `TrueExpression` and `FalseExpression` from `Predicate`, leaving the bare boolean. This makes OpenAPI match the expressions spec and the reference implementation.
Happy to open the PR.
### Query engine
None
### Willingness to contribute
- [x] I can contribute this improvement/feature independently
- [ ] I would be willing to contribute this improvement/feature with guidance from the Iceberg community
- [ ] I cannot contribute this improvement/feature at this time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] OpenAPI: Remove deprecated TrueExpression and FalseExpression [iceberg]
Posted by "Revanth14 (via GitHub)" <gi...@apache.org>.
Revanth14 commented on issue #18351:
URL: https://github.com/apache/iceberg/issues/18351#issuecomment-5958755196
Discussion on dev@: [https://lists.apache.org/thread/48pqzgp1x095yn7clrpbh1vb56gfb](https://lists.apache.org/thread/48pqzgp1x095yn7clrpbh1vb56gfbq1t)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] OpenAPI: Remove deprecated TrueExpression and FalseExpression [iceberg]
Posted by "Revanth14 (via GitHub)" <gi...@apache.org>.
Revanth14 commented on issue #18351:
URL: https://github.com/apache/iceberg/issues/18351#issuecomment-6083990198
Dev list discussion: https://lists.apache.org/thread/48pqzgp1x095yn7clrpbh1vb56gfbq1t
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] OpenAPI: Remove deprecated TrueExpression and FalseExpression [iceberg]
Posted by "zhang-arvin (via GitHub)" <gi...@apache.org>.
zhang-arvin commented on issue #18351:
URL: https://github.com/apache/iceberg/issues/18351#issuecomment-6077443387
@zhang-arvin here — I'd like to take this.
Plan: remove the deprecated `TrueExpression` / `FalseExpression` definitions from the OpenAPI spec (they carry no information) and update the generated/consumed references, then add the spec change note. Scope is limited to `open-api/` plus any generated client references. Happy to extend spec-level tests if the repo has them.
Please assign this to me if convenient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] OpenAPI: Remove deprecated TrueExpression and FalseExpression [iceberg]
Posted by "manuzhang (via GitHub)" <gi...@apache.org>.
manuzhang commented on issue #18351:
URL: https://github.com/apache/iceberg/issues/18351#issuecomment-6071736147
Hi @Revanth14, I already opened https://github.com/apache/iceberg/pull/17120 to fix this. Can you help review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org