You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/04/02 00:54:37 UTC

[GitHub] [spark] rxin commented on issue #24259: [SPARK-27328][SQL] Add 'deprecated' in ExpressionDescription for extended usage and SQL doc

rxin commented on issue #24259: [SPARK-27328][SQL] Add 'deprecated' in ExpressionDescription for extended usage and SQL doc
URL: https://github.com/apache/spark/pull/24259#issuecomment-478800287
 
 
   So the issue with a single flag for all the deprecated functions is that the more functions we deprecate, the more likely one will just turn it on always, and as a result it becomes completely useless. Why do you think it's a lot of overhead to add new flags? Isn't it just a few lines of code? We don't need to define an extra function in the SQLConf object.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org