You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/11/23 16:59:34 UTC
[kudu-CR] cfile-test: use a faster data generator for 100M-string test
Todd Lipcon has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5201
Change subject: cfile-test: use a faster data generator for 100M-string test
......................................................................
cfile-test: use a faster data generator for 100M-string test
The current data generator using StringPrintf is not very fast, and
since we don't care about the contents of the file for this test, it's
just as easy to use FastHex64ToBuffer for better performance.
This resulted in a ~2x speedup in the test. This means that the test
will now better represent the underlying performance of the encoder and
cfile writing code.
Change-Id: I9578681aa2e064dbecd79fdce7b8a083ef03b3c4
---
M src/kudu/cfile/cfile-test.cc
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/5201/1
--
To view, visit http://gerrit.cloudera.org:8080/5201
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9578681aa2e064dbecd79fdce7b8a083ef03b3c4
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
[kudu-CR] cfile-test: use a faster data generator for 100M-string test
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: cfile-test: use a faster data generator for 100M-string test
......................................................................
Patch Set 3:
Right, forgot about the padding.
--
To view, visit http://gerrit.cloudera.org:8080/5201
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9578681aa2e064dbecd79fdce7b8a083ef03b3c4
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] cfile-test: use a faster data generator for 100M-string test
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: cfile-test: use a faster data generator for 100M-string test
......................................................................
Patch Set 3:
I don't think it'll be that much less effective, since now it'll at least have the prefix '0000000000' or somesuch instead of "hello ", right?
--
To view, visit http://gerrit.cloudera.org:8080/5201
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9578681aa2e064dbecd79fdce7b8a083ef03b3c4
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] cfile-test: use a faster data generator for 100M-string test
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: cfile-test: use a faster data generator for 100M-string test
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5201
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9578681aa2e064dbecd79fdce7b8a083ef03b3c4
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] cfile-test: use a faster data generator for 100M-string test
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: cfile-test: use a faster data generator for 100M-string test
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5201
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9578681aa2e064dbecd79fdce7b8a083ef03b3c4
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] cfile-test: use a faster data generator for 100M-string test
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: cfile-test: use a faster data generator for 100M-string test
......................................................................
cfile-test: use a faster data generator for 100M-string test
The current data generator using StringPrintf is not very fast, and
since we don't care about the contents of the file for this test, it's
just as easy to use FastHex64ToBuffer for better performance.
This resulted in a ~2x speedup in the test. This means that the test
will now better represent the underlying performance of the encoder and
cfile writing code.
Change-Id: I9578681aa2e064dbecd79fdce7b8a083ef03b3c4
Reviewed-on: http://gerrit.cloudera.org:8080/5201
Tested-by: Kudu Jenkins
Reviewed-by: Dan Burkert <da...@apache.org>
---
M src/kudu/cfile/cfile-test.cc
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Dan Burkert: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5201
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9578681aa2e064dbecd79fdce7b8a083ef03b3c4
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] cfile-test: use a faster data generator for 100M-string test
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Hello David Ribeiro Alves, Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5201
to look at the new patch set (#2).
Change subject: cfile-test: use a faster data generator for 100M-string test
......................................................................
cfile-test: use a faster data generator for 100M-string test
The current data generator using StringPrintf is not very fast, and
since we don't care about the contents of the file for this test, it's
just as easy to use FastHex64ToBuffer for better performance.
This resulted in a ~2x speedup in the test. This means that the test
will now better represent the underlying performance of the encoder and
cfile writing code.
Change-Id: I9578681aa2e064dbecd79fdce7b8a083ef03b3c4
---
M src/kudu/cfile/cfile-test.cc
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/5201/2
--
To view, visit http://gerrit.cloudera.org:8080/5201
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9578681aa2e064dbecd79fdce7b8a083ef03b3c4
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] cfile-test: use a faster data generator for 100M-string test
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: cfile-test: use a faster data generator for 100M-string test
......................................................................
Patch Set 3:
This is going to make the prefix encoder less effective on the dataset, is that important?
--
To view, visit http://gerrit.cloudera.org:8080/5201
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9578681aa2e064dbecd79fdce7b8a083ef03b3c4
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No