You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/09/02 17:46:40 UTC

[GitHub] [incubator-tvm] jroesch commented on a change in pull request #6377: [RELAY] Fix the FoldConstant Regression for VTA

jroesch commented on a change in pull request #6377:
URL: https://github.com/apache/incubator-tvm/pull/6377#discussion_r482254229



##########
File path: src/relay/transforms/fold_constant.cc
##########
@@ -230,7 +216,17 @@ class ConstantFolder : public ExprMutator {
     auto entry_func = Downcast<Function>(mod->Lookup("main"));
     expr = expr.as<FunctionNode>() == nullptr ? entry_func->body : entry_func;
 
-    FInterpreter executor = GetInterpreter(mod);
+    using tvm::transform::PassContext;

Review comment:
       Why inline this back in?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org