You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Juergen Donnerstag (JIRA)" <ji...@apache.org> on 2008/04/06 10:01:27 UTC

[jira] Resolved: (WICKET-1487) Bug in order of rendered links within ?

     [ https://issues.apache.org/jira/browse/WICKET-1487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Juergen Donnerstag resolved WICKET-1487.
----------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.3.3

I is currently working fine if inheritance is just one level deep. But
if it is 2 or more level deep than each higher level gets inserted
after the first <wicket:head>. E.g.

<script href="basebase.css"/>
<script href="base.css"/>

<script href="basebase.css"/>
 <-- gets inserted here ><script href="extension.css"/>
<script href="base.css"/>

should be like
<script href="basebase.css"/>
<script href="base.css"/>
<script href="extension.css"/>

Juergen

> Bug in order of rendered links within <wicket:head> ?
> -----------------------------------------------------
>
>                 Key: WICKET-1487
>                 URL: https://issues.apache.org/jira/browse/WICKET-1487
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.2
>            Reporter: Juergen Donnerstag
>            Assignee: Juergen Donnerstag
>             Fix For: 1.3.3
>
>
> From: "Matej Knopp" <ma...@gmail.com>
> Date: March 25, 2008 11:51:20 AM PDT
> To: users@wicket.apache.org
> Subject: Re: Bug in order of rendered links within <wicket:head> ?
> Reply-To: users@wicket.apache.org
> I agree that we should. But I'm not sure why the order is like this. Juergen?
> -Matej
> On Tue, Mar 25, 2008 at 7:43 PM, Igor Vaynberg <ig...@gmail.com> wrote:
>     matej? do we guarantee the order? looks like we should?
>     -igor
>     On Tue, Mar 25, 2008 at 11:36 AM, Justin Morgan - Logic Sector
>     <jm...@logicsector.com> wrote:
>         Still wondering if anyone has any input on this...?  Thanks for any
>         help!
>         To clarify, the pages are specified like so...
>         AbstractMasterPage (  <--  extends WebPage)
>                <wicket:head>
>                    <link type="text/css" rel="stylesheet" href="css/
>         AbstractMasterPage.css"/>
>                </wicket:head>
>         AbstractStaticTextPage (  <--  extends AbstractMasterPage)
>                <wicket:head>
>                    <link type="text/css" rel="stylesheet" href="css/
>         AbstractStaticTextPage.css"/>
>                </wicket:head>
>         StaticTextPage (  <--  extends AbstractStaticTextPage)
>                <wicket:head>
>                    <link type="text/css" rel="stylesheet" href="css/
>         StaticTextPage.css"/>
>                </wicket:head>
>         But in the rendered HTML, the CSS links show up in the *wrong order*:
>            <head>
>                    <link href="css/AbstractMasterPage.css" type="text/css"
>         rel="stylesheet"/>
>                   <link href="css/StaticTextPage.css" type="text/css"
>         rel="stylesheet"/>
>                   <link href="css/AbstractStaticTextPage.css" type="text/
>         css" rel="stylesheet"/>
>           </head>
>         This results in parent-CSS overriding child-CSS, which is wrong.
>         Thanks again for any help!
>         On Mar 25, 2008, at 1:19 AM, Justin Morgan - Logic Sector wrote:
>             I'm having an issue with links to CSS files in Wicket 1.3.1.  The
>             problem is the ordering of the links in the rendered HTML.  The page
>             inheritance hierarchy goes like this:
>             AbstractMasterPage --> AbstractStaticTextPage --> StaticTextPage
>             However, the list of links brought in via the <wicket:head> section
>             are:
>             <link from AbstractMasterPage>
>             <link from StaticTextPage >
>             <link from AbstractStaticTextPage >
>             This is causing problems because of the way CSS inheritance works
>             with regard to CSS import order.  In other words, it means that the
>             AbstractStaticTextPage CSS link is overriding the contents of the
>             StaticTextPage CSS link.  This is the reverse of the way I think it
>             *should* work (I want CSS declarations in StaticTextPage to override
>             AbstractStaticTextPage, as you'd expect).
>             Any ideas?  Thanks for any help!
>             Justin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.