[GitHub] HyukjinKwon commented on a change in pull request #23810: [SPARK-26901][SQL][R] Adds child's output into references to avoid column-pruning for vectorized gapply()

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #23810: [SPARK-26901][SQL][R] Adds child's output into references to avoid column-pruning for vectorized gapply()
URL: https://github.com/apache/spark/pull/23810#discussion_r257866538
 
 

 ##########
 File path: R/pkg/tests/fulltests/test_sparkSQL.R
 ##########
 @@ -3564,11 +3564,14 @@ test_that("gapply() Arrow optimization", {
                      stopifnot(is.numeric(key[[1]]))
                    }
                    stopifnot(class(grouped) == "data.frame")
+                   # mtcars' hp is more then 50.
+                   stopifnot(all(grouped$hp > 50))
 
 Review comment:
   Yea, that's actually what I did initially. And then, realised that column numbers were actually fine (because correct columns are set to Arrow writers ahead but the problem looks the data itself)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org