You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/03/30 23:08:41 UTC
[GitHub] [superset] hughhhh opened a new pull request #13877: Implemented testing on DatabaseModal_spec
hughhhh opened a new pull request #13877:
URL: https://github.com/apache/superset/pull/13877
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] hughhhh commented on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
hughhhh commented on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-812641146
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (e327537) into [master](https://codecov.io/gh/apache/superset/commit/d54cc6d82aa86444dff0eaff072ee9e8e9ea915f?el=desc) (d54cc6d) will **decrease** coverage by `1.80%`.
> The diff coverage is `88.23%`.
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
- Coverage 77.55% 75.75% -1.81%
==========================================
Files 935 935
Lines 47301 47320 +19
Branches 5907 5935 +28
==========================================
- Hits 36685 35846 -839
- Misses 10472 11296 +824
- Partials 144 178 +34
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `46.39% <65.11%> (-9.64%)` | :arrow_down: |
| hive | `?` | |
| mysql | `80.60% <ø> (ø)` | |
| postgres | `80.63% <ø> (ø)` | |
| presto | `?` | |
| python | `80.72% <ø> (-0.43%)` | :arrow_down: |
| sqlite | `80.19% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `78.94% <86.95%> (+2.97%)` | :arrow_up: |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `100.00% <100.00%> (+5.26%)` | :arrow_up: |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tend/src/visualizations/FilterBox/controlPanel.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9jb250cm9sUGFuZWwuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rontend/src/dashboard/components/dnd/handleDrop.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVEcm9wLmpz) | `0.00% <0.00%> (-96.16%)` | :arrow_down: |
| [...ontend/src/dashboard/components/dnd/handleHover.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVIb3Zlci5qcw==) | `11.11% <0.00%> (-88.89%)` | :arrow_down: |
| [...ponents/Select/WindowedSelect/WindowedMenuList.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L1dpbmRvd2VkTWVudUxpc3QudHN4) | `10.71% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `0.00% <0.00%> (-81.82%)` | :arrow_down: |
| [...ontend/src/filters/components/Select/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvYnVpbGRRdWVyeS50cw==) | `0.00% <0.00%> (-77.78%)` | :arrow_down: |
| ... and [104 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [d54cc6d...e327537](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (12a32eb) into [master](https://codecov.io/gh/apache/superset/commit/9d6832dc271fcea76302feb4273bd72a8b9d05ba?el=desc) (9d6832d) will **decrease** coverage by `1.91%`.
> The diff coverage is `90.47%`.
> :exclamation: Current head 12a32eb differs from pull request most recent head 791226f. Consider uploading reports for the commit 791226f to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
- Coverage 77.55% 75.64% -1.92%
==========================================
Files 935 936 +1
Lines 47301 47541 +240
Branches 5907 6008 +101
==========================================
- Hits 36685 35961 -724
- Misses 10472 11395 +923
- Partials 144 185 +41
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `43.55% <65.11%> (-12.49%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `82.93% <89.65%> (+6.96%)` | :arrow_up: |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `100.00% <100.00%> (+5.26%)` | :arrow_up: |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rontend/src/dashboard/components/dnd/handleDrop.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVEcm9wLmpz) | `0.00% <0.00%> (-96.16%)` | :arrow_down: |
| [...ontend/src/dashboard/components/dnd/handleHover.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVIb3Zlci5qcw==) | `11.11% <0.00%> (-88.89%)` | :arrow_down: |
| [...ponents/Select/WindowedSelect/WindowedMenuList.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L1dpbmRvd2VkTWVudUxpc3QudHN4) | `10.71% <0.00%> (-85.72%)` | :arrow_down: |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `0.00% <0.00%> (-81.82%)` | :arrow_down: |
| [...ontend/src/filters/components/Select/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvYnVpbGRRdWVyeS50cw==) | `0.00% <0.00%> (-77.78%)` | :arrow_down: |
| [...rc/dashboard/components/dnd/dragDroppableConfig.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9kcmFnRHJvcHBhYmxlQ29uZmlnLmpz) | `35.00% <0.00%> (-65.00%)` | :arrow_down: |
| [...c/dashboard/components/dnd/AddSliceDragPreview.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9BZGRTbGljZURyYWdQcmV2aWV3LmpzeA==) | `35.71% <0.00%> (-64.29%)` | :arrow_down: |
| ... and [90 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [9d6832d...791226f](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (03d120a) into [master](https://codecov.io/gh/apache/superset/commit/d54cc6d82aa86444dff0eaff072ee9e8e9ea915f?el=desc) (d54cc6d) will **increase** coverage by `0.58%`.
> The diff coverage is `90.00%`.
> :exclamation: Current head 03d120a differs from pull request most recent head e9d9be7. Consider uploading reports for the commit e9d9be7 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
+ Coverage 77.55% 78.14% +0.58%
==========================================
Files 935 935
Lines 47301 47340 +39
Branches 5907 5950 +43
==========================================
+ Hits 36685 36992 +307
+ Misses 10472 10204 -268
Partials 144 144
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.00% <64.17%> (-0.03%)` | :arrow_down: |
| hive | `?` | |
| javascript | `66.40% <88.88%> (+2.67%)` | :arrow_up: |
| presto | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...frontend/src/components/DatabaseSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci9pbmRleC50c3g=) | `92.70% <ø> (+1.04%)` | :arrow_up: |
| [...et-frontend/src/components/TableSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci9pbmRleC50c3g=) | `84.92% <ø> (ø)` | |
| [...src/dashboard/components/dnd/handleScroll/index.ts](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVTY3JvbGwvaW5kZXgudHM=) | `73.33% <ø> (ø)` | |
| [...d/src/explore/components/DatasourcePanel/index.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwvaW5kZXgudHN4) | `87.93% <ø> (ø)` | |
| [...rc/explore/components/DisplayQueryButton/index.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24vaW5kZXguanN4) | `100.00% <ø> (ø)` | |
| [...ontrols/AnnotationLayerControl/AnnotationLayer.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sL0Fubm90YXRpb25MYXllci5qc3g=) | `84.76% <ø> (ø)` | |
| [...mponents/controls/AnnotationLayerControl/index.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sL2luZGV4LmpzeA==) | `82.85% <ø> (ø)` | |
| [...re/components/controls/DatasourceControl/index.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC9pbmRleC5qc3g=) | `86.84% <ø> (ø)` | |
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `85.00% <ø> (+50.00%)` | :arrow_up: |
| [...ponents/controls/DndColumnSelectControl/Option.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL09wdGlvbi50c3g=) | `100.00% <ø> (ø)` | |
| ... and [61 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [d54cc6d...e9d9be7](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on a change in pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
eschutho commented on a change in pull request #13877:
URL: https://github.com/apache/superset/pull/13877#discussion_r605183803
##########
File path: superset-frontend/spec/javascripts/sqllab/fixtures.ts
##########
@@ -480,6 +480,8 @@ export const initialState = {
DEFAULT_SQLLAB_LIMIT: 1000,
SQL_MAX_ROW: 100000,
DISPLAY_MAX_ROW: 100,
+ SQLALCHEMY_DOCS_URL: 'test_SQLALCHEMY_DOCS_URL',
+ SQLALCHEMY_DISPLAY_TEXT: 'test_SQLALCHEMY_DISPLAY_TEXT',
Review comment:
wasn't this part of a previous PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (791226f) into [master](https://codecov.io/gh/apache/superset/commit/9d6832dc271fcea76302feb4273bd72a8b9d05ba?el=desc) (9d6832d) will **decrease** coverage by `1.28%`.
> The diff coverage is `90.47%`.
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
- Coverage 77.55% 76.27% -1.29%
==========================================
Files 935 936 +1
Lines 47301 47541 +240
Branches 5907 6008 +101
==========================================
- Hits 36685 36262 -423
- Misses 10472 11118 +646
- Partials 144 161 +17
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `49.90% <65.11%> (-6.14%)` | :arrow_down: |
| hive | `80.29% <ø> (ø)` | |
| javascript | `64.20% <90.47%> (+0.47%)` | :arrow_up: |
| mysql | `80.60% <ø> (ø)` | |
| postgres | `80.63% <ø> (ø)` | |
| presto | `?` | |
| python | `81.01% <ø> (-0.13%)` | :arrow_down: |
| sqlite | `80.19% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `82.93% <89.65%> (+6.96%)` | :arrow_up: |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `100.00% <100.00%> (+5.26%)` | :arrow_up: |
| [...tend/src/visualizations/FilterBox/controlPanel.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9jb250cm9sUGFuZWwuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rc/explore/components/controls/AnnotationLayer.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXIuanN4) | `2.38% <0.00%> (-49.53%)` | :arrow_down: |
| [...hboard/components/filterscope/FilterScopeModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlTW9kYWwudHN4) | `31.25% <0.00%> (-43.75%)` | :arrow_down: |
| [...teFilterControl/components/DateFunctionTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0RhdGVGdW5jdGlvblRvb2x0aXAudHN4) | `58.33% <0.00%> (-41.67%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CommonFrame.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NvbW1vbkZyYW1lLnRzeA==) | `41.66% <0.00%> (-41.67%)` | :arrow_down: |
| [...ore/components/controls/AnnotationLayerControl.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sLmpzeA==) | `42.85% <0.00%> (-40.00%)` | :arrow_down: |
| [...ols/DateFilterControl/components/CalendarFrame.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NhbGVuZGFyRnJhbWUudHN4) | `46.15% <0.00%> (-38.47%)` | :arrow_down: |
| [...hboard/components/resizable/ResizableContainer.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVDb250YWluZXIuanN4) | `71.87% <0.00%> (-28.13%)` | :arrow_down: |
| ... and [52 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [9d6832d...791226f](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (03d120a) into [master](https://codecov.io/gh/apache/superset/commit/d54cc6d82aa86444dff0eaff072ee9e8e9ea915f?el=desc) (d54cc6d) will **decrease** coverage by `0.02%`.
> The diff coverage is `89.16%`.
> :exclamation: Current head 03d120a differs from pull request most recent head aca7984. Consider uploading reports for the commit aca7984 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
- Coverage 77.55% 77.53% -0.03%
==========================================
Files 935 935
Lines 47301 47339 +38
Branches 5907 5950 +43
==========================================
+ Hits 36685 36702 +17
- Misses 10472 10483 +11
- Partials 144 154 +10
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.82% <91.66%> (+1.79%)` | :arrow_up: |
| hive | `?` | |
| javascript | `66.40% <88.88%> (+2.67%)` | :arrow_up: |
| presto | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...frontend/src/components/DatabaseSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci9pbmRleC50c3g=) | `92.70% <ø> (+1.04%)` | :arrow_up: |
| [...et-frontend/src/components/TableSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci9pbmRleC50c3g=) | `84.92% <ø> (ø)` | |
| [...src/dashboard/components/dnd/handleScroll/index.ts](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVTY3JvbGwvaW5kZXgudHM=) | `73.33% <ø> (ø)` | |
| [...d/src/explore/components/DatasourcePanel/index.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwvaW5kZXgudHN4) | `87.93% <ø> (ø)` | |
| [...rc/explore/components/DisplayQueryButton/index.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24vaW5kZXguanN4) | `100.00% <ø> (ø)` | |
| [...ontrols/AnnotationLayerControl/AnnotationLayer.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sL0Fubm90YXRpb25MYXllci5qc3g=) | `84.76% <ø> (ø)` | |
| [...mponents/controls/AnnotationLayerControl/index.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sL2luZGV4LmpzeA==) | `82.85% <ø> (ø)` | |
| [...re/components/controls/DatasourceControl/index.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC9pbmRleC5qc3g=) | `86.84% <ø> (ø)` | |
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `85.00% <ø> (+50.00%)` | :arrow_up: |
| [...ponents/controls/DndColumnSelectControl/Option.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL09wdGlvbi50c3g=) | `100.00% <ø> (ø)` | |
| ... and [103 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [d54cc6d...aca7984](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on a change in pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
eschutho commented on a change in pull request #13877:
URL: https://github.com/apache/superset/pull/13877#discussion_r605270682
##########
File path: superset-frontend/src/views/CRUD/data/database/DatabaseModal.tsx
##########
@@ -69,11 +83,15 @@ const StyledInputContainer = styled.div`
.input-container {
display: flex;
- align-items: center;
+ align-items: top;
label {
display: flex;
margin-right: ${({ theme }) => theme.gridUnit * 2}px;
Review comment:
I think you'll want to remove this `margin-right` style as well, but double check when you have the other labels moved into the correct label tag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (e9d9be7) into [master](https://codecov.io/gh/apache/superset/commit/d54cc6d82aa86444dff0eaff072ee9e8e9ea915f?el=desc) (d54cc6d) will **decrease** coverage by `2.23%`.
> The diff coverage is `86.27%`.
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
- Coverage 77.55% 75.31% -2.24%
==========================================
Files 935 935
Lines 47301 47318 +17
Branches 5907 5935 +28
==========================================
- Hits 36685 35639 -1046
- Misses 10472 11496 +1024
- Partials 144 183 +39
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `45.79% <20.00%> (-10.24%)` | :arrow_down: |
| hive | `?` | |
| javascript | `63.82% <86.27%> (+0.09%)` | :arrow_up: |
| mysql | `80.60% <ø> (ø)` | |
| postgres | `80.63% <ø> (ø)` | |
| presto | `?` | |
| python | `80.72% <ø> (-0.43%)` | :arrow_down: |
| sqlite | `80.19% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `67.83% <84.78%> (-8.14%)` | :arrow_down: |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `100.00% <100.00%> (+5.26%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rontend/src/dashboard/components/dnd/handleDrop.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVEcm9wLmpz) | `0.00% <0.00%> (-96.16%)` | :arrow_down: |
| [...ontend/src/dashboard/components/dnd/handleHover.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVIb3Zlci5qcw==) | `11.11% <0.00%> (-88.89%)` | :arrow_down: |
| [...ponents/Select/WindowedSelect/WindowedMenuList.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L1dpbmRvd2VkTWVudUxpc3QudHN4) | `10.71% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `0.00% <0.00%> (-81.82%)` | :arrow_down: |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| ... and [117 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [d54cc6d...e9d9be7](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
eschutho edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-812756533
looks great! I rebased this recently and saw that an earlier commit had a few trims on database_name in the DatabaseModal file. Do we need to add those in?
`db.database_name.trim()`
Here's the PR if you want to make sure that they changes are represented here: https://github.com/apache/superset/pull/13800/files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (aca7984) into [master](https://codecov.io/gh/apache/superset/commit/d54cc6d82aa86444dff0eaff072ee9e8e9ea915f?el=desc) (d54cc6d) will **decrease** coverage by `1.01%`.
> The diff coverage is `70.14%`.
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
- Coverage 77.55% 76.54% -1.02%
==========================================
Files 935 948 +13
Lines 47301 48216 +915
Branches 5907 6178 +271
==========================================
+ Hits 36685 36906 +221
- Misses 10472 11166 +694
Partials 144 144
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `80.60% <ø> (ø)` | |
| postgres | `80.63% <ø> (ø)` | |
| presto | `?` | |
| python | `80.72% <ø> (-0.43%)` | :arrow_down: |
| sqlite | `80.19% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...frontend/src/views/CRUD/data/database/Checkbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9DaGVja2JveC50c3g=) | `29.41% <29.41%> (ø)` | |
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `74.57% <84.00%> (-1.40%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [...ore/components/controls/AnnotationLayerControl.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sLmpzeA==) | `8.57% <0.00%> (-74.29%)` | :arrow_down: |
| [...rc/explore/components/controls/AnnotationLayer.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXIuanN4) | `0.00% <0.00%> (-51.91%)` | :arrow_down: |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `43.75% <0.00%> (-29.69%)` | :arrow_down: |
| [...nd/src/explore/components/controls/TextControl.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UZXh0Q29udHJvbC50c3g=) | `48.83% <0.00%> (-25.59%)` | :arrow_down: |
| [...ntend/src/dashboard/components/dnd/handleScroll.ts](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVTY3JvbGwudHM=) | `26.66% <0.00%> (-20.01%)` | :arrow_down: |
| [...ontend/src/explore/components/DataTableControl.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVDb250cm9sLnRzeA==) | `32.00% <0.00%> (-18.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| ... and [28 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [d54cc6d...aca7984](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
eschutho commented on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-811533907
Uploading Screen Recording 2021-03-31.mov…
Other checkboxes:
existing:
<img width="232" alt="Screenshot_3_31_21__3_57_PM" src="https://user-images.githubusercontent.com/5186919/113223979-3ed9fb00-923f-11eb-8a17-120b8f96f309.png">
new:
<img width="241" alt="Screenshot_3_31_21__3_57_PM" src="https://user-images.githubusercontent.com/5186919/113224142-a001ce80-923f-11eb-987d-01d4d0e2447f.png">
existing:
<img width="321" alt="_DEV__Superset" src="https://user-images.githubusercontent.com/5186919/113224153-a5f7af80-923f-11eb-9e36-1ba4e3439d86.png">
new:
<img width="366" alt="Superset" src="https://user-images.githubusercontent.com/5186919/113224162-ab54fa00-923f-11eb-8740-b97c55fcd5b4.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (e9d9be7) into [master](https://codecov.io/gh/apache/superset/commit/d54cc6d82aa86444dff0eaff072ee9e8e9ea915f?el=desc) (d54cc6d) will **decrease** coverage by `1.28%`.
> The diff coverage is `84.74%`.
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
- Coverage 77.55% 76.26% -1.29%
==========================================
Files 935 948 +13
Lines 47301 48188 +887
Branches 5907 6178 +271
==========================================
+ Hits 36685 36752 +67
- Misses 10472 11292 +820
Partials 144 144
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `80.19% <ø> (-0.96%)` | :arrow_down: |
| sqlite | `80.19% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `74.57% <83.67%> (-1.40%)` | :arrow_down: |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `97.14% <90.00%> (+2.40%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [...ore/components/controls/AnnotationLayerControl.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sLmpzeA==) | `8.57% <0.00%> (-74.29%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `31.37% <0.00%> (-60.79%)` | :arrow_down: |
| [...rc/explore/components/controls/AnnotationLayer.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXIuanN4) | `0.00% <0.00%> (-51.91%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/utils/network.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvbmV0d29yay5weQ==) | `25.80% <0.00%> (-32.26%)` | :arrow_down: |
| [superset/models/sql\_types/base.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF90eXBlcy9iYXNlLnB5) | `52.63% <0.00%> (-31.58%)` | :arrow_down: |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `43.75% <0.00%> (-29.69%)` | :arrow_down: |
| ... and [52 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [d54cc6d...e9d9be7](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (bbd695f) into [master](https://codecov.io/gh/apache/superset/commit/d54cc6d82aa86444dff0eaff072ee9e8e9ea915f?el=desc) (d54cc6d) will **decrease** coverage by `0.04%`.
> The diff coverage is `88.23%`.
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
- Coverage 77.55% 77.51% -0.05%
==========================================
Files 935 935
Lines 47301 47321 +20
Branches 5907 5918 +11
==========================================
- Hits 36685 36681 -4
- Misses 10472 10493 +21
- Partials 144 147 +3
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `63.82% <86.27%> (+0.09%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `79.06% <86.95%> (+3.09%)` | :arrow_up: |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `100.00% <100.00%> (+5.26%)` | :arrow_up: |
| [...rontend/src/views/CRUD/dashboard/DashboardList.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZExpc3QudHN4) | `75.22% <0.00%> (-5.31%)` | :arrow_down: |
| [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `79.84% <0.00%> (-4.66%)` | :arrow_down: |
| [...src/dashboard/components/HeaderActionsDropdown.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlckFjdGlvbnNEcm9wZG93bi5qc3g=) | `67.56% <0.00%> (-4.06%)` | :arrow_down: |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `74.62% <0.00%> (-3.99%)` | :arrow_down: |
| [...t-frontend/src/dashboard/actions/dashboardState.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZFN0YXRlLmpz) | `64.90% <0.00%> (-3.98%)` | :arrow_down: |
| [...erset-frontend/src/dashboard/components/Header.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci5qc3g=) | `63.23% <0.00%> (-3.68%)` | :arrow_down: |
| [superset-frontend/src/filters/utils.ts](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvdXRpbHMudHM=) | `100.00% <0.00%> (+4.76%)` | :arrow_up: |
| [...ontend/src/common/components/InfoTooltip/index.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0luZm9Ub29sdGlwL2luZGV4LnRzeA==) | `100.00% <0.00%> (+46.15%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [d54cc6d...bbd695f](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (791226f) into [master](https://codecov.io/gh/apache/superset/commit/9d6832dc271fcea76302feb4273bd72a8b9d05ba?el=desc) (9d6832d) will **decrease** coverage by `0.26%`.
> The diff coverage is `90.47%`.
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
- Coverage 77.55% 77.28% -0.27%
==========================================
Files 935 936 +1
Lines 47301 47541 +240
Branches 5907 6008 +101
==========================================
+ Hits 36685 36743 +58
- Misses 10472 10650 +178
- Partials 144 148 +4
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `55.35% <65.11%> (-0.69%)` | :arrow_down: |
| hive | `80.29% <ø> (ø)` | |
| javascript | `64.20% <90.47%> (+0.47%)` | :arrow_up: |
| mysql | `80.60% <ø> (ø)` | |
| postgres | `80.63% <ø> (ø)` | |
| presto | `80.30% <ø> (+<0.01%)` | :arrow_up: |
| python | `81.14% <ø> (+<0.01%)` | :arrow_up: |
| sqlite | `80.19% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `82.93% <89.65%> (+6.96%)` | :arrow_up: |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `100.00% <100.00%> (+5.26%)` | :arrow_up: |
| [...nents/controls/MetricControl/AdhocMetricOption.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljT3B0aW9uLmpzeA==) | `72.72% <0.00%> (-27.28%)` | :arrow_down: |
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `46.30% <0.00%> (-23.27%)` | :arrow_down: |
| [...rols/MetricControl/AdhocMetricEditPopoverTitle.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXJUaXRsZS5qc3g=) | `70.58% <0.00%> (-20.59%)` | :arrow_down: |
| [...rontend/src/views/CRUD/dashboard/DashboardList.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZExpc3QudHN4) | `75.22% <0.00%> (-5.31%)` | :arrow_down: |
| [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `79.84% <0.00%> (-4.66%)` | :arrow_down: |
| [...mponents/controls/MetricControl/MetricsControl.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL01ldHJpY3NDb250cm9sLmpzeA==) | `85.96% <0.00%> (-4.10%)` | :arrow_down: |
| [...src/dashboard/components/HeaderActionsDropdown.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlckFjdGlvbnNEcm9wZG93bi5qc3g=) | `67.56% <0.00%> (-4.06%)` | :arrow_down: |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `74.62% <0.00%> (-3.99%)` | :arrow_down: |
| ... and [8 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [9d6832d...791226f](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (791226f) into [master](https://codecov.io/gh/apache/superset/commit/9d6832dc271fcea76302feb4273bd72a8b9d05ba?el=desc) (9d6832d) will **decrease** coverage by `1.20%`.
> The diff coverage is `90.47%`.
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
- Coverage 77.55% 76.34% -1.21%
==========================================
Files 935 936 +1
Lines 47301 47541 +240
Branches 5907 6008 +101
==========================================
- Hits 36685 36296 -389
- Misses 10472 11084 +612
- Partials 144 161 +17
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `49.90% <65.11%> (-6.14%)` | :arrow_down: |
| hive | `80.29% <ø> (ø)` | |
| javascript | `64.20% <90.47%> (+0.47%)` | :arrow_up: |
| mysql | `80.60% <ø> (ø)` | |
| postgres | `80.63% <ø> (ø)` | |
| presto | `80.30% <ø> (+<0.01%)` | :arrow_up: |
| python | `81.14% <ø> (+<0.01%)` | :arrow_up: |
| sqlite | `80.19% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `82.93% <89.65%> (+6.96%)` | :arrow_up: |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `100.00% <100.00%> (+5.26%)` | :arrow_up: |
| [...tend/src/visualizations/FilterBox/controlPanel.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9jb250cm9sUGFuZWwuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rc/explore/components/controls/AnnotationLayer.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXIuanN4) | `2.38% <0.00%> (-49.53%)` | :arrow_down: |
| [...hboard/components/filterscope/FilterScopeModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlTW9kYWwudHN4) | `31.25% <0.00%> (-43.75%)` | :arrow_down: |
| [...teFilterControl/components/DateFunctionTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0RhdGVGdW5jdGlvblRvb2x0aXAudHN4) | `58.33% <0.00%> (-41.67%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CommonFrame.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NvbW1vbkZyYW1lLnRzeA==) | `41.66% <0.00%> (-41.67%)` | :arrow_down: |
| [...ore/components/controls/AnnotationLayerControl.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sLmpzeA==) | `42.85% <0.00%> (-40.00%)` | :arrow_down: |
| [...ols/DateFilterControl/components/CalendarFrame.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NhbGVuZGFyRnJhbWUudHN4) | `46.15% <0.00%> (-38.47%)` | :arrow_down: |
| [...hboard/components/resizable/ResizableContainer.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVDb250YWluZXIuanN4) | `71.87% <0.00%> (-28.13%)` | :arrow_down: |
| ... and [50 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [9d6832d...791226f](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
eschutho commented on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-811534548
@hughhhh @lyndsiWilliams indeterminate checkboxes are only on this modal and the list views. The list views looked ok. I would just make sure that all of the checkboxes in the modal are passing in the label and then just do a check on updating any styles.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (e327537) into [master](https://codecov.io/gh/apache/superset/commit/4187d9e4c4f3e281c3d8021010b9836cd8da12bc?el=desc) (4187d9e) will **decrease** coverage by `0.32%`.
> The diff coverage is `88.23%`.
> :exclamation: Current head e327537 differs from pull request most recent head 9febdce. Consider uploading reports for the commit 9febdce to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
- Coverage 77.83% 77.51% -0.33%
==========================================
Files 934 935 +1
Lines 47350 47320 -30
Branches 5941 5935 -6
==========================================
- Hits 36853 36678 -175
- Misses 10349 10498 +149
+ Partials 148 144 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.02% <74.41%> (+2.79%)` | :arrow_up: |
| hive | `80.29% <ø> (+0.02%)` | :arrow_up: |
| javascript | `63.82% <86.27%> (-2.47%)` | :arrow_down: |
| mysql | `80.60% <ø> (+0.03%)` | :arrow_up: |
| postgres | `80.63% <ø> (+0.03%)` | :arrow_up: |
| python | `81.01% <ø> (+0.02%)` | :arrow_up: |
| sqlite | `80.19% <ø> (+0.03%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `78.94% <86.95%> (+19.20%)` | :arrow_up: |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `100.00% <100.00%> (+5.26%)` | :arrow_up: |
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `35.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CustomFrame.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0N1c3RvbUZyYW1lLnRzeA==) | `42.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...ols/DateFilterControl/components/AdvancedFrame.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0FkdmFuY2VkRnJhbWUudHN4) | `53.84% <0.00%> (-46.16%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.ts](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLnRz) | `46.66% <0.00%> (-40.00%)` | :arrow_down: |
| [...ontrols/DndColumnSelectControl/DndFilterSelect.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZEZpbHRlclNlbGVjdC50c3g=) | `9.23% <0.00%> (-36.16%)` | :arrow_down: |
| [...ontrols/DndColumnSelectControl/DndColumnSelect.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZENvbHVtblNlbGVjdC50c3g=) | `22.58% <0.00%> (-35.49%)` | :arrow_down: |
| [...ontrols/DndColumnSelectControl/DndMetricSelect.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZE1ldHJpY1NlbGVjdC50c3g=) | `10.31% <0.00%> (-33.34%)` | :arrow_down: |
| [...ols/DndColumnSelectControl/utils/optionSelector.ts](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL3V0aWxzL29wdGlvblNlbGVjdG9yLnRz) | `3.44% <0.00%> (-31.04%)` | :arrow_down: |
| ... and [81 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [4187d9e...9febdce](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (bbd695f) into [master](https://codecov.io/gh/apache/superset/commit/d54cc6d82aa86444dff0eaff072ee9e8e9ea915f?el=desc) (d54cc6d) will **decrease** coverage by `0.33%`.
> The diff coverage is `88.23%`.
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
- Coverage 77.55% 77.22% -0.34%
==========================================
Files 935 935
Lines 47301 47293 -8
Branches 5907 5918 +11
==========================================
- Hits 36685 36521 -164
- Misses 10472 10625 +153
- Partials 144 147 +3
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| javascript | `63.82% <86.27%> (+0.09%)` | :arrow_up: |
| mysql | `80.60% <ø> (ø)` | |
| postgres | `?` | |
| presto | `?` | |
| python | `80.60% <ø> (-0.55%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `79.06% <86.95%> (+3.09%)` | :arrow_up: |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `100.00% <100.00%> (+5.26%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `89.53% <0.00%> (-6.98%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.79% <0.00%> (-6.91%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [...rontend/src/views/CRUD/dashboard/DashboardList.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZExpc3QudHN4) | `75.22% <0.00%> (-5.31%)` | :arrow_down: |
| [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `79.84% <0.00%> (-4.66%)` | :arrow_down: |
| ... and [20 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [d54cc6d...bbd695f](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on a change in pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
eschutho commented on a change in pull request #13877:
URL: https://github.com/apache/superset/pull/13877#discussion_r605269863
##########
File path: superset-frontend/src/views/CRUD/data/database/DatabaseModal.tsx
##########
@@ -587,7 +639,7 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps> = ({
<IndeterminateCheckbox
id="impersonate_user"
indeterminate={false}
- checked={db ? !!db.impersonate_user : false}
+ checked={!!db?.impersonate_user}
onChange={onInputChange}
/>
<div>{t('Impersonate Logged In User (Presto & Hive)')}</div>
Review comment:
you may want to move all of these into `labelText` as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on a change in pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
eschutho commented on a change in pull request #13877:
URL: https://github.com/apache/superset/pull/13877#discussion_r605185200
##########
File path: superset-frontend/spec/javascripts/views/CRUD/data/database/DatabaseModal_spec.jsx
##########
@@ -19,71 +19,243 @@
import React from 'react';
import thunk from 'redux-thunk';
import configureStore from 'redux-mock-store';
+import * as redux from 'react-redux';
import { styledMount as mount } from 'spec/helpers/theming';
+import { render, screen } from 'spec/helpers/testing-library';
+import userEvent from '@testing-library/user-event';
+import { supersetTheme, ThemeProvider } from '@superset-ui/core';
+import { Provider } from 'react-redux';
import DatabaseModal from 'src/views/CRUD/data/database/DatabaseModal';
import Modal from 'src/common/components/Modal';
import Tabs from 'src/common/components/Tabs';
import fetchMock from 'fetch-mock';
import waitForComponentToPaint from 'spec/helpers/waitForComponentToPaint';
+import { initialState } from 'spec/javascripts/sqllab/fixtures';
// store needed for withToasts(DatabaseModal)
const mockStore = configureStore([thunk]);
const store = mockStore({});
-
const mockedProps = {
show: true,
};
-
const dbProps = {
show: true,
database: {
id: 10,
database_name: 'test',
sqlalchemy_uri: 'sqllite:///user:pw/test',
+ expose_in_sqllab: true,
},
};
-jest.mock('react-redux', () => ({
- ...jest.requireActual('react-redux'),
- useSelector: jest.fn(),
-}));
-
const DATABASE_ENDPOINT = 'glob:*/api/v1/database/*';
-
fetchMock.get(DATABASE_ENDPOINT, {});
describe('DatabaseModal', () => {
- const wrapper = mount(<DatabaseModal store={store} {...mockedProps} />);
-
- it('renders', () => {
- expect(wrapper.find(DatabaseModal)).toExist();
+ describe('enzyme', () => {
+ let wrapper;
+ let spyOnUseSelector;
+ beforeAll(() => {
+ spyOnUseSelector = jest.spyOn(redux, 'useSelector');
+ spyOnUseSelector.mockReturnValue(initialState.common.conf);
+ });
+ beforeEach(() => {
+ wrapper = mount(
+ <Provider store={store}>
+ <DatabaseModal store={store} {...mockedProps} />
+ </Provider>,
+ );
+ });
+ afterEach(() => {
+ wrapper.unmount();
+ });
+ it('renders', () => {
+ expect(wrapper.find(DatabaseModal)).toExist();
+ });
+ it('renders a Modal', () => {
+ expect(wrapper.find(Modal)).toExist();
+ });
+ it('renders "Add database" header when no database is included', () => {
+ expect(wrapper.find('h4').text()).toEqual('Add database');
+ });
+ it('renders "Edit database" header when database prop is included', () => {
+ const editWrapper = mount(<DatabaseModal store={store} {...dbProps} />);
+ waitForComponentToPaint(editWrapper);
+ expect(editWrapper.find('h4').text()).toEqual('Edit database');
+ editWrapper.unmount();
+ });
+ it('renders a Tabs menu', () => {
+ expect(wrapper.find(Tabs)).toExist();
+ });
+ it('renders five TabPanes', () => {
+ expect(wrapper.find(Tabs.TabPane)).toExist();
+ expect(wrapper.find(Tabs.TabPane)).toHaveLength(5);
+ });
+ it('renders input elements for Connection section', () => {
+ expect(wrapper.find('input[name="database_name"]')).toExist();
+ expect(wrapper.find('input[name="sqlalchemy_uri"]')).toExist();
+ });
});
- it('renders a Modal', () => {
- expect(wrapper.find(Modal)).toExist();
- });
+ describe('RTL', () => {
+ describe('initial load', () => {
+ it('hides the forms from the db when not selected', () => {
+ render(
+ <ThemeProvider theme={supersetTheme}>
+ <Provider store={store}>
+ <DatabaseModal
+ show
+ database={{
+ expose_in_sqllab: false,
+ allow_ctas: false,
+ allow_cvas: false,
+ }}
+ />
+ </Provider>
+ </ThemeProvider>,
+ );
+ // Select SQL Lab settings tab
+ const sqlLabSettingsTab = screen.getByRole('tab', {
+ name: /sql lab settings/i,
+ });
+ userEvent.click(sqlLabSettingsTab);
- it('renders "Add database" header when no database is included', () => {
- expect(wrapper.find('h4').text()).toEqual('Add database');
- });
+ const exposeInSqlLab = screen.getByText('Expose in SQL Lab');
+ const exposeChoicesForm = exposeInSqlLab.parentElement.nextSibling;
+ const schemaField = screen.getByText('CTAS & CVAS SCHEMA')
+ .parentElement;
+ expect(exposeChoicesForm).not.toHaveClass('open');
+ expect(schemaField).not.toHaveClass('open');
+ });
+ });
+ it('renders all settings when "Expose in SQL Lab" is checked', () => {
+ render(
+ <ThemeProvider theme={supersetTheme}>
+ <Provider store={store}>
+ <DatabaseModal {...dbProps} />
+ </Provider>
+ </ThemeProvider>,
+ );
- it('renders "Edit database" header when database prop is included', () => {
- const editWrapper = mount(<DatabaseModal store={store} {...dbProps} />);
- waitForComponentToPaint(editWrapper);
- expect(editWrapper.find('h4').text()).toEqual('Edit database');
- });
+ // Select SQL Lab settings tab
+ const sqlLabSettingsTab = screen.getByRole('tab', {
+ name: /sql lab settings/i,
+ });
- it('renders a Tabs menu', () => {
- expect(wrapper.find(Tabs)).toExist();
- });
+ userEvent.click(sqlLabSettingsTab);
+ // Grab all SQL Lab Settings by their labels
+ // const exposeInSqlLab = screen.getByText('Expose in SQL Lab');
+ const exposeInSqlLab = screen.getByRole('checkbox', {
+ name: /expose in sql lab/i,
+ });
- it('renders five TabPanes', () => {
- expect(wrapper.find(Tabs.TabPane)).toExist();
- expect(wrapper.find(Tabs.TabPane)).toHaveLength(5);
- });
+ // While 'Expose in SQL Lab' is checked, all settings should display
+ expect(exposeInSqlLab).not.toBeChecked();
+
+ // When clicked, "Expose in SQL Lab" becomes unchecked
+ userEvent.click(exposeInSqlLab);
+
+ // While unchecked, only "Expose in SQL Lab" should display
Review comment:
Are the comments still aligned with the code? This says unchecked, while the assertion below is checked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (16fe3aa) into [master](https://codecov.io/gh/apache/superset/commit/4187d9e4c4f3e281c3d8021010b9836cd8da12bc?el=desc) (4187d9e) will **increase** coverage by `0.39%`.
> The diff coverage is `80.32%`.
> :exclamation: Current head 16fe3aa differs from pull request most recent head 9febdce. Consider uploading reports for the commit 9febdce to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
+ Coverage 77.91% 78.31% +0.39%
==========================================
Files 934 934
Lines 47350 47467 +117
Branches 5941 5993 +52
==========================================
+ Hits 36894 37175 +281
+ Misses 10308 10148 -160
+ Partials 148 144 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.04% <74.41%> (+2.81%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `71.76% <78.00%> (+12.02%)` | :arrow_up: |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `94.28% <90.90%> (-0.46%)` | :arrow_down: |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `90.90% <0.00%> (-1.52%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `63.26% <0.00%> (+0.20%)` | :arrow_up: |
| [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `81.01% <0.00%> (+1.26%)` | :arrow_up: |
| [...-frontend/src/dashboard/actions/dashboardLayout.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZExheW91dC5qcw==) | `98.03% <0.00%> (+1.96%)` | :arrow_up: |
| [...frontend/src/dashboard/reducers/dashboardLayout.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRMYXlvdXQuanM=) | `99.00% <0.00%> (+2.00%)` | :arrow_up: |
| [superset-frontend/src/views/routes.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL3JvdXRlcy50c3g=) | `56.81% <0.00%> (+2.27%)` | :arrow_up: |
| [...-frontend/src/dashboard/reducers/dashboardState.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRTdGF0ZS5qcw==) | `85.71% <0.00%> (+3.57%)` | :arrow_up: |
| ... and [19 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [4187d9e...9febdce](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-813663873
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (791226f) into [master](https://codecov.io/gh/apache/superset/commit/9d6832dc271fcea76302feb4273bd72a8b9d05ba?el=desc) (9d6832d) will **decrease** coverage by `0.53%`.
> The diff coverage is `90.90%`.
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
- Coverage 77.48% 76.95% -0.54%
==========================================
Files 935 938 +3
Lines 47301 47631 +330
Branches 5907 6052 +145
==========================================
Hits 36653 36653
- Misses 10504 10827 +323
- Partials 144 151 +7
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `64.20% <90.47%> (+0.47%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `81.59% <90.16%> (+5.62%)` | :arrow_up: |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `100.00% <100.00%> (+5.26%)` | :arrow_up: |
| [...tend/src/visualizations/FilterBox/controlPanel.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9jb250cm9sUGFuZWwuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ontend/src/dashboard/util/serializeFilterScopes.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3NlcmlhbGl6ZUZpbHRlclNjb3Blcy5qcw==) | `40.00% <0.00%> (-60.00%)` | :arrow_down: |
| [...nd/src/dashboard/util/getFilterValuesByFilterId.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclZhbHVlc0J5RmlsdGVySWQuanM=) | `25.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...et-frontend/src/dashboard/components/SaveModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NhdmVNb2RhbC50c3g=) | `47.16% <0.00%> (-33.97%)` | :arrow_down: |
| [...frontend/src/dashboard/actions/dashboardFilters.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZEZpbHRlcnMuanM=) | `42.85% <0.00%> (-25.72%)` | :arrow_down: |
| [...nd/src/explore/components/controls/TextControl.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UZXh0Q29udHJvbC50c3g=) | `48.83% <0.00%> (-25.59%)` | :arrow_down: |
| [...uperset-frontend/src/components/Checkbox/index.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hlY2tib3gvaW5kZXgudHN4) | `75.00% <0.00%> (-25.00%)` | :arrow_down: |
| [.../explore/components/controls/CollectionControl.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xsZWN0aW9uQ29udHJvbC5qc3g=) | `21.21% <0.00%> (-24.25%)` | :arrow_down: |
| ... and [45 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [9d6832d...791226f](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (07dc6ff) into [master](https://codecov.io/gh/apache/superset/commit/d54cc6d82aa86444dff0eaff072ee9e8e9ea915f?el=desc) (d54cc6d) will **decrease** coverage by `0.77%`.
> The diff coverage is `88.23%`.
> :exclamation: Current head 07dc6ff differs from pull request most recent head bbd695f. Consider uploading reports for the commit bbd695f to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
- Coverage 77.55% 76.78% -0.78%
==========================================
Files 935 935
Lines 47301 47321 +20
Branches 5907 5918 +11
==========================================
- Hits 36685 36334 -351
- Misses 10472 10833 +361
- Partials 144 154 +10
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `51.21% <65.11%> (-4.82%)` | :arrow_down: |
| javascript | `63.82% <86.27%> (+0.09%)` | :arrow_up: |
| presto | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `79.06% <86.95%> (+3.09%)` | :arrow_up: |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `100.00% <100.00%> (+5.26%)` | :arrow_up: |
| [...hboard/components/filterscope/FilterScopeModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlTW9kYWwudHN4) | `31.25% <0.00%> (-43.75%)` | :arrow_down: |
| [...erset-frontend/src/common/hooks/useUrlShortener.ts](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VVcmxTaG9ydGVuZXIudHM=) | `50.00% <0.00%> (-42.86%)` | :arrow_down: |
| [...teFilterControl/components/DateFunctionTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0RhdGVGdW5jdGlvblRvb2x0aXAudHN4) | `58.33% <0.00%> (-41.67%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CommonFrame.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NvbW1vbkZyYW1lLnRzeA==) | `41.66% <0.00%> (-41.67%)` | :arrow_down: |
| [...ols/DateFilterControl/components/CalendarFrame.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NhbGVuZGFyRnJhbWUudHN4) | `46.15% <0.00%> (-38.47%)` | :arrow_down: |
| [...hboard/components/resizable/ResizableContainer.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVDb250YWluZXIuanN4) | `71.87% <0.00%> (-28.13%)` | :arrow_down: |
| [...nents/controls/MetricControl/AdhocMetricOption.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljT3B0aW9uLmpzeA==) | `72.72% <0.00%> (-27.28%)` | :arrow_down: |
| [...ols/DateFilterControl/components/AdvancedFrame.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0FkdmFuY2VkRnJhbWUudHN4) | `26.92% <0.00%> (-26.93%)` | :arrow_down: |
| ... and [47 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [d54cc6d...bbd695f](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] hughhhh commented on a change in pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
hughhhh commented on a change in pull request #13877:
URL: https://github.com/apache/superset/pull/13877#discussion_r605728323
##########
File path: superset-frontend/spec/javascripts/sqllab/fixtures.ts
##########
@@ -480,6 +480,8 @@ export const initialState = {
DEFAULT_SQLLAB_LIMIT: 1000,
SQL_MAX_ROW: 100000,
DISPLAY_MAX_ROW: 100,
+ SQLALCHEMY_DOCS_URL: 'test_SQLALCHEMY_DOCS_URL',
+ SQLALCHEMY_DISPLAY_TEXT: 'test_SQLALCHEMY_DISPLAY_TEXT',
Review comment:
not sure but we wanted to update the fixture to make sure it has all the config items
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (07dc6ff) into [master](https://codecov.io/gh/apache/superset/commit/d54cc6d82aa86444dff0eaff072ee9e8e9ea915f?el=desc) (d54cc6d) will **decrease** coverage by `0.49%`.
> The diff coverage is `88.23%`.
> :exclamation: Current head 07dc6ff differs from pull request most recent head bcee82f. Consider uploading reports for the commit bcee82f to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
- Coverage 77.55% 77.06% -0.50%
==========================================
Files 935 935
Lines 47301 47321 +20
Branches 5907 5918 +11
==========================================
- Hits 36685 36466 -219
- Misses 10472 10701 +229
- Partials 144 154 +10
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.73% <65.11%> (-2.30%)` | :arrow_down: |
| javascript | `63.82% <86.27%> (+0.09%)` | :arrow_up: |
| presto | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `79.06% <86.95%> (+3.09%)` | :arrow_up: |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `100.00% <100.00%> (+5.26%)` | :arrow_up: |
| [...erset-frontend/src/common/hooks/useUrlShortener.ts](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VVcmxTaG9ydGVuZXIudHM=) | `50.00% <0.00%> (-42.86%)` | :arrow_down: |
| [...teFilterControl/components/DateFunctionTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0RhdGVGdW5jdGlvblRvb2x0aXAudHN4) | `58.33% <0.00%> (-41.67%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CommonFrame.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NvbW1vbkZyYW1lLnRzeA==) | `41.66% <0.00%> (-41.67%)` | :arrow_down: |
| [...ols/DateFilterControl/components/CalendarFrame.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NhbGVuZGFyRnJhbWUudHN4) | `46.15% <0.00%> (-38.47%)` | :arrow_down: |
| [...ols/DateFilterControl/components/AdvancedFrame.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0FkdmFuY2VkRnJhbWUudHN4) | `26.92% <0.00%> (-26.93%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CustomFrame.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0N1c3RvbUZyYW1lLnRzeA==) | `16.00% <0.00%> (-26.00%)` | :arrow_down: |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `48.43% <0.00%> (-25.00%)` | :arrow_down: |
| [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `49.29% <0.00%> (-16.91%)` | :arrow_down: |
| ... and [29 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [d54cc6d...bcee82f](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-812641223
@hughhhh Ephemeral environment creation is currently limited to committers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (cedabe2) into [master](https://codecov.io/gh/apache/superset/commit/4187d9e4c4f3e281c3d8021010b9836cd8da12bc?el=desc) (4187d9e) will **decrease** coverage by `0.07%`.
> The diff coverage is `88.23%`.
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
- Coverage 77.91% 77.83% -0.08%
==========================================
Files 934 934
Lines 47350 47342 -8
Branches 5941 5946 +5
==========================================
- Hits 36894 36850 -44
- Misses 10308 10348 +40
+ Partials 148 144 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `80.16% <ø> (-0.99%)` | :arrow_down: |
| sqlite | `80.16% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `78.94% <86.95%> (+19.20%)` | :arrow_up: |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `100.00% <100.00%> (+5.26%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `31.37% <0.00%> (-60.79%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/utils/network.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvbmV0d29yay5weQ==) | `25.80% <0.00%> (-32.26%)` | :arrow_down: |
| [superset/models/sql\_types/base.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF90eXBlcy9iYXNlLnB5) | `52.63% <0.00%> (-31.58%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `60.34% <0.00%> (-22.42%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.42% <0.00%> (-16.42%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| ... and [51 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [4187d9e...cedabe2](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (aca7984) into [master](https://codecov.io/gh/apache/superset/commit/d54cc6d82aa86444dff0eaff072ee9e8e9ea915f?el=desc) (d54cc6d) will **decrease** coverage by `0.97%`.
> The diff coverage is `89.70%`.
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
- Coverage 77.55% 76.57% -0.98%
==========================================
Files 935 948 +13
Lines 47301 48139 +838
Branches 5907 6156 +249
==========================================
+ Hits 36685 36864 +179
- Misses 10472 11131 +659
Partials 144 144
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| javascript | `63.84% <88.23%> (+0.11%)` | :arrow_up: |
| mysql | `80.60% <ø> (ø)` | |
| postgres | `80.63% <ø> (ø)` | |
| presto | `?` | |
| python | `80.72% <ø> (-0.43%)` | :arrow_down: |
| sqlite | `80.19% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `78.94% <87.23%> (+2.97%)` | :arrow_up: |
| [...frontend/src/views/CRUD/data/database/Checkbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9DaGVja2JveC50c3g=) | `95.23% <95.23%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [...ore/components/controls/AnnotationLayerControl.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sLmpzeA==) | `8.57% <0.00%> (-74.29%)` | :arrow_down: |
| [...rc/explore/components/controls/AnnotationLayer.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXIuanN4) | `0.00% <0.00%> (-51.91%)` | :arrow_down: |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `43.75% <0.00%> (-29.69%)` | :arrow_down: |
| [...nd/src/explore/components/controls/TextControl.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UZXh0Q29udHJvbC50c3g=) | `48.83% <0.00%> (-25.59%)` | :arrow_down: |
| [...ntend/src/dashboard/components/dnd/handleScroll.ts](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVTY3JvbGwudHM=) | `26.66% <0.00%> (-20.01%)` | :arrow_down: |
| [...ontend/src/explore/components/DataTableControl.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVDb250cm9sLnRzeA==) | `32.00% <0.00%> (-18.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| ... and [26 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [d54cc6d...aca7984](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] hughhhh commented on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
hughhhh commented on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-813636481
> looks great! I rebased this recently and saw that an earlier commit had a few trims on database_name in the DatabaseModal file. Do we need to add those in?
db.database_name.trim()
Here's the PR if you want to make sure that they changes are represented here: #13800 (files)
Those changes we need are currently on the branch already, the other `database_name` reference don't need to have `trim`. We can add them if want the consistency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (9febdce) into [master](https://codecov.io/gh/apache/superset/commit/4187d9e4c4f3e281c3d8021010b9836cd8da12bc?el=desc) (4187d9e) will **decrease** coverage by `0.24%`.
> The diff coverage is `75.00%`.
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
- Coverage 77.91% 77.66% -0.25%
==========================================
Files 934 934
Lines 47350 47350
Branches 5941 5941
==========================================
- Hits 36894 36776 -118
- Misses 10308 10426 +118
Partials 148 148
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `80.56% <ø> (ø)` | |
| postgres | `80.60% <ø> (+<0.01%)` | :arrow_up: |
| presto | `?` | |
| python | `80.68% <ø> (-0.47%)` | :arrow_down: |
| sqlite | `80.16% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `59.74% <71.42%> (ø)` | |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `94.73% <85.71%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.42% <0.00%> (-16.42%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.83% <0.00%> (-6.89%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.10% <0.00%> (-1.68%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `86.62% <0.00%> (-0.46%)` | :arrow_down: |
| ... and [2 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [4187d9e...9febdce](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (07dc6ff) into [master](https://codecov.io/gh/apache/superset/commit/d54cc6d82aa86444dff0eaff072ee9e8e9ea915f?el=desc) (d54cc6d) will **decrease** coverage by `0.49%`.
> The diff coverage is `88.23%`.
> :exclamation: Current head 07dc6ff differs from pull request most recent head bbd695f. Consider uploading reports for the commit bbd695f to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
- Coverage 77.55% 77.06% -0.50%
==========================================
Files 935 935
Lines 47301 47321 +20
Branches 5907 5918 +11
==========================================
- Hits 36685 36466 -219
- Misses 10472 10701 +229
- Partials 144 154 +10
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.73% <65.11%> (-2.30%)` | :arrow_down: |
| javascript | `63.82% <86.27%> (+0.09%)` | :arrow_up: |
| presto | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `79.06% <86.95%> (+3.09%)` | :arrow_up: |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `100.00% <100.00%> (+5.26%)` | :arrow_up: |
| [...erset-frontend/src/common/hooks/useUrlShortener.ts](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VVcmxTaG9ydGVuZXIudHM=) | `50.00% <0.00%> (-42.86%)` | :arrow_down: |
| [...teFilterControl/components/DateFunctionTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0RhdGVGdW5jdGlvblRvb2x0aXAudHN4) | `58.33% <0.00%> (-41.67%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CommonFrame.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NvbW1vbkZyYW1lLnRzeA==) | `41.66% <0.00%> (-41.67%)` | :arrow_down: |
| [...ols/DateFilterControl/components/CalendarFrame.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NhbGVuZGFyRnJhbWUudHN4) | `46.15% <0.00%> (-38.47%)` | :arrow_down: |
| [...ols/DateFilterControl/components/AdvancedFrame.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0FkdmFuY2VkRnJhbWUudHN4) | `26.92% <0.00%> (-26.93%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CustomFrame.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0N1c3RvbUZyYW1lLnRzeA==) | `16.00% <0.00%> (-26.00%)` | :arrow_down: |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `48.43% <0.00%> (-25.00%)` | :arrow_down: |
| [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `49.29% <0.00%> (-16.91%)` | :arrow_down: |
| ... and [29 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [d54cc6d...bbd695f](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (aca7984) into [master](https://codecov.io/gh/apache/superset/commit/d54cc6d82aa86444dff0eaff072ee9e8e9ea915f?el=desc) (d54cc6d) will **decrease** coverage by `1.04%`.
> The diff coverage is `70.14%`.
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
- Coverage 77.55% 76.51% -1.05%
==========================================
Files 935 948 +13
Lines 47301 48188 +887
Branches 5907 6178 +271
==========================================
+ Hits 36685 36869 +184
- Misses 10472 11175 +703
Partials 144 144
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `80.61% <ø> (-0.02%)` | :arrow_down: |
| presto | `?` | |
| python | `80.66% <ø> (-0.49%)` | :arrow_down: |
| sqlite | `80.19% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...frontend/src/views/CRUD/data/database/Checkbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9DaGVja2JveC50c3g=) | `29.41% <29.41%> (ø)` | |
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `74.57% <84.00%> (-1.40%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [...ore/components/controls/AnnotationLayerControl.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sLmpzeA==) | `8.57% <0.00%> (-74.29%)` | :arrow_down: |
| [...rc/explore/components/controls/AnnotationLayer.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXIuanN4) | `0.00% <0.00%> (-51.91%)` | :arrow_down: |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `43.75% <0.00%> (-29.69%)` | :arrow_down: |
| [...nd/src/explore/components/controls/TextControl.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UZXh0Q29udHJvbC50c3g=) | `48.83% <0.00%> (-25.59%)` | :arrow_down: |
| [...ntend/src/dashboard/components/dnd/handleScroll.ts](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVTY3JvbGwudHM=) | `26.66% <0.00%> (-20.01%)` | :arrow_down: |
| [...ontend/src/explore/components/DataTableControl.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVDb250cm9sLnRzeA==) | `32.00% <0.00%> (-18.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| ... and [37 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [d54cc6d...aca7984](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (cedabe2) into [master](https://codecov.io/gh/apache/superset/commit/4187d9e4c4f3e281c3d8021010b9836cd8da12bc?el=desc) (4187d9e) will **increase** coverage by `0.18%`.
> The diff coverage is `88.23%`.
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
+ Coverage 77.91% 78.10% +0.18%
==========================================
Files 934 934
Lines 47350 47342 -8
Branches 5941 5946 +5
==========================================
+ Hits 36894 36977 +83
+ Misses 10308 10221 -87
+ Partials 148 144 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `80.56% <ø> (ø)` | |
| postgres | `80.58% <ø> (-0.02%)` | :arrow_down: |
| presto | `?` | |
| python | `80.66% <ø> (-0.49%)` | :arrow_down: |
| sqlite | `80.16% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `78.94% <86.95%> (+19.20%)` | :arrow_up: |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `100.00% <100.00%> (+5.26%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.42% <0.00%> (-16.42%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.83% <0.00%> (-6.89%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `75.37% <0.00%> (-2.25%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.08% <0.00%> (-1.69%)` | :arrow_down: |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `90.90% <0.00%> (-1.52%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `86.62% <0.00%> (-0.46%)` | :arrow_down: |
| ... and [34 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [4187d9e...cedabe2](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (07dc6ff) into [master](https://codecov.io/gh/apache/superset/commit/d54cc6d82aa86444dff0eaff072ee9e8e9ea915f?el=desc) (d54cc6d) will **decrease** coverage by `0.49%`.
> The diff coverage is `88.23%`.
> :exclamation: Current head 07dc6ff differs from pull request most recent head 093d946. Consider uploading reports for the commit 093d946 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
- Coverage 77.55% 77.06% -0.50%
==========================================
Files 935 935
Lines 47301 47321 +20
Branches 5907 5918 +11
==========================================
- Hits 36685 36466 -219
- Misses 10472 10701 +229
- Partials 144 154 +10
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.73% <65.11%> (-2.30%)` | :arrow_down: |
| javascript | `63.82% <86.27%> (+0.09%)` | :arrow_up: |
| presto | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `79.06% <86.95%> (+3.09%)` | :arrow_up: |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `100.00% <100.00%> (+5.26%)` | :arrow_up: |
| [...erset-frontend/src/common/hooks/useUrlShortener.ts](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VVcmxTaG9ydGVuZXIudHM=) | `50.00% <0.00%> (-42.86%)` | :arrow_down: |
| [...teFilterControl/components/DateFunctionTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0RhdGVGdW5jdGlvblRvb2x0aXAudHN4) | `58.33% <0.00%> (-41.67%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CommonFrame.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NvbW1vbkZyYW1lLnRzeA==) | `41.66% <0.00%> (-41.67%)` | :arrow_down: |
| [...ols/DateFilterControl/components/CalendarFrame.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NhbGVuZGFyRnJhbWUudHN4) | `46.15% <0.00%> (-38.47%)` | :arrow_down: |
| [...ols/DateFilterControl/components/AdvancedFrame.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0FkdmFuY2VkRnJhbWUudHN4) | `26.92% <0.00%> (-26.93%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CustomFrame.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0N1c3RvbUZyYW1lLnRzeA==) | `16.00% <0.00%> (-26.00%)` | :arrow_down: |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `48.43% <0.00%> (-25.00%)` | :arrow_down: |
| [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `49.29% <0.00%> (-16.91%)` | :arrow_down: |
| ... and [29 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [d54cc6d...093d946](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (12a32eb) into [master](https://codecov.io/gh/apache/superset/commit/d54cc6d82aa86444dff0eaff072ee9e8e9ea915f?el=desc) (d54cc6d) will **decrease** coverage by `1.91%`.
> The diff coverage is `90.47%`.
> :exclamation: Current head 12a32eb differs from pull request most recent head bbd695f. Consider uploading reports for the commit bbd695f to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
- Coverage 77.55% 75.64% -1.92%
==========================================
Files 935 936 +1
Lines 47301 47541 +240
Branches 5907 6008 +101
==========================================
- Hits 36685 35961 -724
- Misses 10472 11395 +923
- Partials 144 185 +41
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `43.55% <65.11%> (-12.48%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `82.93% <89.65%> (+6.96%)` | :arrow_up: |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `100.00% <100.00%> (+5.26%)` | :arrow_up: |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rontend/src/dashboard/components/dnd/handleDrop.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVEcm9wLmpz) | `0.00% <0.00%> (-96.16%)` | :arrow_down: |
| [...ontend/src/dashboard/components/dnd/handleHover.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVIb3Zlci5qcw==) | `11.11% <0.00%> (-88.89%)` | :arrow_down: |
| [...ponents/Select/WindowedSelect/WindowedMenuList.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L1dpbmRvd2VkTWVudUxpc3QudHN4) | `10.71% <0.00%> (-85.72%)` | :arrow_down: |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `0.00% <0.00%> (-81.82%)` | :arrow_down: |
| [...ontend/src/filters/components/Select/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvYnVpbGRRdWVyeS50cw==) | `0.00% <0.00%> (-77.78%)` | :arrow_down: |
| [...rc/dashboard/components/dnd/dragDroppableConfig.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9kcmFnRHJvcHBhYmxlQ29uZmlnLmpz) | `35.00% <0.00%> (-65.00%)` | :arrow_down: |
| [...c/dashboard/components/dnd/AddSliceDragPreview.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9BZGRTbGljZURyYWdQcmV2aWV3LmpzeA==) | `35.71% <0.00%> (-64.29%)` | :arrow_down: |
| ... and [88 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [d54cc6d...bbd695f](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (791226f) into [master](https://codecov.io/gh/apache/superset/commit/9d6832dc271fcea76302feb4273bd72a8b9d05ba?el=desc) (9d6832d) will **decrease** coverage by `1.38%`.
> The diff coverage is `90.47%`.
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
- Coverage 77.48% 76.10% -1.39%
==========================================
Files 935 936 +1
Lines 47301 47513 +212
Branches 5907 6008 +101
==========================================
- Hits 36653 36161 -492
- Misses 10504 11191 +687
- Partials 144 161 +17
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `49.90% <65.11%> (-6.14%)` | :arrow_down: |
| hive | `?` | |
| javascript | `64.20% <90.47%> (+0.47%)` | :arrow_up: |
| mysql | `80.60% <ø> (ø)` | |
| postgres | `80.61% <ø> (-0.02%)` | :arrow_down: |
| python | `80.70% <ø> (-0.32%)` | :arrow_down: |
| sqlite | `80.19% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `82.93% <89.65%> (+6.96%)` | :arrow_up: |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `100.00% <100.00%> (+5.26%)` | :arrow_up: |
| [...tend/src/visualizations/FilterBox/controlPanel.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9jb250cm9sUGFuZWwuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [...rc/explore/components/controls/AnnotationLayer.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXIuanN4) | `2.38% <0.00%> (-49.53%)` | :arrow_down: |
| [...hboard/components/filterscope/FilterScopeModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlTW9kYWwudHN4) | `31.25% <0.00%> (-43.75%)` | :arrow_down: |
| [...teFilterControl/components/DateFunctionTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0RhdGVGdW5jdGlvblRvb2x0aXAudHN4) | `58.33% <0.00%> (-41.67%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CommonFrame.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NvbW1vbkZyYW1lLnRzeA==) | `41.66% <0.00%> (-41.67%)` | :arrow_down: |
| [...ore/components/controls/AnnotationLayerControl.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sLmpzeA==) | `42.85% <0.00%> (-40.00%)` | :arrow_down: |
| [...ols/DateFilterControl/components/CalendarFrame.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NhbGVuZGFyRnJhbWUudHN4) | `46.15% <0.00%> (-38.47%)` | :arrow_down: |
| ... and [62 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [9d6832d...791226f](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (791226f) into [master](https://codecov.io/gh/apache/superset/commit/9d6832dc271fcea76302feb4273bd72a8b9d05ba?el=desc) (9d6832d) will **decrease** coverage by `1.36%`.
> The diff coverage is `90.47%`.
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
- Coverage 77.48% 76.11% -1.37%
==========================================
Files 935 936 +1
Lines 47301 47541 +240
Branches 5907 6008 +101
==========================================
- Hits 36653 36188 -465
- Misses 10504 11192 +688
- Partials 144 161 +17
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `49.90% <65.11%> (-6.14%)` | :arrow_down: |
| hive | `?` | |
| javascript | `64.20% <90.47%> (+0.47%)` | :arrow_up: |
| mysql | `80.60% <ø> (ø)` | |
| postgres | `80.63% <ø> (ø)` | |
| python | `80.72% <ø> (-0.30%)` | :arrow_down: |
| sqlite | `80.19% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `82.93% <89.65%> (+6.96%)` | :arrow_up: |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `100.00% <100.00%> (+5.26%)` | :arrow_up: |
| [...tend/src/visualizations/FilterBox/controlPanel.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9jb250cm9sUGFuZWwuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [...rc/explore/components/controls/AnnotationLayer.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXIuanN4) | `2.38% <0.00%> (-49.53%)` | :arrow_down: |
| [...hboard/components/filterscope/FilterScopeModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlTW9kYWwudHN4) | `31.25% <0.00%> (-43.75%)` | :arrow_down: |
| [...teFilterControl/components/DateFunctionTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0RhdGVGdW5jdGlvblRvb2x0aXAudHN4) | `58.33% <0.00%> (-41.67%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CommonFrame.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NvbW1vbkZyYW1lLnRzeA==) | `41.66% <0.00%> (-41.67%)` | :arrow_down: |
| [...ore/components/controls/AnnotationLayerControl.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sLmpzeA==) | `42.85% <0.00%> (-40.00%)` | :arrow_down: |
| [...ols/DateFilterControl/components/CalendarFrame.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NhbGVuZGFyRnJhbWUudHN4) | `46.15% <0.00%> (-38.47%)` | :arrow_down: |
| ... and [54 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [9d6832d...791226f](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (e9d9be7) into [master](https://codecov.io/gh/apache/superset/commit/d54cc6d82aa86444dff0eaff072ee9e8e9ea915f?el=desc) (d54cc6d) will **decrease** coverage by `0.52%`.
> The diff coverage is `88.23%`.
> :exclamation: Current head e9d9be7 differs from pull request most recent head e327537. Consider uploading reports for the commit e327537 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
- Coverage 77.55% 77.03% -0.53%
==========================================
Files 935 935
Lines 47301 47320 +19
Branches 5907 5935 +28
==========================================
- Hits 36685 36452 -233
- Misses 10472 10718 +246
- Partials 144 150 +6
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.44% <74.41%> (-1.59%)` | :arrow_down: |
| hive | `?` | |
| javascript | `63.82% <86.27%> (+0.09%)` | :arrow_up: |
| mysql | `80.60% <ø> (ø)` | |
| postgres | `80.63% <ø> (ø)` | |
| presto | `?` | |
| python | `80.72% <ø> (-0.43%)` | :arrow_down: |
| sqlite | `80.19% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `78.94% <86.95%> (+2.97%)` | :arrow_up: |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `100.00% <100.00%> (+5.26%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `59.25% <0.00%> (-40.75%)` | :arrow_down: |
| [...nd/src/explore/components/controls/TextControl.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UZXh0Q29udHJvbC50c3g=) | `48.83% <0.00%> (-25.59%)` | :arrow_down: |
| [...ore/components/controls/AnnotationLayerControl.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sLmpzeA==) | `65.71% <0.00%> (-17.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| [...ntend/src/dashboard/components/PropertiesModal.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC5qc3g=) | `58.08% <0.00%> (-16.18%)` | :arrow_down: |
| [...erset-frontend/src/dashboard/components/Header.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci5qc3g=) | `54.41% <0.00%> (-12.50%)` | :arrow_down: |
| [...t-frontend/src/dashboard/actions/dashboardState.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZFN0YXRlLmpz) | `59.60% <0.00%> (-9.28%)` | :arrow_down: |
| ... and [22 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [d54cc6d...e327537](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (03d120a) into [master](https://codecov.io/gh/apache/superset/commit/d54cc6d82aa86444dff0eaff072ee9e8e9ea915f?el=desc) (d54cc6d) will **increase** coverage by `0.58%`.
> The diff coverage is `90.00%`.
> :exclamation: Current head 03d120a differs from pull request most recent head aca7984. Consider uploading reports for the commit aca7984 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
+ Coverage 77.55% 78.14% +0.58%
==========================================
Files 935 935
Lines 47301 47340 +39
Branches 5907 5950 +43
==========================================
+ Hits 36685 36992 +307
+ Misses 10472 10204 -268
Partials 144 144
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.00% <64.17%> (-0.03%)` | :arrow_down: |
| hive | `?` | |
| javascript | `66.40% <88.88%> (+2.67%)` | :arrow_up: |
| presto | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...frontend/src/components/DatabaseSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci9pbmRleC50c3g=) | `92.70% <ø> (+1.04%)` | :arrow_up: |
| [...et-frontend/src/components/TableSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci9pbmRleC50c3g=) | `84.92% <ø> (ø)` | |
| [...src/dashboard/components/dnd/handleScroll/index.ts](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVTY3JvbGwvaW5kZXgudHM=) | `73.33% <ø> (ø)` | |
| [...d/src/explore/components/DatasourcePanel/index.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwvaW5kZXgudHN4) | `87.93% <ø> (ø)` | |
| [...rc/explore/components/DisplayQueryButton/index.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24vaW5kZXguanN4) | `100.00% <ø> (ø)` | |
| [...ontrols/AnnotationLayerControl/AnnotationLayer.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sL0Fubm90YXRpb25MYXllci5qc3g=) | `84.76% <ø> (ø)` | |
| [...mponents/controls/AnnotationLayerControl/index.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sL2luZGV4LmpzeA==) | `82.85% <ø> (ø)` | |
| [...re/components/controls/DatasourceControl/index.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC9pbmRleC5qc3g=) | `86.84% <ø> (ø)` | |
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `85.00% <ø> (+50.00%)` | :arrow_up: |
| [...ponents/controls/DndColumnSelectControl/Option.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL09wdGlvbi50c3g=) | `100.00% <ø> (ø)` | |
| ... and [61 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [d54cc6d...aca7984](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (9febdce) into [master](https://codecov.io/gh/apache/superset/commit/4187d9e4c4f3e281c3d8021010b9836cd8da12bc?el=desc) (4187d9e) will **decrease** coverage by `0.20%`.
> The diff coverage is `85.71%`.
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
- Coverage 77.91% 77.71% -0.21%
==========================================
Files 934 934
Lines 47350 47383 +33
Branches 5941 5952 +11
==========================================
- Hits 36894 36822 -72
- Misses 10308 10413 +105
Partials 148 148
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| javascript | `66.38% <86.27%> (+0.09%)` | :arrow_up: |
| mysql | `80.56% <ø> (ø)` | |
| postgres | `80.59% <ø> (ø)` | |
| presto | `?` | |
| python | `80.68% <ø> (-0.47%)` | :arrow_down: |
| sqlite | `80.16% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `67.83% <84.78%> (+8.09%)` | :arrow_up: |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `97.14% <90.00%> (+2.40%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.42% <0.00%> (-16.42%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.83% <0.00%> (-6.89%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.10% <0.00%> (-1.68%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `86.62% <0.00%> (-0.46%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.10% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.83% <0.00%> (-0.13%)` | :arrow_down: |
| ... and [2 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [4187d9e...9febdce](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (72768d8) into [master](https://codecov.io/gh/apache/superset/commit/4187d9e4c4f3e281c3d8021010b9836cd8da12bc?el=desc) (4187d9e) will **increase** coverage by `0.04%`.
> The diff coverage is `85.71%`.
> :exclamation: Current head 72768d8 differs from pull request most recent head cedabe2. Consider uploading reports for the commit cedabe2 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
+ Coverage 77.91% 77.96% +0.04%
==========================================
Files 934 934
Lines 47350 47383 +33
Branches 5941 5952 +11
==========================================
+ Hits 36894 36940 +46
+ Misses 10308 10295 -13
Partials 148 148
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `66.38% <86.27%> (+0.09%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `67.83% <84.78%> (+8.09%)` | :arrow_up: |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `97.14% <90.00%> (+2.40%)` | :arrow_up: |
| [...ontend/src/common/components/InfoTooltip/index.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0luZm9Ub29sdGlwL2luZGV4LnRzeA==) | `100.00% <0.00%> (+46.15%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [4187d9e...cedabe2](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (9febdce) into [master](https://codecov.io/gh/apache/superset/commit/4187d9e4c4f3e281c3d8021010b9836cd8da12bc?el=desc) (4187d9e) will **increase** coverage by `0.19%`.
> The diff coverage is `88.23%`.
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
+ Coverage 77.91% 78.11% +0.19%
==========================================
Files 934 934
Lines 47350 47369 +19
Branches 5941 5946 +5
==========================================
+ Hits 36894 37003 +109
+ Misses 10308 10222 -86
+ Partials 148 144 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.03% <74.41%> (+2.80%)` | :arrow_up: |
| hive | `?` | |
| javascript | `66.38% <86.27%> (+0.09%)` | :arrow_up: |
| mysql | `80.56% <ø> (ø)` | |
| postgres | `80.59% <ø> (ø)` | |
| presto | `?` | |
| python | `80.68% <ø> (-0.47%)` | :arrow_down: |
| sqlite | `80.16% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `78.94% <86.95%> (+19.20%)` | :arrow_up: |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `100.00% <100.00%> (+5.26%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.42% <0.00%> (-16.42%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.83% <0.00%> (-6.89%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.10% <0.00%> (-1.68%)` | :arrow_down: |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `90.90% <0.00%> (-1.52%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `86.62% <0.00%> (-0.46%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.10% <0.00%> (-0.28%)` | :arrow_down: |
| ... and [27 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [4187d9e...9febdce](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (e327537) into [master](https://codecov.io/gh/apache/superset/commit/d54cc6d82aa86444dff0eaff072ee9e8e9ea915f?el=desc) (d54cc6d) will **decrease** coverage by `0.04%`.
> The diff coverage is `88.23%`.
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
- Coverage 77.55% 77.51% -0.05%
==========================================
Files 935 935
Lines 47301 47320 +19
Branches 5907 5935 +28
==========================================
- Hits 36685 36678 -7
- Misses 10472 10498 +26
Partials 144 144
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.02% <74.41%> (-0.01%)` | :arrow_down: |
| hive | `80.29% <ø> (ø)` | |
| javascript | `63.82% <86.27%> (+0.09%)` | :arrow_up: |
| mysql | `80.60% <ø> (ø)` | |
| postgres | `80.63% <ø> (ø)` | |
| presto | `?` | |
| python | `81.01% <ø> (-0.14%)` | :arrow_down: |
| sqlite | `80.19% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `78.94% <86.95%> (+2.97%)` | :arrow_up: |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `100.00% <100.00%> (+5.26%)` | :arrow_up: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.84% <0.00%> (-5.86%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.87% <0.00%> (-0.61%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.10% <0.00%> (-0.28%)` | :arrow_down: |
| [...ontend/src/common/components/InfoTooltip/index.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0luZm9Ub29sdGlwL2luZGV4LnRzeA==) | `100.00% <0.00%> (+46.15%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [d54cc6d...e327537](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (bbd695f) into [master](https://codecov.io/gh/apache/superset/commit/d54cc6d82aa86444dff0eaff072ee9e8e9ea915f?el=desc) (d54cc6d) will **decrease** coverage by `0.28%`.
> The diff coverage is `88.23%`.
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
- Coverage 77.55% 77.27% -0.29%
==========================================
Files 935 935
Lines 47301 47293 -8
Branches 5907 5918 +11
==========================================
- Hits 36685 36546 -139
- Misses 10472 10600 +128
- Partials 144 147 +3
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| javascript | `63.82% <86.27%> (+0.09%)` | :arrow_up: |
| mysql | `80.60% <ø> (ø)` | |
| postgres | `80.61% <ø> (-0.02%)` | :arrow_down: |
| presto | `?` | |
| python | `80.70% <ø> (-0.45%)` | :arrow_down: |
| sqlite | `80.19% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `79.06% <86.95%> (+3.09%)` | :arrow_up: |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `100.00% <100.00%> (+5.26%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.79% <0.00%> (-6.91%)` | :arrow_down: |
| [...rontend/src/views/CRUD/dashboard/DashboardList.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZExpc3QudHN4) | `75.22% <0.00%> (-5.31%)` | :arrow_down: |
| [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `79.84% <0.00%> (-4.66%)` | :arrow_down: |
| [...src/dashboard/components/HeaderActionsDropdown.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlckFjdGlvbnNEcm9wZG93bi5qc3g=) | `67.56% <0.00%> (-4.06%)` | :arrow_down: |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `74.62% <0.00%> (-3.99%)` | :arrow_down: |
| [...t-frontend/src/dashboard/actions/dashboardState.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZFN0YXRlLmpz) | `64.90% <0.00%> (-3.98%)` | :arrow_down: |
| ... and [14 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [d54cc6d...bbd695f](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] hughhhh commented on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
hughhhh commented on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-812672773
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (791226f) into [master](https://codecov.io/gh/apache/superset/commit/9d6832dc271fcea76302feb4273bd72a8b9d05ba?el=desc) (9d6832d) will **decrease** coverage by `1.41%`.
> The diff coverage is `90.47%`.
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
- Coverage 77.48% 76.07% -1.42%
==========================================
Files 935 936 +1
Lines 47301 47513 +212
Branches 5907 6008 +101
==========================================
- Hits 36653 36145 -508
- Misses 10504 11207 +703
- Partials 144 161 +17
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `49.90% <65.11%> (-6.14%)` | :arrow_down: |
| hive | `?` | |
| javascript | `64.20% <90.47%> (+0.47%)` | :arrow_up: |
| mysql | `80.60% <ø> (ø)` | |
| postgres | `?` | |
| python | `80.63% <ø> (-0.38%)` | :arrow_down: |
| sqlite | `80.19% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `82.93% <89.65%> (+6.96%)` | :arrow_up: |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `100.00% <100.00%> (+5.26%)` | :arrow_up: |
| [...tend/src/visualizations/FilterBox/controlPanel.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9jb250cm9sUGFuZWwuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...rc/explore/components/controls/AnnotationLayer.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXIuanN4) | `2.38% <0.00%> (-49.53%)` | :arrow_down: |
| [...hboard/components/filterscope/FilterScopeModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlTW9kYWwudHN4) | `31.25% <0.00%> (-43.75%)` | :arrow_down: |
| [...teFilterControl/components/DateFunctionTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0RhdGVGdW5jdGlvblRvb2x0aXAudHN4) | `58.33% <0.00%> (-41.67%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CommonFrame.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NvbW1vbkZyYW1lLnRzeA==) | `41.66% <0.00%> (-41.67%)` | :arrow_down: |
| [...ore/components/controls/AnnotationLayerControl.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sLmpzeA==) | `42.85% <0.00%> (-40.00%)` | :arrow_down: |
| ... and [65 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [9d6832d...791226f](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (16fe3aa) into [master](https://codecov.io/gh/apache/superset/commit/4187d9e4c4f3e281c3d8021010b9836cd8da12bc?el=desc) (4187d9e) will **increase** coverage by `0.39%`.
> The diff coverage is `80.32%`.
> :exclamation: Current head 16fe3aa differs from pull request most recent head 5faef21. Consider uploading reports for the commit 5faef21 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
+ Coverage 77.91% 78.31% +0.39%
==========================================
Files 934 934
Lines 47350 47467 +117
Branches 5941 5993 +52
==========================================
+ Hits 36894 37175 +281
+ Misses 10308 10148 -160
+ Partials 148 144 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.04% <74.41%> (+2.81%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `71.76% <78.00%> (+12.02%)` | :arrow_up: |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `94.28% <90.90%> (-0.46%)` | :arrow_down: |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `90.90% <0.00%> (-1.52%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `63.26% <0.00%> (+0.20%)` | :arrow_up: |
| [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `81.01% <0.00%> (+1.26%)` | :arrow_up: |
| [...-frontend/src/dashboard/actions/dashboardLayout.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZExheW91dC5qcw==) | `98.03% <0.00%> (+1.96%)` | :arrow_up: |
| [...frontend/src/dashboard/reducers/dashboardLayout.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRMYXlvdXQuanM=) | `99.00% <0.00%> (+2.00%)` | :arrow_up: |
| [superset-frontend/src/views/routes.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL3JvdXRlcy50c3g=) | `56.81% <0.00%> (+2.27%)` | :arrow_up: |
| [...-frontend/src/dashboard/reducers/dashboardState.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRTdGF0ZS5qcw==) | `85.71% <0.00%> (+3.57%)` | :arrow_up: |
| ... and [19 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [4187d9e...5faef21](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (bbd695f) into [master](https://codecov.io/gh/apache/superset/commit/d54cc6d82aa86444dff0eaff072ee9e8e9ea915f?el=desc) (d54cc6d) will **decrease** coverage by `0.26%`.
> The diff coverage is `88.23%`.
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
- Coverage 77.55% 77.28% -0.27%
==========================================
Files 935 935
Lines 47301 47321 +20
Branches 5907 5918 +11
==========================================
- Hits 36685 36573 -112
- Misses 10472 10601 +129
- Partials 144 147 +3
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| javascript | `63.82% <86.27%> (+0.09%)` | :arrow_up: |
| mysql | `80.60% <ø> (ø)` | |
| postgres | `80.63% <ø> (ø)` | |
| presto | `?` | |
| python | `80.72% <ø> (-0.43%)` | :arrow_down: |
| sqlite | `80.19% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `79.06% <86.95%> (+3.09%)` | :arrow_up: |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `100.00% <100.00%> (+5.26%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.79% <0.00%> (-6.91%)` | :arrow_down: |
| [...rontend/src/views/CRUD/dashboard/DashboardList.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZExpc3QudHN4) | `75.22% <0.00%> (-5.31%)` | :arrow_down: |
| [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `79.84% <0.00%> (-4.66%)` | :arrow_down: |
| [...src/dashboard/components/HeaderActionsDropdown.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlckFjdGlvbnNEcm9wZG93bi5qc3g=) | `67.56% <0.00%> (-4.06%)` | :arrow_down: |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `74.62% <0.00%> (-3.99%)` | :arrow_down: |
| [...t-frontend/src/dashboard/actions/dashboardState.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZFN0YXRlLmpz) | `64.90% <0.00%> (-3.98%)` | :arrow_down: |
| ... and [7 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [d54cc6d...bbd695f](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (03d120a) into [master](https://codecov.io/gh/apache/superset/commit/d54cc6d82aa86444dff0eaff072ee9e8e9ea915f?el=desc) (d54cc6d) will **increase** coverage by `0.07%`.
> The diff coverage is `88.61%`.
> :exclamation: Current head 03d120a differs from pull request most recent head aca7984. Consider uploading reports for the commit aca7984 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
+ Coverage 77.55% 77.63% +0.07%
==========================================
Files 935 947 +12
Lines 47301 48136 +835
Branches 5907 6179 +272
==========================================
+ Hits 36685 37368 +683
- Misses 10472 10624 +152
Partials 144 144
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| javascript | `66.40% <88.88%> (+2.67%)` | :arrow_up: |
| presto | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...frontend/src/components/DatabaseSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci9pbmRleC50c3g=) | `90.29% <ø> (-1.38%)` | :arrow_down: |
| [...et-frontend/src/components/TableSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci9pbmRleC50c3g=) | `85.29% <ø> (+0.37%)` | :arrow_up: |
| [...src/dashboard/components/dnd/handleScroll/index.ts](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVTY3JvbGwvaW5kZXgudHM=) | `73.33% <ø> (ø)` | |
| [...d/src/explore/components/DatasourcePanel/index.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwvaW5kZXgudHN4) | `91.07% <ø> (ø)` | |
| [...rc/explore/components/DisplayQueryButton/index.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24vaW5kZXguanN4) | `87.50% <ø> (ø)` | |
| [...ontrols/AnnotationLayerControl/AnnotationLayer.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sL0Fubm90YXRpb25MYXllci5qc3g=) | `84.28% <ø> (ø)` | |
| [...mponents/controls/AnnotationLayerControl/index.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sL2luZGV4LmpzeA==) | `8.57% <ø> (ø)` | |
| [...re/components/controls/DatasourceControl/index.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC9pbmRleC5qc3g=) | `86.84% <ø> (ø)` | |
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `85.00% <ø> (+50.00%)` | :arrow_up: |
| [...ponents/controls/DndColumnSelectControl/Option.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL09wdGlvbi50c3g=) | `100.00% <ø> (ø)` | |
| ... and [75 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [d54cc6d...aca7984](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] hughhhh merged pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
hughhhh merged pull request #13877:
URL: https://github.com/apache/superset/pull/13877
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (cedabe2) into [master](https://codecov.io/gh/apache/superset/commit/4187d9e4c4f3e281c3d8021010b9836cd8da12bc?el=desc) (4187d9e) will **increase** coverage by `0.16%`.
> The diff coverage is `88.23%`.
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
+ Coverage 77.91% 78.08% +0.16%
==========================================
Files 934 934
Lines 47350 47342 -8
Branches 5941 5946 +5
==========================================
+ Hits 36894 36967 +73
+ Misses 10308 10231 -77
+ Partials 148 144 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `80.58% <ø> (-0.02%)` | :arrow_down: |
| presto | `?` | |
| python | `80.62% <ø> (-0.53%)` | :arrow_down: |
| sqlite | `80.16% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `78.94% <86.95%> (+19.20%)` | :arrow_up: |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `100.00% <100.00%> (+5.26%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.42% <0.00%> (-16.42%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.83% <0.00%> (-6.89%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `75.37% <0.00%> (-2.25%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.08% <0.00%> (-1.69%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `91.66% <0.00%> (-1.67%)` | :arrow_down: |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `90.90% <0.00%> (-1.52%)` | :arrow_down: |
| ... and [36 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [4187d9e...cedabe2](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (e327537) into [master](https://codecov.io/gh/apache/superset/commit/d54cc6d82aa86444dff0eaff072ee9e8e9ea915f?el=desc) (d54cc6d) will **decrease** coverage by `0.20%`.
> The diff coverage is `88.23%`.
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
- Coverage 77.55% 77.35% -0.21%
==========================================
Files 935 935
Lines 47301 47320 +19
Branches 5907 5935 +28
==========================================
- Hits 36685 36604 -81
- Misses 10472 10572 +100
Partials 144 144
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.02% <74.41%> (-0.01%)` | :arrow_down: |
| hive | `?` | |
| mysql | `80.60% <ø> (ø)` | |
| postgres | `80.63% <ø> (ø)` | |
| presto | `?` | |
| python | `80.72% <ø> (-0.43%)` | :arrow_down: |
| sqlite | `80.19% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `78.94% <86.95%> (+2.97%)` | :arrow_up: |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `100.00% <100.00%> (+5.26%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.79% <0.00%> (-6.91%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.87% <0.00%> (-0.61%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `86.65% <0.00%> (-0.46%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.10% <0.00%> (-0.28%)` | :arrow_down: |
| [...ontend/src/common/components/InfoTooltip/index.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0luZm9Ub29sdGlwL2luZGV4LnRzeA==) | `100.00% <0.00%> (+46.15%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [d54cc6d...e327537](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (e327537) into [master](https://codecov.io/gh/apache/superset/commit/d54cc6d82aa86444dff0eaff072ee9e8e9ea915f?el=desc) (d54cc6d) will **decrease** coverage by `0.20%`.
> The diff coverage is `88.23%`.
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
- Coverage 77.55% 77.35% -0.21%
==========================================
Files 935 935
Lines 47301 47320 +19
Branches 5907 5935 +28
==========================================
- Hits 36685 36604 -81
- Misses 10472 10572 +100
Partials 144 144
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.02% <74.41%> (-0.01%)` | :arrow_down: |
| hive | `?` | |
| javascript | `63.82% <86.27%> (+0.09%)` | :arrow_up: |
| mysql | `80.60% <ø> (ø)` | |
| postgres | `80.63% <ø> (ø)` | |
| presto | `?` | |
| python | `80.72% <ø> (-0.43%)` | :arrow_down: |
| sqlite | `80.19% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `78.94% <86.95%> (+2.97%)` | :arrow_up: |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `100.00% <100.00%> (+5.26%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.79% <0.00%> (-6.91%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.87% <0.00%> (-0.61%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `86.65% <0.00%> (-0.46%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.10% <0.00%> (-0.28%)` | :arrow_down: |
| [...ontend/src/common/components/InfoTooltip/index.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0luZm9Ub29sdGlwL2luZGV4LnRzeA==) | `100.00% <0.00%> (+46.15%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [d54cc6d...e327537](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (e327537) into [master](https://codecov.io/gh/apache/superset/commit/d54cc6d82aa86444dff0eaff072ee9e8e9ea915f?el=desc) (d54cc6d) will **decrease** coverage by `0.52%`.
> The diff coverage is `88.23%`.
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
- Coverage 77.55% 77.03% -0.53%
==========================================
Files 935 935
Lines 47301 47320 +19
Branches 5907 5935 +28
==========================================
- Hits 36685 36452 -233
- Misses 10472 10718 +246
- Partials 144 150 +6
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `80.60% <ø> (ø)` | |
| postgres | `80.63% <ø> (ø)` | |
| presto | `?` | |
| python | `80.72% <ø> (-0.43%)` | :arrow_down: |
| sqlite | `80.19% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `78.94% <86.95%> (+2.97%)` | :arrow_up: |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `100.00% <100.00%> (+5.26%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `59.25% <0.00%> (-40.75%)` | :arrow_down: |
| [...nd/src/explore/components/controls/TextControl.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UZXh0Q29udHJvbC50c3g=) | `48.83% <0.00%> (-25.59%)` | :arrow_down: |
| [...ore/components/controls/AnnotationLayerControl.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sLmpzeA==) | `65.71% <0.00%> (-17.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| [...ntend/src/dashboard/components/PropertiesModal.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC5qc3g=) | `58.08% <0.00%> (-16.18%)` | :arrow_down: |
| [...erset-frontend/src/dashboard/components/Header.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci5qc3g=) | `54.41% <0.00%> (-12.50%)` | :arrow_down: |
| [...t-frontend/src/dashboard/actions/dashboardState.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZFN0YXRlLmpz) | `59.60% <0.00%> (-9.28%)` | :arrow_down: |
| ... and [22 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [d54cc6d...e327537](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
eschutho commented on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-811443585
We changed some functionality of the indeterminate checkbox, so we'll need to test across the site cc @rusackas @junlincc
I'm doing some visual testing now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
eschutho edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-811533907
https://user-images.githubusercontent.com/5186919/113224218-c9baf580-923f-11eb-900c-34d855710038.mov
Other checkboxes:
existing:
<img width="232" alt="Screenshot_3_31_21__3_57_PM" src="https://user-images.githubusercontent.com/5186919/113223979-3ed9fb00-923f-11eb-8a17-120b8f96f309.png">
new:
<img width="241" alt="Screenshot_3_31_21__3_57_PM" src="https://user-images.githubusercontent.com/5186919/113224142-a001ce80-923f-11eb-987d-01d4d0e2447f.png">
existing:
<img width="321" alt="_DEV__Superset" src="https://user-images.githubusercontent.com/5186919/113224153-a5f7af80-923f-11eb-9e36-1ba4e3439d86.png">
new:
<img width="366" alt="Superset" src="https://user-images.githubusercontent.com/5186919/113224162-ab54fa00-923f-11eb-8740-b97c55fcd5b4.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (9febdce) into [master](https://codecov.io/gh/apache/superset/commit/4187d9e4c4f3e281c3d8021010b9836cd8da12bc?el=desc) (4187d9e) will **decrease** coverage by `0.27%`.
> The diff coverage is `88.23%`.
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
- Coverage 77.91% 77.64% -0.28%
==========================================
Files 934 934
Lines 47350 47368 +18
Branches 5941 5946 +5
==========================================
- Hits 36894 36778 -116
- Misses 10308 10433 +125
- Partials 148 157 +9
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `58.58% <74.41%> (+5.35%)` | :arrow_up: |
| hive | `?` | |
| javascript | `66.38% <86.27%> (+0.09%)` | :arrow_up: |
| mysql | `80.56% <ø> (ø)` | |
| postgres | `80.59% <ø> (ø)` | |
| presto | `?` | |
| python | `80.68% <ø> (-0.47%)` | :arrow_down: |
| sqlite | `80.16% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `78.94% <86.95%> (+19.20%)` | :arrow_up: |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `100.00% <100.00%> (+5.26%)` | :arrow_up: |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [...c/dashboard/components/dnd/AddSliceDragPreview.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9BZGRTbGljZURyYWdQcmV2aWV3LmpzeA==) | `35.71% <0.00%> (-64.29%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-59.26%)` | :arrow_down: |
| [...et-frontend/src/dashboard/actions/sliceEntities.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL3NsaWNlRW50aXRpZXMuanM=) | `12.90% <0.00%> (-58.07%)` | :arrow_down: |
| [...frontend/src/dashboard/components/AddSliceCard.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0FkZFNsaWNlQ2FyZC5qc3g=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...erset-frontend/src/common/hooks/useUrlShortener.ts](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VVcmxTaG9ydGVuZXIudHM=) | `50.00% <0.00%> (-42.86%)` | :arrow_down: |
| [...set-frontend/src/dashboard/reducers/datasources.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXRhc291cmNlcy5qcw==) | `57.14% <0.00%> (-42.86%)` | :arrow_down: |
| ... and [53 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [4187d9e...9febdce](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (e9d9be7) into [master](https://codecov.io/gh/apache/superset/commit/d54cc6d82aa86444dff0eaff072ee9e8e9ea915f?el=desc) (d54cc6d) will **decrease** coverage by `0.52%`.
> The diff coverage is `88.23%`.
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
- Coverage 77.55% 77.03% -0.53%
==========================================
Files 935 935
Lines 47301 47320 +19
Branches 5907 5935 +28
==========================================
- Hits 36685 36452 -233
- Misses 10472 10718 +246
- Partials 144 150 +6
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.44% <74.41%> (-1.59%)` | :arrow_down: |
| hive | `?` | |
| javascript | `63.82% <86.27%> (+0.09%)` | :arrow_up: |
| mysql | `80.60% <ø> (ø)` | |
| postgres | `80.63% <ø> (ø)` | |
| presto | `?` | |
| python | `80.72% <ø> (-0.43%)` | :arrow_down: |
| sqlite | `80.19% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `78.94% <86.95%> (+2.97%)` | :arrow_up: |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `100.00% <100.00%> (+5.26%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `59.25% <0.00%> (-40.75%)` | :arrow_down: |
| [...nd/src/explore/components/controls/TextControl.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UZXh0Q29udHJvbC50c3g=) | `48.83% <0.00%> (-25.59%)` | :arrow_down: |
| [...ore/components/controls/AnnotationLayerControl.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sLmpzeA==) | `65.71% <0.00%> (-17.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| [...ntend/src/dashboard/components/PropertiesModal.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC5qc3g=) | `58.08% <0.00%> (-16.18%)` | :arrow_down: |
| [...erset-frontend/src/dashboard/components/Header.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci5qc3g=) | `54.41% <0.00%> (-12.50%)` | :arrow_down: |
| [...t-frontend/src/dashboard/actions/dashboardState.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZFN0YXRlLmpz) | `59.60% <0.00%> (-9.28%)` | :arrow_down: |
| ... and [22 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [d54cc6d...e9d9be7](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (07dc6ff) into [master](https://codecov.io/gh/apache/superset/commit/d54cc6d82aa86444dff0eaff072ee9e8e9ea915f?el=desc) (d54cc6d) will **decrease** coverage by `0.58%`.
> The diff coverage is `88.23%`.
> :exclamation: Current head 07dc6ff differs from pull request most recent head bbd695f. Consider uploading reports for the commit bbd695f to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
- Coverage 77.55% 76.97% -0.59%
==========================================
Files 935 935
Lines 47301 47321 +20
Branches 5907 5918 +11
==========================================
- Hits 36685 36425 -260
- Misses 10472 10740 +268
- Partials 144 156 +12
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `63.82% <86.27%> (+0.09%)` | :arrow_up: |
| presto | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `79.06% <86.95%> (+3.09%)` | :arrow_up: |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `100.00% <100.00%> (+5.26%)` | :arrow_up: |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tend/src/visualizations/FilterBox/controlPanel.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9jb250cm9sUGFuZWwuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...c/dashboard/components/dnd/AddSliceDragPreview.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9BZGRTbGljZURyYWdQcmV2aWV3LmpzeA==) | `35.71% <0.00%> (-64.29%)` | :arrow_down: |
| [...et-frontend/src/dashboard/actions/sliceEntities.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL3NsaWNlRW50aXRpZXMuanM=) | `12.90% <0.00%> (-58.07%)` | :arrow_down: |
| [...frontend/src/dashboard/components/AddSliceCard.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0FkZFNsaWNlQ2FyZC5qc3g=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...set-frontend/src/dashboard/reducers/datasources.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXRhc291cmNlcy5qcw==) | `57.14% <0.00%> (-42.86%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/actions/datasources.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2RhdGFzb3VyY2VzLmpz) | `15.78% <0.00%> (-42.11%)` | :arrow_down: |
| [...teFilterControl/components/DateFunctionTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0RhdGVGdW5jdGlvblRvb2x0aXAudHN4) | `58.33% <0.00%> (-41.67%)` | :arrow_down: |
| ... and [40 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [d54cc6d...bbd695f](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (f6abd3f) into [master](https://codecov.io/gh/apache/superset/commit/d54cc6d82aa86444dff0eaff072ee9e8e9ea915f?el=desc) (d54cc6d) will **increase** coverage by `0.30%`.
> The diff coverage is `80.95%`.
> :exclamation: Current head f6abd3f differs from pull request most recent head aca7984. Consider uploading reports for the commit aca7984 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
+ Coverage 77.55% 77.85% +0.30%
==========================================
Files 935 934 -1
Lines 47301 47445 +144
Branches 5907 5984 +77
==========================================
+ Hits 36685 36940 +255
+ Misses 10472 10362 -110
+ Partials 144 143 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `64.72% <85.07%> (+0.99%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...frontend/src/components/DatabaseSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci9pbmRleC50c3g=) | `92.70% <ø> (+1.04%)` | :arrow_up: |
| [...et-frontend/src/components/TableSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci9pbmRleC50c3g=) | `84.92% <ø> (ø)` | |
| [...src/dashboard/components/dnd/handleScroll/index.ts](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVTY3JvbGwvaW5kZXgudHM=) | `73.33% <ø> (ø)` | |
| [...d/src/explore/components/DatasourcePanel/index.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwvaW5kZXgudHN4) | `87.93% <ø> (ø)` | |
| [...rc/explore/components/DisplayQueryButton/index.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24vaW5kZXguanN4) | `100.00% <ø> (ø)` | |
| [...re/components/controls/DatasourceControl/index.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC9pbmRleC5qc3g=) | `86.84% <ø> (ø)` | |
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `35.00% <ø> (ø)` | |
| [...trols/DndColumnSelectControl/components/Option.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL2NvbXBvbmVudHMvT3B0aW9uLnRzeA==) | `50.00% <ø> (ø)` | |
| [...ents/controls/FilterControl/AdhocFilterControl.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC5qc3g=) | `60.00% <ø> (ø)` | |
| [...Control/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTaW1wbGVUYWJDb250ZW50LmpzeA==) | `74.83% <ø> (ø)` | |
| ... and [34 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [d54cc6d...aca7984](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (9febdce) into [master](https://codecov.io/gh/apache/superset/commit/4187d9e4c4f3e281c3d8021010b9836cd8da12bc?el=desc) (4187d9e) will **decrease** coverage by `0.27%`.
> The diff coverage is `75.00%`.
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
- Coverage 77.91% 77.64% -0.28%
==========================================
Files 934 934
Lines 47350 47350
Branches 5941 5941
==========================================
- Hits 36894 36766 -128
- Misses 10308 10436 +128
Partials 148 148
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `80.60% <ø> (+<0.01%)` | :arrow_up: |
| presto | `?` | |
| python | `80.64% <ø> (-0.51%)` | :arrow_down: |
| sqlite | `80.16% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `59.74% <71.42%> (ø)` | |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `94.73% <85.71%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.42% <0.00%> (-16.42%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.83% <0.00%> (-6.89%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.10% <0.00%> (-1.68%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `91.66% <0.00%> (-1.67%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.28% <0.00%> (-1.09%)` | :arrow_down: |
| ... and [4 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [4187d9e...9febdce](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (e327537) into [master](https://codecov.io/gh/apache/superset/commit/d54cc6d82aa86444dff0eaff072ee9e8e9ea915f?el=desc) (d54cc6d) will **decrease** coverage by `0.80%`.
> The diff coverage is `88.23%`.
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
- Coverage 77.55% 76.75% -0.81%
==========================================
Files 935 935
Lines 47301 47292 -9
Branches 5907 5935 +28
==========================================
- Hits 36685 36298 -387
- Misses 10472 10844 +372
- Partials 144 150 +6
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `80.19% <ø> (-0.96%)` | :arrow_down: |
| sqlite | `80.19% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `78.94% <86.95%> (+2.97%)` | :arrow_up: |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `100.00% <100.00%> (+5.26%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `31.37% <0.00%> (-60.79%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `59.25% <0.00%> (-40.75%)` | :arrow_down: |
| [superset/utils/network.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvbmV0d29yay5weQ==) | `25.80% <0.00%> (-32.26%)` | :arrow_down: |
| [superset/models/sql\_types/base.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF90eXBlcy9iYXNlLnB5) | `52.63% <0.00%> (-31.58%)` | :arrow_down: |
| [...nd/src/explore/components/controls/TextControl.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UZXh0Q29udHJvbC50c3g=) | `48.83% <0.00%> (-25.59%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `60.34% <0.00%> (-22.42%)` | :arrow_down: |
| ... and [46 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [d54cc6d...e327537](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (07dc6ff) into [master](https://codecov.io/gh/apache/superset/commit/d54cc6d82aa86444dff0eaff072ee9e8e9ea915f?el=desc) (d54cc6d) will **decrease** coverage by `0.49%`.
> The diff coverage is `88.23%`.
> :exclamation: Current head 07dc6ff differs from pull request most recent head 7608883. Consider uploading reports for the commit 7608883 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
- Coverage 77.55% 77.06% -0.50%
==========================================
Files 935 935
Lines 47301 47321 +20
Branches 5907 5918 +11
==========================================
- Hits 36685 36466 -219
- Misses 10472 10701 +229
- Partials 144 154 +10
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.73% <65.11%> (-2.30%)` | :arrow_down: |
| javascript | `63.82% <86.27%> (+0.09%)` | :arrow_up: |
| presto | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `79.06% <86.95%> (+3.09%)` | :arrow_up: |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `100.00% <100.00%> (+5.26%)` | :arrow_up: |
| [...erset-frontend/src/common/hooks/useUrlShortener.ts](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VVcmxTaG9ydGVuZXIudHM=) | `50.00% <0.00%> (-42.86%)` | :arrow_down: |
| [...teFilterControl/components/DateFunctionTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0RhdGVGdW5jdGlvblRvb2x0aXAudHN4) | `58.33% <0.00%> (-41.67%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CommonFrame.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NvbW1vbkZyYW1lLnRzeA==) | `41.66% <0.00%> (-41.67%)` | :arrow_down: |
| [...ols/DateFilterControl/components/CalendarFrame.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NhbGVuZGFyRnJhbWUudHN4) | `46.15% <0.00%> (-38.47%)` | :arrow_down: |
| [...ols/DateFilterControl/components/AdvancedFrame.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0FkdmFuY2VkRnJhbWUudHN4) | `26.92% <0.00%> (-26.93%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CustomFrame.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0N1c3RvbUZyYW1lLnRzeA==) | `16.00% <0.00%> (-26.00%)` | :arrow_down: |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `48.43% <0.00%> (-25.00%)` | :arrow_down: |
| [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `49.29% <0.00%> (-16.91%)` | :arrow_down: |
| ... and [29 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [d54cc6d...7608883](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
eschutho commented on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-812756533
looks great! I rebased this recently and saw that an earlier commit had a few trims on database_name in the DatabaseModal file. Do we need to add those in?
`db.database_name.trim()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (791226f) into [master](https://codecov.io/gh/apache/superset/commit/9d6832dc271fcea76302feb4273bd72a8b9d05ba?el=desc) (9d6832d) will **decrease** coverage by `0.22%`.
> The diff coverage is `90.47%`.
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
- Coverage 77.55% 77.32% -0.23%
==========================================
Files 935 936 +1
Lines 47301 47541 +240
Branches 5907 6008 +101
==========================================
+ Hits 36685 36763 +78
- Misses 10472 10631 +159
- Partials 144 147 +3
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `55.57% <65.11%> (-0.47%)` | :arrow_down: |
| hive | `80.29% <ø> (ø)` | |
| javascript | `64.20% <90.47%> (+0.47%)` | :arrow_up: |
| mysql | `80.60% <ø> (ø)` | |
| postgres | `80.63% <ø> (ø)` | |
| presto | `80.30% <ø> (+<0.01%)` | :arrow_up: |
| python | `81.14% <ø> (+<0.01%)` | :arrow_up: |
| sqlite | `80.19% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `82.93% <89.65%> (+6.96%)` | :arrow_up: |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `100.00% <100.00%> (+5.26%)` | :arrow_up: |
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `46.30% <0.00%> (-23.27%)` | :arrow_down: |
| [...rontend/src/views/CRUD/dashboard/DashboardList.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZExpc3QudHN4) | `75.22% <0.00%> (-5.31%)` | :arrow_down: |
| [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `79.84% <0.00%> (-4.66%)` | :arrow_down: |
| [...src/dashboard/components/HeaderActionsDropdown.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlckFjdGlvbnNEcm9wZG93bi5qc3g=) | `67.56% <0.00%> (-4.06%)` | :arrow_down: |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `74.62% <0.00%> (-3.99%)` | :arrow_down: |
| [...t-frontend/src/dashboard/actions/dashboardState.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZFN0YXRlLmpz) | `64.90% <0.00%> (-3.98%)` | :arrow_down: |
| [...erset-frontend/src/dashboard/components/Header.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci5qc3g=) | `63.23% <0.00%> (-3.68%)` | :arrow_down: |
| [...ontend/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `0.00% <0.00%> (ø)` | |
| ... and [3 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [9d6832d...791226f](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (791226f) into [master](https://codecov.io/gh/apache/superset/commit/9d6832dc271fcea76302feb4273bd72a8b9d05ba?el=desc) (9d6832d) will **decrease** coverage by `1.14%`.
> The diff coverage is `90.47%`.
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
- Coverage 77.48% 76.34% -1.15%
==========================================
Files 935 936 +1
Lines 47301 47534 +233
Branches 5907 6008 +101
==========================================
- Hits 36653 36288 -365
- Misses 10504 11085 +581
- Partials 144 161 +17
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `49.90% <65.11%> (-6.14%)` | :arrow_down: |
| javascript | `64.20% <90.47%> (+0.47%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `82.93% <89.65%> (+6.96%)` | :arrow_up: |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `100.00% <100.00%> (+5.26%)` | :arrow_up: |
| [...tend/src/visualizations/FilterBox/controlPanel.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9jb250cm9sUGFuZWwuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rc/explore/components/controls/AnnotationLayer.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXIuanN4) | `2.38% <0.00%> (-49.53%)` | :arrow_down: |
| [...hboard/components/filterscope/FilterScopeModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlTW9kYWwudHN4) | `31.25% <0.00%> (-43.75%)` | :arrow_down: |
| [...teFilterControl/components/DateFunctionTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0RhdGVGdW5jdGlvblRvb2x0aXAudHN4) | `58.33% <0.00%> (-41.67%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CommonFrame.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NvbW1vbkZyYW1lLnRzeA==) | `41.66% <0.00%> (-41.67%)` | :arrow_down: |
| [...ore/components/controls/AnnotationLayerControl.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sLmpzeA==) | `42.85% <0.00%> (-40.00%)` | :arrow_down: |
| [...ols/DateFilterControl/components/CalendarFrame.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NhbGVuZGFyRnJhbWUudHN4) | `46.15% <0.00%> (-38.47%)` | :arrow_down: |
| [...hboard/components/resizable/ResizableContainer.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVDb250YWluZXIuanN4) | `71.87% <0.00%> (-28.13%)` | :arrow_down: |
| ... and [56 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [9d6832d...791226f](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (bbd695f) into [master](https://codecov.io/gh/apache/superset/commit/d54cc6d82aa86444dff0eaff072ee9e8e9ea915f?el=desc) (d54cc6d) will **decrease** coverage by `0.58%`.
> The diff coverage is `88.23%`.
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
- Coverage 77.55% 76.97% -0.59%
==========================================
Files 935 935
Lines 47301 47321 +20
Branches 5907 5918 +11
==========================================
- Hits 36685 36425 -260
- Misses 10472 10740 +268
- Partials 144 156 +12
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.41% <65.11%> (-2.62%)` | :arrow_down: |
| hive | `80.29% <ø> (ø)` | |
| javascript | `63.82% <86.27%> (+0.09%)` | :arrow_up: |
| mysql | `80.60% <ø> (ø)` | |
| postgres | `80.63% <ø> (ø)` | |
| presto | `?` | |
| python | `81.01% <ø> (-0.14%)` | :arrow_down: |
| sqlite | `80.19% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `79.06% <86.95%> (+3.09%)` | :arrow_up: |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `100.00% <100.00%> (+5.26%)` | :arrow_up: |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tend/src/visualizations/FilterBox/controlPanel.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9jb250cm9sUGFuZWwuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...c/dashboard/components/dnd/AddSliceDragPreview.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9BZGRTbGljZURyYWdQcmV2aWV3LmpzeA==) | `35.71% <0.00%> (-64.29%)` | :arrow_down: |
| [...et-frontend/src/dashboard/actions/sliceEntities.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL3NsaWNlRW50aXRpZXMuanM=) | `12.90% <0.00%> (-58.07%)` | :arrow_down: |
| [...frontend/src/dashboard/components/AddSliceCard.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0FkZFNsaWNlQ2FyZC5qc3g=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...set-frontend/src/dashboard/reducers/datasources.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXRhc291cmNlcy5qcw==) | `57.14% <0.00%> (-42.86%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/actions/datasources.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2RhdGFzb3VyY2VzLmpz) | `15.78% <0.00%> (-42.11%)` | :arrow_down: |
| [...teFilterControl/components/DateFunctionTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0RhdGVGdW5jdGlvblRvb2x0aXAudHN4) | `58.33% <0.00%> (-41.67%)` | :arrow_down: |
| ... and [40 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [d54cc6d...bbd695f](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (07dc6ff) into [master](https://codecov.io/gh/apache/superset/commit/d54cc6d82aa86444dff0eaff072ee9e8e9ea915f?el=desc) (d54cc6d) will **decrease** coverage by `0.49%`.
> The diff coverage is `88.23%`.
> :exclamation: Current head 07dc6ff differs from pull request most recent head aca7984. Consider uploading reports for the commit aca7984 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
- Coverage 77.55% 77.06% -0.50%
==========================================
Files 935 935
Lines 47301 47321 +20
Branches 5907 5918 +11
==========================================
- Hits 36685 36466 -219
- Misses 10472 10701 +229
- Partials 144 154 +10
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.73% <65.11%> (-2.30%)` | :arrow_down: |
| javascript | `63.82% <86.27%> (+0.09%)` | :arrow_up: |
| presto | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `79.06% <86.95%> (+3.09%)` | :arrow_up: |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `100.00% <100.00%> (+5.26%)` | :arrow_up: |
| [...erset-frontend/src/common/hooks/useUrlShortener.ts](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VVcmxTaG9ydGVuZXIudHM=) | `50.00% <0.00%> (-42.86%)` | :arrow_down: |
| [...teFilterControl/components/DateFunctionTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0RhdGVGdW5jdGlvblRvb2x0aXAudHN4) | `58.33% <0.00%> (-41.67%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CommonFrame.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NvbW1vbkZyYW1lLnRzeA==) | `41.66% <0.00%> (-41.67%)` | :arrow_down: |
| [...ols/DateFilterControl/components/CalendarFrame.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NhbGVuZGFyRnJhbWUudHN4) | `46.15% <0.00%> (-38.47%)` | :arrow_down: |
| [...ols/DateFilterControl/components/AdvancedFrame.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0FkdmFuY2VkRnJhbWUudHN4) | `26.92% <0.00%> (-26.93%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CustomFrame.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0N1c3RvbUZyYW1lLnRzeA==) | `16.00% <0.00%> (-26.00%)` | :arrow_down: |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `48.43% <0.00%> (-25.00%)` | :arrow_down: |
| [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `49.29% <0.00%> (-16.91%)` | :arrow_down: |
| ... and [29 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [d54cc6d...aca7984](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (791226f) into [master](https://codecov.io/gh/apache/superset/commit/9d6832dc271fcea76302feb4273bd72a8b9d05ba?el=desc) (9d6832d) will **decrease** coverage by `0.52%`.
> The diff coverage is `90.47%`.
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
- Coverage 77.55% 77.03% -0.53%
==========================================
Files 935 936 +1
Lines 47301 47541 +240
Branches 5907 6008 +101
==========================================
- Hits 36685 36621 -64
- Misses 10472 10770 +298
- Partials 144 150 +6
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.68% <65.11%> (-2.36%)` | :arrow_down: |
| hive | `80.29% <ø> (ø)` | |
| javascript | `64.20% <90.47%> (+0.47%)` | :arrow_up: |
| mysql | `80.60% <ø> (ø)` | |
| postgres | `80.63% <ø> (ø)` | |
| presto | `80.30% <ø> (+<0.01%)` | :arrow_up: |
| python | `81.14% <ø> (+<0.01%)` | :arrow_up: |
| sqlite | `80.19% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `82.93% <89.65%> (+6.96%)` | :arrow_up: |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `100.00% <100.00%> (+5.26%)` | :arrow_up: |
| [...tend/src/visualizations/FilterBox/controlPanel.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9jb250cm9sUGFuZWwuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...teFilterControl/components/DateFunctionTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0RhdGVGdW5jdGlvblRvb2x0aXAudHN4) | `58.33% <0.00%> (-41.67%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CommonFrame.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NvbW1vbkZyYW1lLnRzeA==) | `41.66% <0.00%> (-41.67%)` | :arrow_down: |
| [...ols/DateFilterControl/components/CalendarFrame.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NhbGVuZGFyRnJhbWUudHN4) | `46.15% <0.00%> (-38.47%)` | :arrow_down: |
| [...hboard/components/resizable/ResizableContainer.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVDb250YWluZXIuanN4) | `71.87% <0.00%> (-28.13%)` | :arrow_down: |
| [...nents/controls/MetricControl/AdhocMetricOption.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljT3B0aW9uLmpzeA==) | `72.72% <0.00%> (-27.28%)` | :arrow_down: |
| [...ols/DateFilterControl/components/AdvancedFrame.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0FkdmFuY2VkRnJhbWUudHN4) | `26.92% <0.00%> (-26.93%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CustomFrame.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0N1c3RvbUZyYW1lLnRzeA==) | `16.00% <0.00%> (-26.00%)` | :arrow_down: |
| ... and [29 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [9d6832d...791226f](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (e9d9be7) into [master](https://codecov.io/gh/apache/superset/commit/d54cc6d82aa86444dff0eaff072ee9e8e9ea915f?el=desc) (d54cc6d) will **decrease** coverage by `1.01%`.
> The diff coverage is `84.74%`.
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
- Coverage 77.55% 76.54% -1.02%
==========================================
Files 935 948 +13
Lines 47301 48216 +915
Branches 5907 6178 +271
==========================================
+ Hits 36685 36906 +221
- Misses 10472 11166 +694
Partials 144 144
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `80.60% <ø> (ø)` | |
| postgres | `80.63% <ø> (+<0.01%)` | :arrow_up: |
| presto | `?` | |
| python | `80.72% <ø> (-0.43%)` | :arrow_down: |
| sqlite | `80.19% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `74.57% <83.67%> (-1.40%)` | :arrow_down: |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `97.14% <90.00%> (+2.40%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [...ore/components/controls/AnnotationLayerControl.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sLmpzeA==) | `8.57% <0.00%> (-74.29%)` | :arrow_down: |
| [...rc/explore/components/controls/AnnotationLayer.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXIuanN4) | `0.00% <0.00%> (-51.91%)` | :arrow_down: |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `43.75% <0.00%> (-29.69%)` | :arrow_down: |
| [...nd/src/explore/components/controls/TextControl.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UZXh0Q29udHJvbC50c3g=) | `48.83% <0.00%> (-25.59%)` | :arrow_down: |
| [...ntend/src/dashboard/components/dnd/handleScroll.ts](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVTY3JvbGwudHM=) | `26.66% <0.00%> (-20.01%)` | :arrow_down: |
| [...ontend/src/explore/components/DataTableControl.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVDb250cm9sLnRzeA==) | `32.00% <0.00%> (-18.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| ... and [28 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [d54cc6d...e9d9be7](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (aca7984) into [master](https://codecov.io/gh/apache/superset/commit/d54cc6d82aa86444dff0eaff072ee9e8e9ea915f?el=desc) (d54cc6d) will **decrease** coverage by `1.28%`.
> The diff coverage is `70.14%`.
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
- Coverage 77.55% 76.26% -1.29%
==========================================
Files 935 948 +13
Lines 47301 48188 +887
Branches 5907 6178 +271
==========================================
+ Hits 36685 36752 +67
- Misses 10472 11292 +820
Partials 144 144
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `80.19% <ø> (-0.96%)` | :arrow_down: |
| sqlite | `80.19% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...frontend/src/views/CRUD/data/database/Checkbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9DaGVja2JveC50c3g=) | `29.41% <29.41%> (ø)` | |
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `74.57% <84.00%> (-1.40%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [...ore/components/controls/AnnotationLayerControl.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sLmpzeA==) | `8.57% <0.00%> (-74.29%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `31.37% <0.00%> (-60.79%)` | :arrow_down: |
| [...rc/explore/components/controls/AnnotationLayer.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXIuanN4) | `0.00% <0.00%> (-51.91%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/utils/network.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvbmV0d29yay5weQ==) | `25.80% <0.00%> (-32.26%)` | :arrow_down: |
| [superset/models/sql\_types/base.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF90eXBlcy9iYXNlLnB5) | `52.63% <0.00%> (-31.58%)` | :arrow_down: |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `43.75% <0.00%> (-29.69%)` | :arrow_down: |
| ... and [52 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [d54cc6d...aca7984](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (07dc6ff) into [master](https://codecov.io/gh/apache/superset/commit/d54cc6d82aa86444dff0eaff072ee9e8e9ea915f?el=desc) (d54cc6d) will **decrease** coverage by `0.49%`.
> The diff coverage is `88.23%`.
> :exclamation: Current head 07dc6ff differs from pull request most recent head 2f89e08. Consider uploading reports for the commit 2f89e08 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
- Coverage 77.55% 77.06% -0.50%
==========================================
Files 935 935
Lines 47301 47321 +20
Branches 5907 5918 +11
==========================================
- Hits 36685 36466 -219
- Misses 10472 10701 +229
- Partials 144 154 +10
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.73% <65.11%> (-2.30%)` | :arrow_down: |
| javascript | `63.82% <86.27%> (+0.09%)` | :arrow_up: |
| presto | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `79.06% <86.95%> (+3.09%)` | :arrow_up: |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `100.00% <100.00%> (+5.26%)` | :arrow_up: |
| [...erset-frontend/src/common/hooks/useUrlShortener.ts](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VVcmxTaG9ydGVuZXIudHM=) | `50.00% <0.00%> (-42.86%)` | :arrow_down: |
| [...teFilterControl/components/DateFunctionTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0RhdGVGdW5jdGlvblRvb2x0aXAudHN4) | `58.33% <0.00%> (-41.67%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CommonFrame.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NvbW1vbkZyYW1lLnRzeA==) | `41.66% <0.00%> (-41.67%)` | :arrow_down: |
| [...ols/DateFilterControl/components/CalendarFrame.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NhbGVuZGFyRnJhbWUudHN4) | `46.15% <0.00%> (-38.47%)` | :arrow_down: |
| [...ols/DateFilterControl/components/AdvancedFrame.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0FkdmFuY2VkRnJhbWUudHN4) | `26.92% <0.00%> (-26.93%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CustomFrame.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0N1c3RvbUZyYW1lLnRzeA==) | `16.00% <0.00%> (-26.00%)` | :arrow_down: |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `48.43% <0.00%> (-25.00%)` | :arrow_down: |
| [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `49.29% <0.00%> (-16.91%)` | :arrow_down: |
| ... and [29 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [d54cc6d...2f89e08](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (aca7984) into [master](https://codecov.io/gh/apache/superset/commit/d54cc6d82aa86444dff0eaff072ee9e8e9ea915f?el=desc) (d54cc6d) will **decrease** coverage by `0.19%`.
> The diff coverage is `89.70%`.
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
- Coverage 77.55% 77.36% -0.20%
==========================================
Files 935 936 +1
Lines 47301 47339 +38
Branches 5907 5941 +34
==========================================
- Hits 36685 36622 -63
- Misses 10472 10573 +101
Partials 144 144
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.00% <58.18%> (-0.03%)` | :arrow_down: |
| hive | `?` | |
| javascript | `63.84% <88.23%> (+0.11%)` | :arrow_up: |
| mysql | `80.60% <ø> (ø)` | |
| postgres | `80.63% <ø> (ø)` | |
| presto | `?` | |
| python | `80.72% <ø> (-0.43%)` | :arrow_down: |
| sqlite | `80.19% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `78.94% <87.23%> (+2.97%)` | :arrow_up: |
| [...frontend/src/views/CRUD/data/database/Checkbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9DaGVja2JveC50c3g=) | `95.23% <95.23%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.79% <0.00%> (-6.91%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.87% <0.00%> (-0.61%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `86.65% <0.00%> (-0.46%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.10% <0.00%> (-0.28%)` | :arrow_down: |
| ... and [2 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [d54cc6d...aca7984](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on a change in pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
eschutho commented on a change in pull request #13877:
URL: https://github.com/apache/superset/pull/13877#discussion_r605261730
##########
File path: superset-frontend/src/views/CRUD/data/database/DatabaseModal.tsx
##########
@@ -43,6 +43,9 @@ interface DatabaseModalProps {
}
const DEFAULT_TAB_KEY = '1';
+const EXPOSE_SQLLAB_FORM_HEIGHT = '260px';
Review comment:
can you bump this up to 270px? It's cutting some off. This approach is admittedly brittle. Maybe we can try to find a way of capturing the current height of the children and adding it up and passing it to emotion for styling in the next iteration of this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (07dc6ff) into [master](https://codecov.io/gh/apache/superset/commit/d54cc6d82aa86444dff0eaff072ee9e8e9ea915f?el=desc) (d54cc6d) will **decrease** coverage by `0.49%`.
> The diff coverage is `88.23%`.
> :exclamation: Current head 07dc6ff differs from pull request most recent head 69815e9. Consider uploading reports for the commit 69815e9 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
- Coverage 77.55% 77.06% -0.50%
==========================================
Files 935 935
Lines 47301 47321 +20
Branches 5907 5918 +11
==========================================
- Hits 36685 36466 -219
- Misses 10472 10701 +229
- Partials 144 154 +10
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.73% <65.11%> (-2.30%)` | :arrow_down: |
| javascript | `63.82% <86.27%> (+0.09%)` | :arrow_up: |
| presto | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `79.06% <86.95%> (+3.09%)` | :arrow_up: |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `100.00% <100.00%> (+5.26%)` | :arrow_up: |
| [...erset-frontend/src/common/hooks/useUrlShortener.ts](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VVcmxTaG9ydGVuZXIudHM=) | `50.00% <0.00%> (-42.86%)` | :arrow_down: |
| [...teFilterControl/components/DateFunctionTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0RhdGVGdW5jdGlvblRvb2x0aXAudHN4) | `58.33% <0.00%> (-41.67%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CommonFrame.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NvbW1vbkZyYW1lLnRzeA==) | `41.66% <0.00%> (-41.67%)` | :arrow_down: |
| [...ols/DateFilterControl/components/CalendarFrame.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NhbGVuZGFyRnJhbWUudHN4) | `46.15% <0.00%> (-38.47%)` | :arrow_down: |
| [...ols/DateFilterControl/components/AdvancedFrame.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0FkdmFuY2VkRnJhbWUudHN4) | `26.92% <0.00%> (-26.93%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CustomFrame.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0N1c3RvbUZyYW1lLnRzeA==) | `16.00% <0.00%> (-26.00%)` | :arrow_down: |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `48.43% <0.00%> (-25.00%)` | :arrow_down: |
| [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `49.29% <0.00%> (-16.91%)` | :arrow_down: |
| ... and [29 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [d54cc6d...69815e9](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
eschutho commented on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-812757097
tested in ephemeral environment, too, and it looks good. I wasn't able to test save functionality b/c of sqllite but I had tested it locally previously.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on a change in pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
eschutho commented on a change in pull request #13877:
URL: https://github.com/apache/superset/pull/13877#discussion_r605185341
##########
File path: superset-frontend/spec/javascripts/views/CRUD/data/database/DatabaseModal_spec.jsx
##########
@@ -19,71 +19,243 @@
import React from 'react';
import thunk from 'redux-thunk';
import configureStore from 'redux-mock-store';
+import * as redux from 'react-redux';
import { styledMount as mount } from 'spec/helpers/theming';
+import { render, screen } from 'spec/helpers/testing-library';
+import userEvent from '@testing-library/user-event';
+import { supersetTheme, ThemeProvider } from '@superset-ui/core';
+import { Provider } from 'react-redux';
import DatabaseModal from 'src/views/CRUD/data/database/DatabaseModal';
import Modal from 'src/common/components/Modal';
import Tabs from 'src/common/components/Tabs';
import fetchMock from 'fetch-mock';
import waitForComponentToPaint from 'spec/helpers/waitForComponentToPaint';
+import { initialState } from 'spec/javascripts/sqllab/fixtures';
// store needed for withToasts(DatabaseModal)
const mockStore = configureStore([thunk]);
const store = mockStore({});
-
const mockedProps = {
show: true,
};
-
const dbProps = {
show: true,
database: {
id: 10,
database_name: 'test',
sqlalchemy_uri: 'sqllite:///user:pw/test',
+ expose_in_sqllab: true,
},
};
-jest.mock('react-redux', () => ({
- ...jest.requireActual('react-redux'),
- useSelector: jest.fn(),
-}));
-
const DATABASE_ENDPOINT = 'glob:*/api/v1/database/*';
-
fetchMock.get(DATABASE_ENDPOINT, {});
describe('DatabaseModal', () => {
- const wrapper = mount(<DatabaseModal store={store} {...mockedProps} />);
-
- it('renders', () => {
- expect(wrapper.find(DatabaseModal)).toExist();
+ describe('enzyme', () => {
+ let wrapper;
+ let spyOnUseSelector;
+ beforeAll(() => {
+ spyOnUseSelector = jest.spyOn(redux, 'useSelector');
+ spyOnUseSelector.mockReturnValue(initialState.common.conf);
+ });
+ beforeEach(() => {
+ wrapper = mount(
+ <Provider store={store}>
+ <DatabaseModal store={store} {...mockedProps} />
+ </Provider>,
+ );
+ });
+ afterEach(() => {
+ wrapper.unmount();
+ });
+ it('renders', () => {
+ expect(wrapper.find(DatabaseModal)).toExist();
+ });
+ it('renders a Modal', () => {
+ expect(wrapper.find(Modal)).toExist();
+ });
+ it('renders "Add database" header when no database is included', () => {
+ expect(wrapper.find('h4').text()).toEqual('Add database');
+ });
+ it('renders "Edit database" header when database prop is included', () => {
+ const editWrapper = mount(<DatabaseModal store={store} {...dbProps} />);
+ waitForComponentToPaint(editWrapper);
+ expect(editWrapper.find('h4').text()).toEqual('Edit database');
+ editWrapper.unmount();
+ });
+ it('renders a Tabs menu', () => {
+ expect(wrapper.find(Tabs)).toExist();
+ });
+ it('renders five TabPanes', () => {
+ expect(wrapper.find(Tabs.TabPane)).toExist();
+ expect(wrapper.find(Tabs.TabPane)).toHaveLength(5);
+ });
+ it('renders input elements for Connection section', () => {
+ expect(wrapper.find('input[name="database_name"]')).toExist();
+ expect(wrapper.find('input[name="sqlalchemy_uri"]')).toExist();
+ });
});
- it('renders a Modal', () => {
- expect(wrapper.find(Modal)).toExist();
- });
+ describe('RTL', () => {
+ describe('initial load', () => {
+ it('hides the forms from the db when not selected', () => {
+ render(
+ <ThemeProvider theme={supersetTheme}>
+ <Provider store={store}>
+ <DatabaseModal
+ show
+ database={{
+ expose_in_sqllab: false,
+ allow_ctas: false,
+ allow_cvas: false,
+ }}
+ />
+ </Provider>
+ </ThemeProvider>,
+ );
+ // Select SQL Lab settings tab
+ const sqlLabSettingsTab = screen.getByRole('tab', {
+ name: /sql lab settings/i,
+ });
+ userEvent.click(sqlLabSettingsTab);
- it('renders "Add database" header when no database is included', () => {
- expect(wrapper.find('h4').text()).toEqual('Add database');
- });
+ const exposeInSqlLab = screen.getByText('Expose in SQL Lab');
+ const exposeChoicesForm = exposeInSqlLab.parentElement.nextSibling;
+ const schemaField = screen.getByText('CTAS & CVAS SCHEMA')
+ .parentElement;
+ expect(exposeChoicesForm).not.toHaveClass('open');
+ expect(schemaField).not.toHaveClass('open');
+ });
+ });
+ it('renders all settings when "Expose in SQL Lab" is checked', () => {
+ render(
+ <ThemeProvider theme={supersetTheme}>
+ <Provider store={store}>
+ <DatabaseModal {...dbProps} />
+ </Provider>
+ </ThemeProvider>,
+ );
- it('renders "Edit database" header when database prop is included', () => {
- const editWrapper = mount(<DatabaseModal store={store} {...dbProps} />);
- waitForComponentToPaint(editWrapper);
- expect(editWrapper.find('h4').text()).toEqual('Edit database');
- });
+ // Select SQL Lab settings tab
+ const sqlLabSettingsTab = screen.getByRole('tab', {
+ name: /sql lab settings/i,
+ });
- it('renders a Tabs menu', () => {
- expect(wrapper.find(Tabs)).toExist();
- });
+ userEvent.click(sqlLabSettingsTab);
+ // Grab all SQL Lab Settings by their labels
+ // const exposeInSqlLab = screen.getByText('Expose in SQL Lab');
+ const exposeInSqlLab = screen.getByRole('checkbox', {
+ name: /expose in sql lab/i,
+ });
- it('renders five TabPanes', () => {
- expect(wrapper.find(Tabs.TabPane)).toExist();
- expect(wrapper.find(Tabs.TabPane)).toHaveLength(5);
- });
+ // While 'Expose in SQL Lab' is checked, all settings should display
+ expect(exposeInSqlLab).not.toBeChecked();
+
+ // When clicked, "Expose in SQL Lab" becomes unchecked
+ userEvent.click(exposeInSqlLab);
+
+ // While unchecked, only "Expose in SQL Lab" should display
+ expect(exposeInSqlLab).toBeChecked();
+ const checkboxes = screen
+ .getAllByRole('checkbox')
+ .filter(checkbox => !checkbox.checked);
Review comment:
nice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] hughhhh closed pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
hughhhh closed pull request #13877:
URL: https://github.com/apache/superset/pull/13877
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on a change in pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
eschutho commented on a change in pull request #13877:
URL: https://github.com/apache/superset/pull/13877#discussion_r605270682
##########
File path: superset-frontend/src/views/CRUD/data/database/DatabaseModal.tsx
##########
@@ -69,11 +83,15 @@ const StyledInputContainer = styled.div`
.input-container {
display: flex;
- align-items: center;
+ align-items: top;
label {
display: flex;
margin-right: ${({ theme }) => theme.gridUnit * 2}px;
Review comment:
I think you'll want to remove this as well, but double check when you have the other labels moved into the correct label tag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (aca7984) into [master](https://codecov.io/gh/apache/superset/commit/d54cc6d82aa86444dff0eaff072ee9e8e9ea915f?el=desc) (d54cc6d) will **decrease** coverage by `1.02%`.
> The diff coverage is `70.14%`.
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
- Coverage 77.55% 76.53% -1.03%
==========================================
Files 935 948 +13
Lines 47301 48188 +887
Branches 5907 6178 +271
==========================================
+ Hits 36685 36879 +194
- Misses 10472 11165 +693
Partials 144 144
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `80.60% <ø> (ø)` | |
| postgres | `80.61% <ø> (-0.02%)` | :arrow_down: |
| presto | `?` | |
| python | `80.70% <ø> (-0.45%)` | :arrow_down: |
| sqlite | `80.19% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...frontend/src/views/CRUD/data/database/Checkbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9DaGVja2JveC50c3g=) | `29.41% <29.41%> (ø)` | |
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `74.57% <84.00%> (-1.40%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [...ore/components/controls/AnnotationLayerControl.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sLmpzeA==) | `8.57% <0.00%> (-74.29%)` | :arrow_down: |
| [...rc/explore/components/controls/AnnotationLayer.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXIuanN4) | `0.00% <0.00%> (-51.91%)` | :arrow_down: |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `43.75% <0.00%> (-29.69%)` | :arrow_down: |
| [...nd/src/explore/components/controls/TextControl.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UZXh0Q29udHJvbC50c3g=) | `48.83% <0.00%> (-25.59%)` | :arrow_down: |
| [...ntend/src/dashboard/components/dnd/handleScroll.ts](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVTY3JvbGwudHM=) | `26.66% <0.00%> (-20.01%)` | :arrow_down: |
| [...ontend/src/explore/components/DataTableControl.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVDb250cm9sLnRzeA==) | `32.00% <0.00%> (-18.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| ... and [35 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [d54cc6d...aca7984](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (16fe3aa) into [master](https://codecov.io/gh/apache/superset/commit/4187d9e4c4f3e281c3d8021010b9836cd8da12bc?el=desc) (4187d9e) will **increase** coverage by `0.39%`.
> The diff coverage is `80.32%`.
> :exclamation: Current head 16fe3aa differs from pull request most recent head cedabe2. Consider uploading reports for the commit cedabe2 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
+ Coverage 77.91% 78.31% +0.39%
==========================================
Files 934 934
Lines 47350 47467 +117
Branches 5941 5993 +52
==========================================
+ Hits 36894 37175 +281
+ Misses 10308 10148 -160
+ Partials 148 144 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.04% <74.41%> (+2.81%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `71.76% <78.00%> (+12.02%)` | :arrow_up: |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `94.28% <90.90%> (-0.46%)` | :arrow_down: |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `90.90% <0.00%> (-1.52%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `63.26% <0.00%> (+0.20%)` | :arrow_up: |
| [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `81.01% <0.00%> (+1.26%)` | :arrow_up: |
| [...-frontend/src/dashboard/actions/dashboardLayout.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZExheW91dC5qcw==) | `98.03% <0.00%> (+1.96%)` | :arrow_up: |
| [...frontend/src/dashboard/reducers/dashboardLayout.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRMYXlvdXQuanM=) | `99.00% <0.00%> (+2.00%)` | :arrow_up: |
| [superset-frontend/src/views/routes.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL3JvdXRlcy50c3g=) | `56.81% <0.00%> (+2.27%)` | :arrow_up: |
| [...-frontend/src/dashboard/reducers/dashboardState.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRTdGF0ZS5qcw==) | `85.71% <0.00%> (+3.57%)` | :arrow_up: |
| ... and [19 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [4187d9e...cedabe2](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (16fe3aa) into [master](https://codecov.io/gh/apache/superset/commit/4187d9e4c4f3e281c3d8021010b9836cd8da12bc?el=desc) (4187d9e) will **increase** coverage by `0.39%`.
> The diff coverage is `80.32%`.
> :exclamation: Current head 16fe3aa differs from pull request most recent head 573ee7e. Consider uploading reports for the commit 573ee7e to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
+ Coverage 77.91% 78.31% +0.39%
==========================================
Files 934 934
Lines 47350 47467 +117
Branches 5941 5993 +52
==========================================
+ Hits 36894 37175 +281
+ Misses 10308 10148 -160
+ Partials 148 144 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.04% <74.41%> (+2.81%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `71.76% <78.00%> (+12.02%)` | :arrow_up: |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `94.28% <90.90%> (-0.46%)` | :arrow_down: |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `90.90% <0.00%> (-1.52%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `63.26% <0.00%> (+0.20%)` | :arrow_up: |
| [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `81.01% <0.00%> (+1.26%)` | :arrow_up: |
| [...-frontend/src/dashboard/actions/dashboardLayout.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZExheW91dC5qcw==) | `98.03% <0.00%> (+1.96%)` | :arrow_up: |
| [...frontend/src/dashboard/reducers/dashboardLayout.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRMYXlvdXQuanM=) | `99.00% <0.00%> (+2.00%)` | :arrow_up: |
| [superset-frontend/src/views/routes.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL3JvdXRlcy50c3g=) | `56.81% <0.00%> (+2.27%)` | :arrow_up: |
| [...-frontend/src/dashboard/reducers/dashboardState.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRTdGF0ZS5qcw==) | `85.71% <0.00%> (+3.57%)` | :arrow_up: |
| ... and [19 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [4187d9e...573ee7e](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-812673471
@hughhhh Ephemeral environment spinning up at http://54.190.134.146:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (16fe3aa) into [master](https://codecov.io/gh/apache/superset/commit/4187d9e4c4f3e281c3d8021010b9836cd8da12bc?el=desc) (4187d9e) will **decrease** coverage by `0.17%`.
> The diff coverage is `80.32%`.
> :exclamation: Current head 16fe3aa differs from pull request most recent head 9febdce. Consider uploading reports for the commit 9febdce to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
- Coverage 77.91% 77.73% -0.18%
==========================================
Files 934 934
Lines 47350 47466 +116
Branches 5941 5993 +52
==========================================
+ Hits 36894 36900 +6
- Misses 10308 10409 +101
- Partials 148 157 +9
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.80% <74.41%> (+4.57%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `71.76% <78.00%> (+12.02%)` | :arrow_up: |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `94.28% <90.90%> (-0.46%)` | :arrow_down: |
| [...tend/src/visualizations/FilterBox/controlPanel.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9jb250cm9sUGFuZWwuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-59.26%)` | :arrow_down: |
| [...erset-frontend/src/common/hooks/useUrlShortener.ts](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VVcmxTaG9ydGVuZXIudHM=) | `50.00% <0.00%> (-42.86%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CommonFrame.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NvbW1vbkZyYW1lLnRzeA==) | `41.66% <0.00%> (-41.67%)` | :arrow_down: |
| [...ols/DateFilterControl/components/CalendarFrame.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NhbGVuZGFyRnJhbWUudHN4) | `46.15% <0.00%> (-38.47%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC50c3g=) | `0.00% <0.00%> (-25.00%)` | :arrow_down: |
| [.../explore/components/controls/CollectionControl.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xsZWN0aW9uQ29udHJvbC5qc3g=) | `21.21% <0.00%> (-24.25%)` | :arrow_down: |
| [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `49.29% <0.00%> (-16.91%)` | :arrow_down: |
| ... and [46 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [4187d9e...9febdce](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13877:
URL: https://github.com/apache/superset/pull/13877#issuecomment-810803906
# [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=h1) Report
> Merging [#13877](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=desc) (bbd695f) into [master](https://codecov.io/gh/apache/superset/commit/d54cc6d82aa86444dff0eaff072ee9e8e9ea915f?el=desc) (d54cc6d) will **decrease** coverage by `0.73%`.
> The diff coverage is `88.23%`.
[](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13877 +/- ##
==========================================
- Coverage 77.55% 76.81% -0.74%
==========================================
Files 935 935
Lines 47301 47321 +20
Branches 5907 5918 +11
==========================================
- Hits 36685 36351 -334
- Misses 10472 10814 +342
- Partials 144 156 +12
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.41% <65.11%> (-2.62%)` | :arrow_down: |
| hive | `?` | |
| javascript | `63.82% <86.27%> (+0.09%)` | :arrow_up: |
| mysql | `80.60% <ø> (ø)` | |
| postgres | `80.63% <ø> (ø)` | |
| presto | `?` | |
| python | `80.72% <ø> (-0.43%)` | :arrow_down: |
| sqlite | `80.19% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `79.06% <86.95%> (+3.09%)` | :arrow_up: |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `100.00% <100.00%> (+5.26%)` | :arrow_up: |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tend/src/visualizations/FilterBox/controlPanel.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9jb250cm9sUGFuZWwuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [...c/dashboard/components/dnd/AddSliceDragPreview.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9BZGRTbGljZURyYWdQcmV2aWV3LmpzeA==) | `35.71% <0.00%> (-64.29%)` | :arrow_down: |
| [...et-frontend/src/dashboard/actions/sliceEntities.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL3NsaWNlRW50aXRpZXMuanM=) | `12.90% <0.00%> (-58.07%)` | :arrow_down: |
| [...frontend/src/dashboard/components/AddSliceCard.jsx](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0FkZFNsaWNlQ2FyZC5qc3g=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...set-frontend/src/dashboard/reducers/datasources.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXRhc291cmNlcy5qcw==) | `57.14% <0.00%> (-42.86%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/actions/datasources.js](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2RhdGFzb3VyY2VzLmpz) | `15.78% <0.00%> (-42.11%)` | :arrow_down: |
| ... and [44 more](https://codecov.io/gh/apache/superset/pull/13877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=footer). Last update [d54cc6d...bbd695f](https://codecov.io/gh/apache/superset/pull/13877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on a change in pull request #13877: refactor: move CTAS/CVAS field II
Posted by GitBox <gi...@apache.org>.
eschutho commented on a change in pull request #13877:
URL: https://github.com/apache/superset/pull/13877#discussion_r605186188
##########
File path: superset-frontend/spec/javascripts/views/CRUD/data/database/DatabaseModal_spec.jsx
##########
@@ -19,71 +19,243 @@
import React from 'react';
import thunk from 'redux-thunk';
import configureStore from 'redux-mock-store';
+import * as redux from 'react-redux';
import { styledMount as mount } from 'spec/helpers/theming';
+import { render, screen } from 'spec/helpers/testing-library';
+import userEvent from '@testing-library/user-event';
+import { supersetTheme, ThemeProvider } from '@superset-ui/core';
+import { Provider } from 'react-redux';
import DatabaseModal from 'src/views/CRUD/data/database/DatabaseModal';
import Modal from 'src/common/components/Modal';
import Tabs from 'src/common/components/Tabs';
import fetchMock from 'fetch-mock';
import waitForComponentToPaint from 'spec/helpers/waitForComponentToPaint';
+import { initialState } from 'spec/javascripts/sqllab/fixtures';
// store needed for withToasts(DatabaseModal)
const mockStore = configureStore([thunk]);
const store = mockStore({});
-
const mockedProps = {
show: true,
};
-
const dbProps = {
show: true,
database: {
id: 10,
database_name: 'test',
sqlalchemy_uri: 'sqllite:///user:pw/test',
+ expose_in_sqllab: true,
},
};
-jest.mock('react-redux', () => ({
- ...jest.requireActual('react-redux'),
- useSelector: jest.fn(),
-}));
-
const DATABASE_ENDPOINT = 'glob:*/api/v1/database/*';
-
fetchMock.get(DATABASE_ENDPOINT, {});
describe('DatabaseModal', () => {
- const wrapper = mount(<DatabaseModal store={store} {...mockedProps} />);
-
- it('renders', () => {
- expect(wrapper.find(DatabaseModal)).toExist();
+ describe('enzyme', () => {
+ let wrapper;
+ let spyOnUseSelector;
+ beforeAll(() => {
+ spyOnUseSelector = jest.spyOn(redux, 'useSelector');
+ spyOnUseSelector.mockReturnValue(initialState.common.conf);
+ });
+ beforeEach(() => {
+ wrapper = mount(
+ <Provider store={store}>
+ <DatabaseModal store={store} {...mockedProps} />
+ </Provider>,
+ );
+ });
+ afterEach(() => {
+ wrapper.unmount();
+ });
+ it('renders', () => {
+ expect(wrapper.find(DatabaseModal)).toExist();
+ });
+ it('renders a Modal', () => {
+ expect(wrapper.find(Modal)).toExist();
+ });
+ it('renders "Add database" header when no database is included', () => {
+ expect(wrapper.find('h4').text()).toEqual('Add database');
+ });
+ it('renders "Edit database" header when database prop is included', () => {
+ const editWrapper = mount(<DatabaseModal store={store} {...dbProps} />);
+ waitForComponentToPaint(editWrapper);
+ expect(editWrapper.find('h4').text()).toEqual('Edit database');
+ editWrapper.unmount();
+ });
+ it('renders a Tabs menu', () => {
+ expect(wrapper.find(Tabs)).toExist();
+ });
+ it('renders five TabPanes', () => {
+ expect(wrapper.find(Tabs.TabPane)).toExist();
+ expect(wrapper.find(Tabs.TabPane)).toHaveLength(5);
+ });
+ it('renders input elements for Connection section', () => {
+ expect(wrapper.find('input[name="database_name"]')).toExist();
+ expect(wrapper.find('input[name="sqlalchemy_uri"]')).toExist();
+ });
});
- it('renders a Modal', () => {
- expect(wrapper.find(Modal)).toExist();
- });
+ describe('RTL', () => {
+ describe('initial load', () => {
+ it('hides the forms from the db when not selected', () => {
+ render(
+ <ThemeProvider theme={supersetTheme}>
+ <Provider store={store}>
+ <DatabaseModal
+ show
+ database={{
+ expose_in_sqllab: false,
+ allow_ctas: false,
+ allow_cvas: false,
+ }}
+ />
+ </Provider>
+ </ThemeProvider>,
+ );
+ // Select SQL Lab settings tab
+ const sqlLabSettingsTab = screen.getByRole('tab', {
+ name: /sql lab settings/i,
+ });
+ userEvent.click(sqlLabSettingsTab);
- it('renders "Add database" header when no database is included', () => {
- expect(wrapper.find('h4').text()).toEqual('Add database');
- });
+ const exposeInSqlLab = screen.getByText('Expose in SQL Lab');
+ const exposeChoicesForm = exposeInSqlLab.parentElement.nextSibling;
+ const schemaField = screen.getByText('CTAS & CVAS SCHEMA')
+ .parentElement;
+ expect(exposeChoicesForm).not.toHaveClass('open');
+ expect(schemaField).not.toHaveClass('open');
+ });
+ });
+ it('renders all settings when "Expose in SQL Lab" is checked', () => {
+ render(
+ <ThemeProvider theme={supersetTheme}>
+ <Provider store={store}>
+ <DatabaseModal {...dbProps} />
+ </Provider>
+ </ThemeProvider>,
+ );
- it('renders "Edit database" header when database prop is included', () => {
- const editWrapper = mount(<DatabaseModal store={store} {...dbProps} />);
- waitForComponentToPaint(editWrapper);
- expect(editWrapper.find('h4').text()).toEqual('Edit database');
- });
+ // Select SQL Lab settings tab
+ const sqlLabSettingsTab = screen.getByRole('tab', {
+ name: /sql lab settings/i,
+ });
- it('renders a Tabs menu', () => {
- expect(wrapper.find(Tabs)).toExist();
- });
+ userEvent.click(sqlLabSettingsTab);
+ // Grab all SQL Lab Settings by their labels
+ // const exposeInSqlLab = screen.getByText('Expose in SQL Lab');
+ const exposeInSqlLab = screen.getByRole('checkbox', {
+ name: /expose in sql lab/i,
+ });
- it('renders five TabPanes', () => {
- expect(wrapper.find(Tabs.TabPane)).toExist();
- expect(wrapper.find(Tabs.TabPane)).toHaveLength(5);
- });
+ // While 'Expose in SQL Lab' is checked, all settings should display
+ expect(exposeInSqlLab).not.toBeChecked();
+
+ // When clicked, "Expose in SQL Lab" becomes unchecked
+ userEvent.click(exposeInSqlLab);
+
+ // While unchecked, only "Expose in SQL Lab" should display
+ expect(exposeInSqlLab).toBeChecked();
+ const checkboxes = screen
+ .getAllByRole('checkbox')
+ .filter(checkbox => !checkbox.checked);
+
+ // While checked make sure all checkboxes are showing
+ expect(checkboxes.length).toEqual(4);
+ });
+
+ it('renders the schema field when allowCTAS is checked', () => {
+ render(
+ <ThemeProvider theme={supersetTheme}>
+ <Provider store={store}>
+ <DatabaseModal {...dbProps} />
+ </Provider>
+ </ThemeProvider>,
+ );
+
+ // Select SQL Lab settings tab
+ const sqlLabSettingsTab = screen.getByRole('tab', {
+ name: /sql lab settings/i,
+ });
+ userEvent.click(sqlLabSettingsTab);
+ // Grab CTAS & schema field by their labels
+ const allowCTAS = screen.getByLabelText('Allow CREATE TABLE AS');
+ const schemaField = screen.getByText('CTAS & CVAS SCHEMA').parentElement;
+
+ // While CTAS & CVAS are unchecked, schema field is not visible
+ expect(schemaField).not.toHaveClass('open');
+
+ // Check "Allow CTAS" to reveal schema field
+ userEvent.click(allowCTAS);
+ expect(schemaField).toHaveClass('open');
+
+ // Uncheck "Allow CTAS" to hide schema field again
+ userEvent.click(allowCTAS);
+ expect(schemaField).not.toHaveClass('open');
+ });
+
+ it('renders the schema field when allowCVAS is checked', () => {
+ render(
+ <ThemeProvider theme={supersetTheme}>
+ <Provider store={store}>
+ <DatabaseModal {...dbProps} />
+ </Provider>
+ </ThemeProvider>,
+ );
+
+ // Select SQL Lab settings tab
+ const sqlLabSettingsTab = screen.getByRole('tab', {
+ name: /sql lab settings/i,
+ });
+ userEvent.click(sqlLabSettingsTab);
+ // Grab CVAS by it's label & schema field
+ const allowCVAS = screen.getByText('Allow CREATE VIEW AS');
+ const schemaField = screen.getByText('CTAS & CVAS SCHEMA').parentElement;
+
+ // While CTAS & CVAS are unchecked, schema field is not visible
+ expect(schemaField).not.toHaveClass('open');
+
+ // Check "Allow CVAS" to reveal schema field
+ userEvent.click(allowCVAS);
+ expect(schemaField).toHaveClass('open');
+
+ // Uncheck "Allow CVAS" to hide schema field again
+ userEvent.click(allowCVAS);
+ expect(schemaField).not.toHaveClass('open');
+ });
+
+ it('renders the schema field when both allowCTAS and allowCVAS are checked', () => {
+ render(
+ <ThemeProvider theme={supersetTheme}>
+ <Provider store={store}>
+ <DatabaseModal {...dbProps} />
+ </Provider>
+ </ThemeProvider>,
+ );
+
+ // Select SQL Lab settings tab
+ const sqlLabSettingsTab = screen.getByRole('tab', {
+ name: /sql lab settings/i,
+ });
+ userEvent.click(sqlLabSettingsTab);
+ // Grab CTAS and CVAS by their labels, & schema field
+ const allowCTAS = screen.getByText('Allow CREATE TABLE AS');
+ const allowCVAS = screen.getByText('Allow CREATE VIEW AS');
+ const schemaField = screen.getByText('CTAS & CVAS SCHEMA').parentElement;
+
+ // While CTAS & CVAS are unchecked, schema field is not visible
+ expect(schemaField).not.toHaveClass('open');
- it('renders input elements for Connection section', () => {
- expect(wrapper.find('input[name="database_name"]')).toExist();
- expect(wrapper.find('input[name="sqlalchemy_uri"]')).toExist();
+ // Check both "Allow CTAS" and "Allow CVAS" to reveal schema field
+ userEvent.click(allowCTAS);
+ userEvent.click(allowCVAS);
+ expect(schemaField).toHaveClass('open');
+ // Uncheck both "Allow CTAS" and "Allow CVAS" to hide schema field again
+ userEvent.click(allowCTAS);
+ // Both checkboxes go unchecked, so the field should no longer render
+ userEvent.click(allowCVAS);
Review comment:
nit, but I would move this up a line with the other click to be more in line with the comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org