You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@libcloud.apache.org by "Daemian Mack (JIRA)" <ji...@apache.org> on 2012/05/14 19:49:51 UTC
[dev] [jira] [Created] (LIBCLOUD-196) Support RegisterIso call in
CloudStack compute driver
Daemian Mack created LIBCLOUD-196:
-------------------------------------
Summary: Support RegisterIso call in CloudStack compute driver
Key: LIBCLOUD-196
URL: https://issues.apache.org/jira/browse/LIBCLOUD-196
Project: Libcloud
Issue Type: New Feature
Components: Compute
Affects Versions: 0.9.1
Reporter: Daemian Mack
Priority: Minor
Fix For: 0.9.1
Patch adds support for RegisterIso call to pass a downloadable URL to CloudStack.
Known concerns:
- Inner 'exhaust_redirects' method may merit inclusion as utility method elsewhere.
- Defaulting to bootable=False may not accurately represent typical use case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[dev] [jira] [Commented] (LIBCLOUD-196) Support RegisterIso call in
CloudStack compute driver
Posted by "Tomaz Muraus (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LIBCLOUD-196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276466#comment-13276466 ]
Tomaz Muraus commented on LIBCLOUD-196:
---------------------------------------
Everything besides the "exhaust_redirects" part looks fine.
I think this should be removed from the patch and just require user to pass in a URL which doesn't return a redirect. Supporting following redirects adds additional complexity and in Libcloud we prefer to do a single HTTP request in a single method call (if that's is possible), because it makes handling exceptions and retrying easier.
> Support RegisterIso call in CloudStack compute driver
> -----------------------------------------------------
>
> Key: LIBCLOUD-196
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-196
> Project: Libcloud
> Issue Type: New Feature
> Components: Compute
> Affects Versions: 0.9.1
> Reporter: Daemian Mack
> Priority: Minor
> Labels: newbie, patch
> Fix For: 0.9.1
>
> Attachments: add_support_for_cloudstack_registeriso.diff
>
>
> Patch adds support for RegisterIso call to pass a downloadable URL to CloudStack.
> Known concerns:
> - Inner 'exhaust_redirects' method may merit inclusion as utility method elsewhere.
> - Defaulting to bootable=False may not accurately represent typical use case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[dev] [jira] [Updated] (LIBCLOUD-196) Support RegisterIso call in
CloudStack compute driver
Posted by "Daemian Mack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LIBCLOUD-196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daemian Mack updated LIBCLOUD-196:
----------------------------------
Attachment: add_support_for_cloudstack_registeriso.diff
> Support RegisterIso call in CloudStack compute driver
> -----------------------------------------------------
>
> Key: LIBCLOUD-196
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-196
> Project: Libcloud
> Issue Type: New Feature
> Components: Compute
> Affects Versions: 0.9.1
> Reporter: Daemian Mack
> Priority: Minor
> Labels: newbie, patch
> Fix For: 0.9.1
>
> Attachments: add_support_for_cloudstack_registeriso.diff
>
>
> Patch adds support for RegisterIso call to pass a downloadable URL to CloudStack.
> Known concerns:
> - Inner 'exhaust_redirects' method may merit inclusion as utility method elsewhere.
> - Defaulting to bootable=False may not accurately represent typical use case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[dev] [jira] [Comment Edited] (LIBCLOUD-196) Support RegisterIso call in
CloudStack compute driver
Posted by "Tomaz Muraus (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LIBCLOUD-196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278572#comment-13278572 ]
Tomaz Muraus edited comment on LIBCLOUD-196 at 5/18/12 4:43 AM:
----------------------------------------------------------------
Thanks for your patch. I've committed it to trunk with some changes:
- Remove exhaust_redirects functionality - it should be a responsibility of a developer to pass in a correct URL
- Use LibcloudError instead od CloudStackException
- Remove unecessary except KeyError - dict.get doesn't throw a KeyError
- Remove trailing white-space
was (Author: kami):
Thanks for your patch. I've committed it to trunk with some changes:
- Remove exhaust_redirects functionality
- Use LibcloudError instead od CloudStackException
- Remove unecessary except KeyError - dict.get doesn't throw a KeyError
- Remove trailing white-space
> Support RegisterIso call in CloudStack compute driver
> -----------------------------------------------------
>
> Key: LIBCLOUD-196
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-196
> Project: Libcloud
> Issue Type: New Feature
> Components: Compute
> Affects Versions: 0.9.1
> Reporter: Daemian Mack
> Priority: Minor
> Labels: newbie, patch
> Fix For: 0.9.1
>
> Attachments: add_support_for_cloudstack_registeriso.diff
>
>
> Patch adds support for RegisterIso call to pass a downloadable URL to CloudStack.
> Known concerns:
> - Inner 'exhaust_redirects' method may merit inclusion as utility method elsewhere.
> - Defaulting to bootable=False may not accurately represent typical use case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[dev] [jira] [Comment Edited] (LIBCLOUD-196) Support RegisterIso call in
CloudStack compute driver
Posted by "Daemian Mack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LIBCLOUD-196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13277989#comment-13277989 ]
Daemian Mack edited comment on LIBCLOUD-196 at 5/17/12 5:17 PM:
----------------------------------------------------------------
Makes sense to leave that out of the libcloud driver.
In a perfect world, CloudStack would handle this itself -- I think that's in line with the general expectation of URL-handling.
Since CloudStack leaves this wrinkle as a surprise to the developer, might we want to document this responsibility on the part of the developer? I'm just not sure where the best place for that might be.
was (Author: daemianmack):
Makes sense to leave that out of the libcloud driver.
In a perfect world, CloudStack would handle this itself -- I think that's in line with the general expectation of URL-handling.
Since CloudStack leaves this wrinkle as a surprise to the developer, might we want to document this responsibility on the part of the user? I'm just not sure where the best place for that might be.
> Support RegisterIso call in CloudStack compute driver
> -----------------------------------------------------
>
> Key: LIBCLOUD-196
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-196
> Project: Libcloud
> Issue Type: New Feature
> Components: Compute
> Affects Versions: 0.9.1
> Reporter: Daemian Mack
> Priority: Minor
> Labels: newbie, patch
> Fix For: 0.9.1
>
> Attachments: add_support_for_cloudstack_registeriso.diff
>
>
> Patch adds support for RegisterIso call to pass a downloadable URL to CloudStack.
> Known concerns:
> - Inner 'exhaust_redirects' method may merit inclusion as utility method elsewhere.
> - Defaulting to bootable=False may not accurately represent typical use case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[dev] [jira] [Resolved] (LIBCLOUD-196) Support RegisterIso call in
CloudStack compute driver
Posted by "Tomaz Muraus (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LIBCLOUD-196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tomaz Muraus resolved LIBCLOUD-196.
-----------------------------------
Resolution: Fixed
> Support RegisterIso call in CloudStack compute driver
> -----------------------------------------------------
>
> Key: LIBCLOUD-196
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-196
> Project: Libcloud
> Issue Type: New Feature
> Components: Compute
> Affects Versions: 0.9.1
> Reporter: Daemian Mack
> Priority: Minor
> Labels: newbie, patch
> Fix For: 0.9.1
>
> Attachments: add_support_for_cloudstack_registeriso.diff
>
>
> Patch adds support for RegisterIso call to pass a downloadable URL to CloudStack.
> Known concerns:
> - Inner 'exhaust_redirects' method may merit inclusion as utility method elsewhere.
> - Defaulting to bootable=False may not accurately represent typical use case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[dev] [jira] [Commented] (LIBCLOUD-196) Support RegisterIso call in
CloudStack compute driver
Posted by "Daemian Mack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LIBCLOUD-196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13277989#comment-13277989 ]
Daemian Mack commented on LIBCLOUD-196:
---------------------------------------
Makes sense to leave that out of the libcloud driver.
In a perfect world, CloudStack would handle this itself -- I think that's in line with the general expectation of URL-handling.
Since CloudStack leaves this wrinkle as a surprise to the developer, might we want to document this responsibility on the part of the user? I'm just not sure where the best place for that might be.
> Support RegisterIso call in CloudStack compute driver
> -----------------------------------------------------
>
> Key: LIBCLOUD-196
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-196
> Project: Libcloud
> Issue Type: New Feature
> Components: Compute
> Affects Versions: 0.9.1
> Reporter: Daemian Mack
> Priority: Minor
> Labels: newbie, patch
> Fix For: 0.9.1
>
> Attachments: add_support_for_cloudstack_registeriso.diff
>
>
> Patch adds support for RegisterIso call to pass a downloadable URL to CloudStack.
> Known concerns:
> - Inner 'exhaust_redirects' method may merit inclusion as utility method elsewhere.
> - Defaulting to bootable=False may not accurately represent typical use case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[dev] [jira] [Updated] (LIBCLOUD-196) Support RegisterIso call in
CloudStack compute driver
Posted by "Tomaz Muraus (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LIBCLOUD-196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tomaz Muraus updated LIBCLOUD-196:
----------------------------------
Assignee: Tomaz Muraus
> Support RegisterIso call in CloudStack compute driver
> -----------------------------------------------------
>
> Key: LIBCLOUD-196
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-196
> Project: Libcloud
> Issue Type: New Feature
> Components: Compute
> Affects Versions: 0.9.1
> Reporter: Daemian Mack
> Assignee: Tomaz Muraus
> Priority: Minor
> Labels: newbie, patch
> Fix For: 0.9.1
>
> Attachments: add_support_for_cloudstack_registeriso.diff
>
>
> Patch adds support for RegisterIso call to pass a downloadable URL to CloudStack.
> Known concerns:
> - Inner 'exhaust_redirects' method may merit inclusion as utility method elsewhere.
> - Defaulting to bootable=False may not accurately represent typical use case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[dev] [jira] [Closed] (LIBCLOUD-196) Support RegisterIso call in
CloudStack compute driver
Posted by "Tomaz Muraus (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LIBCLOUD-196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tomaz Muraus closed LIBCLOUD-196.
---------------------------------
> Support RegisterIso call in CloudStack compute driver
> -----------------------------------------------------
>
> Key: LIBCLOUD-196
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-196
> Project: Libcloud
> Issue Type: New Feature
> Components: Compute
> Affects Versions: 0.9.1
> Reporter: Daemian Mack
> Assignee: Tomaz Muraus
> Priority: Minor
> Labels: newbie, patch
> Fix For: 0.10.1
>
> Attachments: add_support_for_cloudstack_registeriso.diff
>
>
> Patch adds support for RegisterIso call to pass a downloadable URL to CloudStack.
> Known concerns:
> - Inner 'exhaust_redirects' method may merit inclusion as utility method elsewhere.
> - Defaulting to bootable=False may not accurately represent typical use case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[dev] [jira] [Updated] (LIBCLOUD-196) Support RegisterIso call in
CloudStack compute driver
Posted by "Tomaz Muraus (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LIBCLOUD-196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tomaz Muraus updated LIBCLOUD-196:
----------------------------------
Fix Version/s: (was: 0.9.1)
0.10.1
> Support RegisterIso call in CloudStack compute driver
> -----------------------------------------------------
>
> Key: LIBCLOUD-196
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-196
> Project: Libcloud
> Issue Type: New Feature
> Components: Compute
> Affects Versions: 0.9.1
> Reporter: Daemian Mack
> Assignee: Tomaz Muraus
> Priority: Minor
> Labels: newbie, patch
> Fix For: 0.10.1
>
> Attachments: add_support_for_cloudstack_registeriso.diff
>
>
> Patch adds support for RegisterIso call to pass a downloadable URL to CloudStack.
> Known concerns:
> - Inner 'exhaust_redirects' method may merit inclusion as utility method elsewhere.
> - Defaulting to bootable=False may not accurately represent typical use case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[dev] [jira] [Commented] (LIBCLOUD-196) Support RegisterIso call in
CloudStack compute driver
Posted by "Tomaz Muraus (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LIBCLOUD-196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278572#comment-13278572 ]
Tomaz Muraus commented on LIBCLOUD-196:
---------------------------------------
Thanks for your patch. I've committed it to trunk with some changes:
- Remove exhaust_redirects functionality
- Use LibcloudError instead od CloudStackException
- Remove unecessary except KeyError - dict.get doesn't throw a KeyError
- Remove trailing white-space
> Support RegisterIso call in CloudStack compute driver
> -----------------------------------------------------
>
> Key: LIBCLOUD-196
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-196
> Project: Libcloud
> Issue Type: New Feature
> Components: Compute
> Affects Versions: 0.9.1
> Reporter: Daemian Mack
> Priority: Minor
> Labels: newbie, patch
> Fix For: 0.9.1
>
> Attachments: add_support_for_cloudstack_registeriso.diff
>
>
> Patch adds support for RegisterIso call to pass a downloadable URL to CloudStack.
> Known concerns:
> - Inner 'exhaust_redirects' method may merit inclusion as utility method elsewhere.
> - Defaulting to bootable=False may not accurately represent typical use case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira