You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alexander Saydakov (Code Review)" <ge...@cloudera.org> on 2021/08/31 00:10:57 UTC
[Impala-ASF-CR] cleaner and faster operations wtih datasketches
Alexander Saydakov has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17818
Change subject: cleaner and faster operations wtih datasketches
......................................................................
cleaner and faster operations wtih datasketches
Change-Id: I306a2489dac0f4d2d475e8f9987cd58bf95474bb
---
M be/src/exprs/aggregate-functions-ir.cc
M be/src/exprs/datasketches-common.cc
M be/src/exprs/datasketches-common.h
M be/src/exprs/datasketches-functions-ir.cc
4 files changed, 203 insertions(+), 308 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/18/17818/1
--
To view, visit http://gerrit.cloudera.org:8080/17818
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I306a2489dac0f4d2d475e8f9987cd58bf95474bb
Gerrit-Change-Number: 17818
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Saydakov <al...@apache.org>
[Impala-ASF-CR] cleaner and faster operations wtih datasketches
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17818 )
Change subject: cleaner and faster operations wtih datasketches
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/9405/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17818
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I306a2489dac0f4d2d475e8f9987cd58bf95474bb
Gerrit-Change-Number: 17818
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Saydakov <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 31 Aug 2021 00:37:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10901 cleaner and faster operations with datasketches
Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/17818 )
Change subject: IMPALA-10901 cleaner and faster operations with datasketches
......................................................................
Patch Set 3: Code-Review+2
Thanks for making these changes! I'm fine with the patch, I'll run the verify job.
--
To view, visit http://gerrit.cloudera.org:8080/17818
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I306a2489dac0f4d2d475e8f9987cd58bf95474bb
Gerrit-Change-Number: 17818
Gerrit-PatchSet: 3
Gerrit-Owner: Alexander Saydakov <al...@apache.org>
Gerrit-Reviewer: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 Sep 2021 07:48:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10901 cleaner and faster operations with datasketches
Posted by "Alexander Saydakov (Code Review)" <ge...@cloudera.org>.
Hello Fucun Chu, Gabor Kaszab, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17818
to look at the new patch set (#3).
Change subject: IMPALA-10901 cleaner and faster operations with datasketches
......................................................................
IMPALA-10901 cleaner and faster operations with datasketches
- serialize using bytes instead of stream
- avoid unnecessary constructor during deserialization
- simplified code slightly
- added original exception message to re-thrown generic message
Change-Id: I306a2489dac0f4d2d475e8f9987cd58bf95474bb
---
M be/src/exprs/aggregate-functions-ir.cc
M be/src/exprs/datasketches-common.cc
M be/src/exprs/datasketches-common.h
M be/src/exprs/datasketches-functions-ir.cc
M testdata/workloads/functional-query/queries/QueryTest/datasketches-cpc.test
M testdata/workloads/functional-query/queries/QueryTest/datasketches-hll.test
M testdata/workloads/functional-query/queries/QueryTest/datasketches-kll.test
M testdata/workloads/functional-query/queries/QueryTest/datasketches-theta.test
8 files changed, 259 insertions(+), 375 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/18/17818/3
--
To view, visit http://gerrit.cloudera.org:8080/17818
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I306a2489dac0f4d2d475e8f9987cd58bf95474bb
Gerrit-Change-Number: 17818
Gerrit-PatchSet: 3
Gerrit-Owner: Alexander Saydakov <al...@apache.org>
Gerrit-Reviewer: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-10901 cleaner and faster operations with datasketches
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17818 )
Change subject: IMPALA-10901 cleaner and faster operations with datasketches
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/17818
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I306a2489dac0f4d2d475e8f9987cd58bf95474bb
Gerrit-Change-Number: 17818
Gerrit-PatchSet: 4
Gerrit-Owner: Alexander Saydakov <al...@apache.org>
Gerrit-Reviewer: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 Sep 2021 13:58:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] cleaner and faster operations wtih datasketches
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17818 )
Change subject: cleaner and faster operations wtih datasketches
......................................................................
Patch Set 1:
(22 comments)
http://gerrit.cloudera.org:8080/#/c/17818/1/be/src/exprs/aggregate-functions-ir.cc
File be/src/exprs/aggregate-functions-ir.cc:
http://gerrit.cloudera.org:8080/#/c/17818/1/be/src/exprs/aggregate-functions-ir.cc@2089
PS1, Line 2089: dst_union_ptr->update(datasketches::compact_theta_sketch::deserialize(src.ptr, src.len));
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17818/1/be/src/exprs/aggregate-functions-ir.cc@2100
PS1, Line 2100: union_sketch.update(datasketches::compact_theta_sketch::deserialize(src.ptr, src.len));
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17818/1/be/src/exprs/datasketches-common.cc
File be/src/exprs/datasketches-common.cc:
http://gerrit.cloudera.org:8080/#/c/17818/1/be/src/exprs/datasketches-common.cc@39
PS1, Line 39: ctx->SetError(strings::Substitute("Unable to deserialize sketch: $0", e.what()).c_str());
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17818/1/be/src/exprs/datasketches-common.cc@53
PS1, Line 53: union_sketch.update(datasketches::cpc_sketch::deserialize(serialized_sketch.ptr, serialized_sketch.len));
line too long (111 > 90)
http://gerrit.cloudera.org:8080/#/c/17818/1/be/src/exprs/datasketches-common.cc@66
PS1, Line 66: sketch.update(datasketches::compact_theta_sketch::deserialize(serialized_sketch.ptr, serialized_sketch.len));
line too long (115 > 90)
http://gerrit.cloudera.org:8080/#/c/17818/1/be/src/exprs/datasketches-common.cc@79
PS1, Line 79: sketch.update(datasketches::compact_theta_sketch::deserialize(serialized_sketch.ptr, serialized_sketch.len));
line too long (115 > 90)
http://gerrit.cloudera.org:8080/#/c/17818/1/be/src/exprs/datasketches-functions-ir.cc
File be/src/exprs/datasketches-functions-ir.cc:
http://gerrit.cloudera.org:8080/#/c/17818/1/be/src/exprs/datasketches-functions-ir.cc@40
PS1, Line 40: auto sketch = datasketches::hll_sketch::deserialize(serialized_sketch.ptr, serialized_sketch.len);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17818/1/be/src/exprs/datasketches-functions-ir.cc@62
PS1, Line 62: auto sketch = datasketches::hll_sketch::deserialize(serialized_sketch.ptr, serialized_sketch.len);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17818/1/be/src/exprs/datasketches-functions-ir.cc@78
PS1, Line 78: union_sketch.update(datasketches::hll_sketch::deserialize(serialized_sketch1.ptr, serialized_sketch1.len));
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17818/1/be/src/exprs/datasketches-functions-ir.cc@86
PS1, Line 86: union_sketch.update(datasketches::hll_sketch::deserialize(serialized_sketch2.ptr, serialized_sketch2.len));
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17818/1/be/src/exprs/datasketches-functions-ir.cc@102
PS1, Line 102: auto sketch = datasketches::hll_sketch::deserialize(serialized_sketch.ptr, serialized_sketch.len);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17818/1/be/src/exprs/datasketches-functions-ir.cc@117
PS1, Line 117: auto sketch = datasketches::cpc_sketch::deserialize(serialized_sketch.ptr, serialized_sketch.len);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17818/1/be/src/exprs/datasketches-functions-ir.cc@129
PS1, Line 129: auto sketch = datasketches::cpc_sketch::deserialize(serialized_sketch.ptr, serialized_sketch.len);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17818/1/be/src/exprs/datasketches-functions-ir.cc@160
PS1, Line 160: auto sketch = datasketches::compact_theta_sketch::deserialize(serialized_sketch.ptr, serialized_sketch.len);
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17818/1/be/src/exprs/datasketches-functions-ir.cc@182
PS1, Line 182: datasketches::compact_theta_sketch::deserialize(serialized_sketch1.ptr, serialized_sketch1.len),
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/17818/1/be/src/exprs/datasketches-functions-ir.cc@183
PS1, Line 183: datasketches::compact_theta_sketch::deserialize(serialized_sketch2.ptr, serialized_sketch2.len)
line too long (103 > 90)
http://gerrit.cloudera.org:8080/#/c/17818/1/be/src/exprs/datasketches-functions-ir.cc@238
PS1, Line 238: auto sketch = datasketches::kll_sketch<float>::deserialize(serialized_sketch.ptr, serialized_sketch.len);
line too long (109 > 90)
http://gerrit.cloudera.org:8080/#/c/17818/1/be/src/exprs/datasketches-functions-ir.cc@251
PS1, Line 251: auto sketch = datasketches::kll_sketch<float>::deserialize(serialized_sketch.ptr, serialized_sketch.len);
line too long (109 > 90)
http://gerrit.cloudera.org:8080/#/c/17818/1/be/src/exprs/datasketches-functions-ir.cc@263
PS1, Line 263: auto sketch = datasketches::kll_sketch<float>::deserialize(serialized_sketch.ptr, serialized_sketch.len);
line too long (109 > 90)
http://gerrit.cloudera.org:8080/#/c/17818/1/be/src/exprs/datasketches-functions-ir.cc@278
PS1, Line 278: auto sketch = datasketches::kll_sketch<float>::deserialize(serialized_sketch.ptr, serialized_sketch.len);
line too long (109 > 90)
http://gerrit.cloudera.org:8080/#/c/17818/1/be/src/exprs/datasketches-functions-ir.cc@298
PS1, Line 298: auto sketch = datasketches::kll_sketch<float>::deserialize(serialized_sketch.ptr, serialized_sketch.len);
line too long (109 > 90)
http://gerrit.cloudera.org:8080/#/c/17818/1/be/src/exprs/datasketches-functions-ir.cc@326
PS1, Line 326: auto sketch = datasketches::kll_sketch<float>::deserialize(serialized_sketch.ptr, serialized_sketch.len);
line too long (109 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/17818
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I306a2489dac0f4d2d475e8f9987cd58bf95474bb
Gerrit-Change-Number: 17818
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Saydakov <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 31 Aug 2021 00:11:59 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10901 cleaner and faster operations with datasketches
Posted by "Alexander Saydakov (Code Review)" <ge...@cloudera.org>.
Hello Gabor Kaszab, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17818
to look at the new patch set (#2).
Change subject: IMPALA-10901 cleaner and faster operations with datasketches
......................................................................
IMPALA-10901 cleaner and faster operations with datasketches
- serialize using bytes instead of stream
- avoid unnecessary constructor during deserialization
- simplified code slightly
- added original exception message to re-thrown generic message
Change-Id: I306a2489dac0f4d2d475e8f9987cd58bf95474bb
---
M be/src/exprs/aggregate-functions-ir.cc
M be/src/exprs/datasketches-common.cc
M be/src/exprs/datasketches-common.h
M be/src/exprs/datasketches-functions-ir.cc
4 files changed, 233 insertions(+), 342 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/18/17818/2
--
To view, visit http://gerrit.cloudera.org:8080/17818
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I306a2489dac0f4d2d475e8f9987cd58bf95474bb
Gerrit-Change-Number: 17818
Gerrit-PatchSet: 2
Gerrit-Owner: Alexander Saydakov <al...@apache.org>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-10901 cleaner and faster operations with datasketches
Posted by "Fucun Chu (Code Review)" <ge...@cloudera.org>.
Fucun Chu has posted comments on this change. ( http://gerrit.cloudera.org:8080/17818 )
Change subject: IMPALA-10901 cleaner and faster operations with datasketches
......................................................................
Patch Set 2:
The following EE Tests files need to be modified:
testdata/workloads/functional-query/queries/QueryTest/
datasketches-cpc.test
datasketches-hll.test
datasketches-kll.test
datasketches-theta.test
"UDF ERROR: Unable to deserialize sketch" needs to add e.what() information.
Run the above test case file using the following command:
cd tests
impala-py.test query_test/test_datasketches.py
Or use pre-review-test (https://jenkins.impala.io/job/pre-review-test/build?delay=0sec) to run the test
--
To view, visit http://gerrit.cloudera.org:8080/17818
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I306a2489dac0f4d2d475e8f9987cd58bf95474bb
Gerrit-Change-Number: 17818
Gerrit-PatchSet: 2
Gerrit-Owner: Alexander Saydakov <al...@apache.org>
Gerrit-Reviewer: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Sep 2021 03:05:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10901 cleaner and faster operations with datasketches
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17818 )
Change subject: IMPALA-10901 cleaner and faster operations with datasketches
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/9419/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17818
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I306a2489dac0f4d2d475e8f9987cd58bf95474bb
Gerrit-Change-Number: 17818
Gerrit-PatchSet: 3
Gerrit-Owner: Alexander Saydakov <al...@apache.org>
Gerrit-Reviewer: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Sep 2021 21:23:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10901 cleaner and faster operations with datasketches
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17818 )
Change subject: IMPALA-10901 cleaner and faster operations with datasketches
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7474/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/17818
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I306a2489dac0f4d2d475e8f9987cd58bf95474bb
Gerrit-Change-Number: 17818
Gerrit-PatchSet: 4
Gerrit-Owner: Alexander Saydakov <al...@apache.org>
Gerrit-Reviewer: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 Sep 2021 07:48:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] cleaner and faster operations wtih datasketches
Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/17818 )
Change subject: cleaner and faster operations wtih datasketches
......................................................................
Patch Set 1:
(4 comments)
Thanks Alexander for taking care of these changes!
Apart from the automated format checks I left some comments, nothing serious.
http://gerrit.cloudera.org:8080/#/c/17818/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/17818/1//COMMIT_MSG@7
PS1, Line 7: cleaner
I've created a jira ticket for this patch. Could you please add the Jira Id to the beginning of the commit msg (similarly to other patches)?
https://issues.apache.org/jira/browse/IMPALA-10901
http://gerrit.cloudera.org:8080/#/c/17818/1//COMMIT_MSG@7
PS1, Line 7: wtih
typo
http://gerrit.cloudera.org:8080/#/c/17818/1//COMMIT_MSG@8
PS1, Line 8:
Could you please write a sentence or two here to sum up the changes in this patch?
http://gerrit.cloudera.org:8080/#/c/17818/1/be/src/exprs/aggregate-functions-ir.cc
File be/src/exprs/aggregate-functions-ir.cc:
http://gerrit.cloudera.org:8080/#/c/17818/1/be/src/exprs/aggregate-functions-ir.cc@1624
PS1, Line 1624: StringVal SerializeCompactDsHllSketch(FunctionContext* ctx,
With this simplification we ended up with a number of functions that have actually the same body, and a difference between them is a function parameter. I wonder if these could be simplified further to have a single template function that covers all of them.
--
To view, visit http://gerrit.cloudera.org:8080/17818
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I306a2489dac0f4d2d475e8f9987cd58bf95474bb
Gerrit-Change-Number: 17818
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Saydakov <al...@apache.org>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 31 Aug 2021 07:33:07 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10901 cleaner and faster operations with datasketches
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17818 )
Change subject: IMPALA-10901 cleaner and faster operations with datasketches
......................................................................
IMPALA-10901 cleaner and faster operations with datasketches
- serialize using bytes instead of stream
- avoid unnecessary constructor during deserialization
- simplified code slightly
- added original exception message to re-thrown generic message
Change-Id: I306a2489dac0f4d2d475e8f9987cd58bf95474bb
Reviewed-on: http://gerrit.cloudera.org:8080/17818
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/exprs/aggregate-functions-ir.cc
M be/src/exprs/datasketches-common.cc
M be/src/exprs/datasketches-common.h
M be/src/exprs/datasketches-functions-ir.cc
M testdata/workloads/functional-query/queries/QueryTest/datasketches-cpc.test
M testdata/workloads/functional-query/queries/QueryTest/datasketches-hll.test
M testdata/workloads/functional-query/queries/QueryTest/datasketches-kll.test
M testdata/workloads/functional-query/queries/QueryTest/datasketches-theta.test
8 files changed, 259 insertions(+), 375 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/17818
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I306a2489dac0f4d2d475e8f9987cd58bf95474bb
Gerrit-Change-Number: 17818
Gerrit-PatchSet: 5
Gerrit-Owner: Alexander Saydakov <al...@apache.org>
Gerrit-Reviewer: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-10901 cleaner and faster operations with datasketches
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17818 )
Change subject: IMPALA-10901 cleaner and faster operations with datasketches
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/9413/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17818
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I306a2489dac0f4d2d475e8f9987cd58bf95474bb
Gerrit-Change-Number: 17818
Gerrit-PatchSet: 2
Gerrit-Owner: Alexander Saydakov <al...@apache.org>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 31 Aug 2021 23:53:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10901 cleaner and faster operations with datasketches
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17818 )
Change subject: IMPALA-10901 cleaner and faster operations with datasketches
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17818
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I306a2489dac0f4d2d475e8f9987cd58bf95474bb
Gerrit-Change-Number: 17818
Gerrit-PatchSet: 4
Gerrit-Owner: Alexander Saydakov <al...@apache.org>
Gerrit-Reviewer: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 Sep 2021 07:48:49 +0000
Gerrit-HasComments: No