You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/06/08 17:27:49 UTC

[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #5085: Root disk size should be listed in GB at listServiceOffering

GabrielBrascher commented on a change in pull request #5085:
URL: https://github.com/apache/cloudstack/pull/5085#discussion_r647648448



##########
File path: ui/src/components/view/DetailsTab.vue
##########
@@ -35,7 +35,7 @@
         </div>
         <div v-else-if="$route.meta.name === 'computeoffering' && item === 'rootdisksize'">
           <div>
-            {{ parseFloat( resource.rootdisksize / (1024.0 * 1024.0 * 1024.0)).toFixed(1) }} GB
+            {{ resource.rootdisksize }} GB

Review comment:
       @shwstppr thanks for pointing out the change necessary to keep UI aligned with API.
   I believe this will fix it, please let me know if I am missing anything.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org