[GitHub] [camel-quarkus] ppalaga commented on issue #3350: Update Release Guide

[GitBox <gi...@apache.org>]

ppalaga commented on issue #3350:
URL: https://github.com/apache/camel-quarkus/issues/3350#issuecomment-984774750


   > * When we generate the 2.6.x branch. Before pushing the branch, we need to update the antora version, but also scripts (as we push a snapshot version. See this commit as a reference : [d4357cf](https://github.com/apache/camel-quarkus/commit/d4357cf7ce9c451b66654e77b50f0b8a0d78f388)
   
   Could you please explain why the replacement from `version: 2.5.x` to `version: latest`?
   
   >   I wonder if we could automate this, using maven. Let me know
   
   There is `commit-release-changes` profile https://github.com/apache/camel-quarkus/blob/main/pom.xml#L972-L1026 that is active for both the release commit and the commit after: https://github.com/apache/camel-quarkus/blob/main/pom.xml#L331-L332
   You may want to make `tooling/scripts/update-antora-yaml.groovy` behave differently depending on `project.version.endsWith('-SNAPSHOT')` - if that's `true` it is the commit after, otherwise it is the release commit. Is that what you look for?
   
   > * When [we update the subversion repository](https://camel.apache.org/camel-quarkus/next/contributor-guide/release-guide.html#_update_the_apache_camel_quarkus_distribution_subversion_repository.), we delete the latest version, before announcing the new one in the camel website :   For some time, the [download page ](https://camel.apache.org/download/#camel-quarkus)doesn't work.
   >   I'd advise we keep the 2 latest versions. It could make the download page happy + Camel K is not updated yet + https://code.quarkus.io/ presents the 2 latest versions.
   >   Would love to have some feedback on this.
   
   Sound good to me.
   
   > * When we add the release on the website, we must add the new version on the website too. See commit here: [apache/camel-website@b458d78](https://github.com/apache/camel-website/commit/b458d786d725dacc24a7d1e7bb97434e7a1c3042)
   >   I'd advise also to just keep 2 latest versions, for same reason as precedent point.
   
   +1
   
   > * Review the paragraph of [updating camel-quarkus-examples ](https://camel.apache.org/camel-quarkus/next/contributor-guide/release-guide.html#_upgrade_and_tag_examples). The PR must have the next version, and not the next version of snapshot. Maybe do as for the release a push of the tag and release branch ? There is a direct push to main that must be reviewed.
   
   The current text in the guide was meant to first prepare a PR with a SNAPSHOT version, let the CI test it, then merge the PR and only after that update to the release-like version, tag and push directly without running the CI. 
   Yes, the release-like version can be used already in the PR. It is indeed perhaps a bit simpler. Feel free to update the guide.
   
   Note that the part with the direct push would still be required with some modifications: One would have to fetch&reset from upstream, tag the merged commit and then push the tag. The tag was often asked for @vkasala and his friends :)
   
   > * [ update the quarkus platform](https://camel.apache.org/camel-quarkus/next/contributor-guide/release-guide.html#_upgrade_camel_quarkus_in_quarkus_platform) : use their maven wrapper, as I had an issue with my new maven  version, getting more than 100+ files updated, due to style difference. Using the `./mvnw` instead made the PR better.
   
   Ha, you've got me :) I thought those changes were caused by a newer Quarkus BOM generator plugin version. We should propose upgrading their wrapper, FWIW! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org