You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Henry Robinson (Code Review)" <ge...@cloudera.org> on 2017/03/20 18:08:21 UTC

[Impala-ASF-CR] IMPALA-5057: Upgrade glog (0.3.4-p2) and gflags (2.2.0)

Henry Robinson has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/6436

Change subject: IMPALA-5057: Upgrade glog (0.3.4-p2) and gflags (2.2.0)
......................................................................

IMPALA-5057: Upgrade glog (0.3.4-p2) and gflags (2.2.0)

Change-Id: If5c8718c67f021e18b3b95178b077fc147d6fcee
---
M bin/impala-config.sh
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/36/6436/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6436
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If5c8718c67f021e18b3b95178b077fc147d6fcee
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>

[Impala-ASF-CR] IMPALA-5057: Upgrade glog (0.3.4-p2) and gflags (2.2.0)

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-5057: Upgrade glog (0.3.4-p2) and gflags (2.2.0)
......................................................................


IMPALA-5057: Upgrade glog (0.3.4-p2) and gflags (2.2.0)

Change-Id: If5c8718c67f021e18b3b95178b077fc147d6fcee
Reviewed-on: http://gerrit.cloudera.org:8080/6436
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M bin/impala-config.sh
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Tim Armstrong: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/6436
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If5c8718c67f021e18b3b95178b077fc147d6fcee
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-5057: Upgrade glog (0.3.4-p2) and gflags (2.2.0)

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-5057: Upgrade glog (0.3.4-p2) and gflags (2.2.0)
......................................................................


Patch Set 2:

Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/400/

-- 
To view, visit http://gerrit.cloudera.org:8080/6436
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If5c8718c67f021e18b3b95178b077fc147d6fcee
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5057: Upgrade glog (0.3.4-p2) and gflags (2.2.0)

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-5057: Upgrade glog (0.3.4-p2) and gflags (2.2.0)
......................................................................


Patch Set 2: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/6436
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If5c8718c67f021e18b3b95178b077fc147d6fcee
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5057: Upgrade glog (0.3.4-p2) and gflags (2.2.0)

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-5057: Upgrade glog (0.3.4-p2) and gflags (2.2.0)
......................................................................


Patch Set 1: Verified-1

Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/392/

-- 
To view, visit http://gerrit.cloudera.org:8080/6436
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If5c8718c67f021e18b3b95178b077fc147d6fcee
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5057: Upgrade glog (0.3.4-p2) and gflags (2.2.0)

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5057: Upgrade glog (0.3.4-p2) and gflags (2.2.0)
......................................................................


Patch Set 2: Code-Review+2

Seems reasonable so long as it doesn't conflict with other in-flight version bumps.

-- 
To view, visit http://gerrit.cloudera.org:8080/6436
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If5c8718c67f021e18b3b95178b077fc147d6fcee
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5057: Upgrade glog (0.3.4-p2) and gflags (2.2.0)

Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/6436

to look at the new patch set (#2).

Change subject: IMPALA-5057: Upgrade glog (0.3.4-p2) and gflags (2.2.0)
......................................................................

IMPALA-5057: Upgrade glog (0.3.4-p2) and gflags (2.2.0)

Change-Id: If5c8718c67f021e18b3b95178b077fc147d6fcee
---
M bin/impala-config.sh
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/36/6436/2
-- 
To view, visit http://gerrit.cloudera.org:8080/6436
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If5c8718c67f021e18b3b95178b077fc147d6fcee
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins

[Impala-ASF-CR] IMPALA-5057: Upgrade glog (0.3.4-p2) and gflags (2.2.0)

Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.

Change subject: IMPALA-5057: Upgrade glog (0.3.4-p2) and gflags (2.2.0)
......................................................................


Patch Set 1:

All the Kudu tests failed, not clear why one of the table servers failed to start. Unfortunately, looks hard to get on that machine to get at the tablet logs. 

As expected, one sub-build failed because Snappy 1.1.3 is no longer available in the toolchain. Will wait for that build to finish before retrying this.

-- 
To view, visit http://gerrit.cloudera.org:8080/6436
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If5c8718c67f021e18b3b95178b077fc147d6fcee
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5057: Upgrade glog (0.3.4-p2) and gflags (2.2.0)

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-5057: Upgrade glog (0.3.4-p2) and gflags (2.2.0)
......................................................................


Patch Set 1:

Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/392/

-- 
To view, visit http://gerrit.cloudera.org:8080/6436
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If5c8718c67f021e18b3b95178b077fc147d6fcee
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-HasComments: No