You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/06/26 03:02:26 UTC
[GitHub] eric-haibin-lin commented on a change in pull request #11389:
[MXNET-566] Fix flaky test_operator_gpu.test_sparse_dot
eric-haibin-lin commented on a change in pull request #11389: [MXNET-566] Fix flaky test_operator_gpu.test_sparse_dot
URL: https://github.com/apache/incubator-mxnet/pull/11389#discussion_r198000365
##########
File path: src/operator/tensor/dot-inl.cuh
##########
@@ -1053,7 +1053,7 @@ inline void DotDnsCsrDnsImpl(const OpContext& ctx, const gpu& gpu_dev,
TBlob csr_indices = rhs.aux_data(csr::kIdx);
TBlob csr_indptr = rhs.aux_data(csr::kIndPtr);
if (!rhs.storage_initialized()) {
- FillZerosCsrImpl(s, *ret);
Review comment:
Why is there segmentation fault instead of log fatal err msg? The CheckAndAllocData function used by FillZerosCsrImpl does check stype: https://github.com/apache/incubator-mxnet/blob/master/include/mxnet/ndarray.h#L621
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services