You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by prabhjyotsingh <gi...@git.apache.org> on 2018/03/21 12:01:24 UTC

[GitHub] zeppelin pull request #2885: [ZEPPELIN-3001] Disable ace editor code complet...

GitHub user prabhjyotsingh opened a pull request:

    https://github.com/apache/zeppelin/pull/2885

    [ZEPPELIN-3001] Disable ace editor code completion when backend interpreter support completion

    ### What is this PR for?
    This is what I see in zeppelin and jupyter. The difference is due to zeppelin also add code completion of ace editor. I think code completion of ace editor should only be enabled when the backend interpreter doesn't support completion.
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### What is the Jira issue?
    * [ZEPPELIN-3001](https://issues.apache.org/jira/browse/ZEPPELIN-3001)
    
    
    ### Questions:
    * Does the licenses files need update? N/A
    * Is there breaking changes for older versions? N/A
    * Does this needs documentation? N/A


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-3001

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2885.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2885
    
----
commit adaabcbf922eb2ab2476b4209e0e29b97fb4229d
Author: Prabhjyot Singh <pr...@...>
Date:   2018-03-20T10:48:44Z

    ZEPPELIN-3001: Disable ace editor code completion when back-end interpreter support completion
    
    Change-Id: I315ff17c6f50ad3ad912a38366833823e5241574

commit 34b7f61848bd991097f390d7068c22255f9b8606
Author: Prabhjyot Singh <pr...@...>
Date:   2018-03-21T11:59:31Z

    get completionSupport from interpreter (backend)
    
    Change-Id: Id03ba92143dfe4743e7c7b66c92ef4263df4d569

----


---

[GitHub] zeppelin issue #2885: [ZEPPELIN-3001] Disable ace editor code completion whe...

Posted by prabhjyotsingh <gi...@git.apache.org>.

Github user prabhjyotsingh commented on the issue:

    https://github.com/apache/zeppelin/pull/2885
  
    Sure I was able to repro your issue, have pushed another commit with the fix.


---

[GitHub] zeppelin issue #2885: [ZEPPELIN-3001] Disable ace editor code completion whe...

Posted by prabhjyotsingh <gi...@git.apache.org>.

Github user prabhjyotsingh commented on the issue:

    https://github.com/apache/zeppelin/pull/2885
  
    @zjffdu I was able to reproduce the issue that you mentioned, have made a fix for the same.


---

[GitHub] zeppelin issue #2885: [ZEPPELIN-3001] Disable ace editor code completion whe...

Posted by zjffdu <gi...@git.apache.org>.

Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2885
  
    ping @prabhjyotsingh 


---

[GitHub] zeppelin issue #2885: [ZEPPELIN-3001] Disable ace editor code completion whe...

Posted by zjffdu <gi...@git.apache.org>.

Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2885
  
    @prabhjyotsingh What I see is that the paragraphId sent from frontend is incorrect which cause the issue I mention in the last comment. When I type tab in the first paragraph, it would send the last pargraphId to backend. could you help check that ?


---

[GitHub] zeppelin issue #2885: [ZEPPELIN-3001] Disable ace editor code completion whe...

Posted by zjffdu <gi...@git.apache.org>.

Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2885
  
    @prabhjyotsingh I try the latest PR, but it doesn't work when I enable zeppelin.spark.useNew. I can confirm the completion api return the same thing no matter whether zeppelin.spark.useNew is true or false. Could you help check what's difference in frontend ? Thanks


---

[GitHub] zeppelin issue #2885: [ZEPPELIN-3001] Disable ace editor code completion whe...

Posted by prabhjyotsingh <gi...@git.apache.org>.

Github user prabhjyotsingh commented on the issue:

    https://github.com/apache/zeppelin/pull/2885
  
    I didn't know this, there is a difference is spark, let me try it out.


---

[GitHub] zeppelin issue #2885: [ZEPPELIN-3001] Disable ace editor code completion whe...

Posted by prabhjyotsingh <gi...@git.apache.org>.

Github user prabhjyotsingh commented on the issue:

    https://github.com/apache/zeppelin/pull/2885
  
    Thanks for the review will merge this if no more discussion.


---

[GitHub] zeppelin issue #2885: [ZEPPELIN-3001] Disable ace editor code completion whe...

Posted by zjffdu <gi...@git.apache.org>.

Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2885
  
    Thanks @prabhjyotsingh , but it still doesn't work for me. 


---