You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/23 05:50:43 UTC

[GitHub] [spark] HyukjinKwon opened a new pull request #34075: [MINOR][SQL][DOCS] Correct the 'options' description on UnresolvedRelation

HyukjinKwon opened a new pull request #34075:
URL: https://github.com/apache/spark/pull/34075


   ### What changes were proposed in this pull request?
   
   This PR fixes the 'options' description on `UnresolvedRelation`. This comment was added in https://github.com/apache/spark/pull/29535 but not valid anymore because V1 also uses this `options` (and merge the options with the table properties) per https://github.com/apache/spark/pull/29712. 
   
   ### Why are the changes needed?
   
   To make `UnresolvedRelation.options`'s description clearer.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No, dev-only.
   
   ### How was this patch tested?
   
   Scala linter by `dev/linter-scala`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] huaxingao commented on pull request #34075: [MINOR][SQL][DOCS] Correct the 'options' description on UnresolvedRelation

Posted by GitBox <gi...@apache.org>.
huaxingao commented on pull request #34075:
URL: https://github.com/apache/spark/pull/34075#issuecomment-925528106


   Thanks, merged to 3.1/3.2/master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #34075: [MINOR][SQL][DOCS] Correct the 'options' description on UnresolvedRelation

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34075:
URL: https://github.com/apache/spark/pull/34075#issuecomment-925524238


   Thanks @huaxingao.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] huaxingao closed pull request #34075: [MINOR][SQL][DOCS] Correct the 'options' description on UnresolvedRelation

Posted by GitBox <gi...@apache.org>.
huaxingao closed pull request #34075:
URL: https://github.com/apache/spark/pull/34075


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org