You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@camel.apache.org by "igarashitm (via GitHub)" <gi...@apache.org> on 2024/01/29 14:02:40 UTC

[I] Kamelet: Consider restricting the Kamelet route to only allow `from` or `route` [camel-k]

igarashitm opened a new issue, #5118:
URL: https://github.com/apache/camel-k/issues/5118

### Requirement

Restrict Kamelet to only allow either `route` or `from`, but not both.

### Problem

Today we're using Camel `RouteTemplateDefinition` for the Kamelet route definition, on `spec.template`.
https://github.com/apache/camel/blob/2e7578c9426bb327e0ca8c43b4a93063d70b946e/dsl/camel-yaml-dsl/camel-yaml-dsl/src/generated/resources/schema/camelYamlDsl.json#L4928-L4958

Since `RouteTemplateDefinition` allows both `route` and `from`, currently Kamelet could use both `spec.template.route` as well as `spec.template.from`. This is not an ideal situation.

### Proposal

2 options in mind:

1. Change from `spec.template` to a set of `spec.route` and `spec.beans`, where `spec.route` is a `RouteDefinition` and `spec.beans` is an array of `RouteTemplateBeanDefinition`
2. Introduce a Camel K custom type for `spec.template`, then let it have only `route` and `beans`

There would be other options. The point here is to restrict the Kamelet route to only allow one of `route` or `from`, but not both. At the same time keep the capability to define beans.

### Open questions

_No response_

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Kamelet: Consider restricting the Kamelet route to only allow `from` or `route` [camel-k]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on issue #5118:
URL: https://github.com/apache/camel-k/issues/5118#issuecomment-2081714827

   This issue has been automatically marked as stale due to 90 days of inactivity.
   It will be closed if no further activity occurs within 15 days.
   If you think that’s incorrect or the issue should never stale, please simply write any comment.
   Thanks for your contributions!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Kamelet: Consider restricting the Kamelet route to only allow `from` or `route` [camel-k]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] closed issue #5118: Kamelet: Consider restricting the Kamelet route to only allow `from` or `route`
URL: https://github.com/apache/camel-k/issues/5118


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org