You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/23 06:51:00 UTC
[GitHub] [beam] alexeyinkin opened a new pull request, #22013: [Playground] Fix analytics for snippet changing, cancelling, and link following (#22012)
alexeyinkin opened a new pull request, #22013:
URL: https://github.com/apache/beam/pull/22013
Fixes #22012
This is a rebased copy of #21926 that contains all the fixes but does not include Matomo and retains Google Analytics. It also contains `AbstractAnalyticsService` to later swap Matomo in much easier.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #22013: [Playground] Fix analytics for snippet changing, cancelling, and link following (#22012)
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #22013:
URL: https://github.com/apache/beam/pull/22013#issuecomment-1170472844
lgtm thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #22013: [Playground] Fix analytics for snippet changing, cancelling, and link following (#22012)
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #22013:
URL: https://github.com/apache/beam/pull/22013#issuecomment-1164021172
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #22013: [Playground] Fix analytics for snippet changing, cancelling, and link following (#22012)
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #22013:
URL: https://github.com/apache/beam/pull/22013#issuecomment-1164021170
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #22013: [Playground] Fix analytics for snippet changing, cancelling, and link following (#22012)
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #22013:
URL: https://github.com/apache/beam/pull/22013#issuecomment-1164021177
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #22013: [Playground] Fix analytics for snippet changing, cancelling, and link following (#22012)
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #22013:
URL: https://github.com/apache/beam/pull/22013#issuecomment-1164021178
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] alexeyinkin commented on pull request #22013: [Playground] Fix analytics for snippet changing, cancelling, and link following (#22012)
Posted by GitBox <gi...@apache.org>.
alexeyinkin commented on PR #22013:
URL: https://github.com/apache/beam/pull/22013#issuecomment-1164023430
R: @damondouglas
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #22013: [Playground] Fix analytics for snippet changing, cancelling, and link following (#22012)
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #22013:
URL: https://github.com/apache/beam/pull/22013#issuecomment-1164021176
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem merged pull request #22013: [Playground] Fix analytics for snippet changing, cancelling, and link following (#22012)
Posted by GitBox <gi...@apache.org>.
pabloem merged PR #22013:
URL: https://github.com/apache/beam/pull/22013
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org