You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@orc.apache.org by wi...@apache.org on 2021/08/07 05:38:08 UTC

[orc] branch main updated: ORC-915: Remove io.netty.netty from Spark benchmark (#822)

This is an automated email from the ASF dual-hosted git repository.

william pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/orc.git


The following commit(s) were added to refs/heads/main by this push:
     new 599b098  ORC-915: Remove io.netty.netty from Spark benchmark (#822)
599b098 is described below

commit 599b098034914874f9ace68c5f854a11f5ec6206
Author: Dongjoon Hyun <do...@apache.org>
AuthorDate: Fri Aug 6 22:38:03 2021 -0700

    ORC-915: Remove io.netty.netty from Spark benchmark (#822)
    
    ### What changes were proposed in this pull request?
    
    This PR aims to remove `io.netty:netty` dependency from Spark benchmark.
    
    ### Why are the changes needed?
    
    ```
    $ ls spark-2.4.8-bin-hadoop2.7/jars/netty-*
    spark-2.4.8-bin-hadoop2.7/jars/netty-3.9.9.Final.jar      spark-2.4.8-bin-hadoop2.7/jars/netty-all-4.1.47.Final.jar
    
    $ ls spark-3.1.2-bin-hadoop3.2/jars/netty-all-4.1.51.Final.jar
    spark-3.1.2-bin-hadoop3.2/jars/netty-all-4.1.51.Final.jar
    ```
    
    ### How was this patch tested?
    
    Manual.
    ```
    $ java -jar core/target/orc-benchmarks-core-*-uber.jar generate data -d sales -c none -f orc
    $ java -jar spark/target/orc-benchmarks-spark-1.8.0-SNAPSHOT.jar spark data
    ```
    
    This closes #794
---
 java/bench/pom.xml       | 6 ------
 java/bench/spark/pom.xml | 4 ----
 2 files changed, 10 deletions(-)

diff --git a/java/bench/pom.xml b/java/bench/pom.xml
index 0a54c4b..f9dbf59 100644
--- a/java/bench/pom.xml
+++ b/java/bench/pom.xml
@@ -95,12 +95,6 @@
         <scope>runtime</scope>
       </dependency>
       <dependency>
-        <groupId>io.netty</groupId>
-        <artifactId>netty</artifactId>
-        <version>3.9.9.Final</version>
-        <scope>runtime</scope>
-      </dependency>
-      <dependency>
         <groupId>org.apache.avro</groupId>
         <artifactId>avro</artifactId>
         <version>${avro.version}</version>
diff --git a/java/bench/spark/pom.xml b/java/bench/spark/pom.xml
index 40dfa69..72a8a1b 100644
--- a/java/bench/spark/pom.xml
+++ b/java/bench/spark/pom.xml
@@ -53,10 +53,6 @@
       <artifactId>netty-all</artifactId>
     </dependency>
     <dependency>
-      <groupId>io.netty</groupId>
-      <artifactId>netty</artifactId>
-    </dependency>
-    <dependency>
       <groupId>org.apache.commons</groupId>
       <artifactId>commons-lang3</artifactId>
     </dependency>