[GitHub] [incubator-doris] stalary commented on a diff in pull request #9151: Support hive with HA HDFS. Pass ha configuration through hive create table properties.

[GitBox <gi...@apache.org>]

stalary commented on code in PR #9151:
URL: https://github.com/apache/incubator-doris/pull/9151#discussion_r858804841


##########
docs/en/extending-doris/hive-of-doris.md:
##########
@@ -83,6 +103,10 @@ PROPERTIES (
     - `hive.metastore.uris`: Hive Metastore service address
     - `database`: the name of the database to which Hive is mounted
     - `table`: the name of the table to which Hive is mounted
+    - `dfs.nameservices`：the logical name for this new nameservice. See hdfs-site.xml
+    - `dfs.ha.namenodes.[nameservice ID]：unique identifiers for each NameNode in the nameservice. See hdfs-site.xml

Review Comment:
   dfs.ha.namenodes.[nameservice ID] need end with `



##########
docs/en/extending-doris/hive-of-doris.md:
##########
@@ -83,6 +103,10 @@ PROPERTIES (
     - `hive.metastore.uris`: Hive Metastore service address
     - `database`: the name of the database to which Hive is mounted
     - `table`: the name of the table to which Hive is mounted
+    - `dfs.nameservices`：the logical name for this new nameservice. See hdfs-site.xml
+    - `dfs.ha.namenodes.[nameservice ID]：unique identifiers for each NameNode in the nameservice. See hdfs-site.xml
+    - `dfs.namenode.rpc-address.[nameservice ID].[name node ID]`：the fully-qualified RPC address for each NameNode to listen on. See hdfs-site.xml
+    - `dfs.client.failover.proxy.provider.[nameservice ID] `：the Java class that HDFS clients use to contact the Active NameNode, usually it is org.apache.hadoop.hdfs.server.namenode.ha.ConfiguredFailoverProxyProvider

Review Comment:
   [nameservice ID] ` remove blank



##########
fe/fe-core/src/main/java/org/apache/doris/planner/BrokerScanNode.java:
##########
@@ -522,7 +529,12 @@ private void processFileGroup(
                     rangeDesc.setNumAsString(context.fileGroup.isNumAsString());
                     rangeDesc.setReadJsonByLine(context.fileGroup.isReadJsonByLine());
                 }
-                rangeDesc.setHdfsParams(tHdfsParams);
+                if (rangeDesc.hdfs_params != null && rangeDesc.hdfs_params.getFsName() == null) {

Review Comment:
   duplicate with 504



##########
docs/zh-CN/extending-doris/hive-of-doris.md:
##########
@@ -83,6 +103,10 @@ PROPERTIES (
     - `hive.metastore.uris`：Hive Metastore 服务地址
     - `database`：挂载 Hive 对应的数据库名
     - `table`：挂载 Hive 对应的表名
+    - `dfs.nameservices`：name service名称，与hdfs-site.xml保持一致
+    - `dfs.ha.namenodes.[nameservice ID]：namenode的id列表,与hdfs-site.xml保持一致

Review Comment:
   Same as above



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org