You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/08/13 12:02:39 UTC
[GitHub] [kafka] vamossagar12 opened a new pull request, #12512: KAFKA-14138: Wrapping all non-fatal exceptions in KafkaException and throwing all fata exceptions directly for producer.send()
vamossagar12 opened a new pull request, #12512:
URL: https://github.com/apache/kafka/pull/12512
Currently the producer.send() method has different mechanisms of throwing exceptions when EOS is enabled and when it is not. Furthermore, the exceptions returned in callbacks are also different at times which could lead to confusion. This PR aims to close the confusion by following one of the methodologies of [KIP-691](https://cwiki.apache.org/confluence/display/KAFKA/KIP-691%3A+Enhance+Transactional+Producer+Exception+Handling#KIP691:EnhanceTransactionalProducerExceptionHandling-UnifyWrappedKafkaException).
It wraps all non-fatal exceptions in`KafkaException` and throws fatal exceptions directly. It does the same for all styles of producer.send() variations(EOS/non-EOS/callback/future.get()).
To get the PR working, needed to make some test changes. There were places where `AuthorizationException` was wrapped in `KafkaException`. I removed those checks which made the tests working. This is what exactly the PR was aiming for. I didn't add more tests right now. If reviewers feel so, can add for sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] vamossagar12 commented on pull request #12512: KAFKA-14138: Wrapping all non-fatal exceptions in KafkaException and throwing all fata exceptions directly for producer.send()
Posted by GitBox <gi...@apache.org>.
vamossagar12 commented on PR #12512:
URL: https://github.com/apache/kafka/pull/12512#issuecomment-1217053167
Looks like there are some checkstyle failures. Would fix them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang commented on pull request #12512: KAFKA-14138: Wrapping all non-fatal exceptions in KafkaException and throwing all fata exceptions directly for producer.send()
Posted by GitBox <gi...@apache.org>.
guozhangwang commented on PR #12512:
URL: https://github.com/apache/kafka/pull/12512#issuecomment-1220094009
Hello @vamossagar12 thanks for the PR.
I took another pass on KIP-691 and updated some exception cases in the wiki, and I think we need to thoroughly go through them before we can continue on this specific change. Could we hold on that until KIP-691 is completely went through with a consensus?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] vamossagar12 commented on pull request #12512: KAFKA-14138: Wrapping all non-fatal exceptions in KafkaException and throwing all fata exceptions directly for producer.send()
Posted by GitBox <gi...@apache.org>.
vamossagar12 commented on PR #12512:
URL: https://github.com/apache/kafka/pull/12512#issuecomment-1214145903
@guozhangwang , I made some changes based on what I understood of the KIP and whatever we discussed. Plz review whenever you get the chance. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-14138: Wrapping all non-fatal exceptions in KafkaException and throwing all fata exceptions directly for producer.send() [kafka]
Posted by "vamossagar12 (via GitHub)" <gi...@apache.org>.
vamossagar12 closed pull request #12512: KAFKA-14138: Wrapping all non-fatal exceptions in KafkaException and throwing all fata exceptions directly for producer.send()
URL: https://github.com/apache/kafka/pull/12512
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] vamossagar12 commented on pull request #12512: KAFKA-14138: Wrapping all non-fatal exceptions in KafkaException and throwing all fata exceptions directly for producer.send()
Posted by GitBox <gi...@apache.org>.
vamossagar12 commented on PR #12512:
URL: https://github.com/apache/kafka/pull/12512#issuecomment-1232887757
@guozhangwang let me know when the KIP changes are done and this could be re-worked upon..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] vamossagar12 commented on pull request #12512: KAFKA-14138: Wrapping all non-fatal exceptions in KafkaException and throwing all fata exceptions directly for producer.send()
Posted by GitBox <gi...@apache.org>.
vamossagar12 commented on PR #12512:
URL: https://github.com/apache/kafka/pull/12512#issuecomment-1220313754
hello @guozhangwang Thanks for the note. I noticed that you had made some changes to the KIP. This PR, I kept the changes focussed on send method but the KIP covers all methods. Sure, I would wait until there's consensus on that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org