You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Pranav Lodha (Code Review)" <ge...@cloudera.org> on 2025/07/27 19:15:40 UTC

[Impala-ASF-CR] IMPALA-14005: Support for quoted reserved words column names

Pranav Lodha has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23066


Change subject: IMPALA-14005: Support for quoted reserved words column names
......................................................................

IMPALA-14005: Support for quoted reserved words column names

This change updates the way column names are
projected in the SQL query generated for JDBC
external tables. Instead of relying on optional
mapping or default behavior, all column names are now
explicitly quoted using appropriate quote characters.

Column names are now wrapped with quote characters
based on the JDBC driver being used:
1. Backticks (`) for Hive, Impala and MySQL
2. Double quotes (") for all other databases

This helps in the support for case-sensitive or
reserved column names.

Change-Id: I5da5bc7ea5df8f094b7e2877a0ebf35662f93805
---
M fe/src/main/java/org/apache/impala/extdatasource/jdbc/JdbcDataSource.java
M testdata/bin/create-ext-data-source-table.sql
M testdata/bin/load-ext-data-sources.sh
M testdata/bin/setup-mysql-env.sh
M testdata/workloads/functional-query/queries/QueryTest/hive-jdbc-mysql-tables.test
M testdata/workloads/functional-query/queries/QueryTest/hive-jdbc-postgres-tables.test
M tests/custom_cluster/test_ext_data_sources.py
7 files changed, 473 insertions(+), 8 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/66/23066/4
-- 
To view, visit http://gerrit.cloudera.org:8080/23066
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5da5bc7ea5df8f094b7e2877a0ebf35662f93805
Gerrit-Change-Number: 23066
Gerrit-PatchSet: 4
Gerrit-Owner: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>

[Impala-ASF-CR] IMPALA-14005: Support for quoted reserved words column names

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23066 )

Change subject: IMPALA-14005: Support for quoted reserved words column names
......................................................................


Patch Set 5:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/20045/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/23066
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5da5bc7ea5df8f094b7e2877a0ebf35662f93805
Gerrit-Change-Number: 23066
Gerrit-PatchSet: 5
Gerrit-Owner: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Aug 2025 19:51:57 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14005: Support for quoted reserved words column names

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23066 )

Change subject: IMPALA-14005: Support for quoted reserved words column names
......................................................................


Patch Set 4:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/19971/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/23066
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5da5bc7ea5df8f094b7e2877a0ebf35662f93805
Gerrit-Change-Number: 23066
Gerrit-PatchSet: 4
Gerrit-Owner: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Sun, 27 Jul 2025 19:42:59 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14005: Support for quoted reserved words column names

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/23066 )

Change subject: IMPALA-14005: Support for quoted reserved words column names
......................................................................


Patch Set 5: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/23066
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5da5bc7ea5df8f094b7e2877a0ebf35662f93805
Gerrit-Change-Number: 23066
Gerrit-PatchSet: 5
Gerrit-Owner: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Aug 2025 21:14:47 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14005: Support for quoted reserved words column names

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/23066 )

Change subject: IMPALA-14005: Support for quoted reserved words column names
......................................................................


Patch Set 6:

there are some jdbc related test failures.


-- 
To view, visit http://gerrit.cloudera.org:8080/23066
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5da5bc7ea5df8f094b7e2877a0ebf35662f93805
Gerrit-Change-Number: 23066
Gerrit-PatchSet: 6
Gerrit-Owner: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Aug 2025 04:47:47 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14005: Support for quoted reserved words column names

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23066 )

Change subject: IMPALA-14005: Support for quoted reserved words column names
......................................................................

IMPALA-14005: Support for quoted reserved words column names

This change updates the way column names are
projected in the SQL query generated for JDBC
external tables. Instead of relying on optional
mapping or default behavior, all column names are now
explicitly quoted using appropriate quote characters.

Column names are now wrapped with quote characters
based on the JDBC driver being used:
1. Backticks (`) for Hive, Impala and MySQL
2. Double quotes (") for all other databases

This helps in the support for case-sensitive or
reserved column names.

Change-Id: I5da5bc7ea5df8f094b7e2877a0ebf35662f93805
Reviewed-on: http://gerrit.cloudera.org:8080/23066
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/extdatasource/jdbc/JdbcDataSource.java
M testdata/bin/create-ext-data-source-table.sql
M testdata/bin/load-ext-data-sources.sh
M testdata/bin/setup-mysql-env.sh
M testdata/workloads/functional-query/queries/QueryTest/hive-jdbc-mysql-tables.test
M testdata/workloads/functional-query/queries/QueryTest/hive-jdbc-postgres-tables.test
M tests/custom_cluster/test_ext_data_sources.py
7 files changed, 473 insertions(+), 6 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Wenzhe Zhou: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/23066
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5da5bc7ea5df8f094b7e2877a0ebf35662f93805
Gerrit-Change-Number: 23066
Gerrit-PatchSet: 9
Gerrit-Owner: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>

[Impala-ASF-CR] IMPALA-14005: Support for quoted reserved words column names

Posted by "Pranav Lodha (Code Review)" <ge...@cloudera.org>.
Pranav Lodha has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/23066 )

Change subject: IMPALA-14005: Support for quoted reserved words column names
......................................................................

IMPALA-14005: Support for quoted reserved words column names

This change updates the way column names are
projected in the SQL query generated for JDBC
external tables. Instead of relying on optional
mapping or default behavior, all column names are now
explicitly quoted using appropriate quote characters.

Column names are now wrapped with quote characters
based on the JDBC driver being used:
1. Backticks (`) for Hive, Impala and MySQL
2. Double quotes (") for all other databases

This helps in the support for case-sensitive or
reserved column names.

Change-Id: I5da5bc7ea5df8f094b7e2877a0ebf35662f93805
---
M fe/src/main/java/org/apache/impala/extdatasource/jdbc/JdbcDataSource.java
M testdata/bin/create-ext-data-source-table.sql
M testdata/bin/load-ext-data-sources.sh
M testdata/bin/setup-mysql-env.sh
M testdata/workloads/functional-query/queries/QueryTest/hive-jdbc-mysql-tables.test
M testdata/workloads/functional-query/queries/QueryTest/hive-jdbc-postgres-tables.test
M tests/custom_cluster/test_ext_data_sources.py
7 files changed, 471 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/66/23066/5
-- 
To view, visit http://gerrit.cloudera.org:8080/23066
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5da5bc7ea5df8f094b7e2877a0ebf35662f93805
Gerrit-Change-Number: 23066
Gerrit-PatchSet: 5
Gerrit-Owner: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>

[Impala-ASF-CR] IMPALA-14005: Support for quoted reserved words column names

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23066 )

Change subject: IMPALA-14005: Support for quoted reserved words column names
......................................................................


Patch Set 6:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12268/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/23066
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5da5bc7ea5df8f094b7e2877a0ebf35662f93805
Gerrit-Change-Number: 23066
Gerrit-PatchSet: 6
Gerrit-Owner: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Aug 2025 21:15:54 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14005: Support for quoted reserved words column names

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/23066 )

Change subject: IMPALA-14005: Support for quoted reserved words column names
......................................................................


Patch Set 8: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/23066
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5da5bc7ea5df8f094b7e2877a0ebf35662f93805
Gerrit-Change-Number: 23066
Gerrit-PatchSet: 8
Gerrit-Owner: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Aug 2025 15:01:08 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14005: Support for quoted reserved words column names

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23066 )

Change subject: IMPALA-14005: Support for quoted reserved words column names
......................................................................


Patch Set 6: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/12268/


-- 
To view, visit http://gerrit.cloudera.org:8080/23066
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5da5bc7ea5df8f094b7e2877a0ebf35662f93805
Gerrit-Change-Number: 23066
Gerrit-PatchSet: 6
Gerrit-Owner: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Aug 2025 03:28:03 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14005: Support for quoted reserved words column names

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/23066 )

Change subject: IMPALA-14005: Support for quoted reserved words column names
......................................................................


Patch Set 4: Code-Review+1

Please fix the latest comments in test_ext_data_sources.py


-- 
To view, visit http://gerrit.cloudera.org:8080/23066
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5da5bc7ea5df8f094b7e2877a0ebf35662f93805
Gerrit-Change-Number: 23066
Gerrit-PatchSet: 4
Gerrit-Owner: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Sun, 27 Jul 2025 19:44:53 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14005: Support for quoted reserved words column names

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23066 )

Change subject: IMPALA-14005: Support for quoted reserved words column names
......................................................................


Patch Set 8:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12303/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/23066
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5da5bc7ea5df8f094b7e2877a0ebf35662f93805
Gerrit-Change-Number: 23066
Gerrit-PatchSet: 8
Gerrit-Owner: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Aug 2025 17:59:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14005: Support for quoted reserved words column names

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23066 )

Change subject: IMPALA-14005: Support for quoted reserved words column names
......................................................................


Patch Set 8: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/23066
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5da5bc7ea5df8f094b7e2877a0ebf35662f93805
Gerrit-Change-Number: 23066
Gerrit-PatchSet: 8
Gerrit-Owner: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Aug 2025 00:02:33 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14005: Support for quoted reserved words column names

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23066 )

Change subject: IMPALA-14005: Support for quoted reserved words column names
......................................................................


Patch Set 4:

(3 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/23066/4/tests/custom_cluster/test_ext_data_sources.py
File tests/custom_cluster/test_ext_data_sources.py:

http://gerrit.cloudera.org:8080/#/c/23066/4/tests/custom_cluster/test_ext_data_sources.py@316
PS4, Line 316: #
flake8: E265 block comment should start with '# '


http://gerrit.cloudera.org:8080/#/c/23066/4/tests/custom_cluster/test_ext_data_sources.py@362
PS4, Line 362:  
flake8: W293 blank line contains whitespace


http://gerrit.cloudera.org:8080/#/c/23066/4/tests/custom_cluster/test_ext_data_sources.py@362
PS4, Line 362:  
line has trailing whitespace



-- 
To view, visit http://gerrit.cloudera.org:8080/23066
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5da5bc7ea5df8f094b7e2877a0ebf35662f93805
Gerrit-Change-Number: 23066
Gerrit-PatchSet: 4
Gerrit-Owner: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Sun, 27 Jul 2025 19:17:33 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14005: Support for quoted reserved words column names

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23066 )

Change subject: IMPALA-14005: Support for quoted reserved words column names
......................................................................


Patch Set 7:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/20118/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/23066
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5da5bc7ea5df8f094b7e2877a0ebf35662f93805
Gerrit-Change-Number: 23066
Gerrit-PatchSet: 7
Gerrit-Owner: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Aug 2025 07:16:12 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14005: Support for quoted reserved words column names

Posted by "Pranav Lodha (Code Review)" <ge...@cloudera.org>.
Pranav Lodha has posted comments on this change. ( http://gerrit.cloudera.org:8080/23066 )

Change subject: IMPALA-14005: Support for quoted reserved words column names
......................................................................


Patch Set 5:

(2 comments)

> Uploaded patch set 5.

http://gerrit.cloudera.org:8080/#/c/23066/4/tests/custom_cluster/test_ext_data_sources.py
File tests/custom_cluster/test_ext_data_sources.py:

http://gerrit.cloudera.org:8080/#/c/23066/4/tests/custom_cluster/test_ext_data_sources.py@316
PS4, Line 316: i
> flake8: E265 block comment should start with '# '
Done


http://gerrit.cloudera.org:8080/#/c/23066/4/tests/custom_cluster/test_ext_data_sources.py@362
PS4, Line 362: 
> flake8: W293 blank line contains whitespace
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/23066
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5da5bc7ea5df8f094b7e2877a0ebf35662f93805
Gerrit-Change-Number: 23066
Gerrit-PatchSet: 5
Gerrit-Owner: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Aug 2025 19:24:50 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14005: Support for quoted reserved words column names

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23066 )

Change subject: IMPALA-14005: Support for quoted reserved words column names
......................................................................


Patch Set 6: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/23066
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5da5bc7ea5df8f094b7e2877a0ebf35662f93805
Gerrit-Change-Number: 23066
Gerrit-PatchSet: 6
Gerrit-Owner: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Aug 2025 21:15:53 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14005: Support for quoted reserved words column names

Posted by "Pranav Lodha (Code Review)" <ge...@cloudera.org>.
Pranav Lodha has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/23066 )

Change subject: IMPALA-14005: Support for quoted reserved words column names
......................................................................

IMPALA-14005: Support for quoted reserved words column names

This change updates the way column names are
projected in the SQL query generated for JDBC
external tables. Instead of relying on optional
mapping or default behavior, all column names are now
explicitly quoted using appropriate quote characters.

Column names are now wrapped with quote characters
based on the JDBC driver being used:
1. Backticks (`) for Hive, Impala and MySQL
2. Double quotes (") for all other databases

This helps in the support for case-sensitive or
reserved column names.

Change-Id: I5da5bc7ea5df8f094b7e2877a0ebf35662f93805
---
M fe/src/main/java/org/apache/impala/extdatasource/jdbc/JdbcDataSource.java
M testdata/bin/create-ext-data-source-table.sql
M testdata/bin/load-ext-data-sources.sh
M testdata/bin/setup-mysql-env.sh
M testdata/workloads/functional-query/queries/QueryTest/hive-jdbc-mysql-tables.test
M testdata/workloads/functional-query/queries/QueryTest/hive-jdbc-postgres-tables.test
M tests/custom_cluster/test_ext_data_sources.py
7 files changed, 473 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/66/23066/7
-- 
To view, visit http://gerrit.cloudera.org:8080/23066
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5da5bc7ea5df8f094b7e2877a0ebf35662f93805
Gerrit-Change-Number: 23066
Gerrit-PatchSet: 7
Gerrit-Owner: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>