You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by pvillard31 <gi...@git.apache.org> on 2016/11/17 23:02:02 UTC

[GitHub] nifi pull request #1243: NIFI-3016 - Allow template overriding

GitHub user pvillard31 opened a pull request:

    https://github.com/apache/nifi/pull/1243

    NIFI-3016 - Allow template overriding

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pvillard31/nifi NIFI-3016

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1243.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1243
    
----
commit e34612a035b50e765eb205171b0c07f23ee34866
Author: Pierre Villard <pi...@gmail.com>
Date:   2016-11-17T22:47:52Z

    NIFI-3016 - Allow template overriding

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1243: NIFI-3016 - Allow template overriding

Posted by pvillard31 <gi...@git.apache.org>.

Github user pvillard31 commented on the issue:

    https://github.com/apache/nifi/pull/1243
  
    Yes @joewitt , I definitely agree. Closing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1243: NIFI-3016 - Allow template overriding

Posted by pvillard31 <gi...@git.apache.org>.

Github user pvillard31 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1243#discussion_r88567738
  
    --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-actions.js ---
    @@ -1271,7 +1272,43 @@ nf.Actions = (function () {
                                     // clear the template dialog fields
                                     $('#new-template-name').val('');
                                     $('#new-template-description').val('');
    -                            }).fail(nf.Common.handleAjaxError);
    +                            }).fail(function () {
    --- End diff --
    
    Here, I'm saying that I should propose users to override an existing template in case of failure during the first `createTemplate` attempt. However the failure could be caused by something else than "template already exists". I'd like some "UI guru" advice regarding the best way to only catch the wanted error and to execute `nf.Common.handleAjaxError` otherwise.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1243: NIFI-3016 - Allow template overriding

Posted by pvillard31 <gi...@git.apache.org>.

Github user pvillard31 closed the pull request at:

    https://github.com/apache/nifi/pull/1243


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1243: NIFI-3016 - Allow template overriding

Posted by joewitt <gi...@git.apache.org>.

Github user joewitt commented on the issue:

    https://github.com/apache/nifi/pull/1243
  
    @pvillard31 looks like this will need to be rebased.  Given the flow versioning/registry work this might be considered as a not necessary step.  Do you agree?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---