Re: [PR] GH-49078: [FS][Azure] Fix lossy pickling of `SubTreeFileSystem(base_path, AzureFileSystem(...))` [arrow]

["raulcd (via GitHub)" <gi...@apache.org>]

raulcd commented on code in PR #49140:
URL: https://github.com/apache/arrow/pull/49140#discussion_r2871306424


##########
cpp/src/arrow/filesystem/azurefs.cc:
##########
@@ -247,13 +247,17 @@ Result<AzureOptions> AzureOptions::FromUri(const std::string& uri_string,
 }
 
 bool AzureOptions::Equals(const AzureOptions& other) const {
-  const bool equals = blob_storage_authority == other.blob_storage_authority &&
-                      dfs_storage_authority == other.dfs_storage_authority &&
-                      blob_storage_scheme == other.blob_storage_scheme &&
-                      dfs_storage_scheme == other.dfs_storage_scheme &&
-                      default_metadata == other.default_metadata &&
-                      account_name == other.account_name &&
-                      credential_kind_ == other.credential_kind_;
+  const bool equals =
+      account_name == other.account_name &&
+      blob_storage_authority == other.blob_storage_authority &&
+      dfs_storage_authority == other.dfs_storage_authority &&
+      blob_storage_scheme == other.blob_storage_scheme &&
+      dfs_storage_scheme == other.dfs_storage_scheme &&
+      default_metadata == other.default_metadata &&
+      background_writes == other.background_writes &&
+      credential_kind_ == other.credential_kind_ && account_key_ == other.account_key_ &&

Review Comment:
   oops, it seems the linter really dislikes this:
   ```
   pre-commit hook(s) made changes.
   If you are seeing this message in CI, reproduce locally with: `pre-commit run --all-files`.
   To run `pre-commit` as part of git workflow, use `pre-commit install`.
   All changes made by hooks:
   diff --git a/cpp/src/arrow/filesystem/azurefs.cc b/cpp/src/arrow/filesystem/azurefs.cc
   index 5820316f20..20b0a655d8 100644
   --- a/cpp/src/arrow/filesystem/azurefs.cc
   +++ b/cpp/src/arrow/filesystem/azurefs.cc
   @@ -256,12 +256,9 @@ bool AzureOptions::Equals(const AzureOptions& other) const {
          dfs_storage_scheme == other.dfs_storage_scheme &&
          default_metadata == other.default_metadata &&
          background_writes == other.background_writes &&
   -      credential_kind_ == other.credential_kind_ &&
   -      account_key_ == other.account_key_ &&
   -      sas_token_ == other.sas_token_ &&
   -      tenant_id_ == other.tenant_id_ &&
   -      client_id_ == other.client_id_ &&
   -      client_secret_ == other.client_secret_;
   +      credential_kind_ == other.credential_kind_ && account_key_ == other.account_key_ &&
   +      sas_token_ == other.sas_token_ && tenant_id_ == other.tenant_id_ &&
   +      client_id_ == other.client_id_ && client_secret_ == other.client_secret_;
      if (!equals) {
   ```
   I am sorry about that :( btw, the rest of CI failures are unrelated. There's a known issue with the aws-sdk on homebrew that should be solved during the next days when a new version is available there.
   I am happy to merge once the linter is fixed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org