[jira] [Commented] (HBASE-9157) ZKUtil.blockUntilAvailable loops forever with KeeperException.ConnectionLossException

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-9157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14161251#comment-14161251 ] 

Hadoop QA commented on HBASE-9157:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12673246/hbase-9157-v2.patch
  against trunk revision .
  ATTACHMENT ID: 12673246

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11230//console

This message is automatically generated.

> ZKUtil.blockUntilAvailable loops forever with KeeperException.ConnectionLossException
> -------------------------------------------------------------------------------------
>
>                 Key: HBASE-9157
>                 URL: https://issues.apache.org/jira/browse/HBASE-9157
>             Project: HBase
>          Issue Type: Bug
>          Components: Zookeeper
>            Reporter: Jeffrey Zhong
>            Assignee: Jeffrey Zhong
>            Priority: Minor
>         Attachments: hbase-9157-v2.patch, hbase-9157.patch
>
>
> In one of integration test, I observed that a thread keeps spinning error logs "Unexpected exception handling blockUntilAvailable" due to KeeperException.ConnectionLossException. Below is the related code:
> {code}    
>     while (!finished) {
>       try {
>         data = ZKUtil.getData(zkw, znode);
>       } catch(KeeperException e) {
>         LOG.warn("Unexpected exception handling blockUntilAvailable", e);
>       }
>       if (data == null && (System.currentTimeMillis() +
>         HConstants.SOCKET_RETRY_WAIT_MS < endTime)) {
>         Thread.sleep(HConstants.SOCKET_RETRY_WAIT_MS);
>       } else {
>         finished = true;
>       }
>     }
> {code}
> Since ConnectionLossException & SessionExpiredException are not recoverable errors, the while loop can't break.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)