You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by hb...@apache.org on 2015/08/09 17:08:32 UTC
[2/2] maven git commit: improved comments
improved comments
Project: http://git-wip-us.apache.org/repos/asf/maven/repo
Commit: http://git-wip-us.apache.org/repos/asf/maven/commit/28d284b8
Tree: http://git-wip-us.apache.org/repos/asf/maven/tree/28d284b8
Diff: http://git-wip-us.apache.org/repos/asf/maven/diff/28d284b8
Branch: refs/heads/master
Commit: 28d284b8c0067a090f5429d3580b58a9cd15bb05
Parents: 33de197
Author: Hervé Boutemy <hb...@apache.org>
Authored: Sun Aug 9 16:53:00 2015 +0200
Committer: Hervé Boutemy <hb...@apache.org>
Committed: Sun Aug 9 16:53:00 2015 +0200
----------------------------------------------------------------------
.../maven/model/inheritance/DefaultInheritanceAssembler.java | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/maven/blob/28d284b8/maven-model-builder/src/main/java/org/apache/maven/model/inheritance/DefaultInheritanceAssembler.java
----------------------------------------------------------------------
diff --git a/maven-model-builder/src/main/java/org/apache/maven/model/inheritance/DefaultInheritanceAssembler.java b/maven-model-builder/src/main/java/org/apache/maven/model/inheritance/DefaultInheritanceAssembler.java
index dcefe54..8eaa522 100644
--- a/maven-model-builder/src/main/java/org/apache/maven/model/inheritance/DefaultInheritanceAssembler.java
+++ b/maven-model-builder/src/main/java/org/apache/maven/model/inheritance/DefaultInheritanceAssembler.java
@@ -84,10 +84,10 @@ public class DefaultInheritanceAssembler
String childName = child.getArtifactId();
/*
- * This logic exists only for the sake of backward-compat with 2.x (MNG-5000). In generally, it is wrong to
- * base URL inheritance on the project directory names as this information is unavailable for POMs in the
- * repository. In other words, projects where artifactId != projectDirName will see different effective URLs
- * depending on how the POM was constructed.
+ * This logic (using filesystem) exists only for the sake of backward-compat with 2.x (MNG-5000). In general, it is wrong to
+ * base URL inheritance on the module directory names as this information is unavailable for POMs in the
+ * repository. In other words, modules where artifactId != moduleDirName will see different effective URLs
+ * depending on how the model was constructed (from filesystem or from repository).
*/
File childDirectory = child.getProjectDirectory();
if ( childDirectory != null )