You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by purplecabbage <gi...@git.apache.org> on 2017/06/20 05:27:12 UTC
[GitHub] cordova-cli pull request #283: CB-12901 Cli Refactor
GitHub user purplecabbage opened a pull request:
https://github.com/apache/cordova-cli/pull/283
CB-12901 Cli Refactor
### What does this PR do?
- fixed failing tests.
- adjusted tests to call cordova instead of cordova.raw
- added tests to compare cordova.raw and cordova
- changed some console.log to logger.log
- help module returns help text and does not print it
-- this is to make testing easier and not have it spit all over jasmine output.
- various minor refactors, removed some un-needed promises etc.
- added timeoutInSecs property to make user prompts testable without waiting for 30 seconds
- this includes @stevengill 's previous pr
### Platforms affected
tooling
### What testing has been done on this change?
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [x] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/purplecabbage/cordova-cli RefactorWithCB-12901
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-cli/pull/283.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #283
----
commit a4c71847702793fc24cdfe393f954e4b2f1fc863
Author: Steve Gill <st...@gmail.com>
Date: 2017-06-16T21:37:07Z
CB-12901: removed .raw from cordova-lib calls
commit a24ec7968f4b271d9c3487980d29b3766b690053
Author: Jesse MacFadyen <pu...@gmail.com>
Date: 2017-06-20T05:17:56Z
fixed lines that were too long, test was failing
commit a26a73a420f71c972094513580921070a9026a47
Author: Jesse MacFadyen <pu...@gmail.com>
Date: 2017-06-20T05:19:06Z
added timeoutInSecs property to make user prompts testable without waiting for 30 seconds
commit 310d6b0a1c33d2289b8909fc61d13b46c7ca5950
Author: Jesse MacFadyen <pu...@gmail.com>
Date: 2017-06-20T05:22:13Z
adjusted tests to call cordova instead of cordova.raw, added tests to compare cordova.raw and cordova, changed some console.log to logger.log; help module returns help text and does not print it, this is to make testing easier and not have it spit all over jasmine output. various minor refactors, removed some un-needed promises
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-cli issue #283: CB-12901 Cli Refactor
Posted by alsorokin <gi...@git.apache.org>.
Github user alsorokin commented on the issue:
https://github.com/apache/cordova-cli/pull/283
@purplecabbage great, thanks for the clarification
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-cli pull request #283: CB-12901 Cli Refactor
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-cli/pull/283
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-cli issue #283: CB-12901 Cli Refactor
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-cli/pull/283
That is correct!
The cordova-lib changes are already on master, so together they are broken without these changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-cli issue #283: CB-12901 Cli Refactor
Posted by alsorokin <gi...@git.apache.org>.
Github user alsorokin commented on the issue:
https://github.com/apache/cordova-cli/pull/283
Without these changes `cordova create foo` would give us `Error: cordova.raw.create is not a function`, right?
Or is it my local linking issue?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org