You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/10/25 07:00:10 UTC
[GitHub] [flink] zhuzhurk commented on a change in pull request #9955:
[FLINK-14465][runtime] Let `StandaloneJobClusterEntrypoint` use user code
class loader
zhuzhurk commented on a change in pull request #9955: [FLINK-14465][runtime] Let `StandaloneJobClusterEntrypoint` use user code class loader
URL: https://github.com/apache/flink/pull/9955#discussion_r338910226
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/component/AbstractUserClassPathJobGraphRetriever.java
##########
@@ -51,7 +51,7 @@ protected AbstractUserClassPathJobGraphRetriever(@Nullable final File jobDir) th
}
}
- protected List<URL> getUserClassPaths() {
+ public List<URL> getUserClassPaths() {
Review comment:
If you are making it public for testing, please annotate it with @VisibleForTesting.
However, I think it's not good to test what you is not changed in this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services