[GitHub] [accumulo] EdColeman commented on a diff in pull request #3276: Optimize internal data structures in Authorizations

["EdColeman (via GitHub)" <gi...@apache.org>]

EdColeman commented on code in PR #3276:
URL: https://github.com/apache/accumulo/pull/3276#discussion_r1157607792


##########
core/src/main/java/org/apache/accumulo/core/security/Authorizations.java:
##########
@@ -45,6 +46,9 @@ public class Authorizations implements Iterable<byte[]>, Serializable, Authoriza
   private final Set<ByteSequence> auths;
   private final List<byte[]> authsList; // sorted order
 
+  private static final Pair<Set<ByteSequence>,List<byte[]>> EMPTY_INTERNAL_COLLECTIONS =

Review Comment:
   Because this is private it seems internal is implied - do you think that EMPTY_AUTHS would still provide the same clarity, but improve readability? (just a personnel preference / suggestion) 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org