[jira] [Commented] (RYA-362) Improve no-arg error message for shell command create-pcj

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/RYA-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157190#comment-16157190 ] 

ASF GitHub Bot commented on RYA-362:
------------------------------------

GitHub user jdasch opened a pull request:

    https://github.com/apache/incubator-rya/pull/223

    RYA-362 Improved UX for case where create-pcj is called without args.

    <!--
    Licensed to the Apache Software Foundation (ASF) under one
    or more contributor license agreements.  See the NOTICE file
    distributed with this work for additional information
    regarding copyright ownership.  The ASF licenses this file
    to you under the Apache License, Version 2.0 (the
    "License"); you may not use this file except in compliance
    with the License.  You may obtain a copy of the License at
    
      http://www.apache.org/licenses/LICENSE-2.0
    
    Unless required by applicable law or agreed to in writing,
    software distributed under the License is distributed on an
    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    KIND, either express or implied.  See the License for the
    specific language governing permissions and limitations
    under the License.
    -->
    ## Description
    Improved UX for case where create-pcj is called without args.
    Also updated the order of operations so we fail for insufficient arguments before we prompt for the SPARQL query.
    
    ### Tests
    Added a test case to `RyaAdminCommandsTest`
    
    ### Links
    [Jira RYA-362](https://issues.apache.org/jira/browse/RYA-362)
    
    ### Checklist
    - [ ] Code Review
    - [X] Squash Commits
    
    #### People To Review
    @DLotts
    @meiercaleb 
    @amihalik 
    @pujav65 


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jdasch/incubator-rya RYA-362

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-rya/pull/223.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #223
    
----
commit 0d00743a7ecb8e3d87ebc008b74d2b416231c438
Author: jdasch <hc...@gmail.com>
Date:   2017-09-07T14:14:18Z

    RYA-362 Improved UX for case where create-pcj is called without args.

----


> Improve no-arg error message for shell command create-pcj 
> ----------------------------------------------------------
>
>                 Key: RYA-362
>                 URL: https://issues.apache.org/jira/browse/RYA-362
>             Project: Rya
>          Issue Type: Sub-task
>          Components: clients
>            Reporter: Jeff Dasch
>            Assignee: Jeff Dasch
>
> Currently the shell just reports the error:
> {{Nulls cannot be presented to primitive type boolean for option 'exportToRya'}} which is a little cryptic for the end user.
> Add default boolean values for the spring-shell command.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)