You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@pulsar.apache.org by Asaf Mesika <as...@gmail.com> on 2022/09/01 13:00:58 UTC

[DISCUSS] General question regarding PIP comments

Hi,

I'm fairly new to this project and I have seen 2 options to comment to a
PIP:
1. In the GitHub issue.
2. In the mailing list.

I was wondering what is the best practice.

I know there is an ongoing initiative at the moment to switch a PIP to
become a file and actually a PR for submitting it. I guess the question
also applies to this new scheme :)

Thanks,

Asaf

Re: [DISCUSS] General question regarding PIP comments

Posted by tison <wa...@gmail.com>.

Hi Asaf,

Currently, the dev docs about PIP are located at:
https://github.com/apache/pulsar/tree/master/wiki/proposals

I'm writing the contribute guide at: https://pulsar.apache.org/contributing
... but the PIP process update should go through more discussion so I don't
cover it yet.

Best,
tison.


Asaf Mesika <as...@gmail.com> 于2022年11月8日周二 22:01写道：

> Thanks, Enrico (sorry for replying late - I'm hugely backlogged on this
> mailing list).
>
> I wanted to contribute what you wrote in the Contributors guide, but I
> couldn't find any reference to the process of PIP.  Do you know where it is
> documented in the Pulsar website?
>
>
>
>
> On Thu, Sep 1, 2022 at 5:07 PM Enrico Olivelli <eo...@gmail.com>
> wrote:
>
> > Asaf,
> > good question!
> >
> > Il giorno gio 1 set 2022 alle ore 15:01 Asaf Mesika
> > <as...@gmail.com> ha scritto:
> > >
> > > Hi,
> > >
> > > I'm fairly new to this project and I have seen 2 options to comment to
> a
> > > PIP:
> > > 1. In the GitHub issue.
> > > 2. In the mailing list.
> > >
> > > I was wondering what is the best practice.
> >
> >
> > In Apache projects we generally prefer discussions on the mailing
> > list, because it is easier to let the community
> > participate in the discussions.
> >
> > Unfortunately in order to follow a discussion on GH you must actively
> > follow the notifications (hundreds of messages per day)
> > or use any other means to stay up to date.
> >
> > So we generally keep "discussions" here.
> >
> > When you go down to implementation details it is better to work on the
> > PR, as it is more productive.
> > But for high level discussion it is better that they happen here
> >
> > Discussing on the GH issue of the PIP is misleading, and I agree with
> > you that we should keep the discussions only in one place
> >
> > Enrico
> >
> > >
> > > I know there is an ongoing initiative at the moment to switch a PIP to
> > > become a file and actually a PR for submitting it. I guess the question
> > > also applies to this new scheme :)
> > >
> > > Thanks,
> > >
> > > Asaf
> >
>

Re: [DISCUSS] General question regarding PIP comments

Posted by Asaf Mesika <as...@gmail.com>.

Thanks, Enrico (sorry for replying late - I'm hugely backlogged on this
mailing list).

I wanted to contribute what you wrote in the Contributors guide, but I
couldn't find any reference to the process of PIP.  Do you know where it is
documented in the Pulsar website?




On Thu, Sep 1, 2022 at 5:07 PM Enrico Olivelli <eo...@gmail.com> wrote:

> Asaf,
> good question!
>
> Il giorno gio 1 set 2022 alle ore 15:01 Asaf Mesika
> <as...@gmail.com> ha scritto:
> >
> > Hi,
> >
> > I'm fairly new to this project and I have seen 2 options to comment to a
> > PIP:
> > 1. In the GitHub issue.
> > 2. In the mailing list.
> >
> > I was wondering what is the best practice.
>
>
> In Apache projects we generally prefer discussions on the mailing
> list, because it is easier to let the community
> participate in the discussions.
>
> Unfortunately in order to follow a discussion on GH you must actively
> follow the notifications (hundreds of messages per day)
> or use any other means to stay up to date.
>
> So we generally keep "discussions" here.
>
> When you go down to implementation details it is better to work on the
> PR, as it is more productive.
> But for high level discussion it is better that they happen here
>
> Discussing on the GH issue of the PIP is misleading, and I agree with
> you that we should keep the discussions only in one place
>
> Enrico
>
> >
> > I know there is an ongoing initiative at the moment to switch a PIP to
> > become a file and actually a PR for submitting it. I guess the question
> > also applies to this new scheme :)
> >
> > Thanks,
> >
> > Asaf
>

Re: [DISCUSS] General question regarding PIP comments

Posted by Asaf Mesika <as...@gmail.com>.

 I submitted a PR for this here: https://github.com/apache/pulsar/pull/18974


On 1 Sep 2022 at 17:07:29, Enrico Olivelli <eo...@gmail.com> wrote:

> Asaf,
> good question!
>
> Il giorno gio 1 set 2022 alle ore 15:01 Asaf Mesika
> <as...@gmail.com> ha scritto:
>
>
> Hi,
>
>
> I'm fairly new to this project and I have seen 2 options to comment to a
>
> PIP:
>
> 1. In the GitHub issue.
>
> 2. In the mailing list.
>
>
> I was wondering what is the best practice.
>
>
>
> In Apache projects we generally prefer discussions on the mailing
> list, because it is easier to let the community
> participate in the discussions.
>
> Unfortunately in order to follow a discussion on GH you must actively
> follow the notifications (hundreds of messages per day)
> or use any other means to stay up to date.
>
> So we generally keep "discussions" here.
>
> When you go down to implementation details it is better to work on the
> PR, as it is more productive.
> But for high level discussion it is better that they happen here
>
> Discussing on the GH issue of the PIP is misleading, and I agree with
> you that we should keep the discussions only in one place
>
> Enrico
>
>
> I know there is an ongoing initiative at the moment to switch a PIP to
>
> become a file and actually a PR for submitting it. I guess the question
>
> also applies to this new scheme :)
>
>
> Thanks,
>
>
> Asaf
>
>

Re: [DISCUSS] General question regarding PIP comments

Posted by Enrico Olivelli <eo...@gmail.com>.

Asaf,
good question!

Il giorno gio 1 set 2022 alle ore 15:01 Asaf Mesika
<as...@gmail.com> ha scritto:
>
> Hi,
>
> I'm fairly new to this project and I have seen 2 options to comment to a
> PIP:
> 1. In the GitHub issue.
> 2. In the mailing list.
>
> I was wondering what is the best practice.


In Apache projects we generally prefer discussions on the mailing
list, because it is easier to let the community
participate in the discussions.

Unfortunately in order to follow a discussion on GH you must actively
follow the notifications (hundreds of messages per day)
or use any other means to stay up to date.

So we generally keep "discussions" here.

When you go down to implementation details it is better to work on the
PR, as it is more productive.
But for high level discussion it is better that they happen here

Discussing on the GH issue of the PIP is misleading, and I agree with
you that we should keep the discussions only in one place

Enrico

>
> I know there is an ongoing initiative at the moment to switch a PIP to
> become a file and actually a PR for submitting it. I guess the question
> also applies to this new scheme :)
>
> Thanks,
>
> Asaf