You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/12 12:21:55 UTC
[GitHub] [airflow] loustler opened a new pull request #14743: Add workers extraVolumes to Kubernetes pod template for Helm Chart
loustler opened a new pull request #14743:
URL: https://github.com/apache/airflow/pull/14743
As far as I know, the pod_template is a worker template for creating workers by Kubernetes Executor.
We already have the extraVolumes value for workers, I think it can apply to the pod_template.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman commented on pull request #14743: Add workers extraVolumes to Kubernetes pod template for Helm Chart
Posted by GitBox <gi...@apache.org>.
dimberman commented on pull request #14743:
URL: https://github.com/apache/airflow/pull/14743#issuecomment-809748205
@loustler can you please fix tests? I can merge once they pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14743: Add workers extraVolumes to Kubernetes pod template for Helm Chart
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14743:
URL: https://github.com/apache/airflow/pull/14743#issuecomment-805901075
[The Workflow run](https://github.com/apache/airflow/actions/runs/683475867) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] loustler commented on pull request #14743: Add workers extraVolumes to Kubernetes pod template for Helm Chart
Posted by GitBox <gi...@apache.org>.
loustler commented on pull request #14743:
URL: https://github.com/apache/airflow/pull/14743#issuecomment-810941744
@dimberman Fixed. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14743: Add workers extraVolumes to Kubernetes pod template for Helm Chart
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14743:
URL: https://github.com/apache/airflow/pull/14743#issuecomment-806510840
[The Workflow run](https://github.com/apache/airflow/actions/runs/686029372) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #14743: Add workers extraVolumes to Kubernetes pod template for Helm Chart
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #14743:
URL: https://github.com/apache/airflow/pull/14743
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14743: Add workers extraVolumes to Kubernetes pod template for Helm Chart
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14743:
URL: https://github.com/apache/airflow/pull/14743#issuecomment-809786488
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] loustler commented on pull request #14743: Add workers extraVolumes to Kubernetes pod template for Helm Chart
Posted by GitBox <gi...@apache.org>.
loustler commented on pull request #14743:
URL: https://github.com/apache/airflow/pull/14743#issuecomment-805877832
@ianstanton I added test code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org