Re: [PR] Allow separate object and pod labels for chart components [airflow]

["vyncint (via GitHub)" <gi...@apache.org>]

vyncint commented on PR #70205:
URL: https://github.com/apache/airflow/pull/70205#issuecomment-5083935856

   @Miretpl extended the pattern to the remaining components in 177dc55: apiServer, scheduler, workers.celery, triggerer, flower, statsd, pgbouncer, redis and otelCollector. Title and description updated to match the wider scope.
   
   otelCollector turned out to be the one exception. Its Deployment already merged component labels onto the object, so there is no backward-compatibility branch to preserve there — only its pod side gains the knob, and its object labels are unchanged. Every other component follows the dagProcessor shape exactly.
   
   Verification:
   
   - helm template with every component's labels set and podLabels unset is byte-identical to main across 3638 lines, with the random secrets pinned so the render is deterministic. That is the backward-compatibility proof.
   - New parametrized module helm_tests/airflow_aux/test_pod_labels.py covers all three states (unset, set, {}) for every component: 38 passed together with the existing dagProcessor module. I put the new cases in one parametrized module rather than nine near-identical files, following test_annotations.py; happy to split them per component if you prefer that layout.
   - Component suites for statsd, otel_collector, redis, api_server, scheduler, triggerer, worker, flower and pgbouncer: 779 passed, 1 failed.
   - Chart quality, basic chart and annotations modules: 114 passed, 9 failed.
   
   The 10 failures are pre-existing and unrelated. They assert on Helm's JSON-schema error wording, and local Helm 3.14.4 phrases it differently from what the tests expect; they cover dags.persistence.accessMode, pullPolicy and apiServer.securityContext. Running the same modules on a clean checkout of the base gives exactly the same counts, so nothing here is new. CI runs a pinned Helm, so I expect them green there.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org