You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "dubin555 (via GitHub)" <gi...@apache.org> on 2023/04/18 13:09:39 UTC

[GitHub] [hudi] dubin555 opened a new pull request, #8489: [HUDI-6094] make utilities kafka send call from async to sync

dubin555 opened a new pull request, #8489:
URL: https://github.com/apache/hudi/pull/8489

   ### Change Logs
   
   In call method from HoodieWriteCommitKafkaCallback in hudi-utilities module, the kafka send is async, how about to make the send to sync to ensure the kafka send call complete. No performance degradation, because the send call is in a try-with-resource.
   ### Impact
   
   Wait for the kafka send call response
   
   ### Risk level (write none, low medium or high below)
   
   None
   
   ### Documentation Update
   
   None
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] dubin555 commented on pull request #8489: [HUDI-6094] make utilities kafka send call from async to sync

Posted by "dubin555 (via GitHub)" <gi...@apache.org>.
dubin555 commented on PR #8489:
URL: https://github.com/apache/hudi/pull/8489#issuecomment-1515618874

   @hudi-bot  run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] danny0405 commented on pull request #8489: [HUDI-6094] make utilities kafka send call from async to sync

Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #8489:
URL: https://github.com/apache/hudi/pull/8489#issuecomment-1515662740

   Thanks for the contribution, can you elaborate a little more what the gains here?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [HUDI-6094] make utilities kafka send call from async to sync [hudi]

Posted by "bvaradar (via GitHub)" <gi...@apache.org>.
bvaradar commented on PR #8489:
URL: https://github.com/apache/hudi/pull/8489#issuecomment-1848445467

   Rebasing to latest master to verify tests succeed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [HUDI-6094] make utilities kafka send call from async to sync [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8489:
URL: https://github.com/apache/hudi/pull/8489#issuecomment-1848455100

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ed00f4259b97a4d45d5567ebd77c38dc4485c6ab",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16429",
       "triggerID" : "ed00f4259b97a4d45d5567ebd77c38dc4485c6ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "926869521b09a3d17225587f244c85a39606c3d2",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "926869521b09a3d17225587f244c85a39606c3d2",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ed00f4259b97a4d45d5567ebd77c38dc4485c6ab Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16429) 
   * 926869521b09a3d17225587f244c85a39606c3d2 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [HUDI-6094] make utilities kafka send call from async to sync [hudi]

Posted by "bvaradar (via GitHub)" <gi...@apache.org>.
bvaradar merged PR #8489:
URL: https://github.com/apache/hudi/pull/8489


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] dubin555 commented on pull request #8489: [HUDI-6094] make utilities kafka send call from async to sync

Posted by "dubin555 (via GitHub)" <gi...@apache.org>.
dubin555 commented on PR #8489:
URL: https://github.com/apache/hudi/pull/8489#issuecomment-1517300968

   > the
   
   It is difficult to construct a test case that can simulate network faults


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] danny0405 commented on pull request #8489: [HUDI-6094] make utilities kafka send call from async to sync

Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #8489:
URL: https://github.com/apache/hudi/pull/8489#issuecomment-1517161918

   > > Thanks for the contribution, can you elaborate a little more what the gains here?
   > 
   > Kafka producer will put record in the record accumulator in the async call, it is possible to fail during the actual call. So waiting for the response may be a better choice
   
   Can we write a test for that?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #8489: [HUDI-6094] make utilities kafka send call from async to sync

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8489:
URL: https://github.com/apache/hudi/pull/8489#issuecomment-1513833191

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ed00f4259b97a4d45d5567ebd77c38dc4485c6ab",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16429",
       "triggerID" : "ed00f4259b97a4d45d5567ebd77c38dc4485c6ab",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ed00f4259b97a4d45d5567ebd77c38dc4485c6ab Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16429) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #8489: [HUDI-6094] make utilities kafka send call from async to sync

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8489:
URL: https://github.com/apache/hudi/pull/8489#issuecomment-1513205773

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ed00f4259b97a4d45d5567ebd77c38dc4485c6ab",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ed00f4259b97a4d45d5567ebd77c38dc4485c6ab",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ed00f4259b97a4d45d5567ebd77c38dc4485c6ab UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #8489: [HUDI-6094] make utilities kafka send call from async to sync

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8489:
URL: https://github.com/apache/hudi/pull/8489#issuecomment-1513222896

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ed00f4259b97a4d45d5567ebd77c38dc4485c6ab",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16429",
       "triggerID" : "ed00f4259b97a4d45d5567ebd77c38dc4485c6ab",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ed00f4259b97a4d45d5567ebd77c38dc4485c6ab Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16429) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] dubin555 commented on pull request #8489: [HUDI-6094] make utilities kafka send call from async to sync

Posted by "dubin555 (via GitHub)" <gi...@apache.org>.
dubin555 commented on PR #8489:
URL: https://github.com/apache/hudi/pull/8489#issuecomment-1516205480

   > Thanks for the contribution, can you elaborate a little more what the gains here?
   
   Kafka producer will put record in the record accumulator in the async call, it is possible to fail during the actual call. So waiting for the response may be a better choice


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] dubin555 commented on pull request #8489: [HUDI-6094] make utilities kafka send call from async to sync

Posted by "dubin555 (via GitHub)" <gi...@apache.org>.
dubin555 commented on PR #8489:
URL: https://github.com/apache/hudi/pull/8489#issuecomment-1517301331

   > > > Thanks for the contribution, can you elaborate a little more what the gains here?
   > > 
   > > 
   > > Kafka producer will put record in the record accumulator in the async call, it is possible to fail during the actual call. So waiting for the response may be a better choice
   > 
   > Can we write a test for that?
   
   It is difficult to construct a test case that can simulate network faults


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [HUDI-6094] make utilities kafka send call from async to sync [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8489:
URL: https://github.com/apache/hudi/pull/8489#issuecomment-1848498189

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ed00f4259b97a4d45d5567ebd77c38dc4485c6ab",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16429",
       "triggerID" : "ed00f4259b97a4d45d5567ebd77c38dc4485c6ab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "926869521b09a3d17225587f244c85a39606c3d2",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21424",
       "triggerID" : "926869521b09a3d17225587f244c85a39606c3d2",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ed00f4259b97a4d45d5567ebd77c38dc4485c6ab Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16429) 
   * 926869521b09a3d17225587f244c85a39606c3d2 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21424) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org