You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/02/06 13:31:04 UTC
[GitHub] [ozone] umamaheswararao opened a new pull request #3046: HDDS-6188: EC: Adapt java side native coder classes from hadoop.
umamaheswararao opened a new pull request #3046:
URL: https://github.com/apache/ozone/pull/3046
## What changes were proposed in this pull request?
Taken the Native Integration of Java side classes with fallback coder support from hadoop. When native coders not available, it will fallback to java.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6188
## How was this patch tested?
There are tests added to verify the behavior and also integrated with Ozone EC IO streams.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] umamaheswararao merged pull request #3046: HDDS-6188: EC: Adapt java side native coder classes from hadoop.
Posted by GitBox <gi...@apache.org>.
umamaheswararao merged pull request #3046:
URL: https://github.com/apache/ozone/pull/3046
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] umamaheswararao commented on pull request #3046: HDDS-6188: EC: Adapt java side native coder classes from hadoop.
Posted by GitBox <gi...@apache.org>.
umamaheswararao commented on pull request #3046:
URL: https://github.com/apache/ozone/pull/3046#issuecomment-1043548632
Thanks @fapifta for reviewing it. I have just rebased to make sure this is not introducing checkstyle issues. It's not introduced any new ones by my local run.
You may want to approve above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] fapifta commented on pull request #3046: HDDS-6188: EC: Adapt java side native coder classes from hadoop.
Posted by GitBox <gi...@apache.org>.
fapifta commented on pull request #3046:
URL: https://github.com/apache/ozone/pull/3046#issuecomment-1043535786
HI @umamaheswararao
thank you for taking this one on. As I went through the changes I have run into a few things that turned out to be something that I don't like in the original implementation either.
I believe it is good to keep this as close to the hadoop implementation as possible, so I think we are fine.
I haven't gone through it line by line, but in general things look good, tests seems to be reasonably adjusted as well.
LGTM, +!.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org