You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Stephan Erb <se...@apache.org> on 2017/02/12 13:12:12 UTC
Review Request 56577: Add basic test scripts for RPM and DEB packages
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56577/
-----------------------------------------------------------
Review request for Aurora, John Sirois and Renan DelValle.
Repository: aurora-packaging
Description
-------
Add basic test scripts for RPM and DEB packages
This reduces some of the manual effort for verifying the binary packages.
Diffs
-----
.gitignore 2d30051c482a2416026421808876fe456337290f
build-artifact.sh e4efe5f1ac36c9e19082ef9e8be10507b901076f
test/deb/debian-jessie/README.md 2e9bcb70cb0052c48ad325d9cd29b4a1c0a7eaf6
test/deb/debian-jessie/Vagrantfile f79c3379c113190784c40211318a8f19bc8e3fa4
test/deb/debian-jessie/install-aurora.sh PRE-CREATION
test/deb/debian-jessie/provision.sh 175f1ba81c2b1104b13d5c7ea6c463544c85a11c
test/deb/ubuntu-trusty/README.md 116ae8eb95afbafb5f350be5f41fd2f9efc7d9a8
test/deb/ubuntu-trusty/Vagrantfile ed5ec8e6b42d2960df9823bfafa13bf182ea2040
test/deb/ubuntu-trusty/install-aurora.sh PRE-CREATION
test/deb/ubuntu-trusty/provision.sh 123590e63a1440b787836eee937634bd63648517
test/deb/ubuntu-xenial/README.md a5284ecaf6803209037a2915b24469a7e154dc8c
test/deb/ubuntu-xenial/Vagrantfile 3ce6209ba616a4d156c5c4c6f24d8f148a0f7522
test/deb/ubuntu-xenial/install-aurora.sh PRE-CREATION
test/deb/ubuntu-xenial/provision.sh eda79f69395769e02771e290135b0fef05215b91
test/rpm/centos-7/README.md 7fcd5a0da87cd62b72a84cc70be96ab93a1cd3c5
test/rpm/centos-7/Vagrantfile 5059b8410dd271dbae6cd23f5909fd41fb88244a
test/rpm/centos-7/install-aurora.sh PRE-CREATION
test/test-artifact.sh PRE-CREATION
test/test-aurora.sh PRE-CREATION
Diff: https://reviews.apache.org/r/56577/diff/
Testing
-------
See the distribution specific README.md.
Thanks,
Stephan Erb
Re: Review Request 56577: Add basic test scripts for RPM and DEB
packages
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56577/#review165397
-----------------------------------------------------------
Ship it!
LGTM. I always thought we had automated tests, but apparently not.
Thanks for doing this.
- Zameer Manji
On Feb. 12, 2017, 5:12 a.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56577/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2017, 5:12 a.m.)
>
>
> Review request for Aurora, John Sirois and Renan DelValle.
>
>
> Repository: aurora-packaging
>
>
> Description
> -------
>
> Add basic test scripts for RPM and DEB packages
>
> This reduces some of the manual effort for verifying the binary packages.
>
>
> Diffs
> -----
>
> .gitignore 2d30051c482a2416026421808876fe456337290f
> build-artifact.sh e4efe5f1ac36c9e19082ef9e8be10507b901076f
> test/deb/debian-jessie/README.md 2e9bcb70cb0052c48ad325d9cd29b4a1c0a7eaf6
> test/deb/debian-jessie/Vagrantfile f79c3379c113190784c40211318a8f19bc8e3fa4
> test/deb/debian-jessie/install-aurora.sh PRE-CREATION
> test/deb/debian-jessie/provision.sh 175f1ba81c2b1104b13d5c7ea6c463544c85a11c
> test/deb/ubuntu-trusty/README.md 116ae8eb95afbafb5f350be5f41fd2f9efc7d9a8
> test/deb/ubuntu-trusty/Vagrantfile ed5ec8e6b42d2960df9823bfafa13bf182ea2040
> test/deb/ubuntu-trusty/install-aurora.sh PRE-CREATION
> test/deb/ubuntu-trusty/provision.sh 123590e63a1440b787836eee937634bd63648517
> test/deb/ubuntu-xenial/README.md a5284ecaf6803209037a2915b24469a7e154dc8c
> test/deb/ubuntu-xenial/Vagrantfile 3ce6209ba616a4d156c5c4c6f24d8f148a0f7522
> test/deb/ubuntu-xenial/install-aurora.sh PRE-CREATION
> test/deb/ubuntu-xenial/provision.sh eda79f69395769e02771e290135b0fef05215b91
> test/rpm/centos-7/README.md 7fcd5a0da87cd62b72a84cc70be96ab93a1cd3c5
> test/rpm/centos-7/Vagrantfile 5059b8410dd271dbae6cd23f5909fd41fb88244a
> test/rpm/centos-7/install-aurora.sh PRE-CREATION
> test/test-artifact.sh PRE-CREATION
> test/test-aurora.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/56577/diff/
>
>
> Testing
> -------
>
> See the distribution specific README.md.
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 56577: Add basic test scripts for RPM and DEB
packages
Posted by John Sirois <js...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56577/#review166045
-----------------------------------------------------------
Ship it!
A tardy LGTM and thanks.
- John Sirois
On Feb. 14, 2017, 3:33 p.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56577/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2017, 3:33 p.m.)
>
>
> Review request for Aurora, John Sirois and Renan DelValle.
>
>
> Repository: aurora-packaging
>
>
> Description
> -------
>
> Add basic test scripts for RPM and DEB packages
>
> This reduces some of the manual effort for verifying the binary packages.
>
>
> Diffs
> -----
>
> .gitignore 2d30051c482a2416026421808876fe456337290f
> build-artifact.sh e4efe5f1ac36c9e19082ef9e8be10507b901076f
> test/deb/debian-jessie/README.md 2e9bcb70cb0052c48ad325d9cd29b4a1c0a7eaf6
> test/deb/debian-jessie/Vagrantfile f79c3379c113190784c40211318a8f19bc8e3fa4
> test/deb/debian-jessie/install-aurora.sh PRE-CREATION
> test/deb/debian-jessie/provision.sh 175f1ba81c2b1104b13d5c7ea6c463544c85a11c
> test/deb/ubuntu-trusty/README.md 116ae8eb95afbafb5f350be5f41fd2f9efc7d9a8
> test/deb/ubuntu-trusty/Vagrantfile ed5ec8e6b42d2960df9823bfafa13bf182ea2040
> test/deb/ubuntu-trusty/install-aurora.sh PRE-CREATION
> test/deb/ubuntu-trusty/provision.sh 123590e63a1440b787836eee937634bd63648517
> test/deb/ubuntu-xenial/README.md a5284ecaf6803209037a2915b24469a7e154dc8c
> test/deb/ubuntu-xenial/Vagrantfile 3ce6209ba616a4d156c5c4c6f24d8f148a0f7522
> test/deb/ubuntu-xenial/install-aurora.sh PRE-CREATION
> test/deb/ubuntu-xenial/provision.sh eda79f69395769e02771e290135b0fef05215b91
> test/rpm/centos-7/README.md 7fcd5a0da87cd62b72a84cc70be96ab93a1cd3c5
> test/rpm/centos-7/Vagrantfile 5059b8410dd271dbae6cd23f5909fd41fb88244a
> test/rpm/centos-7/install-aurora.sh PRE-CREATION
> test/test-artifact.sh PRE-CREATION
> test/test-aurora.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/56577/diff/
>
>
> Testing
> -------
>
> See the distribution specific README.md.
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 56577: Add basic test scripts for RPM and DEB
packages
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56577/
-----------------------------------------------------------
(Updated Feb. 14, 2017, 11:33 p.m.)
Review request for Aurora, John Sirois and Renan DelValle.
Changes
-------
Review changes.
Repository: aurora-packaging
Description
-------
Add basic test scripts for RPM and DEB packages
This reduces some of the manual effort for verifying the binary packages.
Diffs (updated)
-----
.gitignore 2d30051c482a2416026421808876fe456337290f
build-artifact.sh e4efe5f1ac36c9e19082ef9e8be10507b901076f
test/deb/debian-jessie/README.md 2e9bcb70cb0052c48ad325d9cd29b4a1c0a7eaf6
test/deb/debian-jessie/Vagrantfile f79c3379c113190784c40211318a8f19bc8e3fa4
test/deb/debian-jessie/install-aurora.sh PRE-CREATION
test/deb/debian-jessie/provision.sh 175f1ba81c2b1104b13d5c7ea6c463544c85a11c
test/deb/ubuntu-trusty/README.md 116ae8eb95afbafb5f350be5f41fd2f9efc7d9a8
test/deb/ubuntu-trusty/Vagrantfile ed5ec8e6b42d2960df9823bfafa13bf182ea2040
test/deb/ubuntu-trusty/install-aurora.sh PRE-CREATION
test/deb/ubuntu-trusty/provision.sh 123590e63a1440b787836eee937634bd63648517
test/deb/ubuntu-xenial/README.md a5284ecaf6803209037a2915b24469a7e154dc8c
test/deb/ubuntu-xenial/Vagrantfile 3ce6209ba616a4d156c5c4c6f24d8f148a0f7522
test/deb/ubuntu-xenial/install-aurora.sh PRE-CREATION
test/deb/ubuntu-xenial/provision.sh eda79f69395769e02771e290135b0fef05215b91
test/rpm/centos-7/README.md 7fcd5a0da87cd62b72a84cc70be96ab93a1cd3c5
test/rpm/centos-7/Vagrantfile 5059b8410dd271dbae6cd23f5909fd41fb88244a
test/rpm/centos-7/install-aurora.sh PRE-CREATION
test/test-artifact.sh PRE-CREATION
test/test-aurora.sh PRE-CREATION
Diff: https://reviews.apache.org/r/56577/diff/
Testing
-------
See the distribution specific README.md.
Thanks,
Stephan Erb
Re: Review Request 56577: Add basic test scripts for RPM and DEB
packages
Posted by Renan DelValle <rd...@binghamton.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56577/#review165290
-----------------------------------------------------------
Fix it, then Ship it!
test/deb/debian-jessie/README.md (line 20)
<https://reviews.apache.org/r/56577/#comment237142>
Should this be bumped up to 0.17.0?
test/test-aurora.sh (line 18)
<https://reviews.apache.org/r/56577/#comment237141>
Nit: Remove the space after the . but before the "
- Renan DelValle
On Feb. 12, 2017, 5:12 a.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56577/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2017, 5:12 a.m.)
>
>
> Review request for Aurora, John Sirois and Renan DelValle.
>
>
> Repository: aurora-packaging
>
>
> Description
> -------
>
> Add basic test scripts for RPM and DEB packages
>
> This reduces some of the manual effort for verifying the binary packages.
>
>
> Diffs
> -----
>
> .gitignore 2d30051c482a2416026421808876fe456337290f
> build-artifact.sh e4efe5f1ac36c9e19082ef9e8be10507b901076f
> test/deb/debian-jessie/README.md 2e9bcb70cb0052c48ad325d9cd29b4a1c0a7eaf6
> test/deb/debian-jessie/Vagrantfile f79c3379c113190784c40211318a8f19bc8e3fa4
> test/deb/debian-jessie/install-aurora.sh PRE-CREATION
> test/deb/debian-jessie/provision.sh 175f1ba81c2b1104b13d5c7ea6c463544c85a11c
> test/deb/ubuntu-trusty/README.md 116ae8eb95afbafb5f350be5f41fd2f9efc7d9a8
> test/deb/ubuntu-trusty/Vagrantfile ed5ec8e6b42d2960df9823bfafa13bf182ea2040
> test/deb/ubuntu-trusty/install-aurora.sh PRE-CREATION
> test/deb/ubuntu-trusty/provision.sh 123590e63a1440b787836eee937634bd63648517
> test/deb/ubuntu-xenial/README.md a5284ecaf6803209037a2915b24469a7e154dc8c
> test/deb/ubuntu-xenial/Vagrantfile 3ce6209ba616a4d156c5c4c6f24d8f148a0f7522
> test/deb/ubuntu-xenial/install-aurora.sh PRE-CREATION
> test/deb/ubuntu-xenial/provision.sh eda79f69395769e02771e290135b0fef05215b91
> test/rpm/centos-7/README.md 7fcd5a0da87cd62b72a84cc70be96ab93a1cd3c5
> test/rpm/centos-7/Vagrantfile 5059b8410dd271dbae6cd23f5909fd41fb88244a
> test/rpm/centos-7/install-aurora.sh PRE-CREATION
> test/test-artifact.sh PRE-CREATION
> test/test-aurora.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/56577/diff/
>
>
> Testing
> -------
>
> See the distribution specific README.md.
>
>
> Thanks,
>
> Stephan Erb
>
>