[GitHub] [opennlp] rzo1 commented on a diff in pull request #449: OPENNLP-1406 Enhance JavaDoc in opennlp.tools.parser package

[GitBox <gi...@apache.org>]

rzo1 commented on code in PR #449:
URL: https://github.com/apache/opennlp/pull/449#discussion_r1044334326


##########
opennlp-tools/src/main/java/opennlp/tools/parser/ParserEventTypeEnum.java:
##########
@@ -19,13 +19,14 @@
 package opennlp.tools.parser;
 
 /**
- * Enumerated type of event types for the parser.
+ * Enumeration of event types for a {@link Parser}.
  */
 public enum ParserEventTypeEnum {
 
   BUILD,
   CHECK,
 
+  // TODO Add reason why those enum values are deprecated

Review Comment:
   +1



##########
opennlp-tools/src/main/java/opennlp/tools/parser/ParserModel.java:
##########
@@ -41,16 +41,15 @@
 import opennlp.tools.util.model.POSModelSerializer;
 
 /**
- * This is an abstract base class for {@link ParserModel} implementations.
+ * This is the default {@link ParserModel} implementation.
  */
-// TODO: Model should validate the artifact map

Review Comment:
   Is this still a valid todo?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org