You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/10/20 10:51:03 UTC

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9074: Simplify some code

codecov-commenter edited a comment on pull request #9074:
URL: https://github.com/apache/dubbo/pull/9074#issuecomment-947513898


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9074?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9074](https://codecov.io/gh/apache/dubbo/pull/9074?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0eee7a6) into [3.0](https://codecov.io/gh/apache/dubbo/commit/ba86d61db3a29e11544b30fde4c05981fff39d12?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ba86d61) will **increase** coverage by `0.01%`.
   > The diff coverage is `56.09%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9074/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9074?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #9074      +/-   ##
   ============================================
   + Coverage     64.22%   64.23%   +0.01%     
     Complexity      323      323              
   ============================================
     Files          1176     1176              
     Lines         50642    50662      +20     
     Branches       7528     7539      +11     
   ============================================
   + Hits          32523    32545      +22     
   - Misses        14560    14570      +10     
   + Partials       3559     3547      -12     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9074?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...org/apache/dubbo/config/context/ConfigManager.java](https://codecov.io/gh/apache/dubbo/pull/9074/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvY29udGV4dC9Db25maWdNYW5hZ2VyLmphdmE=) | `80.23% <ø> (ø)` | |
   | [...ache/dubbo/config/context/ModuleConfigManager.java](https://codecov.io/gh/apache/dubbo/pull/9074/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvY29udGV4dC9Nb2R1bGVDb25maWdNYW5hZ2VyLmphdmE=) | `75.28% <ø> (ø)` | |
   | [...o/rpc/model/ScopeModelAwareExtensionProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9074/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvU2NvcGVNb2RlbEF3YXJlRXh0ZW5zaW9uUHJvY2Vzc29yLmphdmE=) | `92.85% <ø> (ø)` | |
   | [...a/org/apache/dubbo/rpc/model/MethodDescriptor.java](https://codecov.io/gh/apache/dubbo/pull/9074/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvTWV0aG9kRGVzY3JpcHRvci5qYXZh) | `75.97% <27.27%> (-8.12%)` | :arrow_down: |
   | [...ain/java/org/apache/dubbo/common/utils/Assert.java](https://codecov.io/gh/apache/dubbo/pull/9074/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvQXNzZXJ0LmphdmE=) | `71.42% <50.00%> (-10.39%)` | :arrow_down: |
   | [...he/dubbo/config/context/AbstractConfigManager.java](https://codecov.io/gh/apache/dubbo/pull/9074/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvY29udGV4dC9BYnN0cmFjdENvbmZpZ01hbmFnZXIuamF2YQ==) | `74.60% <100.00%> (+0.09%)` | :arrow_up: |
   | [...n/java/org/apache/dubbo/rpc/model/ModuleModel.java](https://codecov.io/gh/apache/dubbo/pull/9074/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvTW9kdWxlTW9kZWwuamF2YQ==) | `94.82% <100.00%> (+6.30%)` | :arrow_up: |
   | [...pache/dubbo/rpc/model/ModuleServiceRepository.java](https://codecov.io/gh/apache/dubbo/pull/9074/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvTW9kdWxlU2VydmljZVJlcG9zaXRvcnkuamF2YQ==) | `64.04% <100.00%> (ø)` | |
   | [...java/org/apache/dubbo/rpc/model/ProviderModel.java](https://codecov.io/gh/apache/dubbo/pull/9074/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvUHJvdmlkZXJNb2RlbC5qYXZh) | `35.38% <100.00%> (-2.86%)` | :arrow_down: |
   | [...in/java/org/apache/dubbo/rpc/model/ScopeModel.java](https://codecov.io/gh/apache/dubbo/pull/9074/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvU2NvcGVNb2RlbC5qYXZh) | `80.59% <100.00%> (ø)` | |
   | ... and [19 more](https://codecov.io/gh/apache/dubbo/pull/9074/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9074?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9074?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ba86d61...0eee7a6](https://codecov.io/gh/apache/dubbo/pull/9074?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org