You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/09/19 13:54:20 UTC

[GitHub] [shardingsphere] linghengqian commented on a diff in pull request #21046: Update CODE_OF_CONDUCT about assertThat

linghengqian commented on code in PR #21046:
URL: https://github.com/apache/shardingsphere/pull/21046#discussion_r974275924


##########
CODE_OF_CONDUCT.md:
##########
@@ -63,7 +63,7 @@ The following code of conduct is based on full compliance with [ASF CODE OF COND
  - Environment preparation codes should be separate from test codes.
  - Only those that relate to junit `Assert`, hamcrest `CoreMatchers` and `Mockito` can use static import.
  - For single parameter asserts, `assertTrue`, `assertFalse`, `assertNull` and `assertNotNull` should be used.
- - For multiple parameter asserts, `assertThat` should be used.
+ - For multiple parameter asserts, `org.hamcrest.MatcherAssert.assertThat` should be used.

Review Comment:
   I tweaked the word order to make it readable.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org