[GitHub] [arrow] lidavidm commented on a diff in pull request #34488: MINOR: [Go][CI] Add openssl to macos CGO runs

["lidavidm (via GitHub)" <gi...@apache.org>]

lidavidm commented on code in PR #34488:
URL: https://github.com/apache/arrow/pull/34488#discussion_r1128351119


##########
.github/workflows/go.yml:
##########
@@ -300,18 +300,22 @@ jobs:
         with:
           go-version: ${{ matrix.go }}
           cache: true
-          cache-dependency-path: go/go.sum
+          cache-dependency-path: go/go.sum      
       - name: Brew Install Arrow and pkg-config
         shell: bash
         run: brew install apache-arrow pkg-config
       - name: Install staticcheck
         run: go install honnef.co/go/tools/cmd/staticcheck@${{ matrix.staticcheck }}
       - name: Build
         shell: bash
-        run: ci/scripts/go_build.sh $(pwd)
+        run: |
+          export PKG_CONFIG_PATH=/usr/local/Cellar/openssl@3/3.0.8/lib/pkgconfig:$PKG_CONFIG_PATH

Review Comment:
   Hmm, hardcoding the path like this seems brittle. Are we missing a `brew link` or something similar?



##########
.github/workflows/go.yml:
##########
@@ -300,18 +300,22 @@ jobs:
         with:
           go-version: ${{ matrix.go }}
           cache: true
-          cache-dependency-path: go/go.sum
+          cache-dependency-path: go/go.sum      

Review Comment:
   nit: trailing whitespace



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org