[jira] [Commented] (OOZIE-2541) Resource leak in Hive2Credentials

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OOZIE-2541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15304937#comment-15304937 ] 

Hadoop QA commented on OOZIE-2541:
----------------------------------

Testing JIRA OOZIE-2541

Cleaning local git workspace

----------------------------

{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.    {color:green}+1{color} the patch does not introduce any @author tags
.    {color:green}+1{color} the patch does not introduce any tabs
.    {color:green}+1{color} the patch does not introduce any trailing spaces
.    {color:green}+1{color} the patch does not introduce any line longer than 132
.    {color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.    {color:green}+1{color} the patch does not seem to introduce new RAT warnings
{color:green}+1 JAVADOC{color}
.    {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings
{color:red}-1 COMPILE{color}
.    {color:green}+1{color} HEAD compiles
.    {color:red}-1{color} patch does not compile
.    {color:green}+1{color} the patch does not seem to introduce new javac warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.    {color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
.    {color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color} - patch does not compile, cannot run testcases
{color:red}-1 DISTRO{color}
.    {color:red}-1{color} distro tarball fails with the patch

----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/oozie-trunk-precommit-build/2912/

> Resource leak in Hive2Credentials
> ---------------------------------
>
>                 Key: OOZIE-2541
>                 URL: https://issues.apache.org/jira/browse/OOZIE-2541
>             Project: Oozie
>          Issue Type: Bug
>          Components: core
>            Reporter: Peter Bacsko
>            Assignee: Peter Bacsko
>            Priority: Trivial
>         Attachments: OOZIE-2541-001.patch
>
>
> Connection to Hive is not closed in case of an SQLException:
> {code}
> Connection con = DriverManager.getConnection(url);
> XLog.getLog(getClass()).debug("Connected successfully to " + url);
> // get delegation token for the given proxy user
> String tokenStr = ((HiveConnection)con).getDelegationToken(jobconf.get(USER_NAME), principal);
> XLog.getLog(getClass()).debug("Got token");
> {code}
> Update this piece of code to try-with-resources structure.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)