You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "sodonnel (via GitHub)" <gi...@apache.org> on 2026/03/31 11:00:25 UTC
[PR] HDDS-14940. Create skeleton for ozone admin upgrade status command [ozone]
sodonnel opened a new pull request, #10011:
URL: https://github.com/apache/ozone/pull/10011
## What changes were proposed in this pull request?
Create the skeleton for a new upgrade command ozone admin upgrade status, which will eventually replace the existing commands. This initial version will connect to SCM and pull a placeholder response. The logic to actually query the SCM status will be added in followup PRs.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14940
## How was this patch tested?
Tested manually in docker to prove the command is wired up correctly. Tests can be added when we have real functionality in the command to test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14940. Create skeleton for ozone admin upgrade status command [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #10011:
URL: https://github.com/apache/ozone/pull/10011#discussion_r3015480385
##########
hadoop-ozone/cli-admin/src/main/java/org/apache/hadoop/ozone/admin/upgrade/StatusSubCommand.java:
##########
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.ozone.admin.upgrade;
+
+import java.io.IOException;
+import java.util.UUID;
+import org.apache.hadoop.hdds.cli.HddsVersionProvider;
+import org.apache.hadoop.hdds.protocol.proto.HddsProtos;
+import org.apache.hadoop.hdds.scm.cli.ScmSubcommand;
+import org.apache.hadoop.hdds.scm.client.ScmClient;
+import picocli.CommandLine;
+
+/**
+ * Sub command to query the overall upgrade status of the cluster, returning information about the finalization
+ * status of SCM, the datanodes and OM.
+ */
+@CommandLine.Command(
+ name = "status",
+ description = "Upgrade status of the cluster",
+ mixinStandardHelpOptions = true,
+ versionProvider = HddsVersionProvider.class)
+public class StatusSubCommand extends ScmSubcommand {
+
+ @Override
+ public void execute(ScmClient client) throws IOException {
+ String upgradeClientID = "Upgrade-Client-" + UUID.randomUUID();
+ HddsProtos.UpgradeStatus status = client.queryUpgradeStatus(upgradeClientID, true);
+
+ // Temporary output to validate the command is working.
+ System.out.println("Update status:");
+ System.out.println(" SCM Finalized: " + status.getScmFinalized());
+ System.out.println(" Datanodes finalized: " + status.getNumDatanodesFinalized());
+ System.out.println(" Total Datanodes: " + status.getNumDatanodesTotal());
+ System.out.println(" Should Finalize: " + status.getShouldFinalize());
Review Comment:
nit: please use `out()` (inherited from `AbstractSubcommand`) instead of `System.out`.
##########
hadoop-hdds/interface-client/src/main/proto/hdds.proto:
##########
@@ -426,6 +426,13 @@ message UpgradeFinalizationStatus {
repeated string messages = 2;
}
+message UpgradeStatus {
+ required bool scmFinalized = 1;
+ required int32 numDatanodesFinalized = 2;
+ required int32 numDatanodesTotal = 3;
+ required bool shouldFinalize = 4;
Review Comment:
Please add new fields as `optional`.
https://protobuf.dev/programming-guides/proto2/#required-deprecated
https://protobuf.dev/programming-guides/style/#required
##########
hadoop-ozone/cli-admin/src/main/java/org/apache/hadoop/ozone/admin/upgrade/UpgradeCommands.java:
##########
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.ozone.admin.upgrade;
+
+import org.apache.hadoop.hdds.cli.AdminSubcommand;
+import org.apache.hadoop.hdds.cli.HddsVersionProvider;
+import org.kohsuke.MetaInfServices;
+import picocli.CommandLine;
+
+/**
+ * Subcommand to group upgrade related operations.
+ */
+@CommandLine.Command(
+ name = "upgrade",
+ description = "Upgrade specific operations",
Review Comment:
nit:
```suggestion
description = "Operations related to cluster upgrade",
```
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMClientProtocolServer.java:
##########
@@ -1148,6 +1148,30 @@ public StatusAndMessages queryUpgradeFinalizationProgress(
}
}
+ @Override
+ public HddsProtos.UpgradeStatus queryUpgradeStatus(String upgradeClientID, boolean readonly) throws IOException {
+ Map<String, String> auditMap = Maps.newHashMap();
+ auditMap.put("upgradeClientID", upgradeClientID);
+ auditMap.put("readonly", String.valueOf(readonly));
+
+ try {
+ if (!readonly) {
+ getScm().checkAdminAccess(getRemoteUser(), true);
+ }
+
+ // Returning a placeholder for now.
+ return HddsProtos.UpgradeStatus.newBuilder()
+ .setScmFinalized(true)
+ .setNumDatanodesFinalized(10)
+ .setNumDatanodesTotal(10)
+ .setShouldFinalize(true)
+ .build();
+ } catch (IOException ex) {
+ AUDIT.logReadFailure(buildAuditMessageForFailure(SCMAction.QUERY_UPGRADE_STATUS, auditMap, ex));
Review Comment:
`AUDIT.logReadSuccess` is missing. Should be something like:
```java
HddsProtos.UpgradeStatus response = ...
AUDIT.logReadSuccess(...)
return response
```
##########
hadoop-ozone/cli-admin/src/main/java/org/apache/hadoop/ozone/admin/upgrade/StatusSubCommand.java:
##########
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.ozone.admin.upgrade;
+
+import java.io.IOException;
+import java.util.UUID;
+import org.apache.hadoop.hdds.cli.HddsVersionProvider;
+import org.apache.hadoop.hdds.protocol.proto.HddsProtos;
+import org.apache.hadoop.hdds.scm.cli.ScmSubcommand;
+import org.apache.hadoop.hdds.scm.client.ScmClient;
+import picocli.CommandLine;
+
+/**
+ * Sub command to query the overall upgrade status of the cluster, returning information about the finalization
+ * status of SCM, the datanodes and OM.
+ */
+@CommandLine.Command(
+ name = "status",
+ description = "Upgrade status of the cluster",
Review Comment:
nit:
```suggestion
description = "Show status of cluster upgrade",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14940. Create skeleton for ozone admin upgrade status command [ozone]
Posted by "sodonnel (via GitHub)" <gi...@apache.org>.
sodonnel commented on code in PR #10011:
URL: https://github.com/apache/ozone/pull/10011#discussion_r3015566595
##########
hadoop-hdds/interface-client/src/main/proto/hdds.proto:
##########
@@ -426,6 +426,13 @@ message UpgradeFinalizationStatus {
repeated string messages = 2;
}
+message UpgradeStatus {
+ required bool scmFinalized = 1;
+ required int32 numDatanodesFinalized = 2;
+ required int32 numDatanodesTotal = 3;
+ required bool shouldFinalize = 4;
Review Comment:
This is a new object - shouldn't all its fields be required as we have no backward compatibility issue here - nothing else can be using this object?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14940. Create skeleton for ozone admin upgrade status command [ozone]
Posted by "errose28 (via GitHub)" <gi...@apache.org>.
errose28 merged PR #10011:
URL: https://github.com/apache/ozone/pull/10011
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14940. Create skeleton for ozone admin upgrade status command [ozone]
Posted by "octachoron (via GitHub)" <gi...@apache.org>.
octachoron commented on code in PR #10011:
URL: https://github.com/apache/ozone/pull/10011#discussion_r3050915946
##########
hadoop-ozone/cli-admin/src/main/java/org/apache/hadoop/ozone/admin/upgrade/StatusSubCommand.java:
##########
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.ozone.admin.upgrade;
+
+import java.io.IOException;
+import java.util.UUID;
+import org.apache.hadoop.hdds.cli.HddsVersionProvider;
+import org.apache.hadoop.hdds.protocol.proto.HddsProtos;
+import org.apache.hadoop.hdds.scm.cli.ScmSubcommand;
+import org.apache.hadoop.hdds.scm.client.ScmClient;
+import picocli.CommandLine;
+
+/**
+ * Sub command to query the overall upgrade status of the cluster, returning information about the finalization
+ * status of SCM, the datanodes and OM.
+ */
+@CommandLine.Command(
+ name = "status",
+ description = "Show status of the cluster upgrade",
+ mixinStandardHelpOptions = true,
+ versionProvider = HddsVersionProvider.class)
+public class StatusSubCommand extends ScmSubcommand {
+
+ @Override
+ public void execute(ScmClient client) throws IOException {
+ String upgradeClientID = "Upgrade-Client-" + UUID.randomUUID();
+ HddsProtos.UpgradeStatus status = client.queryUpgradeStatus(upgradeClientID, true);
+
+ // Temporary output to validate the command is working.
+ out().println("Update status:");
+ out().println(" SCM Finalized: " + status.getScmFinalized());
+ out().println(" Datanodes finalized: " + status.getNumDatanodesFinalized());
+ out().println(" Total Datanodes: " + status.getNumDatanodesTotal());
+ out().println(" Should Finalize: " + status.getShouldFinalize());
Review Comment:
I vote +1 on the human and JSON versions.
If we don't print the `shouldFinalize` parameter though (and probably even if we do), it would make a lot of sense to log it when it changes. That would be useful for troubleshooting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14940. Create skeleton for ozone admin upgrade status command [ozone]
Posted by "errose28 (via GitHub)" <gi...@apache.org>.
errose28 commented on code in PR #10011:
URL: https://github.com/apache/ozone/pull/10011#discussion_r3048968988
##########
hadoop-ozone/cli-admin/src/main/java/org/apache/hadoop/ozone/admin/upgrade/StatusSubCommand.java:
##########
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.ozone.admin.upgrade;
+
+import java.io.IOException;
+import java.util.UUID;
+import org.apache.hadoop.hdds.cli.HddsVersionProvider;
+import org.apache.hadoop.hdds.protocol.proto.HddsProtos;
+import org.apache.hadoop.hdds.scm.cli.ScmSubcommand;
+import org.apache.hadoop.hdds.scm.client.ScmClient;
+import picocli.CommandLine;
+
+/**
+ * Sub command to query the overall upgrade status of the cluster, returning information about the finalization
+ * status of SCM, the datanodes and OM.
+ */
+@CommandLine.Command(
+ name = "status",
+ description = "Show status of the cluster upgrade",
+ mixinStandardHelpOptions = true,
+ versionProvider = HddsVersionProvider.class)
+public class StatusSubCommand extends ScmSubcommand {
+
+ @Override
+ public void execute(ScmClient client) throws IOException {
+ String upgradeClientID = "Upgrade-Client-" + UUID.randomUUID();
+ HddsProtos.UpgradeStatus status = client.queryUpgradeStatus(upgradeClientID, true);
+
+ // Temporary output to validate the command is working.
+ out().println("Update status:");
+ out().println(" SCM Finalized: " + status.getScmFinalized());
+ out().println(" Datanodes finalized: " + status.getNumDatanodesFinalized());
+ out().println(" Total Datanodes: " + status.getNumDatanodesTotal());
+ out().println(" Should Finalize: " + status.getShouldFinalize());
Review Comment:
This is fine for now. I'm thinking the final output would have a "human" version:
```
OM is not finalized
SCM is finalized
3/10 Datanodes are finalized
```
and then a `--json` version for scripting:
```json
{
"omFinalized": false,
"scmFinalized": true,
"finalizedDatanodes": 3,
"totalDatanodes": 10
}
```
Note that the final version of this command will also query OM for its finalization status.
We also don't need to print the `shouldFinalize` parameter. That is for SCM to explicitly tell OM when it should finalize so OM does not need to infer this from datanode counts.
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/scm/client/ScmClient.java:
##########
@@ -450,6 +450,8 @@ StatusAndMessages queryUpgradeFinalizationProgress(
String upgradeClientID, boolean force, boolean readonly)
throws IOException;
+ HddsProtos.UpgradeStatus queryUpgradeStatus(String upgradeClientID, boolean readonly) throws IOException;
Review Comment:
We don't need client ID and readonly parameters for the new API. Finalization will not be tracking message state per client now that is one atomic operation per component.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14940. Create skeleton for ozone admin upgrade status command [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #10011:
URL: https://github.com/apache/ozone/pull/10011#discussion_r3015757710
##########
hadoop-hdds/interface-client/src/main/proto/hdds.proto:
##########
@@ -426,6 +426,13 @@ message UpgradeFinalizationStatus {
repeated string messages = 2;
}
+message UpgradeStatus {
+ required bool scmFinalized = 1;
+ required int32 numDatanodesFinalized = 2;
+ required int32 numDatanodesTotal = 3;
+ required bool shouldFinalize = 4;
Review Comment:
It's about backward compatibility of a future version of the software. From the docs I linked:
> `required` must not be used for new fields. Semantics for required fields should be implemented at the application layer instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14940. Create skeleton for ozone admin upgrade status command [ozone]
Posted by "octachoron (via GitHub)" <gi...@apache.org>.
octachoron commented on PR #10011:
URL: https://github.com/apache/ozone/pull/10011#issuecomment-4205855538
Same here - the change lines up with what we talked about, it prints the expected content, and the new subcommands appear in the CLI help. I had one thought inline about printing `shouldFinalize`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14940. Create skeleton for ozone admin upgrade status command [ozone]
Posted by "sodonnel (via GitHub)" <gi...@apache.org>.
sodonnel commented on PR #10011:
URL: https://github.com/apache/ozone/pull/10011#issuecomment-4223777858
I'm good with this change with Zita's latest commit - we can tweak the output and add the JSON as we continue to develop it. I cannot really give a +1 myself as I am the part author of the change, but I am +1 to commit it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14940. Create skeleton for ozone admin upgrade status command [ozone]
Posted by "sodonnel (via GitHub)" <gi...@apache.org>.
sodonnel commented on code in PR #10011:
URL: https://github.com/apache/ozone/pull/10011#discussion_r3063966605
##########
hadoop-ozone/cli-admin/src/main/java/org/apache/hadoop/ozone/admin/upgrade/StatusSubCommand.java:
##########
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.ozone.admin.upgrade;
+
+import java.io.IOException;
+import java.util.UUID;
+import org.apache.hadoop.hdds.cli.HddsVersionProvider;
+import org.apache.hadoop.hdds.protocol.proto.HddsProtos;
+import org.apache.hadoop.hdds.scm.cli.ScmSubcommand;
+import org.apache.hadoop.hdds.scm.client.ScmClient;
+import picocli.CommandLine;
+
+/**
+ * Sub command to query the overall upgrade status of the cluster, returning information about the finalization
+ * status of SCM, the datanodes and OM.
+ */
+@CommandLine.Command(
+ name = "status",
+ description = "Show status of the cluster upgrade",
+ mixinStandardHelpOptions = true,
+ versionProvider = HddsVersionProvider.class)
+public class StatusSubCommand extends ScmSubcommand {
+
+ @Override
+ public void execute(ScmClient client) throws IOException {
+ String upgradeClientID = "Upgrade-Client-" + UUID.randomUUID();
+ HddsProtos.UpgradeStatus status = client.queryUpgradeStatus(upgradeClientID, true);
+
+ // Temporary output to validate the command is working.
+ out().println("Update status:");
+ out().println(" SCM Finalized: " + status.getScmFinalized());
+ out().println(" Datanodes finalized: " + status.getNumDatanodesFinalized());
+ out().println(" Total Datanodes: " + status.getNumDatanodesTotal());
+ out().println(" Should Finalize: " + status.getShouldFinalize());
Review Comment:
Yea the JSON can final output in human readable for can be finalized later when we have the OM status included too. This change was just to get the basic path through the system setup so we can build on it with further small changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14940. Create skeleton for ozone admin upgrade status command [ozone]
Posted by "sodonnel (via GitHub)" <gi...@apache.org>.
sodonnel commented on code in PR #10011:
URL: https://github.com/apache/ozone/pull/10011#discussion_r3016388767
##########
hadoop-hdds/interface-client/src/main/proto/hdds.proto:
##########
@@ -426,6 +426,13 @@ message UpgradeFinalizationStatus {
repeated string messages = 2;
}
+message UpgradeStatus {
+ required bool scmFinalized = 1;
+ required int32 numDatanodesFinalized = 2;
+ required int32 numDatanodesTotal = 3;
+ required bool shouldFinalize = 4;
Review Comment:
OK - this probably should be communicated more widely, as it seems that the established pattern is now not to be followed, and I suspect many people don't know this. The current definition file is also full of required fields.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org