You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@juddi.apache.org by ks...@apache.org on 2009/02/21 21:05:03 UTC
svn commit: r746581 -
/webservices/juddi/branches/v3_trunk/juddi-core/src/main/java/org/apache/juddi/query/FindEntityByCategoryGroupQuery.java
Author: kstam
Date: Sat Feb 21 20:05:03 2009
New Revision: 746581
URL: http://svn.apache.org/viewvc?rev=746581&view=rev
Log:
JUDDI-177 cleaning up warning in the code.
Modified:
webservices/juddi/branches/v3_trunk/juddi-core/src/main/java/org/apache/juddi/query/FindEntityByCategoryGroupQuery.java
Modified: webservices/juddi/branches/v3_trunk/juddi-core/src/main/java/org/apache/juddi/query/FindEntityByCategoryGroupQuery.java
URL: http://svn.apache.org/viewvc/webservices/juddi/branches/v3_trunk/juddi-core/src/main/java/org/apache/juddi/query/FindEntityByCategoryGroupQuery.java?rev=746581&r1=746580&r2=746581&view=diff
==============================================================================
--- webservices/juddi/branches/v3_trunk/juddi-core/src/main/java/org/apache/juddi/query/FindEntityByCategoryGroupQuery.java (original)
+++ webservices/juddi/branches/v3_trunk/juddi-core/src/main/java/org/apache/juddi/query/FindEntityByCategoryGroupQuery.java Sat Feb 21 20:05:03 2009
@@ -272,24 +272,18 @@
List<KeyedReference> keyedRefs = keyedRefGroup.getKeyedReference();
StringBuffer thetaJoins = new StringBuffer(200);
if (keyedRefs != null && keyedRefs.size() > 0) {
-
int tblCount = 0;
- int count = 0;
- //TODO- JUDDI-177 Code Review; why is kr not used in the loop?
- for(KeyedReference kr : keyedRefs) {
+ for(int count = 0; count<keyedRefs.size(); count++) {
if (count != 0) {
tblCount++;
qry.comma().pad().append(ENTITY_KEYEDREFERENCE + " " + ALIAS_KEYEDREFERENCE + tblCount).pad();
thetaJoins.append(ALIAS_KEYEDREFERENCE + (tblCount - 1) + "." + FIELD_KEYEDREFERENCEGROUP + ".id = " + ALIAS_KEYEDREFERENCE + tblCount + "." + FIELD_KEYEDREFERENCEGROUP + ".id ");
thetaJoins.append(DynamicQuery.OPERATOR_AND + " ");
-
- }
- else {
+ } else {
qry.comma().pad().append(ENTITY_KEYEDREFERENCE + " " + ALIAS_KEYEDREFERENCE + tblCount).pad();
thetaJoins.append(ALIAS_KEYEDREFERENCEGROUP + ".id = " + ALIAS_KEYEDREFERENCE + tblCount + "." + FIELD_KEYEDREFERENCEGROUP + ".id ");
thetaJoins.append(DynamicQuery.OPERATOR_AND + " ");
}
- count++;
}
}
qry.WHERE().pad().openParen().pad();
---------------------------------------------------------------------
To unsubscribe, e-mail: juddi-cvs-unsubscribe@ws.apache.org
For additional commands, e-mail: juddi-cvs-help@ws.apache.org