You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Ahmed Radwan (JIRA)" <ji...@apache.org> on 2011/07/08 07:45:16 UTC
[jira] [Created] (MAPREDUCE-2661) Accessing MapTaskImpl from
TaskImpl
Accessing MapTaskImpl from TaskImpl
-----------------------------------
Key: MAPREDUCE-2661
URL: https://issues.apache.org/jira/browse/MAPREDUCE-2661
Project: Hadoop Map/Reduce
Issue Type: Bug
Components: mrv2
Reporter: Ahmed Radwan
Assignee: Ahmed Radwan
Priority: Minor
We are directly accessing MapTaskImpl in TaskImpl.InitialScheduleTransition.transition(..). It'll be better to reorganize the code so each subclass can provide its own behavior instead of explicitly checking for the subclass type.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2661) Accessing MapTaskImpl from
TaskImpl
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061778#comment-13061778 ]
Hadoop QA commented on MAPREDUCE-2661:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12485693/MAPREDUCE-2661.patch
against trunk revision 1144097.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/443//console
This message is automatically generated.
> Accessing MapTaskImpl from TaskImpl
> -----------------------------------
>
> Key: MAPREDUCE-2661
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2661
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Reporter: Ahmed Radwan
> Assignee: Ahmed Radwan
> Priority: Minor
> Attachments: MAPREDUCE-2661.patch
>
>
> We are directly accessing MapTaskImpl in TaskImpl.InitialScheduleTransition.transition(..). It'll be better to reorganize the code so each subclass can provide its own behavior instead of explicitly checking for the subclass type.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2661) MR-279: Accessing MapTaskImpl
from TaskImpl
Posted by "Ahmed Radwan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13064189#comment-13064189 ]
Ahmed Radwan commented on MAPREDUCE-2661:
-----------------------------------------
Typo:
I meant 'simpler' in my previous comment: "it will be simpler that way", not 'similar'.
> MR-279: Accessing MapTaskImpl from TaskImpl
> -------------------------------------------
>
> Key: MAPREDUCE-2661
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2661
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Reporter: Ahmed Radwan
> Assignee: Ahmed Radwan
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2661.patch, MAPREDUCE-2661_rev2.patch, MAPREDUCE-2661_rev3.patch
>
>
> We are directly accessing MapTaskImpl in TaskImpl.InitialScheduleTransition.transition(..). It'll be better to reorganize the code so each subclass can provide its own behavior instead of explicitly checking for the subclass type.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2661) MR-279: Accessing MapTaskImpl
from TaskImpl
Posted by "Devaraj K (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13064062#comment-13064062 ]
Devaraj K commented on MAPREDUCE-2661:
--------------------------------------
I feel it is not correct to give the getSplitsAsString() implementation details of MapTaskImpl.java and ReduceTaskImpl.java in TaskImpl.java.
TaskImpl.java can provide default implementation of getSplitsAsString() instead of making it as abstract and returning with empty string in ReduceTaskImpl.java.
> MR-279: Accessing MapTaskImpl from TaskImpl
> -------------------------------------------
>
> Key: MAPREDUCE-2661
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2661
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Reporter: Ahmed Radwan
> Assignee: Ahmed Radwan
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2661.patch, MAPREDUCE-2661_rev2.patch
>
>
> We are directly accessing MapTaskImpl in TaskImpl.InitialScheduleTransition.transition(..). It'll be better to reorganize the code so each subclass can provide its own behavior instead of explicitly checking for the subclass type.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2661) Accessing MapTaskImpl from
TaskImpl
Posted by "Ahmed Radwan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ahmed Radwan updated MAPREDUCE-2661:
------------------------------------
Status: Patch Available (was: Open)
Reorganization of the related code in TaskImpl, MapTaskImpl and ReduceTaskImpl.
> Accessing MapTaskImpl from TaskImpl
> -----------------------------------
>
> Key: MAPREDUCE-2661
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2661
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Reporter: Ahmed Radwan
> Assignee: Ahmed Radwan
> Priority: Minor
> Attachments: MAPREDUCE-2661.patch
>
>
> We are directly accessing MapTaskImpl in TaskImpl.InitialScheduleTransition.transition(..). It'll be better to reorganize the code so each subclass can provide its own behavior instead of explicitly checking for the subclass type.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2661) MR-279: Accessing MapTaskImpl
from TaskImpl
Posted by "Ahmed Radwan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ahmed Radwan updated MAPREDUCE-2661:
------------------------------------
Attachment: MAPREDUCE-2661_rev3.patch
Thanks Devaraj for your review!
> I feel it is not correct to give the getSplitsAsString() implementation details of MapTaskImpl.java and ReduceTaskImpl.java in TaskImpl.java.
Yes, and this is why the patch pushes the implementation detail to subclasses.
> TaskImpl.java can provide default implementation of getSplitsAsString() instead of making it as abstract and returning with empty string in ReduceTaskImpl.java.
Agree, it will be similar that way. I have updated the patch accordingly.
Thanks
> MR-279: Accessing MapTaskImpl from TaskImpl
> -------------------------------------------
>
> Key: MAPREDUCE-2661
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2661
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Reporter: Ahmed Radwan
> Assignee: Ahmed Radwan
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2661.patch, MAPREDUCE-2661_rev2.patch, MAPREDUCE-2661_rev3.patch
>
>
> We are directly accessing MapTaskImpl in TaskImpl.InitialScheduleTransition.transition(..). It'll be better to reorganize the code so each subclass can provide its own behavior instead of explicitly checking for the subclass type.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2661) MR-279: Accessing MapTaskImpl
from TaskImpl
Posted by "Ahmed Radwan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13066278#comment-13066278 ]
Ahmed Radwan commented on MAPREDUCE-2661:
-----------------------------------------
Did anyone had a chance to review the updated patch? Thanks!
> MR-279: Accessing MapTaskImpl from TaskImpl
> -------------------------------------------
>
> Key: MAPREDUCE-2661
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2661
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Reporter: Ahmed Radwan
> Assignee: Ahmed Radwan
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2661.patch, MAPREDUCE-2661_rev2.patch, MAPREDUCE-2661_rev3.patch
>
>
> We are directly accessing MapTaskImpl in TaskImpl.InitialScheduleTransition.transition(..). It'll be better to reorganize the code so each subclass can provide its own behavior instead of explicitly checking for the subclass type.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2661) Accessing MapTaskImpl from
TaskImpl
Posted by "Ahmed Radwan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ahmed Radwan updated MAPREDUCE-2661:
------------------------------------
Attachment: MAPREDUCE-2661_rev2.patch
Thanks Josh for your review! I have updated the patch to include comments for the added methods.
> Accessing MapTaskImpl from TaskImpl
> -----------------------------------
>
> Key: MAPREDUCE-2661
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2661
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Reporter: Ahmed Radwan
> Assignee: Ahmed Radwan
> Priority: Minor
> Attachments: MAPREDUCE-2661.patch, MAPREDUCE-2661_rev2.patch
>
>
> We are directly accessing MapTaskImpl in TaskImpl.InitialScheduleTransition.transition(..). It'll be better to reorganize the code so each subclass can provide its own behavior instead of explicitly checking for the subclass type.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2661) Accessing MapTaskImpl from
TaskImpl
Posted by "Josh Wills (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13062055#comment-13062055 ]
Josh Wills commented on MAPREDUCE-2661:
---------------------------------------
+1
An optional thought: add a comment to the definition of the getSplitsAsString() method in TaskImpl.java to specify that it will return the empty string for reduce tasks since they don't have splits.
> Accessing MapTaskImpl from TaskImpl
> -----------------------------------
>
> Key: MAPREDUCE-2661
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2661
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Reporter: Ahmed Radwan
> Assignee: Ahmed Radwan
> Priority: Minor
> Attachments: MAPREDUCE-2661.patch
>
>
> We are directly accessing MapTaskImpl in TaskImpl.InitialScheduleTransition.transition(..). It'll be better to reorganize the code so each subclass can provide its own behavior instead of explicitly checking for the subclass type.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2661) MR-279: Accessing MapTaskImpl
from TaskImpl
Posted by "Sharad Agarwal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sharad Agarwal updated MAPREDUCE-2661:
--------------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I committed to MR-279 branch. Thanks Ahmed!
> MR-279: Accessing MapTaskImpl from TaskImpl
> -------------------------------------------
>
> Key: MAPREDUCE-2661
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2661
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Reporter: Ahmed Radwan
> Assignee: Ahmed Radwan
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2661.patch, MAPREDUCE-2661_rev2.patch, MAPREDUCE-2661_rev3.patch
>
>
> We are directly accessing MapTaskImpl in TaskImpl.InitialScheduleTransition.transition(..). It'll be better to reorganize the code so each subclass can provide its own behavior instead of explicitly checking for the subclass type.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2661) Accessing MapTaskImpl from
TaskImpl
Posted by "Ahmed Radwan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ahmed Radwan updated MAPREDUCE-2661:
------------------------------------
Attachment: MAPREDUCE-2661.patch
> Accessing MapTaskImpl from TaskImpl
> -----------------------------------
>
> Key: MAPREDUCE-2661
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2661
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Reporter: Ahmed Radwan
> Assignee: Ahmed Radwan
> Priority: Minor
> Attachments: MAPREDUCE-2661.patch
>
>
> We are directly accessing MapTaskImpl in TaskImpl.InitialScheduleTransition.transition(..). It'll be better to reorganize the code so each subclass can provide its own behavior instead of explicitly checking for the subclass type.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2661) MR-279: Accessing MapTaskImpl
from TaskImpl
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated MAPREDUCE-2661:
-------------------------------------
Fix Version/s: 0.23.0
Summary: MR-279: Accessing MapTaskImpl from TaskImpl (was: Accessing MapTaskImpl from TaskImpl)
> MR-279: Accessing MapTaskImpl from TaskImpl
> -------------------------------------------
>
> Key: MAPREDUCE-2661
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2661
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Reporter: Ahmed Radwan
> Assignee: Ahmed Radwan
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2661.patch, MAPREDUCE-2661_rev2.patch
>
>
> We are directly accessing MapTaskImpl in TaskImpl.InitialScheduleTransition.transition(..). It'll be better to reorganize the code so each subclass can provide its own behavior instead of explicitly checking for the subclass type.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2661) MR-279: Accessing MapTaskImpl
from TaskImpl
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13064152#comment-13064152 ]
Hadoop QA commented on MAPREDUCE-2661:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12486224/MAPREDUCE-2661_rev3.patch
against trunk revision 1145679.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/459//console
This message is automatically generated.
> MR-279: Accessing MapTaskImpl from TaskImpl
> -------------------------------------------
>
> Key: MAPREDUCE-2661
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2661
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Reporter: Ahmed Radwan
> Assignee: Ahmed Radwan
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2661.patch, MAPREDUCE-2661_rev2.patch, MAPREDUCE-2661_rev3.patch
>
>
> We are directly accessing MapTaskImpl in TaskImpl.InitialScheduleTransition.transition(..). It'll be better to reorganize the code so each subclass can provide its own behavior instead of explicitly checking for the subclass type.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2661) Accessing MapTaskImpl from
TaskImpl
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13062122#comment-13062122 ]
Hadoop QA commented on MAPREDUCE-2661:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12485772/MAPREDUCE-2661_rev2.patch
against trunk revision 1144403.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/449//console
This message is automatically generated.
> Accessing MapTaskImpl from TaskImpl
> -----------------------------------
>
> Key: MAPREDUCE-2661
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2661
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Reporter: Ahmed Radwan
> Assignee: Ahmed Radwan
> Priority: Minor
> Attachments: MAPREDUCE-2661.patch, MAPREDUCE-2661_rev2.patch
>
>
> We are directly accessing MapTaskImpl in TaskImpl.InitialScheduleTransition.transition(..). It'll be better to reorganize the code so each subclass can provide its own behavior instead of explicitly checking for the subclass type.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira