You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by tn...@apache.org on 2012/09/03 20:33:53 UTC
svn commit: r1380304 - in
/commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/bm:
Lang.java Languages.java Rule.java
Author: tn
Date: Mon Sep 3 18:33:52 2012
New Revision: 1380304
URL: http://svn.apache.org/viewvc?rev=1380304&view=rev
Log:
Fix findbugs warnings.
Modified:
commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/bm/Lang.java
commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/bm/Languages.java
commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/bm/Rule.java
Modified: commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/bm/Lang.java
URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/bm/Lang.java?rev=1380304&r1=1380303&r2=1380304&view=diff
==============================================================================
--- commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/bm/Lang.java (original)
+++ commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/bm/Lang.java Mon Sep 3 18:33:52 2012
@@ -141,10 +141,9 @@ public class Lang {
String line = rawLine;
if (inExtendedComment) {
+ // check for closing comment marker, otherwise discard doc comment line
if (line.endsWith(ResourceConstants.EXT_CMT_END)) {
inExtendedComment = false;
- } else {
- // discard doc comment line
}
} else {
if (line.startsWith(ResourceConstants.EXT_CMT_START)) {
Modified: commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/bm/Languages.java
URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/bm/Languages.java?rev=1380304&r1=1380303&r2=1380304&view=diff
==============================================================================
--- commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/bm/Languages.java (original)
+++ commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/bm/Languages.java Mon Sep 3 18:33:52 2012
@@ -164,16 +164,12 @@ public class Languages {
if (inExtendedComment) {
if (line.endsWith(ResourceConstants.EXT_CMT_END)) {
inExtendedComment = false;
- } else {
- // skip
}
} else {
if (line.startsWith(ResourceConstants.EXT_CMT_START)) {
inExtendedComment = true;
} else if (line.length() > 0) {
ls.add(line);
- } else {
- // skip blank lines
}
}
}
Modified: commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/bm/Rule.java
URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/bm/Rule.java?rev=1380304&r1=1380303&r2=1380304&view=diff
==============================================================================
--- commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/bm/Rule.java (original)
+++ commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/bm/Rule.java Mon Sep 3 18:33:52 2012
@@ -334,8 +334,6 @@ public class Rule {
if (inMultilineComment) {
if (line.endsWith(ResourceConstants.EXT_CMT_END)) {
inMultilineComment = false;
- } else {
- // skip
}
} else {
if (line.startsWith(ResourceConstants.EXT_CMT_START)) {