[jira] [Commented] (FLUME-3043) KafkaSink SinkCallback throws NullPointerException when Log4J level is debug

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLUME-3043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15970532#comment-15970532 ] 

ASF subversion and git services commented on FLUME-3043:
--------------------------------------------------------

Commit c718dae09d10db640cb9eb59f8abb11bd385a799 in flume's branch refs/heads/trunk from [~lolee_k]
[ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=c718dae ]

FLUME-3043. Fix NPE in Kafka Sink and Channel

When logging level is set to DEBUG, Kafka Sink and Kafka Channel may throw a NullPointerException.

This patch ensures that `metadata` is not null to avoid the exception.

This closes #125

Reviewers: Denes Arvay, Bessenyei Balázs Donát

(loleek via Bessenyei Balázs Donát)


> KafkaSink SinkCallback throws NullPointerException when Log4J level is debug
> ----------------------------------------------------------------------------
>
>                 Key: FLUME-3043
>                 URL: https://issues.apache.org/jira/browse/FLUME-3043
>             Project: Flume
>          Issue Type: Bug
>          Components: Sinks+Sources
>    Affects Versions: 1.7.0
>            Reporter: dengkai
>            Assignee: dengkai
>         Attachments: FLUME-3043.patch
>
>
> When we send a event with SinkCallback to kafka under DEBUG level of log4j, if kafka reponses a result with exception but not a RecordMetadata. Kafka Sink will throw NPE.
> code in SinkCallback:
> {code}
> if (logger.isDebugEnabled()) {
>   long eventElapsedTime = System.currentTimeMillis() - startTime;
>   logger.debug("Acked message partition:{} ofset:{}",  metadata.partition(), metadata.offset());
>   logger.debug("Elapsed time for send: {}", eventElapsedTime);
> }
> {code}
> code in Kafka Producer:
> {code}
> if (exception == null) { 
>   RecordMetadata metadata = new RecordMetadata(...);
>   thunk.callback.onCompletion(metadata, null);
> } else {
>   thunk.callback.onCompletion(null, exception);
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)