You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "angela (JIRA)" <ji...@apache.org> on 2007/03/09 12:34:24 UTC

[jira] Created: (JCR-782) TCK: LockTest.testGetLock compares Nodes with equals

TCK: LockTest.testGetLock compares Nodes with equals
----------------------------------------------------

                 Key: JCR-782
                 URL: https://issues.apache.org/jira/browse/JCR-782
             Project: Jackrabbit
          Issue Type: Bug
          Components: JCR TCK
            Reporter: angela
            Priority: Trivial


i think comparison by 'isSame' would be better.

-> line 545

-        assertTrue("lock holding node must be parent", lock.getNode().equals(n1));
+        assertTrue("lock holding node must be parent", lock.getNode().isSame(n1));

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (JCR-782) TCK: LockTest.testGetLock compares Nodes with equals

Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jukka Zitting updated JCR-782:
------------------------------

        Fix Version/s: 1.3
    Affects Version/s: 1.0
                       1.0.1
                       1.1
                       1.1.1
                       1.2.1
                       1.2.2
                       1.2.3

> TCK: LockTest.testGetLock compares Nodes with equals
> ----------------------------------------------------
>
>                 Key: JCR-782
>                 URL: https://issues.apache.org/jira/browse/JCR-782
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: JCR TCK
>    Affects Versions: 1.0, 1.0.1, 1.1, 1.1.1, 1.2.1, 1.2.2, 1.2.3
>            Reporter: angela
>            Priority: Trivial
>             Fix For: 1.3
>
>
> i think comparison by 'isSame' would be better.
> -> line 545
> -        assertTrue("lock holding node must be parent", lock.getNode().equals(n1));
> +        assertTrue("lock holding node must be parent", lock.getNode().isSame(n1));

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (JCR-782) TCK: LockTest.testGetLock compares Nodes with equals

Posted by "Marcel Reutegger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marcel Reutegger resolved JCR-782.
----------------------------------

    Resolution: Fixed

Agreed. Fixed in revision: 516420

Thanks for reporting this issue.

> TCK: LockTest.testGetLock compares Nodes with equals
> ----------------------------------------------------
>
>                 Key: JCR-782
>                 URL: https://issues.apache.org/jira/browse/JCR-782
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: JCR TCK
>            Reporter: angela
>            Priority: Trivial
>
> i think comparison by 'isSame' would be better.
> -> line 545
> -        assertTrue("lock holding node must be parent", lock.getNode().equals(n1));
> +        assertTrue("lock holding node must be parent", lock.getNode().isSame(n1));

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.