You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jinmei Liao <ji...@pivotal.io> on 2017/01/14 03:53:07 UTC
Review Request 55532: GEODE-2198: close and re-create the cache on a
server when importing new cluster configuration
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55532/
-----------------------------------------------------------
Review request for geode, Jared Stewart, Kevin Duling, and Kirk Lund.
Repository: geode
Description
-------
* When importing cluster config first check if there is any non-empty region
* close and re-create cache if no data exists when importing new cluster configuration
* put the acquire/release lock inside the ClusterConfigurationService instead of command execution strategy.
Diffs
-----
geode-core/src/main/java/org/apache/geode/distributed/internal/ClusterConfigurationService.java 1d4030a8dedd017a0ab096925055f375bb5d3ef0
geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 795164d7a86f87afb60e800885fb5fb2c540451b
geode-core/src/main/java/org/apache/geode/internal/cache/xmlcache/CacheCreation.java 1c3c93314841f5623c0e6387500af88f106328d9
geode-core/src/main/java/org/apache/geode/management/cli/CliMetaData.java 2e272fc083514456f0ef89d4b9824126e86828fa
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java 7df4112950cefcc1ae18bdd88cb752cdec5b7de1
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DeployCommands.java f076cec670a4c787fbe4002edfdacde4b025d1bf
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommands.java 14114cff2febf0e1ba7ae67427549ad4fd19ed85
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportImportSharedConfigurationCommands.java 914576b2b24eec670c06510aa5b056c0acd808fc
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/IndexCommands.java bc436ba40e107b931e8d0d10082e26cf068dd56b
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/PDXCommands.java 72d5c0fc65090880b95f37868e72ef9dcba6c55f
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/QueueCommands.java 095bd68f54d0f06d9f9439fcaffbca72e49083fc
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/WanCommands.java cbf589185e94345be6fd64ebd630f76e84cc2a09
geode-core/src/main/java/org/apache/geode/management/internal/cli/remote/RemoteExecutionStrategy.java 1e4870f9b48e5cc5e4c7ded2af907f4e63aa2977
geode-core/src/main/java/org/apache/geode/management/internal/configuration/functions/RecreateCacheFunction.java PRE-CREATION
geode-core/src/main/java/org/apache/geode/management/internal/configuration/functions/RegionsWithDataOnServerFunction.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/extension/mock/MockExtensionCommands.java 1bd4478538f0e0c9413e95a01e835fa6af3a24ea
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ClusterConfigurationServiceCommandsDUnitTest.java 87cac55bc672ed380d3abb8ab69c9499f931e4b3
geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfig.java c2d511d1c4d34aea434751c2bb5b7e9b924482ad
geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigBaseTest.java 506428a48c27435a3c89f97bc4d296853fe99415
geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigImportDUnitTest.java b301b80a1268c8ad0954e9abe86711cdfe5ac066
geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigStartMemberDUnitTest.java 7dd0da67bdb38f027f717bfc96adc5f5ffc0af37
geode-core/src/test/java/org/apache/geode/test/dunit/rules/ServerStarterRule.java c94185a3b7f8e82cdab620b79c3cb836d0a7e530
geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedSerializables.txt 9626be76c35194e07df10d3ad650cb3d2df4d73a
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/cli/LuceneIndexCommands.java 6a5a1e09c03b9a5362e44fd6fe55a6e6181ea17c
geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/CommandOverHttpDUnitTest.java a1810b6eaa7d940ad359d64faab98c7d113165f0
Diff: https://reviews.apache.org/r/55532/diff/
Testing
-------
precheckin successful
Thanks,
Jinmei Liao
Re: Review Request 55532: GEODE-2198: close and re-create the cache
on a server when importing new cluster configuration
Posted by Jared Stewart <js...@pivotal.io>.
> On Jan. 16, 2017, 6:32 p.m., Jared Stewart wrote:
> > Ship It!
+1 after Kevin's comment is addressed
- Jared
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55532/#review161765
-----------------------------------------------------------
On Jan. 14, 2017, 3:52 a.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55532/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2017, 3:52 a.m.)
>
>
> Review request for geode, Jared Stewart, Kevin Duling, and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> * When importing cluster config first check if there is any non-empty region
> * close and re-create cache if no data exists when importing new cluster configuration
> * put the acquire/release lock inside the ClusterConfigurationService instead of command execution strategy.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/distributed/internal/ClusterConfigurationService.java 1d4030a8dedd017a0ab096925055f375bb5d3ef0
> geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 795164d7a86f87afb60e800885fb5fb2c540451b
> geode-core/src/main/java/org/apache/geode/internal/cache/xmlcache/CacheCreation.java 1c3c93314841f5623c0e6387500af88f106328d9
> geode-core/src/main/java/org/apache/geode/management/cli/CliMetaData.java 2e272fc083514456f0ef89d4b9824126e86828fa
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java 7df4112950cefcc1ae18bdd88cb752cdec5b7de1
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DeployCommands.java f076cec670a4c787fbe4002edfdacde4b025d1bf
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommands.java 14114cff2febf0e1ba7ae67427549ad4fd19ed85
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportImportSharedConfigurationCommands.java 914576b2b24eec670c06510aa5b056c0acd808fc
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/IndexCommands.java bc436ba40e107b931e8d0d10082e26cf068dd56b
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/PDXCommands.java 72d5c0fc65090880b95f37868e72ef9dcba6c55f
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/QueueCommands.java 095bd68f54d0f06d9f9439fcaffbca72e49083fc
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/WanCommands.java cbf589185e94345be6fd64ebd630f76e84cc2a09
> geode-core/src/main/java/org/apache/geode/management/internal/cli/remote/RemoteExecutionStrategy.java 1e4870f9b48e5cc5e4c7ded2af907f4e63aa2977
> geode-core/src/main/java/org/apache/geode/management/internal/configuration/functions/RecreateCacheFunction.java PRE-CREATION
> geode-core/src/main/java/org/apache/geode/management/internal/configuration/functions/RegionsWithDataOnServerFunction.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/extension/mock/MockExtensionCommands.java 1bd4478538f0e0c9413e95a01e835fa6af3a24ea
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ClusterConfigurationServiceCommandsDUnitTest.java 87cac55bc672ed380d3abb8ab69c9499f931e4b3
> geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfig.java c2d511d1c4d34aea434751c2bb5b7e9b924482ad
> geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigBaseTest.java 506428a48c27435a3c89f97bc4d296853fe99415
> geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigImportDUnitTest.java b301b80a1268c8ad0954e9abe86711cdfe5ac066
> geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigStartMemberDUnitTest.java 7dd0da67bdb38f027f717bfc96adc5f5ffc0af37
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/ServerStarterRule.java c94185a3b7f8e82cdab620b79c3cb836d0a7e530
> geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedSerializables.txt 9626be76c35194e07df10d3ad650cb3d2df4d73a
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/cli/LuceneIndexCommands.java 6a5a1e09c03b9a5362e44fd6fe55a6e6181ea17c
> geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/CommandOverHttpDUnitTest.java a1810b6eaa7d940ad359d64faab98c7d113165f0
>
> Diff: https://reviews.apache.org/r/55532/diff/
>
>
> Testing
> -------
>
> precheckin successful
>
>
> Thanks,
>
> Jinmei Liao
>
>
Re: Review Request 55532: GEODE-2198: close and re-create the cache
on a server when importing new cluster configuration
Posted by Jared Stewart <js...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55532/#review161765
-----------------------------------------------------------
Ship it!
Ship It!
- Jared Stewart
On Jan. 14, 2017, 3:52 a.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55532/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2017, 3:52 a.m.)
>
>
> Review request for geode, Jared Stewart, Kevin Duling, and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> * When importing cluster config first check if there is any non-empty region
> * close and re-create cache if no data exists when importing new cluster configuration
> * put the acquire/release lock inside the ClusterConfigurationService instead of command execution strategy.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/distributed/internal/ClusterConfigurationService.java 1d4030a8dedd017a0ab096925055f375bb5d3ef0
> geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 795164d7a86f87afb60e800885fb5fb2c540451b
> geode-core/src/main/java/org/apache/geode/internal/cache/xmlcache/CacheCreation.java 1c3c93314841f5623c0e6387500af88f106328d9
> geode-core/src/main/java/org/apache/geode/management/cli/CliMetaData.java 2e272fc083514456f0ef89d4b9824126e86828fa
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java 7df4112950cefcc1ae18bdd88cb752cdec5b7de1
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DeployCommands.java f076cec670a4c787fbe4002edfdacde4b025d1bf
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommands.java 14114cff2febf0e1ba7ae67427549ad4fd19ed85
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportImportSharedConfigurationCommands.java 914576b2b24eec670c06510aa5b056c0acd808fc
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/IndexCommands.java bc436ba40e107b931e8d0d10082e26cf068dd56b
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/PDXCommands.java 72d5c0fc65090880b95f37868e72ef9dcba6c55f
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/QueueCommands.java 095bd68f54d0f06d9f9439fcaffbca72e49083fc
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/WanCommands.java cbf589185e94345be6fd64ebd630f76e84cc2a09
> geode-core/src/main/java/org/apache/geode/management/internal/cli/remote/RemoteExecutionStrategy.java 1e4870f9b48e5cc5e4c7ded2af907f4e63aa2977
> geode-core/src/main/java/org/apache/geode/management/internal/configuration/functions/RecreateCacheFunction.java PRE-CREATION
> geode-core/src/main/java/org/apache/geode/management/internal/configuration/functions/RegionsWithDataOnServerFunction.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/extension/mock/MockExtensionCommands.java 1bd4478538f0e0c9413e95a01e835fa6af3a24ea
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ClusterConfigurationServiceCommandsDUnitTest.java 87cac55bc672ed380d3abb8ab69c9499f931e4b3
> geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfig.java c2d511d1c4d34aea434751c2bb5b7e9b924482ad
> geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigBaseTest.java 506428a48c27435a3c89f97bc4d296853fe99415
> geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigImportDUnitTest.java b301b80a1268c8ad0954e9abe86711cdfe5ac066
> geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigStartMemberDUnitTest.java 7dd0da67bdb38f027f717bfc96adc5f5ffc0af37
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/ServerStarterRule.java c94185a3b7f8e82cdab620b79c3cb836d0a7e530
> geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedSerializables.txt 9626be76c35194e07df10d3ad650cb3d2df4d73a
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/cli/LuceneIndexCommands.java 6a5a1e09c03b9a5362e44fd6fe55a6e6181ea17c
> geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/CommandOverHttpDUnitTest.java a1810b6eaa7d940ad359d64faab98c7d113165f0
>
> Diff: https://reviews.apache.org/r/55532/diff/
>
>
> Testing
> -------
>
> precheckin successful
>
>
> Thanks,
>
> Jinmei Liao
>
>
Re: Review Request 55532: GEODE-2198: close and re-create the cache
on a server when importing new cluster configuration
Posted by Kevin Duling <kd...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55532/#review161751
-----------------------------------------------------------
Wouldn't you want all of your lock/release calls to be in a try/finally block? Some are and some are not.
- Kevin Duling
On Jan. 13, 2017, 7:52 p.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55532/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2017, 7:52 p.m.)
>
>
> Review request for geode, Jared Stewart, Kevin Duling, and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> * When importing cluster config first check if there is any non-empty region
> * close and re-create cache if no data exists when importing new cluster configuration
> * put the acquire/release lock inside the ClusterConfigurationService instead of command execution strategy.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/distributed/internal/ClusterConfigurationService.java 1d4030a8dedd017a0ab096925055f375bb5d3ef0
> geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 795164d7a86f87afb60e800885fb5fb2c540451b
> geode-core/src/main/java/org/apache/geode/internal/cache/xmlcache/CacheCreation.java 1c3c93314841f5623c0e6387500af88f106328d9
> geode-core/src/main/java/org/apache/geode/management/cli/CliMetaData.java 2e272fc083514456f0ef89d4b9824126e86828fa
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java 7df4112950cefcc1ae18bdd88cb752cdec5b7de1
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DeployCommands.java f076cec670a4c787fbe4002edfdacde4b025d1bf
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommands.java 14114cff2febf0e1ba7ae67427549ad4fd19ed85
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportImportSharedConfigurationCommands.java 914576b2b24eec670c06510aa5b056c0acd808fc
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/IndexCommands.java bc436ba40e107b931e8d0d10082e26cf068dd56b
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/PDXCommands.java 72d5c0fc65090880b95f37868e72ef9dcba6c55f
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/QueueCommands.java 095bd68f54d0f06d9f9439fcaffbca72e49083fc
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/WanCommands.java cbf589185e94345be6fd64ebd630f76e84cc2a09
> geode-core/src/main/java/org/apache/geode/management/internal/cli/remote/RemoteExecutionStrategy.java 1e4870f9b48e5cc5e4c7ded2af907f4e63aa2977
> geode-core/src/main/java/org/apache/geode/management/internal/configuration/functions/RecreateCacheFunction.java PRE-CREATION
> geode-core/src/main/java/org/apache/geode/management/internal/configuration/functions/RegionsWithDataOnServerFunction.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/extension/mock/MockExtensionCommands.java 1bd4478538f0e0c9413e95a01e835fa6af3a24ea
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ClusterConfigurationServiceCommandsDUnitTest.java 87cac55bc672ed380d3abb8ab69c9499f931e4b3
> geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfig.java c2d511d1c4d34aea434751c2bb5b7e9b924482ad
> geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigBaseTest.java 506428a48c27435a3c89f97bc4d296853fe99415
> geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigImportDUnitTest.java b301b80a1268c8ad0954e9abe86711cdfe5ac066
> geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigStartMemberDUnitTest.java 7dd0da67bdb38f027f717bfc96adc5f5ffc0af37
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/ServerStarterRule.java c94185a3b7f8e82cdab620b79c3cb836d0a7e530
> geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedSerializables.txt 9626be76c35194e07df10d3ad650cb3d2df4d73a
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/cli/LuceneIndexCommands.java 6a5a1e09c03b9a5362e44fd6fe55a6e6181ea17c
> geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/CommandOverHttpDUnitTest.java a1810b6eaa7d940ad359d64faab98c7d113165f0
>
> Diff: https://reviews.apache.org/r/55532/diff/
>
>
> Testing
> -------
>
> precheckin successful
>
>
> Thanks,
>
> Jinmei Liao
>
>
Re: Review Request 55532: GEODE-2198: close and re-create the cache
on a server when importing new cluster configuration
Posted by Jared Stewart <js...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55532/#review161991
-----------------------------------------------------------
geode-core/src/main/java/org/apache/geode/management/internal/configuration/functions/RecreateCacheFunction.java (line 37)
<https://reviews.apache.org/r/55532/#comment233255>
I think that we should use the
```
public CliFunctionResult(final String memberIdOrName, final Throwable throwable,
final String message) {
``` constructor for CliFunctionResult and probably also get a Logger and log `e` or else we'll lose the stack trace when an exception gets thrown
- Jared Stewart
On Jan. 17, 2017, 11:27 p.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55532/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2017, 11:27 p.m.)
>
>
> Review request for geode, Jared Stewart, Kevin Duling, and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> * When importing cluster config first check if there is any non-empty region
> * close and re-create cache if no data exists when importing new cluster configuration
> * put the acquire/release lock inside the ClusterConfigurationService instead of command execution strategy.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/distributed/internal/ClusterConfigurationService.java 1d4030a8dedd017a0ab096925055f375bb5d3ef0
> geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 795164d7a86f87afb60e800885fb5fb2c540451b
> geode-core/src/main/java/org/apache/geode/management/cli/CliMetaData.java 2e272fc083514456f0ef89d4b9824126e86828fa
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java 7df4112950cefcc1ae18bdd88cb752cdec5b7de1
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DeployCommands.java f076cec670a4c787fbe4002edfdacde4b025d1bf
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommands.java 14114cff2febf0e1ba7ae67427549ad4fd19ed85
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportImportSharedConfigurationCommands.java 914576b2b24eec670c06510aa5b056c0acd808fc
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/IndexCommands.java bc436ba40e107b931e8d0d10082e26cf068dd56b
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/PDXCommands.java 72d5c0fc65090880b95f37868e72ef9dcba6c55f
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/QueueCommands.java 095bd68f54d0f06d9f9439fcaffbca72e49083fc
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/WanCommands.java cbf589185e94345be6fd64ebd630f76e84cc2a09
> geode-core/src/main/java/org/apache/geode/management/internal/cli/remote/RemoteExecutionStrategy.java 1e4870f9b48e5cc5e4c7ded2af907f4e63aa2977
> geode-core/src/main/java/org/apache/geode/management/internal/configuration/functions/RecreateCacheFunction.java PRE-CREATION
> geode-core/src/main/java/org/apache/geode/management/internal/configuration/functions/RegionsWithDataOnServerFunction.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/extension/mock/MockExtensionCommands.java 1bd4478538f0e0c9413e95a01e835fa6af3a24ea
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ClusterConfigurationServiceCommandsDUnitTest.java 87cac55bc672ed380d3abb8ab69c9499f931e4b3
> geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfig.java c2d511d1c4d34aea434751c2bb5b7e9b924482ad
> geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigBaseTest.java 506428a48c27435a3c89f97bc4d296853fe99415
> geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigImportDUnitTest.java b301b80a1268c8ad0954e9abe86711cdfe5ac066
> geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigStartMemberDUnitTest.java 7dd0da67bdb38f027f717bfc96adc5f5ffc0af37
> geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigWithSecurityDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/ServerStarterRule.java c94185a3b7f8e82cdab620b79c3cb836d0a7e530
> geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedSerializables.txt 9626be76c35194e07df10d3ad650cb3d2df4d73a
> geode-core/src/test/resources/org/apache/geode/management/internal/configuration/cluster_config_security.zip PRE-CREATION
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/cli/LuceneIndexCommands.java 6a5a1e09c03b9a5362e44fd6fe55a6e6181ea17c
> geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/CommandOverHttpDUnitTest.java a1810b6eaa7d940ad359d64faab98c7d113165f0
>
> Diff: https://reviews.apache.org/r/55532/diff/
>
>
> Testing
> -------
>
> precheckin successful
>
>
> Thanks,
>
> Jinmei Liao
>
>
Re: Review Request 55532: GEODE-2198: close and re-create the cache
on a server when importing new cluster configuration
Posted by Jared Stewart <js...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55532/#review162331
-----------------------------------------------------------
Ship it!
Ship It!
- Jared Stewart
On Jan. 17, 2017, 11:27 p.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55532/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2017, 11:27 p.m.)
>
>
> Review request for geode, Jared Stewart, Kevin Duling, and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> * When importing cluster config first check if there is any non-empty region
> * close and re-create cache if no data exists when importing new cluster configuration
> * put the acquire/release lock inside the ClusterConfigurationService instead of command execution strategy.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/distributed/internal/ClusterConfigurationService.java 1d4030a8dedd017a0ab096925055f375bb5d3ef0
> geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 795164d7a86f87afb60e800885fb5fb2c540451b
> geode-core/src/main/java/org/apache/geode/management/cli/CliMetaData.java 2e272fc083514456f0ef89d4b9824126e86828fa
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java 7df4112950cefcc1ae18bdd88cb752cdec5b7de1
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DeployCommands.java f076cec670a4c787fbe4002edfdacde4b025d1bf
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommands.java 14114cff2febf0e1ba7ae67427549ad4fd19ed85
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportImportSharedConfigurationCommands.java 914576b2b24eec670c06510aa5b056c0acd808fc
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/IndexCommands.java bc436ba40e107b931e8d0d10082e26cf068dd56b
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/PDXCommands.java 72d5c0fc65090880b95f37868e72ef9dcba6c55f
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/QueueCommands.java 095bd68f54d0f06d9f9439fcaffbca72e49083fc
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/WanCommands.java cbf589185e94345be6fd64ebd630f76e84cc2a09
> geode-core/src/main/java/org/apache/geode/management/internal/cli/remote/RemoteExecutionStrategy.java 1e4870f9b48e5cc5e4c7ded2af907f4e63aa2977
> geode-core/src/main/java/org/apache/geode/management/internal/configuration/functions/RecreateCacheFunction.java PRE-CREATION
> geode-core/src/main/java/org/apache/geode/management/internal/configuration/functions/RegionsWithDataOnServerFunction.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/extension/mock/MockExtensionCommands.java 1bd4478538f0e0c9413e95a01e835fa6af3a24ea
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ClusterConfigurationServiceCommandsDUnitTest.java 87cac55bc672ed380d3abb8ab69c9499f931e4b3
> geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfig.java c2d511d1c4d34aea434751c2bb5b7e9b924482ad
> geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigBaseTest.java 506428a48c27435a3c89f97bc4d296853fe99415
> geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigImportDUnitTest.java b301b80a1268c8ad0954e9abe86711cdfe5ac066
> geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigStartMemberDUnitTest.java 7dd0da67bdb38f027f717bfc96adc5f5ffc0af37
> geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigWithSecurityDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/ServerStarterRule.java c94185a3b7f8e82cdab620b79c3cb836d0a7e530
> geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedSerializables.txt 9626be76c35194e07df10d3ad650cb3d2df4d73a
> geode-core/src/test/resources/org/apache/geode/management/internal/configuration/cluster_config_security.zip PRE-CREATION
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/cli/LuceneIndexCommands.java 6a5a1e09c03b9a5362e44fd6fe55a6e6181ea17c
> geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/CommandOverHttpDUnitTest.java a1810b6eaa7d940ad359d64faab98c7d113165f0
>
> Diff: https://reviews.apache.org/r/55532/diff/
>
>
> Testing
> -------
>
> precheckin successful
>
>
> Thanks,
>
> Jinmei Liao
>
>
Re: Review Request 55532: GEODE-2198: close and re-create the cache
on a server when importing new cluster configuration
Posted by Kevin Duling <kd...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55532/#review162318
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Duling
On Jan. 17, 2017, 3:27 p.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55532/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2017, 3:27 p.m.)
>
>
> Review request for geode, Jared Stewart, Kevin Duling, and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> * When importing cluster config first check if there is any non-empty region
> * close and re-create cache if no data exists when importing new cluster configuration
> * put the acquire/release lock inside the ClusterConfigurationService instead of command execution strategy.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/distributed/internal/ClusterConfigurationService.java 1d4030a8dedd017a0ab096925055f375bb5d3ef0
> geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 795164d7a86f87afb60e800885fb5fb2c540451b
> geode-core/src/main/java/org/apache/geode/management/cli/CliMetaData.java 2e272fc083514456f0ef89d4b9824126e86828fa
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java 7df4112950cefcc1ae18bdd88cb752cdec5b7de1
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DeployCommands.java f076cec670a4c787fbe4002edfdacde4b025d1bf
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommands.java 14114cff2febf0e1ba7ae67427549ad4fd19ed85
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportImportSharedConfigurationCommands.java 914576b2b24eec670c06510aa5b056c0acd808fc
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/IndexCommands.java bc436ba40e107b931e8d0d10082e26cf068dd56b
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/PDXCommands.java 72d5c0fc65090880b95f37868e72ef9dcba6c55f
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/QueueCommands.java 095bd68f54d0f06d9f9439fcaffbca72e49083fc
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/WanCommands.java cbf589185e94345be6fd64ebd630f76e84cc2a09
> geode-core/src/main/java/org/apache/geode/management/internal/cli/remote/RemoteExecutionStrategy.java 1e4870f9b48e5cc5e4c7ded2af907f4e63aa2977
> geode-core/src/main/java/org/apache/geode/management/internal/configuration/functions/RecreateCacheFunction.java PRE-CREATION
> geode-core/src/main/java/org/apache/geode/management/internal/configuration/functions/RegionsWithDataOnServerFunction.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/extension/mock/MockExtensionCommands.java 1bd4478538f0e0c9413e95a01e835fa6af3a24ea
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ClusterConfigurationServiceCommandsDUnitTest.java 87cac55bc672ed380d3abb8ab69c9499f931e4b3
> geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfig.java c2d511d1c4d34aea434751c2bb5b7e9b924482ad
> geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigBaseTest.java 506428a48c27435a3c89f97bc4d296853fe99415
> geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigImportDUnitTest.java b301b80a1268c8ad0954e9abe86711cdfe5ac066
> geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigStartMemberDUnitTest.java 7dd0da67bdb38f027f717bfc96adc5f5ffc0af37
> geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigWithSecurityDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/ServerStarterRule.java c94185a3b7f8e82cdab620b79c3cb836d0a7e530
> geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedSerializables.txt 9626be76c35194e07df10d3ad650cb3d2df4d73a
> geode-core/src/test/resources/org/apache/geode/management/internal/configuration/cluster_config_security.zip PRE-CREATION
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/cli/LuceneIndexCommands.java 6a5a1e09c03b9a5362e44fd6fe55a6e6181ea17c
> geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/CommandOverHttpDUnitTest.java a1810b6eaa7d940ad359d64faab98c7d113165f0
>
> Diff: https://reviews.apache.org/r/55532/diff/
>
>
> Testing
> -------
>
> precheckin successful
>
>
> Thanks,
>
> Jinmei Liao
>
>
Re: Review Request 55532: GEODE-2198: close and re-create the cache
on a server when importing new cluster configuration
Posted by Jinmei Liao <ji...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55532/
-----------------------------------------------------------
(Updated Jan. 17, 2017, 11:27 p.m.)
Review request for geode, Jared Stewart, Kevin Duling, and Kirk Lund.
Repository: geode
Description
-------
* When importing cluster config first check if there is any non-empty region
* close and re-create cache if no data exists when importing new cluster configuration
* put the acquire/release lock inside the ClusterConfigurationService instead of command execution strategy.
Diffs (updated)
-----
geode-core/src/main/java/org/apache/geode/distributed/internal/ClusterConfigurationService.java 1d4030a8dedd017a0ab096925055f375bb5d3ef0
geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 795164d7a86f87afb60e800885fb5fb2c540451b
geode-core/src/main/java/org/apache/geode/management/cli/CliMetaData.java 2e272fc083514456f0ef89d4b9824126e86828fa
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java 7df4112950cefcc1ae18bdd88cb752cdec5b7de1
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DeployCommands.java f076cec670a4c787fbe4002edfdacde4b025d1bf
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommands.java 14114cff2febf0e1ba7ae67427549ad4fd19ed85
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportImportSharedConfigurationCommands.java 914576b2b24eec670c06510aa5b056c0acd808fc
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/IndexCommands.java bc436ba40e107b931e8d0d10082e26cf068dd56b
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/PDXCommands.java 72d5c0fc65090880b95f37868e72ef9dcba6c55f
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/QueueCommands.java 095bd68f54d0f06d9f9439fcaffbca72e49083fc
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/WanCommands.java cbf589185e94345be6fd64ebd630f76e84cc2a09
geode-core/src/main/java/org/apache/geode/management/internal/cli/remote/RemoteExecutionStrategy.java 1e4870f9b48e5cc5e4c7ded2af907f4e63aa2977
geode-core/src/main/java/org/apache/geode/management/internal/configuration/functions/RecreateCacheFunction.java PRE-CREATION
geode-core/src/main/java/org/apache/geode/management/internal/configuration/functions/RegionsWithDataOnServerFunction.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/extension/mock/MockExtensionCommands.java 1bd4478538f0e0c9413e95a01e835fa6af3a24ea
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ClusterConfigurationServiceCommandsDUnitTest.java 87cac55bc672ed380d3abb8ab69c9499f931e4b3
geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfig.java c2d511d1c4d34aea434751c2bb5b7e9b924482ad
geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigBaseTest.java 506428a48c27435a3c89f97bc4d296853fe99415
geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigImportDUnitTest.java b301b80a1268c8ad0954e9abe86711cdfe5ac066
geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigStartMemberDUnitTest.java 7dd0da67bdb38f027f717bfc96adc5f5ffc0af37
geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigWithSecurityDUnitTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/test/dunit/rules/ServerStarterRule.java c94185a3b7f8e82cdab620b79c3cb836d0a7e530
geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedSerializables.txt 9626be76c35194e07df10d3ad650cb3d2df4d73a
geode-core/src/test/resources/org/apache/geode/management/internal/configuration/cluster_config_security.zip PRE-CREATION
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/cli/LuceneIndexCommands.java 6a5a1e09c03b9a5362e44fd6fe55a6e6181ea17c
geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/CommandOverHttpDUnitTest.java a1810b6eaa7d940ad359d64faab98c7d113165f0
Diff: https://reviews.apache.org/r/55532/diff/
Testing
-------
precheckin successful
Thanks,
Jinmei Liao
Re: Review Request 55532: GEODE-2198: close and re-create the cache
on a server when importing new cluster configuration
Posted by Jinmei Liao <ji...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55532/
-----------------------------------------------------------
(Updated Jan. 17, 2017, 10:21 p.m.)
Review request for geode, Jared Stewart, Kevin Duling, and Kirk Lund.
Changes
-------
do not overwrite security settings when importing, added a test to cover it.
Repository: geode
Description
-------
* When importing cluster config first check if there is any non-empty region
* close and re-create cache if no data exists when importing new cluster configuration
* put the acquire/release lock inside the ClusterConfigurationService instead of command execution strategy.
Diffs (updated)
-----
geode-core/src/main/java/org/apache/geode/distributed/internal/ClusterConfigurationService.java 1d4030a8dedd017a0ab096925055f375bb5d3ef0
geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigImportDUnitTest.java b301b80a1268c8ad0954e9abe86711cdfe5ac066
geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigWithSecurityDUnitTest.java PRE-CREATION
geode-core/src/test/resources/org/apache/geode/management/internal/configuration/cluster_config_security.zip PRE-CREATION
Diff: https://reviews.apache.org/r/55532/diff/
Testing
-------
precheckin successful
Thanks,
Jinmei Liao
Re: Review Request 55532: GEODE-2198: close and re-create the cache
on a server when importing new cluster configuration
Posted by Jinmei Liao <ji...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55532/
-----------------------------------------------------------
(Updated Jan. 17, 2017, 5:07 a.m.)
Review request for geode, Jared Stewart, Kevin Duling, and Kirk Lund.
Repository: geode
Description
-------
* When importing cluster config first check if there is any non-empty region
* close and re-create cache if no data exists when importing new cluster configuration
* put the acquire/release lock inside the ClusterConfigurationService instead of command execution strategy.
Diffs (updated)
-----
geode-core/src/main/java/org/apache/geode/distributed/internal/ClusterConfigurationService.java 1d4030a8dedd017a0ab096925055f375bb5d3ef0
geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 795164d7a86f87afb60e800885fb5fb2c540451b
geode-core/src/main/java/org/apache/geode/management/cli/CliMetaData.java 2e272fc083514456f0ef89d4b9824126e86828fa
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java 7df4112950cefcc1ae18bdd88cb752cdec5b7de1
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DeployCommands.java f076cec670a4c787fbe4002edfdacde4b025d1bf
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommands.java 14114cff2febf0e1ba7ae67427549ad4fd19ed85
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportImportSharedConfigurationCommands.java 914576b2b24eec670c06510aa5b056c0acd808fc
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/IndexCommands.java bc436ba40e107b931e8d0d10082e26cf068dd56b
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/PDXCommands.java 72d5c0fc65090880b95f37868e72ef9dcba6c55f
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/QueueCommands.java 095bd68f54d0f06d9f9439fcaffbca72e49083fc
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/WanCommands.java cbf589185e94345be6fd64ebd630f76e84cc2a09
geode-core/src/main/java/org/apache/geode/management/internal/cli/remote/RemoteExecutionStrategy.java 1e4870f9b48e5cc5e4c7ded2af907f4e63aa2977
geode-core/src/main/java/org/apache/geode/management/internal/configuration/functions/RecreateCacheFunction.java PRE-CREATION
geode-core/src/main/java/org/apache/geode/management/internal/configuration/functions/RegionsWithDataOnServerFunction.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/extension/mock/MockExtensionCommands.java 1bd4478538f0e0c9413e95a01e835fa6af3a24ea
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ClusterConfigurationServiceCommandsDUnitTest.java 87cac55bc672ed380d3abb8ab69c9499f931e4b3
geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfig.java c2d511d1c4d34aea434751c2bb5b7e9b924482ad
geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigBaseTest.java 506428a48c27435a3c89f97bc4d296853fe99415
geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigImportDUnitTest.java b301b80a1268c8ad0954e9abe86711cdfe5ac066
geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigStartMemberDUnitTest.java 7dd0da67bdb38f027f717bfc96adc5f5ffc0af37
geode-core/src/test/java/org/apache/geode/test/dunit/rules/ServerStarterRule.java c94185a3b7f8e82cdab620b79c3cb836d0a7e530
geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedSerializables.txt 9626be76c35194e07df10d3ad650cb3d2df4d73a
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/cli/LuceneIndexCommands.java 6a5a1e09c03b9a5362e44fd6fe55a6e6181ea17c
geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/CommandOverHttpDUnitTest.java a1810b6eaa7d940ad359d64faab98c7d113165f0
Diff: https://reviews.apache.org/r/55532/diff/
Testing
-------
precheckin successful
Thanks,
Jinmei Liao