You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jesse Daniels (JIRA)" <ji...@apache.org> on 2011/03/11 05:24:59 UTC

[jira] Created: (HBASE-3624) Only one coprocessor of each priority type can be loaded for a table

Only one coprocessor of each priority type can be loaded for a table
--------------------------------------------------------------------

                 Key: HBASE-3624
                 URL: https://issues.apache.org/jira/browse/HBASE-3624
             Project: HBase
          Issue Type: Bug
          Components: coprocessors
    Affects Versions: 0.92.0
         Environment: Standalone HBase, linux
            Reporter: Jesse Daniels


Coprocessors are added to HBase using a TreeSet that is initialized with an EnvironmentPriorityComparator. The net effect is that only one coprocessor of a given priority can be loaded at a time for a given table. This appears to be due to how the TreeSet uses the EnvironmentPriorityComparator to determine whether there are duplicate entries - if the coprocessors have the same priority (e.g., User), they are considered the same and won't be added to the Set.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (HBASE-3624) Only one coprocessor of each priority type can be loaded for a table

Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-3624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Purtell reassigned HBASE-3624:
-------------------------------------

    Assignee: Andrew Purtell

> Only one coprocessor of each priority type can be loaded for a table
> --------------------------------------------------------------------
>
>                 Key: HBASE-3624
>                 URL: https://issues.apache.org/jira/browse/HBASE-3624
>             Project: HBase
>          Issue Type: Bug
>          Components: coprocessors
>    Affects Versions: 0.92.0
>         Environment: Standalone HBase, linux
>            Reporter: Jesse Daniels
>            Assignee: Andrew Purtell
>
> Coprocessors are added to HBase using a TreeSet that is initialized with an EnvironmentPriorityComparator. The net effect is that only one coprocessor of a given priority can be loaded at a time for a given table. This appears to be due to how the TreeSet uses the EnvironmentPriorityComparator to determine whether there are duplicate entries - if the coprocessors have the same priority (e.g., User), they are considered the same and won't be added to the Set.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-3624) Only one coprocessor of each priority type can be loaded for a table

Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-3624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Purtell updated HBASE-3624:
----------------------------------

      Resolution: Fixed
    Hadoop Flags: [Reviewed]
          Status: Resolved  (was: Patch Available)

Committed to trunk including Gary's suggest change.

> Only one coprocessor of each priority type can be loaded for a table
> --------------------------------------------------------------------
>
>                 Key: HBASE-3624
>                 URL: https://issues.apache.org/jira/browse/HBASE-3624
>             Project: HBase
>          Issue Type: Bug
>          Components: coprocessors
>    Affects Versions: 0.92.0
>         Environment: Standalone HBase, linux
>            Reporter: Jesse Daniels
>            Assignee: Andrew Purtell
>             Fix For: 0.92.0
>
>         Attachments: HBASE-3624.patch
>
>
> Coprocessors are added to HBase using a TreeSet that is initialized with an EnvironmentPriorityComparator. The net effect is that only one coprocessor of a given priority can be loaded at a time for a given table. This appears to be due to how the TreeSet uses the EnvironmentPriorityComparator to determine whether there are duplicate entries - if the coprocessors have the same priority (e.g., User), they are considered the same and won't be added to the Set.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-3624) Only one coprocessor of each priority type can be loaded for a table

Posted by "Gary Helmling (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-3624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13017243#comment-13017243 ] 

Gary Helmling commented on HBASE-3624:
--------------------------------------

+1

In CoprocessorHost, though, I don't think we need this change:
{noformat}
-  public E load(Path path, String className, Coprocessor.Priority priority)
+  public E load(Path path, String className, Coprocessor.Priority priority, int seq)
{noformat}

since the counter will still be incremented down in loadInstance()?  You want to remove it (and usage in RegionCoprocessorHost.loadTableCoprocessors()) on commit?



> Only one coprocessor of each priority type can be loaded for a table
> --------------------------------------------------------------------
>
>                 Key: HBASE-3624
>                 URL: https://issues.apache.org/jira/browse/HBASE-3624
>             Project: HBase
>          Issue Type: Bug
>          Components: coprocessors
>    Affects Versions: 0.92.0
>         Environment: Standalone HBase, linux
>            Reporter: Jesse Daniels
>            Assignee: Andrew Purtell
>             Fix For: 0.92.0
>
>         Attachments: HBASE-3624.patch
>
>
> Coprocessors are added to HBase using a TreeSet that is initialized with an EnvironmentPriorityComparator. The net effect is that only one coprocessor of a given priority can be loaded at a time for a given table. This appears to be due to how the TreeSet uses the EnvironmentPriorityComparator to determine whether there are duplicate entries - if the coprocessors have the same priority (e.g., User), they are considered the same and won't be added to the Set.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-3624) Only one coprocessor of each priority type can be loaded for a table

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-3624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13018777#comment-13018777 ] 

Hudson commented on HBASE-3624:
-------------------------------

Integrated in HBase-TRUNK #1846 (See [https://hudson.apache.org/hudson/job/HBase-TRUNK/1846/])
    

> Only one coprocessor of each priority type can be loaded for a table
> --------------------------------------------------------------------
>
>                 Key: HBASE-3624
>                 URL: https://issues.apache.org/jira/browse/HBASE-3624
>             Project: HBase
>          Issue Type: Bug
>          Components: coprocessors
>    Affects Versions: 0.92.0
>         Environment: Standalone HBase, linux
>            Reporter: Jesse Daniels
>            Assignee: Andrew Purtell
>             Fix For: 0.92.0
>
>         Attachments: HBASE-3624.patch
>
>
> Coprocessors are added to HBase using a TreeSet that is initialized with an EnvironmentPriorityComparator. The net effect is that only one coprocessor of a given priority can be loaded at a time for a given table. This appears to be due to how the TreeSet uses the EnvironmentPriorityComparator to determine whether there are duplicate entries - if the coprocessors have the same priority (e.g., User), they are considered the same and won't be added to the Set.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-3624) Only one coprocessor of each priority type can be loaded for a table

Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-3624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Purtell updated HBASE-3624:
----------------------------------

    Attachment: HBASE-3624.patch

> Only one coprocessor of each priority type can be loaded for a table
> --------------------------------------------------------------------
>
>                 Key: HBASE-3624
>                 URL: https://issues.apache.org/jira/browse/HBASE-3624
>             Project: HBase
>          Issue Type: Bug
>          Components: coprocessors
>    Affects Versions: 0.92.0
>         Environment: Standalone HBase, linux
>            Reporter: Jesse Daniels
>            Assignee: Andrew Purtell
>         Attachments: HBASE-3624.patch
>
>
> Coprocessors are added to HBase using a TreeSet that is initialized with an EnvironmentPriorityComparator. The net effect is that only one coprocessor of a given priority can be loaded at a time for a given table. This appears to be due to how the TreeSet uses the EnvironmentPriorityComparator to determine whether there are duplicate entries - if the coprocessors have the same priority (e.g., User), they are considered the same and won't be added to the Set.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-3624) Only one coprocessor of each priority type can be loaded for a table

Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-3624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Purtell updated HBASE-3624:
----------------------------------

    Fix Version/s: 0.92.0
           Status: Patch Available  (was: Open)

> Only one coprocessor of each priority type can be loaded for a table
> --------------------------------------------------------------------
>
>                 Key: HBASE-3624
>                 URL: https://issues.apache.org/jira/browse/HBASE-3624
>             Project: HBase
>          Issue Type: Bug
>          Components: coprocessors
>    Affects Versions: 0.92.0
>         Environment: Standalone HBase, linux
>            Reporter: Jesse Daniels
>            Assignee: Andrew Purtell
>             Fix For: 0.92.0
>
>         Attachments: HBASE-3624.patch
>
>
> Coprocessors are added to HBase using a TreeSet that is initialized with an EnvironmentPriorityComparator. The net effect is that only one coprocessor of a given priority can be loaded at a time for a given table. This appears to be due to how the TreeSet uses the EnvironmentPriorityComparator to determine whether there are duplicate entries - if the coprocessors have the same priority (e.g., User), they are considered the same and won't be added to the Set.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira