You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/02/04 05:50:23 UTC
[GitHub] [activemq-website] lucastetreault opened a new pull request #39: Simpler ActiveMQ Classic Version Release
lucastetreault opened a new pull request #39:
URL: https://github.com/apache/activemq-website/pull/39
Make it simpler to release a new version by:
1. Templating the detailed download page (e.g.: https://activemq.apache.org/activemq-5161-release) to reduce copy/pasting
2. Building the [past releases](https://activemq.apache.org/download-archives) page programatically
3. Maintaining the current versions in _config.yml and automatically updating the [current releases](https://activemq.apache.org/components/classic/download/)
I renamed all the activemq-{{version}}-release.md files so that I could use the file names to sort the releases on the past releases page and for finding the latest patch release of a minor release. To preserve the old URLs I included a plugin called jekyll-redirect-from and configured redirects for all existing releases. Future releases won't need the redirect and can be published with the updated filename format.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-website] lucastetreault commented on pull request #39: Simpler ActiveMQ Classic Version Release
Posted by GitBox <gi...@apache.org>.
lucastetreault commented on pull request #39:
URL: https://github.com/apache/activemq-website/pull/39#issuecomment-773528101
Addressed feedback in another commit! Let me know if there's anything else :+1:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-website] gemmellr commented on pull request #39: Simpler ActiveMQ Classic Version Release
Posted by GitBox <gi...@apache.org>.
gemmellr commented on pull request #39:
URL: https://github.com/apache/activemq-website/pull/39#issuecomment-775267994
I have just applied your few PRs, as JB didnt yet have any additional feedback beyond my own, and further changes are easily made afterwards. I did make a tiny change to fix an issue with the past releases page not working (and then update my fix as it sporadically provoked a warning about an error, heh, though it did seem to work fine).
I have also since removed all the really really old release pages < 5.x (but not the really old 5.x ones) as mentioned on the other PR, and reworked the 5.16.1 release detail file a touch to improve things further and make it even less effort to add another based on it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-website] asfgit closed pull request #39: Simpler ActiveMQ Classic Version Release
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #39:
URL: https://github.com/apache/activemq-website/pull/39
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-website] gemmellr commented on a change in pull request #39: Simpler ActiveMQ Classic Version Release
Posted by GitBox <gi...@apache.org>.
gemmellr commented on a change in pull request #39:
URL: https://github.com/apache/activemq-website/pull/39#discussion_r570381353
##########
File path: README.md
##########
@@ -47,3 +47,22 @@ If you are a committer, do the following:
4. The CI build will run and commit the generated site to the `asf-site` branch automatically within a few minutes, from where it will also be published. CI build status mails go to the commits list.
4. Verify the updated website works as expected by browsing it.
+Add a new ActiveMQ Classic Release
Review comment:
I also think this section would be better somewhere other than the main readme. Either a new file, or the 5.x release guide page at src/release-guide.md
The latter is out of date generally, but seems the appropriate place for this should be. In either case the readme could then link to it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-website] jbonofre commented on a change in pull request #39: Simpler ActiveMQ Classic Version Release
Posted by GitBox <gi...@apache.org>.
jbonofre commented on a change in pull request #39:
URL: https://github.com/apache/activemq-website/pull/39#discussion_r570342424
##########
File path: src/_layouts/release.md
##########
@@ -1,23 +1,20 @@
---
layout: default_md
-title: ActiveMQ 5.15.13 Release
-title-class: page-title-activemq5
-type: activemq5
---
-[Overview](overview) > [Download](download) > [ActiveMQ 5.15.13 Release](activemq-51513-release)
+[Overview](overview) > [Download](download) > [ActiveMQ {{page.version}} Release](activemq-51513-release)
-ActiveMQ 5.15.13 Release
+ActiveMQ {{page.version}} Release
-----------------------
-Apache ActiveMQ 5.15.13 includes several resolved[ issues](https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311210&version=12347002) and bug fixes.
+{{content}}
### Getting the Binary Distributions
Description|Download Link|_Verify_
---|---|---
-Windows Distribution|[apache-activemq-5.15.13-bin.zip](https://archive.apache.org/dist/activemq/5.15.13/apache-activemq-5.15.13-bin.zip)|[ASC](https://archive.apache.org/dist/activemq/5.15.13/apache-activemq-5.15.13-bin.zip.asc), [SHA512](https://archive.apache.org/dist/activemq/5.15.13/apache-activemq-5.15.13-bin.zip.sha512)
-Unix/Linux/Cygwin Distribution|[apache-activemq-5.15.13-bin.tar.gz](https://archive.apache.org/dist/activemq/5.15.13/apache-activemq-5.15.13-bin.tar.gz)|[ASC](https://archive.apache.org/dist/activemq/5.15.13/apache-activemq-5.15.13-bin.tar.gz.asc), [SHA512](https://archive.apache.org/dist/activemq/5.15.13/apache-activemq-5.15.13-bin.tar.gz.sha512)
+Windows Distribution|[apache-activemq-{{page.version}}-bin.zip](https://archive.apache.org/dist/activemq/{{page.version}}/apache-activemq-{{page.version}}-bin.zip)|[ASC](https://archive.apache.org/dist/activemq/{{page.version}}/apache-activemq-{{page.version}}-bin.zip.asc), [SHA512](https://archive.apache.org/dist/activemq/{{page.version}}/apache-activemq-{{page.version}}-bin.zip.sha512)
+Unix/Linux/Cygwin Distribution|[apache-activemq-{{page.version}}-bin.tar.gz](https://archive.apache.org/dist/activemq/{{page.version}}/apache-activemq-{{page.version}}-bin.tar.gz)|[ASC](https://archive.apache.org/dist/activemq/{{page.version}}/apache-activemq-{{page.version}}-bin.tar.gz.asc), [SHA512](https://archive.apache.org/dist/activemq/{{page.version}}/apache-activemq-{{page.version}}-bin.tar.gz.sha512)
Review comment:
Correct: for "active" download (basically, the one located on https://dist.apache.org/repos/dist/release/activemq/), the download link is not archive.
Archive is used for "old" release (automatically copied from dist): https://archive.apache.org/dist/activemq/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-website] lucastetreault commented on pull request #39: Simpler ActiveMQ Classic Version Release
Posted by GitBox <gi...@apache.org>.
lucastetreault commented on pull request #39:
URL: https://github.com/apache/activemq-website/pull/39#issuecomment-773528101
Addressed feedback in another commit! Let me know if there's anything else :+1:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-website] gemmellr edited a comment on pull request #39: Simpler ActiveMQ Classic Version Release
Posted by GitBox <gi...@apache.org>.
gemmellr edited a comment on pull request #39:
URL: https://github.com/apache/activemq-website/pull/39#issuecomment-775267994
I have just applied your few PRs, as JB didnt yet have any additional feedback beyond my own, and further changes are easily made afterwards. I did make a tiny change to fix an issue with the past releases page not working (and then update my fix as it sporadically provoked a warning about an error, heh, though it did seem to work fine).
I have also since removed all the really really old release pages < 5.x (but not the really old 5.x ones) as mentioned on the other PR, and reworked the 5.16.1 release detail file a touch to improve things further and make it even less effort to add another based on it.
Thanks for the contribution!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-website] gemmellr commented on a change in pull request #39: Simpler ActiveMQ Classic Version Release
Posted by GitBox <gi...@apache.org>.
gemmellr commented on a change in pull request #39:
URL: https://github.com/apache/activemq-website/pull/39#discussion_r570381353
##########
File path: README.md
##########
@@ -47,3 +47,22 @@ If you are a committer, do the following:
4. The CI build will run and commit the generated site to the `asf-site` branch automatically within a few minutes, from where it will also be published. CI build status mails go to the commits list.
4. Verify the updated website works as expected by browsing it.
+Add a new ActiveMQ Classic Release
Review comment:
I also think these sections would be better somewhere other than the main readme. Either a new file, or the 5.x release guide page at src/release-guide.md
The latter is out of date generally, but seems the appropriate place for this should be. In either case the readme could then link to it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-website] jbonofre commented on a change in pull request #39: Simpler ActiveMQ Classic Version Release
Posted by GitBox <gi...@apache.org>.
jbonofre commented on a change in pull request #39:
URL: https://github.com/apache/activemq-website/pull/39#discussion_r570342424
##########
File path: src/_layouts/release.md
##########
@@ -1,23 +1,20 @@
---
layout: default_md
-title: ActiveMQ 5.15.13 Release
-title-class: page-title-activemq5
-type: activemq5
---
-[Overview](overview) > [Download](download) > [ActiveMQ 5.15.13 Release](activemq-51513-release)
+[Overview](overview) > [Download](download) > [ActiveMQ {{page.version}} Release](activemq-51513-release)
-ActiveMQ 5.15.13 Release
+ActiveMQ {{page.version}} Release
-----------------------
-Apache ActiveMQ 5.15.13 includes several resolved[ issues](https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311210&version=12347002) and bug fixes.
+{{content}}
### Getting the Binary Distributions
Description|Download Link|_Verify_
---|---|---
-Windows Distribution|[apache-activemq-5.15.13-bin.zip](https://archive.apache.org/dist/activemq/5.15.13/apache-activemq-5.15.13-bin.zip)|[ASC](https://archive.apache.org/dist/activemq/5.15.13/apache-activemq-5.15.13-bin.zip.asc), [SHA512](https://archive.apache.org/dist/activemq/5.15.13/apache-activemq-5.15.13-bin.zip.sha512)
-Unix/Linux/Cygwin Distribution|[apache-activemq-5.15.13-bin.tar.gz](https://archive.apache.org/dist/activemq/5.15.13/apache-activemq-5.15.13-bin.tar.gz)|[ASC](https://archive.apache.org/dist/activemq/5.15.13/apache-activemq-5.15.13-bin.tar.gz.asc), [SHA512](https://archive.apache.org/dist/activemq/5.15.13/apache-activemq-5.15.13-bin.tar.gz.sha512)
+Windows Distribution|[apache-activemq-{{page.version}}-bin.zip](https://archive.apache.org/dist/activemq/{{page.version}}/apache-activemq-{{page.version}}-bin.zip)|[ASC](https://archive.apache.org/dist/activemq/{{page.version}}/apache-activemq-{{page.version}}-bin.zip.asc), [SHA512](https://archive.apache.org/dist/activemq/{{page.version}}/apache-activemq-{{page.version}}-bin.zip.sha512)
+Unix/Linux/Cygwin Distribution|[apache-activemq-{{page.version}}-bin.tar.gz](https://archive.apache.org/dist/activemq/{{page.version}}/apache-activemq-{{page.version}}-bin.tar.gz)|[ASC](https://archive.apache.org/dist/activemq/{{page.version}}/apache-activemq-{{page.version}}-bin.tar.gz.asc), [SHA512](https://archive.apache.org/dist/activemq/{{page.version}}/apache-activemq-{{page.version}}-bin.tar.gz.sha512)
Review comment:
Correct: for "active" download (basically, the one located on https://dist.apache.org/repos/dist/release/activemq/), the download link is not archive.
Archive is used for "old" release (automatically copied from dist): https://archive.apache.org/dist/activemq/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-website] gemmellr commented on a change in pull request #39: Simpler ActiveMQ Classic Version Release
Posted by GitBox <gi...@apache.org>.
gemmellr commented on a change in pull request #39:
URL: https://github.com/apache/activemq-website/pull/39#discussion_r570308367
##########
File path: src/_layouts/release.md
##########
@@ -70,15 +67,30 @@ Getting the Source Code
Description|Download Link|Verify
---|---|---
-Source Release|[activemq-parent-5.15.13-source-release.zip](https://archive.apache.org/dist/activemq/5.15.13/activemq-parent-5.15.13-source-release.zip)|[ASC](https://archive.apache.org/dist/activemq/5.15.13/activemq-parent-5.15.13-source-release.zip.asc), [SHA512](https://archive.apache.org/dist/activemq/5.15.13/activemq-parent-5.15.13-source-release.zip.sha512)
+Source Release|[activemq-parent-{{page.version}}-source-release.zip](https://archive.apache.org/dist/activemq/{{page.version}}/activemq-parent-{{page.version}}-source-release.zip)|[ASC](https://archive.apache.org/dist/activemq/{{page.version}}/activemq-parent-{{page.version}}-source-release.zip.asc), [SHA512](https://archive.apache.org/dist/activemq/{{page.version}}/activemq-parent-{{page.version}}-source-release.zip.sha512)
Review comment:
As earlier comment.
##########
File path: src/_layouts/release.md
##########
@@ -1,23 +1,20 @@
---
layout: default_md
-title: ActiveMQ 5.15.13 Release
-title-class: page-title-activemq5
-type: activemq5
---
-[Overview](overview) > [Download](download) > [ActiveMQ 5.15.13 Release](activemq-51513-release)
+[Overview](overview) > [Download](download) > [ActiveMQ {{page.version}} Release](activemq-51513-release)
-ActiveMQ 5.15.13 Release
+ActiveMQ {{page.version}} Release
-----------------------
-Apache ActiveMQ 5.15.13 includes several resolved[ issues](https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311210&version=12347002) and bug fixes.
+{{content}}
### Getting the Binary Distributions
Description|Download Link|_Verify_
---|---|---
-Windows Distribution|[apache-activemq-5.15.13-bin.zip](https://archive.apache.org/dist/activemq/5.15.13/apache-activemq-5.15.13-bin.zip)|[ASC](https://archive.apache.org/dist/activemq/5.15.13/apache-activemq-5.15.13-bin.zip.asc), [SHA512](https://archive.apache.org/dist/activemq/5.15.13/apache-activemq-5.15.13-bin.zip.sha512)
-Unix/Linux/Cygwin Distribution|[apache-activemq-5.15.13-bin.tar.gz](https://archive.apache.org/dist/activemq/5.15.13/apache-activemq-5.15.13-bin.tar.gz)|[ASC](https://archive.apache.org/dist/activemq/5.15.13/apache-activemq-5.15.13-bin.tar.gz.asc), [SHA512](https://archive.apache.org/dist/activemq/5.15.13/apache-activemq-5.15.13-bin.tar.gz.sha512)
+Windows Distribution|[apache-activemq-{{page.version}}-bin.zip](https://archive.apache.org/dist/activemq/{{page.version}}/apache-activemq-{{page.version}}-bin.zip)|[ASC](https://archive.apache.org/dist/activemq/{{page.version}}/apache-activemq-{{page.version}}-bin.zip.asc), [SHA512](https://archive.apache.org/dist/activemq/{{page.version}}/apache-activemq-{{page.version}}-bin.zip.sha512)
+Unix/Linux/Cygwin Distribution|[apache-activemq-{{page.version}}-bin.tar.gz](https://archive.apache.org/dist/activemq/{{page.version}}/apache-activemq-{{page.version}}-bin.tar.gz)|[ASC](https://archive.apache.org/dist/activemq/{{page.version}}/apache-activemq-{{page.version}}-bin.tar.gz.asc), [SHA512](https://archive.apache.org/dist/activemq/{{page.version}}/apache-activemq-{{page.version}}-bin.tar.gz.sha512)
Review comment:
The archive links should go the download mirrors for the current release(s), not the archive, like the main download page. See the existing 5.16.1 release page this change would replace, for example. Same for the source links below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-website] gemmellr commented on a change in pull request #39: Simpler ActiveMQ Classic Version Release
Posted by GitBox <gi...@apache.org>.
gemmellr commented on a change in pull request #39:
URL: https://github.com/apache/activemq-website/pull/39#discussion_r570401171
##########
File path: _config.yml
##########
@@ -3,27 +3,45 @@ title: ActiveMQ
email:
author:
description:
- url: http://apache.activemq.org
+ url: http://apache.activemq.org
# Build settings
permalink: none
# permalink: :title/
sass:
sass_dir: css/
+collections:
+ releases:
+ output: true
+ permalink: /:name
+
+current_releases:
+ - 5.16
+ - 5.15
+
Review comment:
Another thought...since there are multiple components and others could similarly use this approach, we should probably make these variable namings more specific for clarity...e.g. 5x_releases, current_5x_releases
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-website] gemmellr commented on a change in pull request #39: Simpler ActiveMQ Classic Version Release
Posted by GitBox <gi...@apache.org>.
gemmellr commented on a change in pull request #39:
URL: https://github.com/apache/activemq-website/pull/39#discussion_r570308367
##########
File path: src/_layouts/release.md
##########
@@ -70,15 +67,30 @@ Getting the Source Code
Description|Download Link|Verify
---|---|---
-Source Release|[activemq-parent-5.15.13-source-release.zip](https://archive.apache.org/dist/activemq/5.15.13/activemq-parent-5.15.13-source-release.zip)|[ASC](https://archive.apache.org/dist/activemq/5.15.13/activemq-parent-5.15.13-source-release.zip.asc), [SHA512](https://archive.apache.org/dist/activemq/5.15.13/activemq-parent-5.15.13-source-release.zip.sha512)
+Source Release|[activemq-parent-{{page.version}}-source-release.zip](https://archive.apache.org/dist/activemq/{{page.version}}/activemq-parent-{{page.version}}-source-release.zip)|[ASC](https://archive.apache.org/dist/activemq/{{page.version}}/activemq-parent-{{page.version}}-source-release.zip.asc), [SHA512](https://archive.apache.org/dist/activemq/{{page.version}}/activemq-parent-{{page.version}}-source-release.zip.sha512)
Review comment:
As earlier comment.
##########
File path: src/_layouts/release.md
##########
@@ -1,23 +1,20 @@
---
layout: default_md
-title: ActiveMQ 5.15.13 Release
-title-class: page-title-activemq5
-type: activemq5
---
-[Overview](overview) > [Download](download) > [ActiveMQ 5.15.13 Release](activemq-51513-release)
+[Overview](overview) > [Download](download) > [ActiveMQ {{page.version}} Release](activemq-51513-release)
-ActiveMQ 5.15.13 Release
+ActiveMQ {{page.version}} Release
-----------------------
-Apache ActiveMQ 5.15.13 includes several resolved[ issues](https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311210&version=12347002) and bug fixes.
+{{content}}
### Getting the Binary Distributions
Description|Download Link|_Verify_
---|---|---
-Windows Distribution|[apache-activemq-5.15.13-bin.zip](https://archive.apache.org/dist/activemq/5.15.13/apache-activemq-5.15.13-bin.zip)|[ASC](https://archive.apache.org/dist/activemq/5.15.13/apache-activemq-5.15.13-bin.zip.asc), [SHA512](https://archive.apache.org/dist/activemq/5.15.13/apache-activemq-5.15.13-bin.zip.sha512)
-Unix/Linux/Cygwin Distribution|[apache-activemq-5.15.13-bin.tar.gz](https://archive.apache.org/dist/activemq/5.15.13/apache-activemq-5.15.13-bin.tar.gz)|[ASC](https://archive.apache.org/dist/activemq/5.15.13/apache-activemq-5.15.13-bin.tar.gz.asc), [SHA512](https://archive.apache.org/dist/activemq/5.15.13/apache-activemq-5.15.13-bin.tar.gz.sha512)
+Windows Distribution|[apache-activemq-{{page.version}}-bin.zip](https://archive.apache.org/dist/activemq/{{page.version}}/apache-activemq-{{page.version}}-bin.zip)|[ASC](https://archive.apache.org/dist/activemq/{{page.version}}/apache-activemq-{{page.version}}-bin.zip.asc), [SHA512](https://archive.apache.org/dist/activemq/{{page.version}}/apache-activemq-{{page.version}}-bin.zip.sha512)
+Unix/Linux/Cygwin Distribution|[apache-activemq-{{page.version}}-bin.tar.gz](https://archive.apache.org/dist/activemq/{{page.version}}/apache-activemq-{{page.version}}-bin.tar.gz)|[ASC](https://archive.apache.org/dist/activemq/{{page.version}}/apache-activemq-{{page.version}}-bin.tar.gz.asc), [SHA512](https://archive.apache.org/dist/activemq/{{page.version}}/apache-activemq-{{page.version}}-bin.tar.gz.sha512)
Review comment:
The archive links should go the download mirrors for the current release(s), not the archive, like the main download page. See the existing 5.16.1 release page this change would replace, for example. Same for the source links below.
##########
File path: src/_layouts/release.md
##########
@@ -1,23 +1,20 @@
---
layout: default_md
-title: ActiveMQ 5.15.13 Release
-title-class: page-title-activemq5
-type: activemq5
---
-[Overview](overview) > [Download](download) > [ActiveMQ 5.15.13 Release](activemq-51513-release)
+[Overview](overview) > [Download](download) > [ActiveMQ {{page.version}} Release](activemq-51513-release)
-ActiveMQ 5.15.13 Release
+ActiveMQ {{page.version}} Release
-----------------------
-Apache ActiveMQ 5.15.13 includes several resolved[ issues](https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311210&version=12347002) and bug fixes.
+{{content}}
### Getting the Binary Distributions
Description|Download Link|_Verify_
---|---|---
-Windows Distribution|[apache-activemq-5.15.13-bin.zip](https://archive.apache.org/dist/activemq/5.15.13/apache-activemq-5.15.13-bin.zip)|[ASC](https://archive.apache.org/dist/activemq/5.15.13/apache-activemq-5.15.13-bin.zip.asc), [SHA512](https://archive.apache.org/dist/activemq/5.15.13/apache-activemq-5.15.13-bin.zip.sha512)
-Unix/Linux/Cygwin Distribution|[apache-activemq-5.15.13-bin.tar.gz](https://archive.apache.org/dist/activemq/5.15.13/apache-activemq-5.15.13-bin.tar.gz)|[ASC](https://archive.apache.org/dist/activemq/5.15.13/apache-activemq-5.15.13-bin.tar.gz.asc), [SHA512](https://archive.apache.org/dist/activemq/5.15.13/apache-activemq-5.15.13-bin.tar.gz.sha512)
+Windows Distribution|[apache-activemq-{{page.version}}-bin.zip](https://archive.apache.org/dist/activemq/{{page.version}}/apache-activemq-{{page.version}}-bin.zip)|[ASC](https://archive.apache.org/dist/activemq/{{page.version}}/apache-activemq-{{page.version}}-bin.zip.asc), [SHA512](https://archive.apache.org/dist/activemq/{{page.version}}/apache-activemq-{{page.version}}-bin.zip.sha512)
+Unix/Linux/Cygwin Distribution|[apache-activemq-{{page.version}}-bin.tar.gz](https://archive.apache.org/dist/activemq/{{page.version}}/apache-activemq-{{page.version}}-bin.tar.gz)|[ASC](https://archive.apache.org/dist/activemq/{{page.version}}/apache-activemq-{{page.version}}-bin.tar.gz.asc), [SHA512](https://archive.apache.org/dist/activemq/{{page.version}}/apache-activemq-{{page.version}}-bin.tar.gz.sha512)
Review comment:
The tar/zip links should go the download mirrors for the current release(s), not the archive, like the main download page. See the existing 5.16.1 release page this change would replace, for example. Same for the source links below.
##########
File path: README.md
##########
@@ -47,3 +47,22 @@ If you are a committer, do the following:
4. The CI build will run and commit the generated site to the `asf-site` branch automatically within a few minutes, from where it will also be published. CI build status mails go to the commits list.
4. Verify the updated website works as expected by browsing it.
+Add a new ActiveMQ Classic Release
Review comment:
I also think this section would be better somewhere other than the main readme. Either a new file, or the 5.x release guide page at src/release-guide.md
The latter is out of date generally, but seems the appropriate place for this should be. In either case the readme could then link to it.
##########
File path: README.md
##########
@@ -47,3 +47,22 @@ If you are a committer, do the following:
4. The CI build will run and commit the generated site to the `asf-site` branch automatically within a few minutes, from where it will also be published. CI build status mails go to the commits list.
4. Verify the updated website works as expected by browsing it.
+Add a new ActiveMQ Classic Release
Review comment:
I also think these sections would be better somewhere other than the main readme. Either a new file, or the 5.x release guide page at src/release-guide.md
The latter is out of date generally, but seems the appropriate place for this should be. In either case the readme could then link to it.
##########
File path: _config.yml
##########
@@ -3,27 +3,45 @@ title: ActiveMQ
email:
author:
description:
- url: http://apache.activemq.org
+ url: http://apache.activemq.org
# Build settings
permalink: none
# permalink: :title/
sass:
sass_dir: css/
+collections:
+ releases:
+ output: true
+ permalink: /:name
+
+current_releases:
+ - 5.16
+ - 5.15
+
Review comment:
Another thought...since there are multiple components and others could similarly use this approach, we should probably make these variable namings more specific for clarity...e.g. 5x_releases, current_5x_releases
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-website] gemmellr commented on a change in pull request #39: Simpler ActiveMQ Classic Version Release
Posted by GitBox <gi...@apache.org>.
gemmellr commented on a change in pull request #39:
URL: https://github.com/apache/activemq-website/pull/39#discussion_r570307993
##########
File path: src/_layouts/release.md
##########
@@ -1,23 +1,20 @@
---
layout: default_md
-title: ActiveMQ 5.15.13 Release
-title-class: page-title-activemq5
-type: activemq5
---
-[Overview](overview) > [Download](download) > [ActiveMQ 5.15.13 Release](activemq-51513-release)
+[Overview](overview) > [Download](download) > [ActiveMQ {{page.version}} Release](activemq-51513-release)
-ActiveMQ 5.15.13 Release
+ActiveMQ {{page.version}} Release
-----------------------
-Apache ActiveMQ 5.15.13 includes several resolved[ issues](https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311210&version=12347002) and bug fixes.
+{{content}}
### Getting the Binary Distributions
Description|Download Link|_Verify_
---|---|---
-Windows Distribution|[apache-activemq-5.15.13-bin.zip](https://archive.apache.org/dist/activemq/5.15.13/apache-activemq-5.15.13-bin.zip)|[ASC](https://archive.apache.org/dist/activemq/5.15.13/apache-activemq-5.15.13-bin.zip.asc), [SHA512](https://archive.apache.org/dist/activemq/5.15.13/apache-activemq-5.15.13-bin.zip.sha512)
-Unix/Linux/Cygwin Distribution|[apache-activemq-5.15.13-bin.tar.gz](https://archive.apache.org/dist/activemq/5.15.13/apache-activemq-5.15.13-bin.tar.gz)|[ASC](https://archive.apache.org/dist/activemq/5.15.13/apache-activemq-5.15.13-bin.tar.gz.asc), [SHA512](https://archive.apache.org/dist/activemq/5.15.13/apache-activemq-5.15.13-bin.tar.gz.sha512)
+Windows Distribution|[apache-activemq-{{page.version}}-bin.zip](https://archive.apache.org/dist/activemq/{{page.version}}/apache-activemq-{{page.version}}-bin.zip)|[ASC](https://archive.apache.org/dist/activemq/{{page.version}}/apache-activemq-{{page.version}}-bin.zip.asc), [SHA512](https://archive.apache.org/dist/activemq/{{page.version}}/apache-activemq-{{page.version}}-bin.zip.sha512)
+Unix/Linux/Cygwin Distribution|[apache-activemq-{{page.version}}-bin.tar.gz](https://archive.apache.org/dist/activemq/{{page.version}}/apache-activemq-{{page.version}}-bin.tar.gz)|[ASC](https://archive.apache.org/dist/activemq/{{page.version}}/apache-activemq-{{page.version}}-bin.tar.gz.asc), [SHA512](https://archive.apache.org/dist/activemq/{{page.version}}/apache-activemq-{{page.version}}-bin.tar.gz.sha512)
Review comment:
The tar/zip links should go the download mirrors for the current release(s), not the archive, like the main download page. See the existing 5.16.1 release page this change would replace, for example. Same for the source links below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org